Debian Bug report logs - #793511
pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Aaron M. Ucko" <ucko@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Fri, 24 Jul 2015 14:58:34 -0400

Source: pinba-engine-mysql
Version: 1.1.0-1
Severity: serious
Justification: fails to build from source (but built successfully in the past)

Builds of pinba-engine-mysql for 32-bit architectures such as i386 are
failing:

  ha_pinba.cc: In member function 'int ha_pinba::read_next_row(unsigned char*, uint, bool)':
  ha_pinba.cc:2687:59: error: cannot convert 'uint64_t* {aka long long unsigned int*}' to 'Word_t* {aka long unsigned int*}' for argument '2' to 'void** JudyLNext(Pcvoid_t, Word_t*, PJError_t)'
       ppvalue = JudyLNext(D->tag.name_index, &str_hash, NULL);
     
Could you please take a look?

Thanks!

Message #16 received at 793511@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: 793511@bugs.debian.org

Subject: Re: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Tue, 26 Apr 2016 08:45:22 +0200

Control: severity -1 important

On Fri, 24 Jul 2015 14:58:34 -0400 "Aaron M. Ucko" <ucko@debian.org> wrote:
> Builds of pinba-engine-mysql for 32-bit architectures such as i386 are
> failing:

Downgrading since the outdated 32-bit binaries have been decrufted.


Andreas

Message #23 received at 793511@bugs.debian.org (full text, mbox, reply):

From: Vincent Bernat <bernat@debian.org>

To: Andreas Beckmann <anbe@debian.org>

Cc: 793511@bugs.debian.org

Subject: Re: Bug#793511: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Tue, 26 Apr 2016 08:54:36 +0200

[Message part 1 (text/plain, inline)]

 ❦ 26 avril 2016 08:45 +0200, Andreas Beckmann <anbe@debian.org> :

>> Builds of pinba-engine-mysql for 32-bit architectures such as i386 are
>> failing:
>
> Downgrading since the outdated 32-bit binaries have been decrufted.

What do you mean?

As for the bug, no progress upstream and I am not comfortable with
applying the current patch as I think it would break on some arches at
runtime. If there is no solution, I'll just ask for the package
removal. It is unlikely to ever go into stable one day as it relies on
being rebuilt on each MySQL version and MySQL doesn't commit for an ABI
for third-party engines, even in stable.
-- 
When in doubt, tell the truth.
		-- Mark Twain

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 793511@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: 793511@bugs.debian.org

Subject: Re: Bug#793511: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Tue, 26 Apr 2016 10:16:07 +0200

On 2016-04-26 08:54, Vincent Bernat wrote:
>> Downgrading since the outdated 32-bit binaries have been decrufted.
> 
> What do you mean?

The outdated binary packages for all 32-bit architectures have been
removed. The package still FTBFS there but this is no longer a
regression, since these arches is in "uncompiled" state, and therefore
no longer RC. On 64-bit architectures building succeeds.


Andreas

Message #33 received at 793511@bugs.debian.org (full text, mbox, reply):

From: Jurica Stanojkovic <Jurica.Stanojkovic@imgtec.com>

To: "793511@bugs.debian.org" <793511@bugs.debian.org>

Cc: "ucko@debian.org" <ucko@debian.org>, "anbe@debian.org" <anbe@debian.org>, "bernat@debian.org" <bernat@debian.org>

Subject: Re: Bug#793511: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Tue, 24 May 2016 15:33:05 +0000

[Message part 1 (text/plain, inline)]

Hello,


I am sending a patch for this package.
This was already suggested by vincentbernat upstream.

With this patch package was successfully built on mips, mipsel, i386.

I have changed a type of str_hash in  file src/ha_pinba.cc 

--- pinba-engine-mysql-1.1.0.orig/src/ha_pinba.cc
+++ pinba-engine-mysql-1.1.0/src/ha_pinba.cc
@@ -2680,7 +2680,7 @@ int ha_pinba::read_next_row(unsigned cha
                                PPvoid_t ppvalue;
                                char name[PINBA_MAX_LINE_LEN] = {0};
                                pinba_tag *tag;
-                               uint64_t str_hash;
+                               Word_t str_hash;

                                str_hash = this_index[active_index].ival;

loking at a  pinba-engine-mysql-1.1.0/src/ha_pinba.h one can notice that ival is of type size_t:

typedef struct pinba_index_st { /* {{{ */
        union {
                size_t ival;
                struct {
                        unsigned char *val;
                        uint len;
                } str;
        };
        struct {
                unsigned char *val;
                uint len;
        } subindex;
        size_t position;
} pinba_index_st;
/* }}} */

However if we replace "uint64_t str_hash;" with "size_t str_hash;" on 32bit archs we have following problem:
ha_pinba.cc:2687:59: error: invalid conversion from 'size_t* {aka unsigned int*}' to 'Word_t* {aka long unsigned int*}' [-fpermissive]

Taking a look at a Word_t one can find that:
A Word_t is a typedef unsigned long int in Judy.h and must be the same size as sizeof(void *) I.E. a pointer.

Same size as size_t but on 32bit one is "unsigned int" (size_t) and the other "long unsigned int" (Word_t)
While on 64bit they are both "long unsigned int".

Taking this into consideration i have proposed a patch that i think it is safer than one proposed upstream, which will probably fail during run-time on big-endian:
https://github.com/tony2001/pinba_engine/issues/40

Please include this patch.


Regards,
Jurica Stanojkovic

[fix-32-bit-archs-build.patch (text/x-patch, attachment)]

Message #38 received at 793511@bugs.debian.org (full text, mbox, reply):

From: Vincent Bernat <bernat@debian.org>

To: Jurica Stanojkovic <Jurica.Stanojkovic@imgtec.com>

Cc: "793511\@bugs.debian.org" <793511@bugs.debian.org>, "ucko\@debian.org" <ucko@debian.org>, "anbe\@debian.org" <anbe@debian.org>

Subject: Re: Bug#793511: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Tue, 24 May 2016 18:11:09 +0200

[Message part 1 (text/plain, inline)]

 ❦ 24 mai 2016 15:33 GMT, Jurica Stanojkovic <Jurica.Stanojkovic@imgtec.com> :

> Taking this into consideration i have proposed a patch that i think it
> is safer than one proposed upstream, which will probably fail during
> run-time on big-endian:
> https://github.com/tony2001/pinba_engine/issues/40
>
> Please include this patch.

Hi!

Thanks for the patch. However, please, propose it upstream for comments.
-- 
Parenthesise to avoid ambiguity.
            - The Elements of Programming Style (Kernighan & Plauger)

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 793511@bugs.debian.org (full text, mbox, reply):

From: Dejan Latinovic <Dejan.Latinovic@imgtec.com>

To: "793511@bugs.debian.org" <793511@bugs.debian.org>

Cc: Vincent Bernat <bernat@debian.org>

Subject: Re: Bug#793511: pinba-engine-mysql: FTBFS (32-bit): cannot convert 'uint64_t*' to 'Word_t*

Date: Mon, 5 Sep 2016 14:07:13 +0000

I tried the patch that Jurica had proposed and made a comment on upstream
but unfortunately there are no other activities for this subject for a while now.

Should we consider a NMU?

Regards,
Dejan

Message #50 received at 793511-done@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 793511-done@bugs.debian.org,

Cc: pinba-engine-mysql@packages.debian.org, pinba-engine-mysql@packages.qa.debian.org

Subject: Bug#838039: Removed package(s) from unstable

Date: Sat, 17 Sep 2016 21:41:21 +0000

Version: 1.1.0-2+rm

Dear submitter,

as the package pinba-engine-mysql has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/838039

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Chris Lamb (the ftpmaster behind the curtain)

Send a report that this bug log contains spam.