Debian Bug report logs - #788098
dh_usrlocal leaves directories behind

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: yorick-data: unowned directories in /usr/local after purge (policy 6.8 and 9.1.2): /usr/local/lib/yorick/

Date: Fri, 05 Jun 2015 16:06:09 +0200

[Message part 1 (text/plain, inline)]

Package: yorick-data
Version: 2.2.04+dfsg1-2
Severity: normal
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

>From the attached log (scroll to the bottom...):

0m43.6s ERROR: FAIL: Package purging left files on system:
  /usr/local/lib/yorick/	 not owned


Leaving directories in /usr/local after purge is also a violation of a
should-directive in
https://www.debian.org/doc/debian-policy/ch-opersys.html#s9.1.2


cheers,

Andreas

[yorick-data_2.2.04+dfsg1-2.log.gz (application/gzip, attachment)]

Message #10 received at 787837@bugs.debian.org (full text, mbox, reply):

From: Thibaut Paumard <thibaut@debian.org>

To: 787837@bugs.debian.org

Subject: Re: Bug#787837: yorick-data: unowned directories in /usr/local after purge (policy 6.8 and 9.1.2): /usr/local/lib/yorick/

Date: Mon, 08 Jun 2015 15:26:37 +0200

Control: clone -1 -2
Control: reassign -2 debhelper
Control: retitle -2 dh_usrlocal leaves directories behind
Control: severity -2 normal

Le 05/06/2015 16:06, Andreas Beckmann a écrit :
> during a test with piuparts I noticed your package left unowned files on
> the system after purge, which is a violation of policy 6.8:

Hi,

Yorick uses dh_usrlocal to manage a tree of directories in /usr/local:
  /usr/local/lib/yorick
  /usr/local/lib/yorick/bin
  /usr/local/lib/yorick/lib
  /usr/local/lib/yorick/share
  ...

The problem is that dh_usrlocal attempts to remove the trunk directory
(/usr/local/lib/yorick) before the branches. At that point, the trunk is
not empty *yet*. Therefore, this directory remains.

I'll work around the problem in Yorick, but a bug is left in
dh_usrlocal, which should remove a tree in depth first, so the trunk is
removed too. I don't code in Perl (yet), so I can't provide a patch
efficiently.

Kind regards, Thibaut.

Message #23 received at 788098@bugs.debian.org (full text, mbox, reply):

From: Thibaut Paumard <thibaut@debian.org>

To: 788098@bugs.debian.org

Subject: [patch] Re: dh_usrlocal leaves directories behind

Date: Wed, 10 Jun 2015 15:49:18 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 + patch
Control: found -1 9.20150501
Control: notfound -1 9.20150101
Control: thanks

Hi,

The attached path sorts the directories in reverse order for prerm. This
has the effect that subdirectories are removed first, so that "trunk"
directories have a chance of being empty when we try to remove them.

Kind regards, Thibaut.

[dh_usrlocal-remove-directories-in-reverse-order.patch (text/x-diff, attachment)]

Message #32 received at 788098@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Thibaut Paumard <thibaut@debian.org>, 788098@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#788098: [patch] Re: dh_usrlocal leaves directories behind

Date: Wed, 10 Jun 2015 16:10:37 +0200

On 2015-06-10 15:49, Thibaut Paumard wrote:
> Control: tag -1 + patch
> Control: found -1 9.20150501
> Control: notfound -1 9.20150101
> Control: thanks
> 
> Hi,
> 

Hi,

Did you intend to add a found version only to remove it again?

> The attached path sorts the directories in reverse order for prerm. This
> has the effect that subdirectories are removed first, so that "trunk"
> directories have a chance of being empty when we try to remove them.
> 
> Kind regards, Thibaut.
> 
> 

Thanks, only one remark (see interleaved)

> dh_usrlocal-remove-directories-in-reverse-order.patch
> 
> 
> diff --git a/dh_usrlocal b/dh_usrlocal
> index 193d70d..94940a3 100755
> --- a/dh_usrlocal
> +++ b/dh_usrlocal
> @@ -103,7 +103,7 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
>  		# is parsed by the shell in double-quotes
>  		my $dirs = join("$ebs\n", sort @dirs);
>  		pop @justdirs; # don't remove directories directly in /usr/local
> -		my $justdirs = join("$ebs\n", sort @justdirs);
> +		my $justdirs = join("$ebs\n", sort {$b cmp $a} @justdirs);


There is a better idiom for reversed sorts in perl, which is:

  reverse sort @justdirs;

"Recent" versions of perl already optimise it to avoid doing two
separate list operations.

With that changed, it looks good to go.

~Niels

Message #37 received at 788098@bugs.debian.org (full text, mbox, reply):

From: Thibaut Paumard <thibaut@debian.org>

To: 788098@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#788098: [patch] Re: dh_usrlocal leaves directories behind

Date: Wed, 10 Jun 2015 17:05:11 +0200

Le 10/06/2015 16:10, Niels Thykier a écrit :
> On 2015-06-10 15:49, Thibaut Paumard wrote:
>> Control: tag -1 + patch
>> Control: found -1 9.20150501
>> Control: notfound -1 9.20150101
>> Control: thanks
>>
>> Hi,
>>
> 
> Hi,
> 
> Did you intend to add a found version only to remove it again?

Hi Niels,

The two versions are not identical. I wanted to specify that the bug was
not present in the jessie version, but it was unnecessary.


> There is a better idiom for reversed sorts in perl, which is:
> 
>   reverse sort @justdirs;
> 
> "Recent" versions of perl already optimise it to avoid doing two
> separate list operations.
> 
> With that changed, it looks good to go.
> 

Should I implement this change and commit to alioth?

Kind regards, Thibaut.

Message #42 received at 788098@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Thibaut Paumard <thibaut@debian.org>, 788098@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#788098: Bug#788098: [patch] Re: dh_usrlocal leaves directories behind

Date: Wed, 10 Jun 2015 17:11:10 +0200

[Message part 1 (text/plain, inline)]

On 2015-06-10 17:05, Thibaut Paumard wrote:
> Le 10/06/2015 16:10, Niels Thykier a écrit :
>> On 2015-06-10 15:49, Thibaut Paumard wrote:
>>> Control: tag -1 + patch
>>> Control: found -1 9.20150501
>>> Control: notfound -1 9.20150101
>>> Control: thanks
>>>
>>> Hi,
>>>
>>
>> Hi,
>>
>> Did you intend to add a found version only to remove it again?
> 
> Hi Niels,
> 
> The two versions are not identical. I wanted to specify that the bug was
> not present in the jessie version, but it was unnecessary.
> 

Ah, indeed.  We should stop releasing on the first of the month to avoid
this kind of confusion! :P

> 
>> There is a better idiom for reversed sorts in perl, which is:
>>
>>   reverse sort @justdirs;
>>
>> "Recent" versions of perl already optimise it to avoid doing two
>> separate list operations.
>>
>> With that changed, it looks good to go.
>>
> 
> Should I implement this change and commit to alioth?
> 
> Kind regards, Thibaut.
> 
> [...]

Please do. :)

~Niels

[signature.asc (application/pgp-signature, attachment)]

Message #47 received at 788098@bugs.debian.org (full text, mbox, reply):

From: Thibaut Paumard <thibaut@debian.org>

To: Niels Thykier <niels@thykier.net>, 788098@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#788098: Bug#788098: [patch] Re: dh_usrlocal leaves directories behind

Date: Wed, 10 Jun 2015 17:40:17 +0200

[Message part 1 (text/plain, inline)]

Le 10/06/2015 17:11, Niels Thykier a écrit :
>> Should I implement this change and commit to alioth?
>>
>> [...]
> 
> Please do. :)
> 

Turns out I can't, not being part of the debhelper group.

New patch attached, includes update to debian/changelog.

Kind regards, Thibaut.

[dh_usrlocal-remove-directories-in-reverse-order.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #52 received at 788098@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Thibaut Paumard <thibaut@debian.org>, 788098@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#788098: Bug#788098: Bug#788098: [patch] Re: dh_usrlocal leaves directories behind

Date: Wed, 10 Jun 2015 17:45:07 +0200

[Message part 1 (text/plain, inline)]

On 2015-06-10 17:40, Thibaut Paumard wrote:
> Le 10/06/2015 17:11, Niels Thykier a écrit :
>>> Should I implement this change and commit to alioth?
>>>
>>> [...]
>>
>> Please do. :)
>>
> 
> Turns out I can't, not being part of the debhelper group.
> 

Ah, forgot about that...

> New patch attached, includes update to debian/changelog.
> 
> Kind regards, Thibaut.
> 
> [...]

Thanks, applied to master.

~Niels

[signature.asc (application/pgp-signature, attachment)]

Message #59 received at 788098-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 788098-close@bugs.debian.org

Subject: Bug#788098: fixed in debhelper 9.20150628

Date: Sun, 28 Jun 2015 13:04:54 +0000

Source: debhelper
Source-Version: 9.20150628

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 788098@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 28 Jun 2015 13:51:48 +0200
Source: debhelper
Binary: debhelper
Architecture: source all
Version: 9.20150628
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper-devel@lists.alioth.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 debhelper  - helper programs for debian/rules
Closes: 726967 740405 785811 788098 788473
Changes:
 debhelper (9.20150628) unstable; urgency=medium
 .
   * Upload to unstable with ddebs support disabled by default.
 .
   [ Niels Thykier ]
   * Buildsystem.pm: Apply patch from Emmanuel Bourg to
     provide doit_in_{build,source}dir_noerror methods.
     (Closes: #785811)
   * Dh_Lib.pm: Promote error_exitcode to a regular exported
     subroutine (from an internal one).
   * dh_compress: Apply patch from Osamu Aoki to avoid compressing
     ".xhtml" files and to use a POSIX compliant find expression.
     (Closes: #740405)
   * dh_makeshlibs: Fix typo in manpage.  Thanks to Jakub Wilk for
     reporting it.  (Closes: #788473)
   * dh_auto_test: Run tests by default even during cross-building.
     (Closes: #726967)
   * dh_gencontrol: Put ddebs in the "debugsym" section.
   * dh_strip: Support a new --[no-]ddebs option intended for
     packages to disable automatic ddebs.
   * dh_strip: Do not create ddebs for "-dbg" packages.
   * dh_builddeb/dh_gencontrol: Let dpkg figure out the name
     of the ddebs itself now that ddebs uses a ".deb"
     extension.
 .
   [ Thibaut Paumard ]
   * Bug fix: "dh_usrlocal leaves directories behind", thanks to Andreas
     Beckmann (Closes: #788098).
Checksums-Sha1:
 7a8cb5f36c087c71e49063bd6c5888f8c2b445eb 1749 debhelper_9.20150628.dsc
 91f6ad0460184d1fad3433d88fc7a4a7191838aa 317804 debhelper_9.20150628.tar.xz
 79280dce6b68c4f8c50702f11601ff8e6e4c2e94 817082 debhelper_9.20150628_all.deb
Checksums-Sha256:
 83b554662468cde25cb246d57af1a9dd82b981bfe915061412191dae734a9183 1749 debhelper_9.20150628.dsc
 8fb59c2a03fa9f6061db8091e7ecaf68c5680495eec05d6c145e3f782b09d68f 317804 debhelper_9.20150628.tar.xz
 5fb29fe5a7efbe0451dc7225efc2fd925471747a9a1f6e1b45e0b9d64b53e87d 817082 debhelper_9.20150628_all.deb
Files:
 3cbd6e16cd6e97da8a0dcc629bd4c006 1749 devel optional debhelper_9.20150628.dsc
 2f4153c555a9cd624fb2e4b7adab216b 317804 devel optional debhelper_9.20150628.tar.xz
 b5a0b54c9adb7360a29b3086c38fd0ed 817082 devel optional debhelper_9.20150628_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVj+9XAAoJEAVLu599gGRCH44P+gLllhq18BDmJP719GGdJ2/f
pb90cnULqiY9hb5AOUnq7o4Qhu46aveUiWDg29sA/Qd+laHjsHH6MhM+kfiIWnn/
4ZVFSLgPe7OCt4v6BSA0bPJy5guKPOeWcnWiWNGQldkAahtOWjRXT8iC+3lOgG3v
BU6qsKbbC3pZXGLuUFiX4sJSb7XZFDUhz1TEx0sg6x1ZYWf+ikgjKfnEzpEwIpA5
bAJZoHQqMjllQcr73+J3xZ5WotqxWC1AXgLklzvWs6UpmaxNoR01hGrptBQdPceD
kynGjWvSaxZKkirojipR3oz1swGremJutGHX/6FTj+mKkv18jY/BRc1ctBFhFXMA
jlJ+5zRfjIaeajb0VDBP5G63E/nvIcTFH6sNHxsM4Zu5L/hjysDbh/Zz1FwtbfDr
aYNCBKSzkMs+l+dufH7UuwoKnmZ0LsERj4LrH9oS4PFOUTTm1KUSZGPUyPYyCzK/
Vi/9T+fTnX78YaM90+iKyrvOdqKOaP7JXHBWBfp0Ozk2JJVvPeED7Bw95rtO1zsv
r/xVyYSZJjwOmvKem44kurXYGESahH/I6rSnSFHgRIgUlRNoadQ47g3LALxuzkS2
/Oggd1QSivMX8D5A1xKoorrulPDYq3OkCljeZxAZE/FvnV/7YSxJlZQhYvLAMujR
fIlO3JMNij+0gFf/V6NL
=djO2
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.