Debian Bug report logs - #787698
supertux: FTBFS on big-endian archs

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <vcheng@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: supertux: FTBFS on big-endian archs

Date: Thu, 04 Jun 2015 00:40:28 -0700

Package: supertux
Version: 0.3.5a-1
Severity: serious
Justification: fails to build from source (but built successfully in the past)

supertux/0.3.5a-1 currently FTBFS on mips, powerpc, s390x, and sparc. Build
logs can be found at [1]; tail of build log is as follows:

[ 89%] Building CXX object CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o
/usr/bin/c++    -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2  -std=c++11 -I/usr/include/GL -I/usr/include/AL -I/«PKGBUILDDIR»/obj-mips-linux-gnu -I/«PKGBUILDDIR»/src -I/«PKGBUILDDIR»/external/squirrel/include -I/«PKGBUILDDIR»/external/tinygettext/include -I/«PKGBUILDDIR»/external/findlocale -I/«PKGBUILDDIR»/external/obstack -isystem /usr/include/SDL2    -Wall -Wextra -Wno-unused-parameter -funit-at-a-time -fno-strict-aliasing -o CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o -c /«PKGBUILDDIR»/src/audio/wav_sound_file.cpp
/«PKGBUILDDIR»/src/audio/wav_sound_file.cpp: In member function 'virtual size_t WavSoundFile::read(void*, size_t)':
/«PKGBUILDDIR»/src/audio/wav_sound_file.cpp:162:4: error: 'void*' is not a pointer-to-object type
   *buffer = tmp;
    ^
make[3]: *** [CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o] Error 1

Any help (or better yet, patches) would be greatly appreciated!

Regards,
Vincent

[1] https://buildd.debian.org/status/package.php?p=supertux&suite=unstable

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.0-4-vclaptop-amd64 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages supertux depends on:
ii  libc6                     2.19-18
ii  libcurl3-gnutls           7.42.1-2
ii  libgcc1                   1:5.1.1-8
ii  libgl1-mesa-glx [libgl1]  10.5.5-1
ii  libglew1.10               1.10.0-3
ii  libglu1-mesa [libglu1]    9.0.0-2
ii  libogg0                   1.3.2-1
ii  libopenal1                1:1.16.0-3
ii  libphysfs1                2.0.3-2
ii  libsdl2-2.0-0             2.0.2+dfsg1-7
ii  libsdl2-image-2.0-0       2.0.0+dfsg-3+b4
ii  libstdc++6                5.1.1-8
ii  libvorbis0a               1.3.4-2
ii  libvorbisfile3            1.3.4-2
ii  supertux-data             0.3.5a-1

supertux recommends no packages.

supertux suggests no packages.

-- no debconf information

Message #14 received at 787698@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@debian.org>

To: Vincent Cheng <vcheng@debian.org>, 787698@bugs.debian.org

Subject: Re: Bug#787698: supertux: FTBFS on big-endian archs

Date: Mon, 08 Jun 2015 09:07:31 +0200

[Message part 1 (text/plain, inline)]

Hi Vincent,

Am Donnerstag, den 04.06.2015, 00:40 -0700 schrieb Vincent Cheng: 
> /«PKGBUILDDIR»/src/audio/wav_sound_file.cpp:162:4: error: 'void*' is not a pointer-to-object type
>    *buffer = tmp;
>     ^
> make[3]: *** [CMakeFiles/supertux2.dir/src/audio/wav_sound_file.cpp.o] Error 1
> 
> Any help (or better yet, patches) would be greatly appreciated!

in the WavSoundFile::read function, the "buffer" argument is a void
pointer, so de-referencing it is a bad idea. You might want to try
type-punning the pointer by e.g.

  *((char *)buffer) = tmp;

Hope that helps,

Fabian

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 787698@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: Vincent Cheng <vcheng@debian.org>, 787698@bugs.debian.org

Subject: Re: Bug#787698: supertux: FTBFS on big-endian archs

Date: Mon, 17 Aug 2015 13:06:25 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 + patch

Am Montag, den 08.06.2015, 09:07 +0200 schrieb Fabian Greffrath:
>   *((char *)buffer) = tmp;

Correction: You'll also need to dereference the tmp pointer, i.e.:

--- supertux-0.3.5a.orig/src/audio/wav_sound_file.cpp
+++ supertux-0.3.5a/src/audio/wav_sound_file.cpp
@@ -159,7 +159,7 @@ WavSoundFile::read(void* buffer, size_t
     tmp[2*i+1] = c;
   }
 
-  *buffer = tmp;
+  *(char *)buffer = *tmp;
 #endif
 
   return readsize;

Cheers,

Fabian

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 787698@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <vcheng@debian.org>

To: Fabian Greffrath <fabian@greffrath.com>

Cc: 787698@bugs.debian.org

Subject: Re: Bug#787698: supertux: FTBFS on big-endian archs

Date: Thu, 20 Aug 2015 01:05:44 -0700

Hi Fabian,

On Mon, Aug 17, 2015 at 4:06 AM, Fabian Greffrath <fabian@greffrath.com> wrote:
> Control: tags -1 + patch
>
> Am Montag, den 08.06.2015, 09:07 +0200 schrieb Fabian Greffrath:
>>   *((char *)buffer) = tmp;
>
> Correction: You'll also need to dereference the tmp pointer, i.e.:
>
> --- supertux-0.3.5a.orig/src/audio/wav_sound_file.cpp
> +++ supertux-0.3.5a/src/audio/wav_sound_file.cpp
> @@ -159,7 +159,7 @@ WavSoundFile::read(void* buffer, size_t
>      tmp[2*i+1] = c;
>    }
>
> -  *buffer = tmp;
> +  *(char *)buffer = *tmp;
>  #endif
>
>    return readsize;
>

Thanks for the patch, and sorry for dropping the ball on this! I'll
upload an updated package within the next hour.

Regards,
Vincent

Message #31 received at 787698-close@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <vcheng@debian.org>

To: 787698-close@bugs.debian.org

Subject: Bug#787698: fixed in supertux 0.3.5a-2

Date: Thu, 20 Aug 2015 09:22:55 +0000

Source: supertux
Source-Version: 0.3.5a-2

We believe that the bug you reported is fixed in the latest version of
supertux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 787698@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Cheng <vcheng@debian.org> (supplier of updated supertux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 20 Aug 2015 01:45:06 PDT
Source: supertux
Binary: supertux supertux-data
Architecture: source all
Version: 0.3.5a-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Vincent Cheng <vcheng@debian.org>
Description: 
 supertux - Classic 2D jump 'n run sidescroller with Tux
 supertux-data - Classic 2D jump 'n run sidescroller with Tux (data files)
Closes: 787698 794358
Changes:
 supertux (0.3.5a-2) unstable; urgency=medium
 .
   * Fix FTBFS on big-endian archs. Thanks to Fabian Greffrath for the patch!
     (Closes: #787698)
   * Install high resolution icon. (Closes: #794358)
Checksums-Sha256: 
 1bd361074568c9aafecd071a74e56d90c0de2a01302c3490440fa7aee1c2ff01 2223 supertux_0.3.5a-2.dsc
 74856f03e722a8500ade8db367c6b84ace4155103d4fdf38f01f484b5f88de05 9484 supertux_0.3.5a-2.debian.tar.xz
 a79132b780805bc96107f017a54bf00b154520f675c5ba5cc78283638c3840b7 70220052 supertux-data_0.3.5a-2_all.deb
Checksums-Sha1: 
 9d029cd4b92d90264ccd4db4a5a0ccd222cfe3bd 2223 supertux_0.3.5a-2.dsc
 8ad1efd67cadc1074394286e7fb7d71801d3cfc9 9484 supertux_0.3.5a-2.debian.tar.xz
 9088b238688fdb29352f0cd54ae8351cdd155e11 70220052 supertux-data_0.3.5a-2_all.deb
Files: 
 f569da118ec7f0119cf9266e06de5057 2223 games optional supertux_0.3.5a-2.dsc
 02cf237036d6d7b89455ab92051cd8a1 9484 games optional supertux_0.3.5a-2.debian.tar.xz
 2b7f21bbe894d6af5fb5209432781052 70220052 games optional supertux-data_0.3.5a-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJV1ZOWAAoJEI7tzBuqHzL/2oAP/2rau/wZK+Bzm2C8lP0N322Y
8MdpDPdXqxhDfOofhH14o+jt2jqJMcCA+Tcxog18h+OUIdqgObWqKah8qHNMLH81
7sO7v5Cqiq6i40fDXi3iNPOPjURe2AU8x5MMAN/XB0W716ZUS35vubbHsk5iDr4O
US3GGseEMjZt04cif5/7Eb7Q/ymi//j12OhDKzRDKAdJT4n1Lmy1omqPgw8Ed1V9
BCpwGEhhtk68mytkt+C6N8AWfrrnKooARgMPZYY0qlB+IG2Ega44HXeU6O6tzXie
iXxV1Y+tuFYSwtzbqlRNwMGe27Y/HbU34GlqMw8z8NZcZjkcBZeGiTqCVa1/J2Zo
grf5yvrguzE/96bhGpxPdRSWAi79cJRKjjD8iqUpvpHB1wiXNR4QPhPTQhEladUd
JRG52ApUdF+r49nsPmk9fJzrxlPHjDvUeGddk2Vq+lWeYRFcfvx5Ioy9oLc8B2wE
LiHEL8+0UMynAnVaYM1NOwN+mXgMUgF9gKxK5kR3j1n34rpg4mEWO2Leo2qwd6HI
ANWjrYgkoB8MPdSPs4XVOXJSV/1QjV3H4rZvEwEGvJscCANOn5Y+jQ3SHNwYggUm
sMkpLN8ee2BkIbEAf0k5oxcxXUOj19Qk2t7yJHviyJCb7BLtgNYSEe7s9UBs2MEf
7YOw+01LMQJ7UlX2I3Ua
=hAtb
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.