Debian Bug report logs -
#787424
emacs24: improve reproducibility: please order hashes when generating .el files
Reported by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Mon, 1 Jun 2015 15:48:02 UTC
Severity: normal
Tags: patch
Found in version emacs24/24.4+1-5
Fixed in version 24.5+1-11+rm
Done: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, Rob Browning <rlb@defaultvalue.org>:
Bug#787424; Package emacs24.
(Mon, 01 Jun 2015 15:48:05 GMT) (full text, mbox, link).
Acknowledgement sent
to Daniel Kahn Gillmor <dkg@fifthhorseman.net>:
New Bug report received and forwarded. Copy sent to Rob Browning <rlb@defaultvalue.org>.
(Mon, 01 Jun 2015 15:48:05 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
Package: emacs24
Version: 24.4+1-5
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
emacs24 is not currently reproducible, for many reasons. One of those
reasons is that .el files are generated with hash tables and lists that
are ordered stochastically. Sorting the lists or hashtables before
generating the .el should avoid this particular problem.
One example can be seen in the difference in
/usr/share/emacs/24.4/lisp/finder-inf.el from here:
https://reproducible.debian.net/dbd/unstable/amd64/emacs24_24.4+1-5.debbindiff.html
compare the list after "convenience" here, which sorts the first 13
items differently on each build:
convenience·(table·picture·emacs·makeinfo·flyspell·calc·keypad·cua-base·erc·diff-mode·compare-w·winner·windmove·vcursor·tmm·ruler-mode·repeat·pcomplete·minibuf-eldef·mb-depth·linum·kmacro·json·imenu·ido·ibuffer·hippie-exp·frameset·follow·filesets·filecache·ffap·ebuff-menu·desktop·delsel·dabbrev·completion·chistory·calculator·bs·autorevert·autoinsert·align)
convenience·(emacs·keypad·cua-base·diff-mode·compare-w·calc·erc·table·picture·makeinfo·flyspell·winner·windmove·vcursor·tmm·ruler-mode·repeat·pcomplete·minibuf-eldef·mb-depth·linum·kmacro·json·imenu·ido·ibuffer·hippie-exp·frameset·follow·filesets·filecache·ffap·ebuff-menu·desktop·delsel·dabbrev·completion·chistory·calculator·bs·autorevert·autoinsert·align)
This file is generated in lisp/Makefile.in with:
$(emacs) -l finder \
--eval '(setq generated-finder-keywords-file (unmsys--file-name "$(srcdir)/finder-inf.el"))' \
-f finder-compile-keywords-make-dist $$wins
which maps back to finder-compile-keywords in lisp/finder.el. Maybe
someplace in that function can do a sort before emitting the file?
Sorry to not be enough of an elisp hacker to provide a patch directly.
--dkg
Information forwarded
to debian-bugs-dist@lists.debian.org, Rob Browning <rlb@defaultvalue.org>:
Bug#787424; Package emacs24.
(Thu, 12 May 2016 17:15:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Alexis Bienvenüe <pado@passoire.fr>:
Extra info received and forwarded to list. Copy sent to Rob Browning <rlb@defaultvalue.org>.
(Thu, 12 May 2016 17:15:04 GMT) (full text, mbox, link).
Message #10 received at 787424@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Control: tags -1 + patch
Hi.
On Mon, 01 Jun 2015 11:44:06 -0400 Daniel Kahn Gillmor
<dkg@fifthhorseman.net> wrote:
> One example can be seen in the difference in
> /usr/share/emacs/24.4/lisp/finder-inf.el from here:
>
> https://reproducible.debian.net/dbd/unstable/amd64/emacs24_24.4+1-5.debbindiff.html
>
> compare the list after "convenience" here, which sorts the first 13
> items differently on each build:
This difference is coming from the Makefile, which passes file names in
a non-reproducible order to finder-compile-keywords-make-dist, which
itself seem to me reproducible.
The attached patch sorts the filenames before passing them to
finder-compile-keywords-make-dist, and fixes this non-reproductible
behavior in my experimental toolchain [1].
Regards,
Alexis Bienvenüe.
[1] https://wiki.debian.org/ReproducibleBuilds/ExperimentalToolchain
[0022-sort-files-in-wins.patch (text/x-patch, attachment)]
Added tag(s) patch.
Request was from Alexis Bienvenüe <pado@passoire.fr>
to 787424-submit@bugs.debian.org.
(Thu, 12 May 2016 17:15:04 GMT) (full text, mbox, link).
Reply sent
to Debian FTP Masters <ftpmaster@ftp-master.debian.org>:
You have taken responsibility.
(Fri, 11 Aug 2017 18:46:37 GMT) (full text, mbox, link).
Notification sent
to Daniel Kahn Gillmor <dkg@fifthhorseman.net>:
Bug acknowledged by developer.
(Fri, 11 Aug 2017 18:46:38 GMT) (full text, mbox, link).
Message #17 received at 787424-done@bugs.debian.org (full text, mbox, reply):
Version: 24.5+1-11+rm
Dear submitter,
as the package emacs24 has just been removed from the Debian archive
unstable we hereby close the associated bug reports. We are sorry
that we couldn't deal with your issue properly.
For details on the removal, please see https://bugs.debian.org/871627
The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.
This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.
Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Sat, 09 Sep 2017 07:31:42 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Wed May 17 13:49:36 2023;
Machine Name:
buxtehude
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.