Debian Bug report logs - #787418
Drop " (loader)" suffixes on Microsoft operating systems

version graph

Package: os-prober; Maintainer for os-prober is Debian Install System Team <debian-boot@lists.debian.org>; Source for os-prober is src:os-prober (PTS, buildd, popcon).

Reported by: Chris Lamb <lamby@debian.org>

Date: Mon, 1 Jun 2015 14:03:01 UTC

Severity: wishlist

Tags: patch

Found in version os-prober/1.65

Fixed in version os-prober/1.72

Done: Colin Watson <cjwatson@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#787418; Package os-prober. (Mon, 01 Jun 2015 14:03:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Mon, 01 Jun 2015 14:03:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: submit@bugs.debian.org
Subject: Drop " (loader)" suffixes on Microsoft operating systems
Date: Mon, 01 Jun 2015 15:00:09 +0100
[Message part 1 (text/plain, inline)]
Package: os-prober
Version: 1.65
Severity: wishlist
Tags: patch

Hi,

Does the " (loader)" suffix on (eg.) Grub menu options really mean
anything? If not, I think it looks much nicer with these suffixes
removed.

(Indeed, the current situation is actually somewhat misleading to the
average user - Linux menu entries don't have these prefixes, encouraging
an end-user to think that they do something other than, well, load/boot
Linux. Especially in a bootloader..)

If the suffix does have some significant meaning, feel free to close
this bug. Patch attached for clarity.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[patch.diff.txt (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#787418; Package os-prober. (Mon, 08 Jun 2015 13:39:03 GMT) (full text, mbox, link).


Acknowledgement sent to Steve McIntyre <steve@einval.com>:
Extra info received and forwarded to list. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Mon, 08 Jun 2015 13:39:03 GMT) (full text, mbox, link).


Message #10 received at 787418@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <steve@einval.com>
To: Chris Lamb <lamby@debian.org>, 787418@bugs.debian.org
Subject: Re: Bug#787418: Drop " (loader)" suffixes on Microsoft operating systems
Date: Mon, 8 Jun 2015 14:34:44 +0100
On Mon, Jun 01, 2015 at 03:00:09PM +0100, Chris Lamb wrote:
>Package: os-prober
>Version: 1.65
>Severity: wishlist
>Tags: patch
>
>Hi,
>
>Does the " (loader)" suffix on (eg.) Grub menu options really mean
>anything? If not, I think it looks much nicer with these suffixes
>removed.
>
>(Indeed, the current situation is actually somewhat misleading to the
>average user - Linux menu entries don't have these prefixes, encouraging
>an end-user to think that they do something other than, well, load/boot
>Linux. Especially in a bootloader..)
>
>If the suffix does have some significant meaning, feel free to close
>this bug. Patch attached for clarity.

Looks good to me, and I can't see any good reason to keep the (loader)
suffix.

>
>
>Regards,
>
>-- 
>      ,''`.
>     : :'  :     Chris Lamb
>     `. `'`      lamby@debian.org / chris-lamb.co.uk
>       `-

>diff --git a/os-probes/mounted/x86/20microsoft b/os-probes/mounted/x86/20microsoft
>index 6fb3cc5..a8437d2 100755
>--- a/os-probes/mounted/x86/20microsoft
>+++ b/os-probes/mounted/x86/20microsoft
>@@ -32,21 +32,21 @@ if item_in_dir -q bootmgr "$2"; then
> 		bcd=$(item_in_dir bcd "$2/$boot")
> 		if [ -n "$bcd" ]; then
> 			if grep -qs "W.i.n.d.o.w.s. .8" "$2/$boot/$bcd"; then
>-				long="Windows 8 (loader)"
>+				long="Windows 8"
> 			elif grep -qs "W.i.n.d.o.w.s. .7" "$2/$boot/$bcd"; then
>-				long="Windows 7 (loader)"
>+				long="Windows 7"
> 			elif grep -qs "W.i.n.d.o.w.s. .V.i.s.t.a" "$2/$boot/$bcd"; then
>-				long="Windows Vista (loader)"
>+				long="Windows Vista"
> 			elif grep -qs "W.i.n.d.o.w.s. .S.e.r.v.e.r. .2.0.0.8. .R.2." "$2/$boot/$bcd"; then
>-				long="Windows Server 2008 R2 (loader)"
>+				long="Windows Server 2008 R2"
> 			elif grep -qs "W.i.n.d.o.w.s. .S.e.r.v.e.r. .2.0.0.8." "$2/$boot/$bcd"; then
>-				long="Windows Server 2008 (loader)"
>+				long="Windows Server 2008"
> 			elif grep -qs "W.i.n.d.o.w.s. .R.e.c.o.v.e.r.y. .E.n.v.i.r.o.n.m.e.n.t" "$2/$boot/$bcd"; then
>-				long="Windows Recovery Environment (loader)"
>+				long="Windows Recovery Environment"
> 			elif grep -qs "W.i.n.d.o.w.s. .S.e.t.u.p" "$2/$boot/$bcd"; then
>-				long="Windows Recovery Environment (loader)"
>+				long="Windows Recovery Environment"
> 			else
>-				long="Windows Vista (loader)"
>+				long="Windows Vista"
> 			fi
> 			short=Windows
> 
>@@ -82,7 +82,7 @@ if [ -z "$found" ] && item_in_dir -q ntldr "$2" && item_in_dir -q ntdetect.com "
> 				long="Windows NT/2000/XP"
> 			fi
> 		else
>-			long="Windows NT/2000/XP (loader)"
>+			long="Windows NT/2000/XP"
> 		fi
> 
> 		found=true

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
< Aardvark> I dislike C++ to start with. C++11 just seems to be
            handing rope-creating factories for users to hang multiple
            instances of themselves.




Added tag(s) pending. Request was from Colin Watson <cjwatson@debian.org> to control@bugs.debian.org. (Fri, 20 Jan 2017 12:42:03 GMT) (full text, mbox, link).


Reply sent to Colin Watson <cjwatson@debian.org>:
You have taken responsibility. (Fri, 20 Jan 2017 13:06:32 GMT) (full text, mbox, link).


Notification sent to Chris Lamb <lamby@debian.org>:
Bug acknowledged by developer. (Fri, 20 Jan 2017 13:06:32 GMT) (full text, mbox, link).


Message #17 received at 787418-close@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>
To: 787418-close@bugs.debian.org
Subject: Bug#787418: fixed in os-prober 1.72
Date: Fri, 20 Jan 2017 13:04:29 +0000
Source: os-prober
Source-Version: 1.72

We believe that the bug you reported is fixed in the latest version of
os-prober, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 787418@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated os-prober package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 20 Jan 2017 12:44:34 +0000
Source: os-prober
Binary: os-prober-udeb os-prober
Architecture: source
Version: 1.72
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 os-prober  - utility to detect other OSes on a set of drives
 os-prober-udeb - utility to detect other OSes on a set of drives (udeb)
Closes: 648208 674561 698598 698733 701814 776275 784709 787418 794409 801631 803155
Changes:
 os-prober (1.72) unstable; urgency=medium
 .
   * Improve logging of mounting and setting partitions to ro/rw (thanks, Ivo
     De Decker).
   * Use a read-only device-mapper entry if possible rather than setting the
     underlying device to read-only (thanks, Ivo De Decker; closes: #701814).
     Note that this introduces a dependency on dmsetup on Linux
     architectures.
   * Remove the "blockdev --setro" code path entirely, since the read-only
     device-mapper arrangement supersedes it and should be safer (closes:
     #648208).
   * Make os-prober-udeb depend on grub-mount-udeb on all Linux and kFreeBSD
     architectures, now that it's available on them all (thanks, James
     Cowgill; closes: #776275).
   * Make os-prober depend on grub-common on Linux and kFreeBSD, in order
     that grub-mount is consistently available.
   * Fix detection of /usr/ partition as a GNU/Linux root partition when
     /lib* directories are moved to /usr/ completely (thanks, Hedayat
     Vatankhah; closes: #698733).
   * Make the yaboot parser more tolerant about the syntax of "append"
     options (thanks, Hedayat Vatankhah; closes: #674561).
   * Disable debugging if OS_PROBER_DISABLE_DEBUG is set (thanks, Hedayat
     Vatankhah; closes: #698598).
   * Replace basename/dirname with shell string processing (thanks, Hedayat
     Vatankhah; part of #694668).
   * Call dmraid only once (thanks, Jeff Mahoney).
   * Fix typos in README (thanks, Nyav; closes: #803155).
   * Add os-release support (based loosely on a patch by Török Edwin; closes:
     #794409).
   * Add Devuan detection (thanks, David Hare; closes: #801631).
   * Work harder to avoid trying to mount extended partitions (thanks,
     Philippe Coval; closes: #784709).
   * Drop " (loader)" suffixes on Microsoft operating systems (thanks, Chris
     Lamb; closes: #787418).
Checksums-Sha1:
 8438248e4fbc40749b85e37c16cf433db51b3cff 1816 os-prober_1.72.dsc
 c7b3b51719328b7cf0258561f4ee9c08f9a21d79 26452 os-prober_1.72.tar.xz
Checksums-Sha256:
 f79975ddbd06ed371c3f27a781d423b2d88af6cc04896946f8df03fa42915f70 1816 os-prober_1.72.dsc
 13ed24f78e83f0c49e11635891458f067e6c8348be210adda46629dd3b7b627a 26452 os-prober_1.72.tar.xz
Files:
 90ced5506beca6dc949347ab30f6e174 1816 debian-installer optional os-prober_1.72.dsc
 16ce39ea58a684f102dd7aff1779cbf5 26452 debian-installer optional os-prober_1.72.tar.xz

-----BEGIN PGP SIGNATURE-----
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAliCBlMACgkQOTWH2X2G
UAuXBw/+J+SAw+8es7Ca2xByEwor4P28IqkoU5uiBZ2zYo4xs727tAo6CVX0yw7Z
ctRSJhOpKF1/FtiIUNq+6E6ZKKRzqEder4S7fRI92e7FXbW0yn5unUz84EvVrcI1
5V/rhEe3y8IrXEgVWMJoY+Vg5/sQWRMHap7HamC0Zj+9zlGmjZkc01gJRr0hTvw/
ApCUhZncVSlqXb7zgjU74HVX3+YHzJaOsZY4XyhVjmEnWlY8U0pNffCnzuxJDTuY
gMDqC9AQmKyA3bhmzgi5DSh+5r6j2nwvYV9a3+xgJZvu0mv6Ng+UNd3p+uS+7BFU
8KdPy3Cnd0Xv/DkMKYdU5sOoFzsDwXF0sxJtlBpJyMFt9ZAnpRz7oxIS7D76HzYI
msUVsvnBLaldkdTKpn9BlhxGVCH1iIlwN6w3aCW/fBNjuA9VBJyEdzzhCuaAfXZC
fYwryq2gXgeowwdvH6rQcu04C7AHWiXulsl9yV1be8OlbRk8yc+CF08Ma7ABAweI
ToYXEupEfdWEkKyQPaGtgoowUquX6cmYKeKBn5E6N2AVgU+yT10JbWeg6VLzlkKe
p3UD6+iFKjfdKCjM9iy9aoyGjDGCy35lqb824R+nAZsGsJmkEMgRFgTMqYtgCOkU
Jtp0pdbat3CXTQn50nbICF77jOzcFM4p2sO3yVOI0sFOa0mitMY=
=lgmu
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 18 Feb 2017 07:27:46 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jun 4 07:07:05 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.