Debian Bug report logs - #787043
adequate: missing autopkgtest dependency on pkg-config

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Micah Gersten <micahg@ubuntu.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: adequate: Adequate needs dependency on pkg-config for new missing-pkgconfig-dependency tag

Date: Wed, 27 May 2015 23:58:55 -0500

[Message part 1 (text/plain, inline)]

Package: adequate
Version: 0.13.1
Severity: important
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu wily ubuntu-patch



*** /tmp/tmpPmRSCM/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

  * Add missing depends on pkg-config for adequate so it can test the new
    missing-pkgconfig-dependency tag; This also allows the autopkgtest to
    complete as well
    - update debian/control


Thanks for considering the patch.


-- System Information:
Debian Release: jessie/sid
  APT prefers trusty-updates
  APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 'trusty-proposed'), (500, 'trusty'), (100, 'trusty-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13.0-53-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

[adequate_0.13.1ubuntu1.debdiff (text/x-diff, attachment)]

Message #8 received at 787043@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: Micah Gersten <micahg@ubuntu.com>, 787043@bugs.debian.org

Subject: Re: Bug#787043: adequate: Adequate needs dependency on pkg-config for new missing-pkgconfig-dependency tag

Date: Thu, 28 May 2015 09:56:18 +0200

Control: tags -1 + confirmed

Hi Micah!

Thanks for the bug report.

* Micah Gersten <micahg@ubuntu.com>, 2015-05-27, 23:58:
>In Ubuntu, the attached patch was applied to achieve the following:
>
>  * Add missing depends on pkg-config for adequate so it can test the 
>new missing-pkgconfig-dependency tag;

That's not quite right. adequate doesn't have hard dependency on 
pkg-config. It silently skips pkg-config checks if the package is not 
installed.

The dependency on pkg-config should have been added to 
debian/tests/control instead. I'll fix it soon.

-- 
Jakub Wilk

Message #17 received at 787043-close@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 787043-close@bugs.debian.org

Subject: Bug#787043: fixed in adequate 0.13.2

Date: Thu, 28 May 2015 10:34:33 +0000

Source: adequate
Source-Version: 0.13.2

We believe that the bug you reported is fixed in the latest version of
adequate, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 787043@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jakub Wilk <jwilk@debian.org> (supplier of updated adequate package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 28 May 2015 10:42:14 +0200
Source: adequate
Binary: adequate
Architecture: source all
Version: 0.13.2
Distribution: unstable
Urgency: low
Maintainer: Jakub Wilk <jwilk@debian.org>
Changed-By: Jakub Wilk <jwilk@debian.org>
Description:
 adequate   - Debian package quality testing tool
Closes: 787043
Changes:
 adequate (0.13.2) unstable; urgency=low
 .
   * Drop “XS-Testsuite: autopkgtest”.
   * Add pkg-config to the DEP-8 test Depends (closes: #787043).
     Thanks to Micah Gersten for the bug report.
Checksums-Sha1:
 da9266de24261029ea05c99a459bcf89599efd60 1603 adequate_0.13.2.dsc
 e985b66cb68ede276ffed82903222d6475521306 31582 adequate_0.13.2.tar.gz
 9f4b0d2f7e9e46bbfa6d2e2fbea65487bd245b72 24500 adequate_0.13.2_all.deb
Checksums-Sha256:
 a7338d2ecf6a7a09a7027d5cf75da712625adb73e33293726ad182fccc253823 1603 adequate_0.13.2.dsc
 240384838b5662b29b7c3e4eae6c2992b8b27859d319586d4fb410e126a343e5 31582 adequate_0.13.2.tar.gz
 119db6728d4afccd8bbd04415b66b77ca0eaca8583647505e23a06b727270b07 24500 adequate_0.13.2_all.deb
Files:
 5eab0fc65fd9094441d05c592da83e43 1603 utils optional adequate_0.13.2.dsc
 17f52cc81fe966b3c74765956b36e7e2 31582 utils optional adequate_0.13.2.tar.gz
 f5de68ed421e6d6c01ce6c6e80d8a382 24500 utils optional adequate_0.13.2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVZtnAAAoJEC1Os6YBVHX1bmgP/0a0vsdmVu/Zrw557idxNzBp
T31nlInNw6aMKP+L8jHt3SQBSI/2VvCINKVC80JvqU99BNLgKk4lJAsK0A0auWKH
3/BDyTrK4sfyH2Ua6Qg2MlqKvy+8E2OnzQHZuRrrAagKtvDnLo478Jy+Sz5JqLWp
CT0M27OUuJ0N/j9BrFOfxTNm2G+8uacP5XmrwTtRw9BazOyY68mbV18pdTwvZvts
re2Imgi2UX9oWnCQj3Dj4THKj+yh2fjRTGQGQQZANGBu4edsVfKuuKdkKSsTU4dw
IISpa//RnLrFT+7ZSufiU0izJ2Sbr1o4kGkE6IVkAEGV1bZuLZLhGh2Mc3PEJswc
D8lRUejFRnj4G5hNgvejgKQCnng8Tb19QKjk3/9P20nXQ+7aq5ygCYkbaelf4piO
MhvEU2Z2aBn9ZJVPTkP2BBiGUiJFSQ1uMhgUJP6t7yUtztfQaL4cjrnDOm9Po2mq
drnZtk1hjZB7V/KsgF8A6xQw7z3DjtqsnkHsglb7KfkmRhU7W+wTQygMns7g9jSL
lwAg+f3quphmZCKbQBxuOl3vGOzgdUjdvz0f1ln8T3uAiJUCcZB0qa2Cq4QEreXR
8TZLZ4AhsG/3pYxsttpB7vRgVY2PT/VsCMedMkJuzXDJo8fu1Ox7vaEMMiWQNM+I
yH+Us4S5sOAPnuLC+M6/
=XQUx
-----END PGP SIGNATURE-----

Message #22 received at 787043@bugs.debian.org (full text, mbox, reply):

From: Micah Gersten <micahg@ubuntu.com>

To: Jakub Wilk <jwilk@debian.org>,787043@bugs.debian.org

Subject: Re: Bug#787043: adequate: Adequate needs dependency on pkg-config for new missing-pkgconfig-dependency tag

Date: Thu, 28 May 2015 15:12:56 -0500

[Message part 1 (text/plain, inline)]

Hi Jakub,
Thanks for getting the autopkgtest fix in so quickly. 

On May 28, 2015 2:56:18 AM CDT, Jakub Wilk <jwilk@debian.org> wrote:
>Hi Micah!
>
>Thanks for the bug report.
>
>* Micah Gersten <micahg@ubuntu.com>, 2015-05-27, 23:58:
>>In Ubuntu, the attached patch was applied to achieve the following:
>>
>>  * Add missing depends on pkg-config for adequate so it can test the 
>>new missing-pkgconfig-dependency tag;
>
>That's not quite right. adequate doesn't have hard dependency on 
>pkg-config. It silently skips pkg-config checks if the package is not 
>installed.

Shouldn't it at least be a recommends since one would probably want to check all the tags in all but unusual cases? Or at least a Suggests? Otherwise, someone might not realize there's missing functionality.  I can file a new bug for this if you like.
Thanks, 
Micah

[Message part 2 (text/html, inline)]

Message #25 received at 787043@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 787043@bugs.debian.org

Cc: Micah Gersten <micahg@ubuntu.com>

Subject: Re: Bug#787043: adequate: Adequate needs dependency on pkg-config for new missing-pkgconfig-dependency tag

Date: Fri, 29 May 2015 13:20:26 +0200

Control: retitle 787043 adequate: missing autopkgtest dependency on pkg-config
Control: clone 787043 -1
Control: retitle 787043 -1 adequate: missing Suggests/Recommends on pkg-config
Control: found -1 0.13.2

* Micah Gersten <micahg@ubuntu.com>, 2015-05-28, 15:12:
>>adequate doesn't have hard dependency on pkg-config. It silently skips 
>>pkg-config checks if the package is not installed.
>Shouldn't it at least be a recommends since one would probably want to 
>check all the tags in all but unusual cases? Or at least a Suggests?

You're right of course.

-- 
Jakub Wilk

Send a report that this bug log contains spam.