Debian Bug report logs - #786421
warn against usage of spaces, i.e. 'Type = notify' in systemd unit files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Patrick Schleizer <adrelanos@riseup.net>

To: submit@bugs.debian.org

Subject: warn against usage of spaces, i.e. 'Type = notify' in systemd unit files

Date: Thu, 21 May 2015 13:24:58 +0000

Package: lintian
Severity: wishlist

systemd man pages always uses the syntax without spaces, for example
'Type=notify' and so forth.

A systemd contributor on #systemd irc.freenode.net also recommended
against it.

<zdzichu> adrelanos: please do not use spaces
<zdzichu> adrelanos: there was recently a problem with spaces in ExecStart=

There is an issue with deb-systemd-helper when using spaces. [1]

Therefore I suggest to add a lintian warning when spaces of that type
are found in systemd unit files.

Cheers,
Patrick

[1] deb-systemd-helper fails to enable systemd units when using
'WantedBy = ' with spaces [2]
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786418

Message #10 received at 786421@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Debian Bug Tracking System <786421@bugs.debian.org>

Subject: Re: warn against usage of spaces, i.e. 'Type = notify' in systemd unit files

Date: Sat, 13 Jun 2015 12:47:06 -0300

[Message part 1 (text/plain, inline)]

Package: lintian
Followup-For: Bug #786421
Control: tag -1 patch

Please find attached a patch that implements this check.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.0.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                       2.25-8
ii  bzip2                          1.0.6-8
ii  diffstat                       1.58-1
ii  file                           1:5.22+15-2
ii  gettext                        0.19.4-1
ii  hardening-includes             2.7
ii  intltool-debian                0.35.0+20060710.2
ii  libapt-pkg-perl                0.1.29+b2
ii  libarchive-zip-perl            1.39-1
ii  libclass-accessor-perl         0.34-1
ii  libclone-perl                  0.38-1
ii  libdpkg-perl                   1.18.1
ii  libemail-valid-perl            1.195-1
ii  libfile-basedir-perl           0.03-1
ii  libipc-run-perl                0.94-1
ii  liblist-moreutils-perl         0.410-1
ii  libparse-debianchangelog-perl  1.2.0-3
ii  libtext-levenshtein-perl       0.12-1
ii  libtimedate-perl               2.3000-2
ii  liburi-perl                    1.64-1
ii  man-db                         2.7.0.2-5
ii  patchutils                     0.3.4-1
ii  perl [libdigest-sha-perl]      5.20.2-6
ii  t1utils                        1.38-4
ii  xz-utils                       5.1.1alpha+20120614-2+b3

Versions of packages lintian recommends:
ii  dpkg                            1.18.1
ii  libautodie-perl                 2.25-1
ii  libperlio-gzip-perl             0.18-3+b1
ii  perl                            5.20.2-6
ii  perl-modules [libautodie-perl]  5.20.2-6

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.18.1
ii  libhtml-parser-perl    3.71-2
ii  libtext-template-perl  1.46-1
ii  libyaml-perl           1.13-1

-- no debconf information

[0001-checks-systemd.-desc-pm-Add-check-to-detect-service-.patch (text/x-diff, attachment)]

Message #19 received at 786421-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 786421-close@bugs.debian.org

Subject: Bug#786421: fixed in lintian 2.5.32

Date: Sun, 28 Jun 2015 13:05:46 +0000

Source: lintian
Source-Version: 2.5.32

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 786421@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 28 Jun 2015 14:08:29 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.32
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 lintian    - Debian package checker
Closes: 646965 761649 762105 762179 763456 763457 767867 771191 778328 783628 785084 785329 785353 785662 786362 786421 786533 786895 787248 787930 787937 788629 788796 788839 789151
Changes:
 lintian (2.5.32) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - changelog-empty-entry
       - dh-manual-sequence-control-obsolete
       - license-problem-non-free-img-lenna
       - missing-intermediate-directory
       - package-contains-cmake-private-file
       - package-contains-mime-file-outside-package-dir
       - package-install-apt-preferences
       - package-install-apt-sources
       - package-install-ieee-data
       - service-key-has-whitespace
       - source-contains-autogenerated-gperf-data
       - source-contains-data-from-ieee-data-oui-db
       - static-library-has-unneeded-section
     + Removed:
       - hyphen-used-as-minus-sign
 .
   * checks/*.pm:
     + [NT] Rewrite to handle new check_spelling{,_picky}
   * checks/binaries.pm:
     + [NT] Also apply the binary-has-unneeded-section check on
       static libs.  (See #662998)
   * checks/cruft.{desc,pm}:
     + [BR] Detect non free lenna file based on filename and filetype.
       (Closes: #771191).
     + [BR] Avoid a false positive for autogenerated index in dx package
       for source-is-missing.
   * checks/changes-file.{desc,pm}:
     + [NT] Downgrade backports-changes-missing to a wishlist (I) tag.
       Thanks to Vincent Cheng for the report.  (Closes: #785084)
   * checks/changelog-file.{desc,pm}:
     + [BR] Detect empty changelog entry.  (Closes:  #763457)
   * checks/debhelper.{desc,pm}:
     + [NT] Warn about using dh --{until,before,after,remaining} as
       these are deprecated and have been since debhelper/8.9.4.
     + [NT] Permit the use of dh-exec-install in ".manpages" as well
       since dh-exec now advertises this as acceptable.  Thanks to
       Andreas Henriksson for reporting this.  (Closes: #788796)
   * checks/fields.pm:
     + [BR] Detect double comma in  uploaders fields.
       (Closes: #783628).
   * checks/files.{desc,pm}:
     + [NT] Apply patch from Tomasz Buchert to avoid false-positive
       package-contains-timestamped-gzip in some cases.
       (Closes: #762105)
     + [BR] Detects // tricks in privacy breach test.
       (Closes: #786362)
     + [BR] Apply patch from Lisandro Damián Nicanor Pérez Meyer
       for detecting private cmake file.
       (Closes: #785329).
     + [BR] Detect package shipping apt_preferences(5) file.
       (Closes: #786533).
     + [BR] Detect package shipping oui or iab ieee database.
       (Closes: #785662).
     + [NT] Add a check for packages without intermediate
       directories.
     + [BR] Avoid a false positive in jsom for defaultpresets.xml
       from openmapstreet.
     + [NT] Tweak the "extra-license-file" check to avoid some
       common false-positives.
     + [BR] Raise severity of package-contains-timestamped-gzip.
       (Closes: #778328).
     + [BR] Detect package shipping apt_sources(5) file.
       (Closes: #646965).
     + [BR] Warn about files installed in /usr/share/mime/ other
       than in packages/.  (Closes: #761649).
   * checks/java.pm:
     + [NT] Fix "off-by-one" in the check for the maximum permitted
       Java major version.
   * checks/manpages.{desc,pm}:
     + [NT] Retire the hyphen-used-as-minus-sign tag as upstream now
       renders both "-" and "\-" as HYPHEN-MINUS.  (Closes: #785353)
   * checks/po-debconf.pm:
     + [JW] Use TMPDIR rather than TEMPDIR for temporary files.
       (Closes: #787930)
   * checks/source-copyright.pm:
     + [NT] Apply patch from Evgeni Golov to permit multiple
       different "public-domain licenses", as they are expected to
       describe why the affected files are in public domain.
       (Closes: #787248)
   * checks/systemd.{desc,pm}:
     + [NT] Apply patch from Felipe Sateler to mark service files in
       /usr/lib as invalid.  (Closes: #788629)
     + [NT] Apply patch from Felipe Sateler to detect service files
       that use spaces around the = in the key definition.
       (Closes: #786421)
 .
   * collection/{debfiles,doc-base-files,init.d,menu-files}{,.desc}:
     + [NT] Remove deprecated and unused collections.  These were
       deprecated in 2.5.28.  Note that debfiles was omitted in the
       deprecation list by mistake in the original 2.5.28 release.
   * collection/objdump-info:
     + [NT] Also analyse static libraries.
   * collection/unpacked:
     + [NT] Apply patch from Tomasz Buchert to extract the full time
       in UTC.
 .
   * commands/reporting-sync-state.pm:
     + [NT] Read mirror files as UTF-8 files to avoid mojibake in
       maintainer names.  Once again, thanks to Andreas Rönnquist
       for the report.
   * commands/spellintian.pm:
     + [JW,NT] Import Jakub Wilk's spellintian tool with minor
       modifications.
 .
   * data/binaries/embedded-libs:
     + [BR] Detect embedded ieee-data package.
   * data/cruft/non-free-license:
     + [BR] Detect autogenerated gperf data.  (Closes: #762179).
     + [BR] Detect ieee oui db in source files.
   * data/cruft/missing-dir-search-path:
     + [BR] Fix a false positive in fspy for source-is-missing.
   * data/cruft/warn-file-type:
     + [BR] Fix a false positive source-is-missing by checking
       -nc.js suffix.
     + [BR] Fix a false positive source-is-missing in zivot
       package by adding .e as binary suffix.
     + [BR] Fix a false positive source-is-missing by adding
       yorick source file as source.
     + [BR] Fix a false positive source-is-missing in
       haskell-pretty-show by adding -src.js suffix.
     + [BR] Fix a false positive source-is-missing in
       iceweasel by adding -prod.js suffix.
   * data/debhelper/*:
     + [NT] Refresh against unstable to pick up the rename of
       libaqbanking-dev.  Thanks to Micha Lenk for the reminder.
       (Closes: #787937)
   * data/debhelper/filename-config-files:
     + [NT] Add "links" file.
   * data/fields/archive-sections:
     + [NT] Pre-emptively support the "debugsym" section, which is
       expected to be used by debhelper for "ddebs".
   * data/files/js-libraries:
     + [NT] Apply patch from Jean-Michael Vourgère to detect
       embedded versions of libjs-raphael.  (Closes: #788839)
   * data/files/privacy-breaker-websites:
     + [BR] Detect mascot as logos.
   * data/java/constants:
     + [NT] Accept Java7 class files without warning as OpenJDK-7
       is now the default implementation.  Thanks to Markus
       Koschany for the report.  (Closes: #786895)
 .
   * debian/changelog:
     + [NT] Add missing list of new / removed tags to the
       entry for the previous release.
     + [NT] Add missing "debfiles" in the list of collections
       deprecated in 2.5.28.  It was deprecated in that release
       despite the omission.
   * debian/copyright:
     + [NT] Document new text case being under the Expat license.
   * debian/{lintian.links,manpages}:
     + [NT] Install spellintian in PATH and install its manpage.
       Thanks to Paul Wise for the suggestion.  (Closes: #767867)
   * debian/rules:
     + [NT] Generate the spellintian manpage during build.
 .
   * frontend/spellintian:
     + [NT] Add symlink to dplint.
 .
   * helpers/coll/objdump-info-helper:
     + [NT] Collect readelf output from static libraries.
     + [NT] Fix bug that caused lintian to ignore the up to 10
       valid named sections.
 .
   * lib/Lintian/Check.pm:
     + [NT] Rewrite check_spelling{,_picky} with a new interface,
       which is better suited for additional purposes than just
       emitting Lintian tags.
     + [JW, NT] Normalise spaces a bit better in check_spelling to
       catch some "multi-word" misspellings, where said words are
       not on the same line.  (Closes: #763456)
   * lib/Lintian/Collect/Binary.pm:
     + [JW, NT] Make is_pkg_class case-insensitive to avoid some
       false-positive "empty-binary-package" warnings.
       (Closes: #789151)
     + [NT] Make data from static libraries available.
   * lib/Lintian/Collect/Package.pm:
     + [NT] Create "faux" Lintian::Path entries for missing
       intermediate directories.  This avoids a crash and made
       some checks work correctly even in the absence of such
       immediate directories.  (Closes: LP: #1351380)
   * lib/Lintian/Path.pm:
     + [NT] Apply patch from Tomasz Buchert to add "timestamp"
       method.
     + [NT] Add "faux" method that returns at truth value for
       path entries, which Lintian has created from templates
       to fully connect all path entries in the package.
   * lib/Lintian/Tag/Info.pm:
     + [NT] Expand BTS links using https rather than http.
   * lib/Test/Lintian.pm:
     + [NT] Output spelling mistakes as "diag()" messages now.
 .
   * mail-templates/source-is-missing:
     + [BR] Apply patch from Holger Levsen improving language.
 .
   * profiles/debian/ftp-master-auto-reject.profile:
     + [NT] Refresh against current rule set.
 .
   * t/scripts/spellintian.t:
     + [JW,NT] Import spellintian test case.
Checksums-Sha1:
 f3f8f709de68e4a33f205e711ffda012db03d48c 2731 lintian_2.5.32.dsc
 04dc7f24cdda09edce9997674f0af2dc06a2fcde 1215216 lintian_2.5.32.tar.xz
 e3d6decacd05d878b8c11ab328bea69ac1f91748 816250 lintian_2.5.32_all.deb
Checksums-Sha256:
 618f706d682398109e71b09675b6a727b2a71dc4fcdbac22733c2fd9618972de 2731 lintian_2.5.32.dsc
 ddb33e7d1403a0f731e21b0ae9df134b354ba0538adbb733e1e3fbc40079be09 1215216 lintian_2.5.32.tar.xz
 3dc2b5a71109659c3e91ffd6fc9b9e1f5ff175ea3c61d11df30e73e3364fba6b 816250 lintian_2.5.32_all.deb
Files:
 72871ad01f84b6ab12eab6bd06751256 2731 devel optional lintian_2.5.32.dsc
 0de167219a6e9d8d40c727f875e70cf8 1215216 devel optional lintian_2.5.32.tar.xz
 b43309c116954b682232bc1a1ab8433a 816250 devel optional lintian_2.5.32_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVj+z+AAoJEAVLu599gGRCytsP/RAJ3D8ok2yZznBzdLIesRhb
bmJ4Crj+T5/jlXGuSBCi38xIiuigzPNIMbniMi/1PG8eQ+1PcI+e6do/CyP957+t
1EtJtL+AYwb63wewR6PQmStWDh5KS8vXXnRdgSXcYz4P6LIXdI+l66/gVq53KUcJ
KHdGCUE2cD8qCeE/y96TbfIr+shKOqFC2FIXf1WSfIAL+6EPoDdADXa6MUHrD/AF
dKuopJc/2NWwrfwer25hB0ZYD9OGGNijduWJ2f/xt40zMVdmRY6/VKDO0q1c5SCv
k2CIAGGxO/yYBasxiVmZQ5qE7OBNOvV2K1mpLHjiwH+a4vUcgDON4e2q7YzXrEdx
UUJ09sq0eV2aZk941wK6UEibqA7omMckIK0BK41eAxlxUblkG5QX6jT52Ma+/s2F
5OSLIiqSbOdCwupzl0rkTxNp/Be7UoReI107arF4NRL02EU7ZHA+No6T/J7AnOmO
Gb+qAAERJFIAvC42JpzDMHq6iPOdNQGxbXluUIUIlj0dJBdScLuobIQ7jtKUHp0T
Gjgxzmjued4enXvR4NpInTAfKPu7a40Gt5JbS/A32WPW49LaU74Tpl/+Wq5rWqWB
Ou3uOor9F3YgtUHDKV88ODQRIltesOm0Tr92Z/4nIAJTWD76Msf4RcEqnfH4WI+s
KWUXPhCdzKyQfbNzNvCN
=h1B5
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.