Debian Bug report logs - #786351
Eigen2 support is deprecated in Eigen 3.2.x and will be removed in Eigen 3.3

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Anton Gladky <gladk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Eigen2 support is deprecated in Eigen 3.2.x and will be removed in Eigen 3.3

Date: Wed, 20 May 2015 22:27:51 +0200

Package: step
Version: 1:1.2.2-1.1
Severity: wishlist
Usertags: remove-eigen2-support

Dear Maintainer,

your package has libeigen3-dev in build-depends but
uses EIGEN2_SUPPORT define, which is deprecated
and will be removed in the next stable Eigen3 version [1].

Please try to migrate your package fully on Eigen3 and not
to use Eigen2-specific modules and constructions.

The bug`s severity will be raised when the new version of
eigen3 will be uploaded into Debian.

[1] http://eigen.tuxfamily.org/dox/Eigen2SupportModes.html

Thanks,

Anton

Message #10 received at 786351@bugs.debian.org (full text, mbox, reply):

From: Anton Gladky <gladk@debian.org>

To: 786351@bugs.debian.org, Control bugs server <control@bugs.debian.org>

Subject: Patch, upload to experimental?

Date: Tue, 15 Sep 2015 22:32:38 +0200

[Message part 1 (text/plain, inline)]

tags 786351 +patch
thanks

Dear maintainer,

in attachment there is a proposed patch, which removes
eigen2_support for this package. The patch is relatively
large, but it should work and it will be very good to ask
upstream to merge it there.

There is one problem place in this patch (see comments
starting from "This term was disabled...."). There is a
Vector2d constructed as Vector2d(double), what is
strange and leads to undefined behavior, because it
requires 2 values. Such construction fails to build with
a 3.3~alpha1 of eigen3 (in experimental).

Is it OK for you if I apply this patch and upload it to
experimental to test this version?

Thank you

Anton

[0001-Remove-eigen2-support.-Closes-786351.patch (text/x-patch, attachment)]

Message #17 received at 786351-close@bugs.debian.org (full text, mbox, reply):

From: Maximiliano Curia <maxy@debian.org>

To: 786351-close@bugs.debian.org

Subject: Bug#786351: fixed in step 4:15.08.0-2

Date: Wed, 16 Sep 2015 05:34:32 +0000

Source: step
Source-Version: 4:15.08.0-2

We believe that the bug you reported is fixed in the latest version of
step, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 786351@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Maximiliano Curia <maxy@debian.org> (supplier of updated step package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 16 Sep 2015 07:27:30 +0200
Source: step
Binary: step
Architecture: source
Version: 4:15.08.0-2
Distribution: experimental
Urgency: medium
Maintainer: Debian/Kubuntu Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Maximiliano Curia <maxy@debian.org>
Description:
 step       - interactive physical simulator for KDE
Closes: 786351
Changes:
 step (4:15.08.0-2) experimental; urgency=medium
 .
   * New patch: eigen3.patch, that removes the eigen2 support (Closes:
     #786351) Thanks to Anton Gladky
Checksums-Sha1:
 096a846f6378d8b17cb61a2f67120200c5f0325e 2315 step_15.08.0-2.dsc
 9be334f1897be3f24b2e3e0c04f30c694a842371 9520 step_15.08.0-2.debian.tar.xz
Checksums-Sha256:
 a0e4b342716828d90dcc6ce99a229a6ec5e81db533c31bb461d1fd3d1d8c31c8 2315 step_15.08.0-2.dsc
 e8cc3f637de6da75132e68c36aafc711882250e7023c118182b379a36ada16a5 9520 step_15.08.0-2.debian.tar.xz
Files:
 a55a5d74ecbef976af890bbab1ff56b7 2315 kde optional step_15.08.0-2.dsc
 1ee7c857f4dad7c159797dfaf23f47e6 9520 kde optional step_15.08.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJV+P39AAoJEMcZdpmymyMqxTkQAL3uiE2XiQ9V1m3NzLQYLlGz
MiYw35pKl5hmSTggk2JlT804uk0wMqzn/DpN1lUMKXYMWa63MFE8rmqSNnlapTrg
1LDRCOYHHHplFLkST07+/OwVIxJO/nG1CFal0+UCblv8b0spZJuQwuS6YpWg3I//
K2wr+W0mqT4cF/8ZmrFnQ5nRJuA8CVI47nlyq4Pp0BNyXf3tzdXZjm9XAl4rDKEE
/Mc9LDbwpnyLFeh2pAvDl/5q1y9RdyIoxu459GkjPRTH3u8R0hl8oi+aedqx2OBf
FBUPG0eFzKfEp5e+3z433Dz6jvBWjvXNhwFj6Yvg0hhb+dBoNiPtdtfJQKQN6/RM
SpUtiu7vssqSUIZrse5KeKFXJ3XRjIGx/7C4UZUziDkvhCrIedg76sPVZ9eQQKBJ
ZA70RQCDwVGoKitB0nuK0fvuqk0LlZBzx+kcOFLiaeZB9BDsqe4X7vineN8BBOR1
nbLiKsesERJGbbq8bh2doq19jSE/rtDMGWKFeXUPwjFZtA/gWkL4GGJSenEPgY/k
KVEFCytu3sjzYbpZyvM0UOKG5yTrDqsVqGTDRy/FEODcyE3EtroHLPX1eaTGs0Sg
DflVSfaQKLDUIE6hrXEwMluMBQTzNTbuZefRo4IhIDNWpReW94DsKm+IxzVGQclD
6ljQ1nUgK+q7Pn57jZPs
=B0Ac
-----END PGP SIGNATURE-----

Message #22 received at 786351@bugs.debian.org (full text, mbox, reply):

From: Maximiliano Curia <maxy@gnuservers.com.ar>

To: Anton Gladky <gladk@debian.org>, 786351@bugs.debian.org

Subject: Re: Bug#786351: Patch, upload to experimental?

Date: Wed, 16 Sep 2015 07:42:27 +0200

[Message part 1 (text/plain, inline)]

Hi,

On 15/09/15 22:32, Anton Gladky wrote:
> tags 786351 +patch
> thanks

> in attachment there is a proposed patch, which removes
> eigen2_support for this package. The patch is relatively
> large, but it should work and it will be very good to ask
> upstream to merge it there.

> There is one problem place in this patch (see comments
> starting from "This term was disabled...."). There is a
> Vector2d constructed as Vector2d(double), what is
> strange and leads to undefined behavior, because it
> requires 2 values. Such construction fails to build with
> a 3.3~alpha1 of eigen3 (in experimental).

> Is it OK for you if I apply this patch and upload it to
> experimental to test this version?

I've adapted your patch missing piece to something that makes sense gut wise,
that is, the first Vector2d is the variance related to the charges and the
second one to the position.

In any case, the previous version was segfaulting in this calculation.

I've uploaded this patched version to experimental, and it needs to be tested.
At the same time we need to send this patch upstream, could you do this?
It's always better to be able to give some input on the patch if upstream has
some question regarding it, and eigen3 wise, you are the expert here.

Happy hacking,
-- 
"Can you imagine what I would do if I could do all I can?" -- Sun Tzu
Saludos /\/\ /\ >< `/

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 786351@bugs.debian.org (full text, mbox, reply):

From: Anton Gladky <gladk@debian.org>

To: Maximiliano Curia <maxy@gnuservers.com.ar>

Cc: 786351@bugs.debian.org, Control bugs server <control@bugs.debian.org>

Subject: Re: Bug#786351: Patch, upload to experimental?

Date: Wed, 16 Sep 2015 23:06:48 +0200

forwarded 786351 https://git.reviewboard.kde.org/r/125269/
thanks

Send a report that this bug log contains spam.