Debian Bug report logs - #785271
dh_bash-completion script/file list autodetection fails hiding bugs which can become RC

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dh_bash-completion script/file list autodetection fails hiding bugs which can become RC

Date: Wed, 13 May 2015 23:19:12 -0300

Package: bash-completion
Version: 1:2.1-4.1
Severity: serious
Justification: hides bugs which can become RC

dh_bash-completion's heuristics for detecting wheter a
debian/package.bash-completion file is a script or a list of files it's not
safe enough, hiding possible bugs which can create RC bugs like #785267.

In this case the problem was that the paths listed contained ther version
of cmake in it. The version changed and dh_bash-completion detected the file
as a script causing #785267, instead of failing and telling the maintainer
that there was a problem.

I think the best thing to do here is simply list files and not expect scripts,
they can easily be added there.

Another way to solve this could be changing the file suffix to something like
bash-completion-script and/or bash-completion-install.

For now the easy way around is using * in the paths, but that's just a
workaround.

Kinds regards, Lisandro.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages bash-completion depends on:
ii  bash  4.3-12
ii  dpkg  1.17.25

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information

Message #10 received at 785271@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <ah@debian.org>

To: Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org>, 785271@bugs.debian.org

Subject: Re: dh_bash-completion script/file list autodetection fails hiding bugs which can become RC

Date: Fri, 8 Jul 2016 12:29:58 +0000

Hello!

As I've done bash-completion NMU(s) the RC bugs for this Debian package
now shows up on my tracking page, thus commenting on this issue...

I think your bug report makes kind of sense and in some ways I agree,
but at the same time I totally disagree with the severity you've
set. You're basically saying the current design of the dh_bash-completion
helper is wrong and suggesting another design. This is in my view
a "wishlist" severity request according to debian policy. You're mentioning
a case where you incorrectly used the helper with disastrous result. That
is a RC issue in *your* package for sure, but in the view of the helper
it's just you using the helper incorrectly (and thus ending up with
undefined results).

Changing the design of the helper now could be problematic for existing
users so likely you'd instead want to introduce a new helper and then
use that and convert existing users over to the new one while finally
deprecating/removing the old helper.

Unless you're volunteering to actually fix this issue (which doesn't
seem to be the case since nothing has happened in over a year) I'll
go downgrade the severity to wishlist. Ok?

Regards,
Andreas Henriksson

Message #15 received at 785271@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <andreas@fatal.se>

To: 785271@bugs.debian.org

Subject: dh_bash-completion: lowering severity and wontfix

Date: Mon, 1 Aug 2016 01:27:26 +0200

Control: severity -1 wishlist
Control: tags -1 + wontfix

Hello!

Given the lack of followup on my previous mail I'm following up
with setting what I consider the correct severity for this bug
report. While at it I'm also tagging wontfix as I don't think
there are any volunteers to work on redesigning the helper
(which existance is kind of questionable since in my view
it doesn't bring much more than dh_install with additional
rename support, which if needed dh-exec is a more flexible and
general solution for anyway).

Regards,
Andreas Henriksson

Send a report that this bug log contains spam.