Debian Bug report logs -
#783826
cloud-utils: growpart uses deprecated sfdisk options
Reported by: Andreas Henriksson <andreas@fatal.se>
Date: Thu, 30 Apr 2015 14:24:07 UTC
Severity: important
Found in version cloud-utils/0.26-2
Fixed in version cloud-utils/0.27-1
Done: Thomas Goirand <zigo@debian.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Thu, 30 Apr 2015 14:24:11 GMT) (full text, mbox, link).
Acknowledgement sent
to Andreas Henriksson <andreas@fatal.se>:
New Bug report received and forwarded. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Thu, 30 Apr 2015 14:24:11 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
Package: cloud-utils
Version: 0.26-2
Severity: important
Dear Maintainer,
Please make growpart (of cloud-utils) use non-deprecated commandline
options for sfdisk. Multiple deprecated options has been removed
in the new upstream 2.26 release of util-linux.
Using CHS partition layouts are generally deprecated and not suitable
for growpart anyway.
Please check with your upstream for preferred solution (and fall
back to fedora solution if needed).
Please get a fixed version into sid ASAP as the upload of util-linux
v2.26.2 will happen soon (and can include a versioned Breaks if you
manage to produce a fixed version).
For reference see:
https://bugzilla.redhat.com/show_bug.cgi?id=1197894
http://pkgs.fedoraproject.org/cgit/cloud-utils.git/tree/0002-Support-new-sfdisk-version-2.26.patch
-- System Information:
Debian Release: 8.0
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 08:21:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Juerg Haefliger <juergh@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 08:21:04 GMT) (full text, mbox, link).
Message #10 received at 783826@bugs.debian.org (full text, mbox, reply):
> Please check with your upstream for preferred solution (and fall
> back to fedora solution if needed).
>
> Please get a fixed version into sid ASAP as the upload of util-linux
> v2.26.2 will happen soon (and can include a versioned Breaks if you
> manage to produce a fixed version).
>
> For reference see:
> https://bugzilla.redhat.com/show_bug.cgi?id=1197894
> http://pkgs.fedoraproject.org/cgit/cloud-utils.git/tree/0002-Support-new-sfdisk-version-2.26.patch
I created the Fedora patch and will contact upstream to see how they
want to handle this.
...Juerg
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 13:18:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Thomas Goirand <thomas@goirand.fr>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 13:18:04 GMT) (full text, mbox, link).
Message #15 received at 783826@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Hi Scott and Juerg,
Someone has filed this bug in Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783826
Unfortunately, the patch here:
http://pkgs.fedoraproject.org/cgit/cloud-utils.git/plain/0002-Support-new-sfdisk-version-2.26.patch
doesn't work with the older sfdisk, currently in Sid, but works with
version 2.26 only.
To make a smooth transition, best would be to make a conditional test,
and check if we're running with util-linux 2.25, or >= 2.26. This would
also allow newer cloud-utils to be backported to Jessie.
This is what I've done on the attached patch. Scott, could you please
use that upstream from now on?
Also, what about the do-not-use-EXIT-when-trapping.patch patch which I
had to add in Debian? Could you please apply them both?
Cheers,
Thomas Goirand (zigo)
[also-support-sfdisk-2.26-and-higher.patch (text/x-patch, attachment)]
[do-not-use-EXIT-when-trapping.patch (text/x-patch, attachment)]
Reply sent
to Thomas Goirand <zigo@debian.org>:
You have taken responsibility.
(Mon, 04 May 2015 13:21:06 GMT) (full text, mbox, link).
Notification sent
to Andreas Henriksson <andreas@fatal.se>:
Bug acknowledged by developer.
(Mon, 04 May 2015 13:21:06 GMT) (full text, mbox, link).
Message #20 received at 783826-close@bugs.debian.org (full text, mbox, reply):
Source: cloud-utils
Source-Version: 0.27-1
We believe that the bug you reported is fixed in the latest version of
cloud-utils, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 783826@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Goirand <zigo@debian.org> (supplier of updated cloud-utils package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 04 May 2015 09:34:24 +0200
Source: cloud-utils
Binary: cloud-utils
Architecture: source all
Version: 0.27-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Cloud <debian-cloud@lists.debian.org>
Changed-By: Thomas Goirand <zigo@debian.org>
Description:
cloud-utils - cloud image management utilities
Closes: 783826
Changes:
cloud-utils (0.27-1) unstable; urgency=medium
.
* New upstream release.
* Refreshed do-not-use-EXIT-when-trapping.patch.
* Added also-support-sfdisk-2.26-and-higher.patch (Closes: #783826).
* Added Debian package maintainers to debian/copyright.
* Build-depends on python-all, not just python.
* Standards-Version: 3.9.6 (no change).
* Added to debian/rules: include /usr/share/openstack-pkg-tools/pkgos.make
and build-depends on openstack-pkg-tools.
* Added Homepage field.
* Fixed lintian warning about non-canonical Vcs-Git.
Checksums-Sha1:
761fe610586c46839f2caa6f27112bed33948d8a 1969 cloud-utils_0.27-1.dsc
cda96c568a50ef5e28476dbaafb5e3706b8e5392 34168 cloud-utils_0.27.orig.tar.xz
5ab5ac49e7fdd9fc46bd1548660247ed77258e3d 7884 cloud-utils_0.27-1.debian.tar.xz
4ae3a2cb6e0b7fa383eac634c13cffeb8b93a11a 43056 cloud-utils_0.27-1_all.deb
Checksums-Sha256:
214d42544c382c7da99b031967da062029d6408ffb6d446d54c5ab996587dd95 1969 cloud-utils_0.27-1.dsc
3329f5e9918299c89e32260d35367321427006bf78fbe86384e0e668cfbe9d2e 34168 cloud-utils_0.27.orig.tar.xz
68cad3d49f29f78672d2814ebbee441654162cf2328c26a1c89d0bd5d4efcb93 7884 cloud-utils_0.27-1.debian.tar.xz
4682309216a9462e6ab639c0e596214f8c46643b81dc94432ab2ea4074c5e365 43056 cloud-utils_0.27-1_all.deb
Files:
d2d0b7a41a0706d0178507680a574ef1 1969 admin extra cloud-utils_0.27-1.dsc
9e4dfcce8982e06fa1120a2c2ff38438 34168 admin extra cloud-utils_0.27.orig.tar.xz
6fd1355543527cc10daa350d8e5d80b3 7884 admin extra cloud-utils_0.27-1.debian.tar.xz
35de7ed0a93f61aadf4533a37c737d97 43056 admin extra cloud-utils_0.27-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVR27wAAoJENQWrRWsa0P+iEQP/0QR9+Gdu0fMtTLW73+PggLX
PXZ2xEiEUL2mE3lkWSqYnx3aTWu5VkyGg9qY4MLHgEAd906UGhnc8EuMVFAGos/a
MJC8R5trwLNFNisGy5z3T+A1Ika+qm3as8HbxAwJO0HWzIJgzjcushTRndHpc3cf
7/lp4TtMYIKxY/phi7CFzz07rbatXuUEZxeaX4GRVsubucesN3eafsiHt/g1MVL+
9R340DlgyNVjGteRFIVwY5sKSZvwfhKV4uWx1wHPGDvR//qB6o2tt4CzLIj3Guae
Bjr8TulZTVYlyS4+0ZD2Y41Xt19dg4WNjHwU8RJSyrn4MdE4dscnltjAdlJEi3U7
1VVDzZjTrCJHgHhG2N9PzBgor/wFVXtrakkx5DkHlxz81pa4mjwPjyF5pBgDsUjC
ZmHF/e1Qfo7EpSMcj9X7wKjRJJn9dpJWuYwfQUlIchnKmKL5ID4jii27zltRTHUo
MztF6oAhoYKh+JAV7znWjavm/x579ICm3hVUFhOresV4DcDzCOBDkOpGki6ezov2
ld5EFNLoW9C8cgolLIRWJqwuV+F7BCHTHncm3F/i8F4kbGkGHNJ3zhBinyY1F4aA
V+2CFn+RCseRlK7fTD8+DB/a09goCgTufQ5KOjH4oUmJTCloWGfqTwcgniSj2buQ
iKAVBQB/HnLeFPw0VGMi
=6kQW
-----END PGP SIGNATURE-----
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 16:51:08 GMT) (full text, mbox, link).
Acknowledgement sent
to Scott Moser <scott.moser@canonical.com>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 16:51:08 GMT) (full text, mbox, link).
Message #25 received at 783826@bugs.debian.org (full text, mbox, reply):
On Mon, 4 May 2015, Thomas Goirand wrote:
> Hi Scott and Juerg,
>
> Someone has filed this bug in Debian:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783826
>
> Unfortunately, the patch here:
> http://pkgs.fedoraproject.org/cgit/cloud-utils.git/plain/0002-Support-new-sfdisk-version-2.26.patch
>
> doesn't work with the older sfdisk, currently in Sid, but works with version
> 2.26 only.
>
> To make a smooth transition, best would be to make a conditional test, and
> check if we're running with util-linux 2.25, or >= 2.26. This would also allow
> newer cloud-utils to be backported to Jessie.
Juerg's 'Support-new-sfdisk-version-2.26.patch' seems to do 4 things:
a.) drop use of MBR_CHS, which I think is probably no longer necessary.
this was originally added when dealing with loop devices, but might not be
necessary with --unit=S.
b.) obtain 'tot' (the total size in sectors) of the disk differently
sfdisk --list
rather than
tot=$$((cyl*$heads*$sectors)
c.) use dd to restore the original in case of failure.
I suspect that you're working around upstream sfdisk bug 1211405 here.
https://bugzilla.redhat.com/show_bug.cgi?id=1211405
I'd rather not make assumptions on the output format of '-O'. Using '-I'
and expecting sfdisk to do the right thing seems safer.
d.) removal of use of --unit=S
util-linux 2.26 seems to support this, so I'd just as soon leave it for
now.
> This is what I've done on the attached patch. Scott, could you please use that
> upstream from now on?
>
> Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
> add in Debian? Could you please apply them both?
EXIT is posix compatible. you really should change the shell to be posix
compatible rather than changing all programs to expect a subset of poxix
shell.
http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
I'll work something up upstream probably based on checking the sfdisk
version.
>
> Cheers,
>
> Thomas Goirand (zigo)
>
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 18:27:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Juerg Haefliger <juerg.haefliger@hp.com>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 18:27:04 GMT) (full text, mbox, link).
Message #30 received at 783826@bugs.debian.org (full text, mbox, reply):
On 05/04/2015 06:48 PM, Scott Moser wrote:
> On Mon, 4 May 2015, Thomas Goirand wrote:
>
>> Hi Scott and Juerg,
>>
>> Someone has filed this bug in Debian:
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=783826
>>
>> Unfortunately, the patch here:
>> http://pkgs.fedoraproject.org/cgit/cloud-utils.git/plain/0002-Support-new-sfdisk-version-2.26.patch
>>
>> doesn't work with the older sfdisk, currently in Sid, but works with version
>> 2.26 only.
>>
>> To make a smooth transition, best would be to make a conditional test, and
>> check if we're running with util-linux 2.25, or >= 2.26. This would also allow
>> newer cloud-utils to be backported to Jessie.
>
> Juerg's 'Support-new-sfdisk-version-2.26.patch' seems to do 4 things:
>
> a.) drop use of MBR_CHS, which I think is probably no longer necessary.
> this was originally added when dealing with loop devices, but might not be
> necessary with --unit=S.
From the manpage of sfdisk 2.26:
-u, --unit S
Deprecated option. Only the sector unit is supported.
> b.) obtain 'tot' (the total size in sectors) of the disk differently
> sfdisk --list
> rather than
> tot=$$((cyl*$heads*$sectors)
>
> c.) use dd to restore the original in case of failure.
>
> I suspect that you're working around upstream sfdisk bug 1211405 here.
> https://bugzilla.redhat.com/show_bug.cgi?id=1211405
>
> I'd rather not make assumptions on the output format of '-O'. Using '-I'
> and expecting sfdisk to do the right thing seems safer.
I agree that the assumption on the filename is ugly and might need
rework but there is no -I option anymore and -O only lets you specify
the fist part of the filename.
From the manpage:
-O, --backup-file path
Override the default backup file name. Note that the device name and
offset are always appended to the file name.
Note that sfdisk since version 2.26 no longer provides the -I option to
restore sectors. dd (1) provides all necessary functionality.
> d.) removal of use of --unit=S
> util-linux 2.26 seems to support this, so I'd just as soon leave it for
> now.
Ok.
...Juerg
>> This is what I've done on the attached patch. Scott, could you please use that
>> upstream from now on?
>>
>> Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
>> add in Debian? Could you please apply them both?
>
> EXIT is posix compatible. you really should change the shell to be posix
> compatible rather than changing all programs to expect a subset of poxix
> shell.
> http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
>
>
> I'll work something up upstream probably based on checking the sfdisk
> version.
>
>
>>
>> Cheers,
>>
>> Thomas Goirand (zigo)
>>
--
Juerg Haefliger
Hewlett-Packard
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 20:21:11 GMT) (full text, mbox, link).
Acknowledgement sent
to Antonio Terceiro <terceiro@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 20:21:11 GMT) (full text, mbox, link).
Message #35 received at 783826@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
On Mon, May 04, 2015 at 12:48:37PM -0400, Scott Moser wrote:
> > Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
> > add in Debian? Could you please apply them both?
>
> EXIT is posix compatible. you really should change the shell to be posix
> compatible rather than changing all programs to expect a subset of poxix
> shell.
> http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
EXIT is supported by dash ... I have just tested the script below and it
works as expected on all Debian release since at least wheezy.
----------------8<----------------8<----------------8<-----------------
$ cat /tmp/test
#!/bin/sh
cleanup() {
echo "exiting ..."
}
trap cleanup EXIT
$ for release in wheezy jessie sid; do echo $release; schroot -c $release /tmp/test; done
wheezy
exiting ...
jessie
exiting ...
sid
exiting ...
----------------8<----------------8<----------------8<-----------------
--
Antonio Terceiro <terceiro@debian.org>
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 20:42:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Scott Moser <scott.moser@canonical.com>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 20:42:04 GMT) (full text, mbox, link).
Message #40 received at 783826@bugs.debian.org (full text, mbox, reply):
On Mon, 4 May 2015, Antonio Terceiro wrote:
> On Mon, May 04, 2015 at 12:48:37PM -0400, Scott Moser wrote:
> > > Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
> > > add in Debian? Could you please apply them both?
> >
> > EXIT is posix compatible. you really should change the shell to be posix
> > compatible rather than changing all programs to expect a subset of poxix
> > shell.
> > http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
>
> EXIT is supported by dash ... I have just tested the script below and it
> works as expected on all Debian release since at least wheezy.
I think its not supported in the static busybox that is in debian
initramfs.
Not sure, but I think that was the problem.
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Mon, 04 May 2015 20:45:12 GMT) (full text, mbox, link).
Acknowledgement sent
to Scott Moser <scott.moser@canonical.com>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Mon, 04 May 2015 20:45:12 GMT) (full text, mbox, link).
Message #45 received at 783826@bugs.debian.org (full text, mbox, reply):
On Mon, 4 May 2015, Juerg Haefliger wrote:
>
> >> This is what I've done on the attached patch. Scott, could you please use that
> >> upstream from now on?
> >>
> >> Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
> >> add in Debian? Could you please apply them both?
> >
> > EXIT is posix compatible. you really should change the shell to be posix
> > compatible rather than changing all programs to expect a subset of poxix
> > shell.
> > http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
> >
> >
> > I'll work something up upstream probably based on checking the sfdisk
> > version.
initial start at
lp:~smoser/cloud-utils/growpart-sfdisk-2.26
I'm open to using sfdisk for gpt also if that actually works (instead of
using sgdisk).
Scott
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Tue, 05 May 2015 08:51:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Thomas Goirand <thomas@goirand.fr>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Tue, 05 May 2015 08:51:04 GMT) (full text, mbox, link).
Message #50 received at 783826@bugs.debian.org (full text, mbox, reply):
On 05/04/2015 10:39 PM, Scott Moser wrote:
> On Mon, 4 May 2015, Antonio Terceiro wrote:
>
>> On Mon, May 04, 2015 at 12:48:37PM -0400, Scott Moser wrote:
>>>> Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
>>>> add in Debian? Could you please apply them both?
>>>
>>> EXIT is posix compatible. you really should change the shell to be posix
>>> compatible rather than changing all programs to expect a subset of poxix
>>> shell.
>>> http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
>>
>> EXIT is supported by dash ... I have just tested the script below and it
>> works as expected on all Debian release since at least wheezy.
>
> I think its not supported in the static busybox that is in debian
> initramfs.
>
> Not sure, but I think that was the problem.
Scott, you are correct, the issue is in early boot using busybox within
the initramfs.
I'm ok with having the issue fixed in Stretch for adding support for
EXIT in busybox, but as you know, it will be a lot more difficult to fix
the issue in Jessie and Wheezy, so I think it's better to just keep the
patch to not use EXIT.
What's the problem for applying the patch upstream? Don't you think that
other distribution may as well have the issue? Shouldn't we just try to
stay on the safe side here?
Cheers,
Thomas Goirand (zigo)
Information forwarded
to debian-bugs-dist@lists.debian.org, Debian Cloud <debian-cloud@lists.debian.org>:
Bug#783826; Package cloud-utils.
(Tue, 05 May 2015 16:15:08 GMT) (full text, mbox, link).
Acknowledgement sent
to Antonio Terceiro <terceiro@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Cloud <debian-cloud@lists.debian.org>.
(Tue, 05 May 2015 16:15:08 GMT) (full text, mbox, link).
Message #55 received at 783826@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
On Tue, May 05, 2015 at 10:48:37AM +0200, Thomas Goirand wrote:
>
>
> On 05/04/2015 10:39 PM, Scott Moser wrote:
> >On Mon, 4 May 2015, Antonio Terceiro wrote:
> >
> >>On Mon, May 04, 2015 at 12:48:37PM -0400, Scott Moser wrote:
> >>>>Also, what about the do-not-use-EXIT-when-trapping.patch patch which I had to
> >>>>add in Debian? Could you please apply them both?
> >>>
> >>>EXIT is posix compatible. you really should change the shell to be posix
> >>>compatible rather than changing all programs to expect a subset of poxix
> >>>shell.
> >>> http://pubs.opengroup.org/onlinepubs/000095399/utilities/trap.html
> >>
> >>EXIT is supported by dash ... I have just tested the script below and it
> >>works as expected on all Debian release since at least wheezy.
> >
> >I think its not supported in the static busybox that is in debian
> >initramfs.
> >
> >Not sure, but I think that was the problem.
>
> Scott, you are correct, the issue is in early boot using busybox within the
> initramfs.
There is something weird, then. I have just tested that same script
against the busybox `sh` from busybox-static on wheezy, jessie and sid
and they all worked just fine.
----------------8<----------------8<----------------8<-----------------
$ cat /tmp/test
#!/bin/sh
cleanup() {
echo "exiting ..."
}
trap cleanup EXIT
$ for release in wheezy jessie sid; do echo $release; echo $release | sed -e 's/./-'/g; echo; schroot -c $release -u root -- bash -x -c 'apt-get install -qy busybox-static >/dev/null 2>&1 && busybox sh -x /tmp/test'; echo; done
wheezy
------
+ apt-get install -qy busybox-static
+ busybox sh -x /tmp/test
+ trap cleanup EXIT
+ cleanup
+ echo exiting ...
exiting ...
jessie
------
+ apt-get install -qy busybox-static
+ busybox sh -x /tmp/test
+ trap cleanup EXIT
+ cleanup
+ echo exiting ...
exiting ...
sid
---
+ apt-get install -qy busybox-static
+ busybox sh -x /tmp/test
+ trap cleanup EXIT
+ cleanup
+ echo exiting ...
exiting ...
$
----------------8<----------------8<----------------8<-----------------
>
> I'm ok with having the issue fixed in Stretch for adding support for EXIT in
> busybox, but as you know, it will be a lot more difficult to fix the issue
> in Jessie and Wheezy, so I think it's better to just keep the patch to not
> use EXIT.
>
> What's the problem for applying the patch upstream? Don't you think that
> other distribution may as well have the issue? Shouldn't we just try to stay
> on the safe side here?
>
> Cheers,
>
> Thomas Goirand (zigo)
>
>
> --
> To UNSUBSCRIBE, email to debian-cloud-request@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: https://lists.debian.org/554883E5.6060703@goirand.fr
>
--
Antonio Terceiro <terceiro@debian.org>
[signature.asc (application/pgp-signature, inline)]
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Sun, 07 Jun 2015 07:27:37 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Thu Jan 4 18:05:48 2018;
Machine Name:
beach
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.