Debian Bug report logs - #783475
texi2html: [PATCH] Allow make the build of documentation reproducible adding the use-date flag.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Juan Picca <jumapico@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: texi2html: [PATCH] Allow make the build of documentation reproducible adding the use-date flag.

Date: Mon, 27 Apr 2015 07:48:53 -0300

[Message part 1 (text/plain, inline)]

Package: texi2html
Version: 1.82+dfsg1
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that texi2html could not allow to built documentation reproducibly.

The attached patch adds the flag use-date that allows use the given  string
for the date, instead the generated timestamps.
Once applied, we can build reproducibly the packages that use
texi2html for generate documentation in our current experimental
framework.

 [1]: https://wiki.debian.org/ReproducibleBuilds

-- System Information:
Debian Release: 8.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

[03_use-date_command_line_option.patch (text/x-diff, attachment)]

Message #12 received at 783475@bugs.debian.org (full text, mbox, reply):

From: Jérémy Bobbio <lunar@debian.org>

To: Juan Picca <jumapico@gmail.com>, 783475@bugs.debian.org

Subject: Re: Bug#783475: texi2html: [PATCH] Allow make the build of documentation reproducible adding the use-date flag.

Date: Fri, 15 May 2015 21:43:11 +0200

[Message part 1 (text/plain, inline)]

Juan Picca:
> The attached patch adds the flag use-date that allows use the given string
> for the date, instead the generated timestamps.

After review, the patch is either unneeded or incomplete.

> @@ -1910,6 +1911,8 @@ sub set_date()
>      }
>      $Texi2HTML::THISDOC{'today'} = $Texi2HTML::Config::DATE 
>          if (defined($Texi2HTML::Config::DATE));
> +    $Texi2HTML::THISDOC{'today'} = $Texi2HTML::Config::USE_DATE
> +        if (defined($Texi2HTML::Config::USE_DATE));

The two lines above actually already allow to set a date externally. I
don't see the need to add a new variable.

> +$T2H_OPTIONS -> {'use-date'} =
> +{
> + type => '=s',
> + linkage => \$Texi2HTML::Config::USE_DATE,
> + verbose => 'use given date in generation timestamps $s'
> +};
> +

Another problem is that the date given here will be copied straight to
the output when the default is to use a translated version of “January 1,
2015” (see `pretty_date` in `T2h_i18n.pm`). I guess it would make sense
to add an extra variable if it would be then use to replace the
`localtime` call in `pretty_date`.

-- 
Lunar                                .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 783475@bugs.debian.org (full text, mbox, reply):

From: Juan Picca <jumapico@gmail.com>

To: Debian Bug Tracking System <783475@bugs.debian.org>

Subject: Re: texi2html: [PATCH] Allow make the build of documentation reproducible adding the use-date flag.

Date: Sun, 17 May 2015 20:25:31 -0300

[Message part 1 (text/plain, inline)]

Package: texi2html
Version: 1.82+dfsg1-3
Followup-For: Bug #783475

Modified patch after comments and advices of Jérémy Bobbio.
The option was renamed to --build-date and now expects an unix time
integer which is formatted using pretty_time instead of using a given
string to show as timestamp.

-- System Information:
Debian Release: stretch/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

[03_add_build-date_param.patch (text/x-diff, attachment)]

Message #22 received at 783475@bugs.debian.org (full text, mbox, reply):

From: Maria Valentina Marin <marivalenm@gmail.com>

To: 783475@bugs.debian.org

Cc: jumapico@gmail.com

Subject: Re: texi2html: [PATCH] Allow make the build of documentation reproducible adding the use-date flag.

Date: Fri, 07 Aug 2015 19:07:40 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Sun, 17 May 2015 20:25:31 -0300 Juan Picca <jumapico@gmail.com> wrote:
> Modified patch after comments and advices of Jérémy Bobbio.
> The option was renamed to --build-date and now expects an unix time
> integer which is formatted using pretty_time instead of using a given
> string to show as timestamp.

I have done two modifications to your patch:

 - Instead of letting the default for --build-date be undef (resulting
in the date of today being printed) the default is now the values of the
environment variable $SOURCE_DATE_EPOCH.

 - Explicitly check if variable is undef or otherwise SOURCE_DATE_EPOCH
can never be set to 0 as this would then evaluate as false

Kind regards,
akira

[texi2html-source-date-epoch.diff (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 783475@bugs.debian.org (full text, mbox, reply):

From: Maria Valentina Marin <marivalenm@gmail.com>

To: 783475@bugs.debian.org

Subject: Re: texi2html: [PATCH] Allow make the build of documentation reproducible adding the use-date flag.

Date: Sat, 08 Aug 2015 09:27:38 +0200

[Message part 1 (text/plain, inline)]

Hi,

In addition to my last update to this bug I have now also patched
texi2html to sort its hash values, which solves the issue
randomness_in_html_generated_by_texi2html [1].

The attached debdiff fixes this an also includes the changes of the
previous patches and is ready to be QA uploaded.

Kind regards,
akira

[1]
https://wiki.debian.org/ReproducibleBuilds/RandomnessInHTMLGeneratedByTexi2html

[texi2html.debdiff (application/octet-stream, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #32 received at 783475-close@bugs.debian.org (full text, mbox, reply):

From: akira <marivalenm@gmail.com>

To: 783475-close@bugs.debian.org

Subject: Bug#783475: fixed in texi2html 1.82+dfsg1-4

Date: Sat, 08 Aug 2015 07:34:18 +0000

Source: texi2html
Source-Version: 1.82+dfsg1-4

We believe that the bug you reported is fixed in the latest version of
texi2html, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 783475@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
akira <marivalenm@gmail.com> (supplier of updated texi2html package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 08 Aug 2015 09:04:44 +0200
Source: texi2html
Binary: texi2html
Architecture: source all
Version: 1.82+dfsg1-4
Distribution: sid
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: akira <marivalenm@gmail.com>
Description:
 texi2html  - Convert Texinfo files to HTML
Closes: 783475
Changes:
 texi2html (1.82+dfsg1-4) unstable; urgency=medium
 .
   * QA upload.
   * Make texi2html produce reproducible output (Closes: #783475):
      - Add patch: 03_add_build-date_param.patch to honour $SOURCE_DATE_EPOCH and
        command line option --build-date
      - Add patch: 04_sort-perl-hash to sort hash values
Checksums-Sha1:
 17259ef87056caf5ba9486eba468351935e0ee02 1782 texi2html_1.82+dfsg1-4.dsc
 0157683a879afcfaa5add9832915a2834448efc8 4349557 texi2html_1.82+dfsg1.orig.tar.gz
 368293f1da57840e879cb17cb7e9164ec8ec575c 7106 texi2html_1.82+dfsg1-4.diff.gz
 13b9b7efb7947726185814cdf55f870dc5c41e36 356248 texi2html_1.82+dfsg1-4_all.deb
Checksums-Sha256:
 d79557463df89f2564e78ff75ccce09894a8d07bfbefb6b84da266493bdb5f6b 1782 texi2html_1.82+dfsg1-4.dsc
 7ac504504593f404162b53c3d822d0718aab30ca04ab54405940c4cb352f0f9b 4349557 texi2html_1.82+dfsg1.orig.tar.gz
 527412286acd195a05d30084a7779533d4dd940d6387adb7c345fc76854fec44 7106 texi2html_1.82+dfsg1-4.diff.gz
 86421004d0d1ca587b17989dba745f9e7a35eaecf7763bfaa66bbb99b0f22425 356248 texi2html_1.82+dfsg1-4_all.deb
Files:
 f83aece657b7ec51a5f03380c163426d 1782 text optional texi2html_1.82+dfsg1-4.dsc
 2b15ae6289cbcedd34b6855b5d536dc7 4349557 text optional texi2html_1.82+dfsg1.orig.tar.gz
 9fc257bd13b864b4559c655c7f25e0c8 7106 text optional texi2html_1.82+dfsg1-4.diff.gz
 cbdcd25ab2543d90edaf4661c55f3705 356248 text optional texi2html_1.82+dfsg1-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVxa6RAAoJEPLLpcePvYPhBLYP/AvmOozgt0WYpbodP+nsBYv2
fBn6auadXjvK4DHau2mWrsahsnrEiQzLN61CbgQ3Lo785YpQUwab0u/DFwonrueZ
AkTk9iywXlksFNnZIYnkXa3EosvivmZv+MGJ0zMfMzoQ3im51XkWsI5VbL/LTjq9
fMgZvP1seHCvQgNNnuFyQaoHgvZ56uNbWhyrNapI9exWC9daFCUGNUst3C2Okw5M
W4YdxuXNYsFH5j/jaZtfmvKpm3+nZUVExpTkxFzpOfiYi78WSR66ul2VoRq5f5Os
1Gtgc7rO0k7NmiDoM69holrGuJ8xyLQsk655E0o6KxXh70F3m2Vy3dRBeFxwxaZb
GCT/mfGKZ8KaOB13NdpX10ZEmcJ2SgnwLLSYN7udFqAPcYWqfArpNurSmACw/6HJ
GcegF2/5tGs7azTgF2bzUshLWFRdLvMpXoppCeGVLXD6wh5rx8Vb4Q7KYsrgpk3k
5eGR17vvn/HLeopiOz8PwXxSY5byPWcRSnPB/y3vdq1oyLXXqxJj7+mjWSylAKPC
D9w4/rQFHXny37HMJN02TiQkk9ywqmsPc6iGUCzV0NhDD1vPgohJegG7Vpoi+6dc
cBI5r4OnsEfCcczfdShfC8SE1ckxEr6fSsJkYHsIBoiKVWtTTN5EFjeiXCB2l5i/
bNv2q9diOaKYSUOfUlA7
=B9xY
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.