Debian Bug report logs - #782624
Hard-codes "firefox"

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Trent W. Buck" <trentbuck@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Hard-codes "firefox"

Date: Wed, 15 Apr 2015 16:20:05 +1000

Package: scorched3d
Version: 43.2a.dfsg-6.1
Severity: minor

Clicking on "Help" doesn't do anything for me,
because I don't have "firefox" in my path:

    root@tough:~# cat ~p678/.xsession-errors
    [...]
    sh: 1: firefox: not found

    twb@frey[scorched3d-43.2a.dfsg]$ grep -r firefox
    src/common/common/DefinesScorched.cpp:  std::string buffer = S3D::formatStringBuffer("firefox %s", url.c_str());

This should

  1. probably refer to sensible-browser.
  2. use execvp (or similar), not system().
     (Ref. http://cwe.mitre.org/top25/#CWE-78)

Due to (1), the debian/control may need
Recommends: sensible-utils --
I don't remember what the current rules are for that.


-- System Information:
Debian Release: 8.0
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Message #10 received at 782624-close@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: 782624-close@bugs.debian.org

Subject: Bug#782624: fixed in scorched3d 44+dfsg-1

Date: Sat, 16 Jul 2016 04:25:08 +0000

Source: scorched3d
Source-Version: 44+dfsg-1

We believe that the bug you reported is fixed in the latest version of
scorched3d, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 782624@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <apo@debian.org> (supplier of updated scorched3d package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 16 Jul 2016 04:41:26 +0200
Source: scorched3d
Binary: scorched3d scorched3d-data
Architecture: source
Version: 44+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Markus Koschany <apo@debian.org>
Description:
 scorched3d - 3D artillery game similar to Scorched Earth
 scorched3d-data - data files for Scorched3D game
Closes: 782624 811647
Changes:
 scorched3d (44+dfsg-1) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Phil Morrell ]
   * use https and update vcs urls
   * remove .menu file now .desktop files expected
   * simplify watch file using version 4
   * add myself to uploaders in preparation
   * make debian/copyright machine-readable (DEP-5)
   * update dependency on {ttf,fonts}-dejavu
   * remove fonts-dejavu embedded copy from orig source
   * remove scorched3d-dbg in favour of automatic dgbsym
   * use Files-Excluded for uscan repacking
   * replace custom get-orig-source with uscan
   * clean Makefile.am left over after dh clean
 .
   [ Markus Koschany ]
   * Imported Upstream version 44+dfsg.
   * Declare compliance with Debian Policy 3.9.8.
   * wrap-and-sort -sab.
   * Remove Pre-Depends: dpkg-dev because it is satisfied in every supported
     release.
   * Remove debian/source/options since xz is the default now.
   * Remove override for dh_builddeb. XZ compression is the default now.
   * Remove scorched3d.docs and do not install BUGS and NEWS.Debian anymore.
     Both files contain outdated information.
   * Drop libpng16.patch. Fixed upstream.
   * Drop 0003-remove-embedded-glew.patch.
   * Drop 0005-append-buildflags.patch. Fixed upstream.
   * Refresh 0008-wx3.0-compat.patch.
   * Update debian/copyright and exclude more cruft and non-dfsg files.
   * Add gcc-6-ftbfs.patch and fix FTBFS with GCC-6.
     Thanks to Martin Michlmayr for the report. (Closes: #811647)
   * Export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed.
   * Ensure that Scorched3D can be built twice in a row.
   * Use sensible-browser instead of hardcoding firefox. (Closes: #782624).
     Thanks to Trent W. Buck for the report.
   * Update copyright for new release.
Checksums-Sha1:
 63d25f4906e4cadbdf33d3cbc9b1275e26a86941 2557 scorched3d_44+dfsg-1.dsc
 87b6dc9457584d97fedce3b65f746101f09234b3 32916656 scorched3d_44+dfsg.orig.tar.xz
 f835684952a5d3e0dedd97b44d8c2f3a4b842cce 120888 scorched3d_44+dfsg-1.debian.tar.xz
Checksums-Sha256:
 377a053a97c3dfc23e98521198b69c72a19282acd3c701b38510a0158566e1cd 2557 scorched3d_44+dfsg-1.dsc
 5b5e09bd9b2c186545a75cff9dde893edce766fa80b2ae3a6fe80ef7a2b59e38 32916656 scorched3d_44+dfsg.orig.tar.xz
 4ca73e3c05de68969fadc57e383e5bc627f9fb655cc47c1039dd6215f9071f47 120888 scorched3d_44+dfsg-1.debian.tar.xz
Files:
 30b94c163306f88eb1160e248e614002 2557 games optional scorched3d_44+dfsg-1.dsc
 c21d06a5c8892ed1c032fe1eed07f2d0 32916656 games optional scorched3d_44+dfsg.orig.tar.xz
 eced44bd303e212f646314b3b5faa05a 120888 games optional scorched3d_44+dfsg-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJXialJXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBQ0YzRDA4OEVGMzJFREVGNkExQTgzNUZE
OUFEMTRCOTUxM0I1MUU0AAoJENmtFLlRO1Hk3AQP/2A7b7IWhDm0k7Bq2sN3yNy6
YCWSwdvhNZxn1rK0Scr55yUrhvVCK52Yu628M6oZ5+Hva8UJpenFWK/FEIy8fk1d
K8B5uVTcbGUj4OIt8n4gAXMFFi/+xHTKpiZURLiRJRpf7zAMjl2D22Yv+axqS4dX
Mvrb0Zv/Qb4lbn9KGZx18bxRrjeVe2cgp/Ry0fh5m2btxylZZPfkzZtR2adc+GW6
Zpx7khWTD2XeYkyF4MYzsOMgDsKiDfDiQnLylqO9+WlwZh8n/coBCNx/JYxh7f3e
V/VllF3/H7l2xCuKOcbQX+8YzffiAso02loOH9syd1H36GrsWWoclOcx/YCXh3Sx
Jq/YbJwMRNHJ1SwNDwYv+B0zysFg35tCOMCNJbBdFdrUsyESiR3T8JIrcbaTtKaa
g+N6AH8IJdOHIdIhm5QPJ4xUw3EtI20x8uDQWB9v9aD9xzhrZPHYkgTTaE/9LcX4
1XooLNPn6RHUPoTFsjZRVfULKQ9s0Wev0p1qtL4YyNC6sQA8K0dwSd4bN3QgcFXh
IpY/L7dNZ6iTFgWmBc6X8wr2UjVgb+ibOMeuALP2dn8eJclrb7jghoqPwAkCkfVb
v3a1MDEDfg4E5Ng/FM4LhNv2Fu4JtJZwc76EX/BLhkYnlkNbTNI9AwgiZolzBTyY
jniqoOkMpvPo/DAjhwFy
=skXb
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.