Debian Bug report logs - #782552
recordfail false positive causes headless servers to hang on boot

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Robie Basak <robie.basak@ubuntu.com>

To: submit@bugs.debian.org

Subject: recordfail false positive causes headless servers to hang on boot

Date: Tue, 14 Apr 2015 03:32:17 +0100

[Message part 1 (text/plain, inline)]

Package: grub-common
Version: 2.02~beta2-22
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu vivid ubuntu-patch

Downstream report: https://launchpad.net/bugs/1443735

A headless system will hang indefinitely waiting on user interaction
after a well timed double power failure. This patch changes the default
GRUB_RECORDFAIL_TIMEOUT to 30, so interactive users still get the
opporunity to intervene after a real boot failure, but headless users
will not end up stuck after boot failures that were really power
failures.

diff -Nru grub2-2.02~beta2/debian/patches/quick_boot.patch grub2-2.02~beta2/debian/patches/quick_boot.patch
--- grub2-2.02~beta2/debian/patches/quick_boot.patch	2015-02-11 19:53:36.000000000 +0000
+++ grub2-2.02~beta2/debian/patches/quick_boot.patch	2015-04-14 02:00:20.000000000 +0100
@@ -18,7 +18,7 @@
 
 Author: Richard Laager <rlaager@wiktel.com>
 Forwarded: no
-Last-Update: 2014-01-17
+Last-Update: 2015-04-14
 
 Patch-Name: quick_boot.patch
 ---
@@ -31,10 +31,10 @@
  util/grub.d/30_os-prober.in | 21 ++++++++++++++++
  7 files changed, 117 insertions(+), 13 deletions(-)
 
-diff --git a/configure.ac b/configure.ac
-index 7c8d0af..2a7e410 100644
---- a/configure.ac
-+++ b/configure.ac
+Index: grub2-2.02~beta2/configure.ac
+===================================================================
+--- grub2-2.02~beta2.orig/configure.ac
++++ grub2-2.02~beta2/configure.ac
 @@ -1594,6 +1594,17 @@ else
  fi
  AC_SUBST([QUIET_BOOT])
@@ -53,18 +53,23 @@
  LIBS=""
  
  AC_SUBST([FONT_SOURCE])
-diff --git a/docs/grub.texi b/docs/grub.texi
-index 46b9e7f..28743d5 100644
---- a/docs/grub.texi
-+++ b/docs/grub.texi
-@@ -1490,6 +1490,15 @@ This option may be set to a list of GRUB module names separated by spaces.
+Index: grub2-2.02~beta2/docs/grub.texi
+===================================================================
+--- grub2-2.02~beta2.orig/docs/grub.texi
++++ grub2-2.02~beta2/docs/grub.texi
+@@ -1490,6 +1490,20 @@ This option may be set to a list of GRUB
  Each module will be loaded as early as possible, at the start of
  @file{grub.cfg}.
  
 +@item GRUB_RECORDFAIL_TIMEOUT
-+If this option is set, it overrides the default recordfail setting. The
-+default setting is -1, which causes GRUB to wait for user input. This option
-+should be set on headless and appliance systems where access to a console is
++If this option is set, it overrides the default recordfail setting. A setting
++of -1 causes GRUB to wait for user input indefinitely. However, a false
++positive in the recordfail mechanism may occur if power is lost during boot
++before boot success is recorded in userspace. The default setting is 30, which
++causes GRUB to wait for user input for thirty seconds before continuing. This
++default allows interactive users the opportunity to switch to a different,
++working kernel, while avoiding a false positive causing the boot to block
++indefinitely on headless and appliance systems where access to a console is
 +restricted or limited.
 +
 +This option is only effective when GRUB was configured with the
@@ -73,11 +78,11 @@
  @end table
  
  The following options are still accepted for compatibility with existing
-diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.c
-index 7b55c27..a968e0f 100644
---- a/grub-core/normal/menu.c
-+++ b/grub-core/normal/menu.c
-@@ -604,6 +604,30 @@ run_menu (grub_menu_t menu, int nested, int *auto_boot)
+Index: grub2-2.02~beta2/grub-core/normal/menu.c
+===================================================================
+--- grub2-2.02~beta2.orig/grub-core/normal/menu.c
++++ grub2-2.02~beta2/grub-core/normal/menu.c
+@@ -604,6 +604,30 @@ run_menu (grub_menu_t menu, int nested,
        static struct grub_term_coordinate *pos;
        int entry = -1;
  
@@ -108,10 +113,10 @@
        if (timeout_style == TIMEOUT_STYLE_COUNTDOWN && timeout)
  	{
  	  pos = grub_term_save_pos ();
-diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
-index 62780bf..17350d4 100644
---- a/util/grub-mkconfig.in
-+++ b/util/grub-mkconfig.in
+Index: grub2-2.02~beta2/util/grub-mkconfig.in
+===================================================================
+--- grub2-2.02~beta2.orig/util/grub-mkconfig.in
++++ grub2-2.02~beta2/util/grub-mkconfig.in
 @@ -236,7 +236,8 @@ export GRUB_DEFAULT \
    GRUB_ENABLE_CRYPTODISK \
    GRUB_BADRAM \
@@ -122,10 +127,10 @@
  
  if test "x${grub_cfg}" != "x"; then
    rm -f "${grub_cfg}.new"
-diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in
-index 0c82f23..8dc5592 100644
---- a/util/grub.d/00_header.in
-+++ b/util/grub.d/00_header.in
+Index: grub2-2.02~beta2/util/grub.d/00_header.in
+===================================================================
+--- grub2-2.02~beta2.orig/util/grub.d/00_header.in
++++ grub2-2.02~beta2/util/grub.d/00_header.in
 @@ -21,6 +21,8 @@ prefix="@prefix@"
  exec_prefix="@exec_prefix@"
  datarootdir="@datarootdir@"
@@ -135,7 +140,7 @@
  
  export TEXTDOMAIN=@PACKAGE@
  export TEXTDOMAINDIR="@localedir@"
-@@ -44,6 +46,7 @@ if [ "x${GRUB_TIMEOUT_BUTTON}" = "x" ] ; then GRUB_TIMEOUT_BUTTON="$GRUB_TIMEOUT
+@@ -44,6 +46,7 @@ if [ "x${GRUB_TIMEOUT_BUTTON}" = "x" ] ;
  
  cat << EOF
  if [ -s \$prefix/grubenv ]; then
@@ -148,7 +153,7 @@
    fi
  }
 +EOF
- 
++
 +if [ "$quick_boot" = 1 ]; then
 +    cat <<EOF
 +function recordfail {
@@ -170,7 +175,7 @@
 +}
 +EOF
 +fi
-+
+ 
 +cat <<EOF
  function load_video {
  EOF
@@ -181,7 +186,7 @@
  {
 +    cat << EOF
 +if [ "\${recordfail}" = 1 ] ; then
-+  set timeout=${GRUB_RECORDFAIL_TIMEOUT:--1}
++  set timeout=${GRUB_RECORDFAIL_TIMEOUT:-30}
 +else
 +EOF
      if [ "x${3}" != "x" ] ; then
@@ -232,10 +237,10 @@
  fi
  EOF
  }
-diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
-index 0616c6d..aa2c369 100644
---- a/util/grub.d/10_linux.in
-+++ b/util/grub.d/10_linux.in
+Index: grub2-2.02~beta2/util/grub.d/10_linux.in
+===================================================================
+--- grub2-2.02~beta2.orig/util/grub.d/10_linux.in
++++ grub2-2.02~beta2/util/grub.d/10_linux.in
 @@ -22,6 +22,7 @@ exec_prefix="@exec_prefix@"
  datarootdir="@datarootdir@"
  ubuntu_recovery="@UBUNTU_RECOVERY@"
@@ -254,10 +259,10 @@
    if [ x$type != xrecovery ] ; then
        save_default_entry | grub_add_tab
    fi
-diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in
-index 1c44cf2..1106ad1 100644
---- a/util/grub.d/30_os-prober.in
-+++ b/util/grub.d/30_os-prober.in
+Index: grub2-2.02~beta2/util/grub.d/30_os-prober.in
+===================================================================
+--- grub2-2.02~beta2.orig/util/grub.d/30_os-prober.in
++++ grub2-2.02~beta2/util/grub.d/30_os-prober.in
 @@ -20,12 +20,26 @@ set -e
  prefix="@prefix@"
  exec_prefix="@exec_prefix@"

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 782552-close@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: 782552-close@bugs.debian.org

Subject: Bug#782552: fixed in grub2 2.02~beta2-23

Date: Thu, 14 May 2015 15:52:45 +0000

Source: grub2
Source-Version: 2.02~beta2-23

We believe that the bug you reported is fixed in the latest version of
grub2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 782552@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated grub2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 14 May 2015 16:18:33 +0100
Source: grub2
Binary: grub2 grub-linuxbios grub-efi grub-common grub2-common grub-emu grub-emu-dbg grub-pc-bin grub-pc-dbg grub-pc grub-rescue-pc grub-coreboot-bin grub-coreboot-dbg grub-coreboot grub-efi-ia32-bin grub-efi-ia32-dbg grub-efi-ia32 grub-efi-amd64-bin grub-efi-amd64-dbg grub-efi-amd64 grub-efi-ia64-bin grub-efi-ia64-dbg grub-efi-ia64 grub-efi-arm-bin grub-efi-arm-dbg grub-efi-arm grub-efi-arm64-bin grub-efi-arm64-dbg grub-efi-arm64 grub-ieee1275-bin grub-ieee1275-dbg grub-ieee1275 grub-firmware-qemu grub-uboot-bin grub-uboot-dbg grub-uboot grub-xen-bin grub-xen-dbg grub-xen grub-xen-host grub-yeeloong-bin grub-yeeloong-dbg grub-yeeloong grub-theme-starfield grub-mount-udeb
Architecture: source
Version: 2.02~beta2-23
Distribution: unstable
Urgency: medium
Maintainer: GRUB Maintainers <pkg-grub-devel@lists.alioth.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 grub-common - GRand Unified Bootloader (common files)
 grub-coreboot - GRand Unified Bootloader, version 2 (Coreboot version)
 grub-coreboot-bin - GRand Unified Bootloader, version 2 (Coreboot binaries)
 grub-coreboot-dbg - GRand Unified Bootloader, version 2 (Coreboot debug files)
 grub-efi   - GRand Unified Bootloader, version 2 (dummy package)
 grub-efi-amd64 - GRand Unified Bootloader, version 2 (EFI-AMD64 version)
 grub-efi-amd64-bin - GRand Unified Bootloader, version 2 (EFI-AMD64 binaries)
 grub-efi-amd64-dbg - GRand Unified Bootloader, version 2 (EFI-AMD64 debug files)
 grub-efi-arm - GRand Unified Bootloader, version 2 (ARM UEFI version)
 grub-efi-arm-bin - GRand Unified Bootloader, version 2 (ARM UEFI binaries)
 grub-efi-arm-dbg - GRand Unified Bootloader, version 2 (ARM UEFI debug files)
 grub-efi-arm64 - GRand Unified Bootloader, version 2 (ARM64 UEFI version)
 grub-efi-arm64-bin - GRand Unified Bootloader, version 2 (ARM64 UEFI binaries)
 grub-efi-arm64-dbg - GRand Unified Bootloader, version 2 (ARM64 UEFI debug files)
 grub-efi-ia32 - GRand Unified Bootloader, version 2 (EFI-IA32 version)
 grub-efi-ia32-bin - GRand Unified Bootloader, version 2 (EFI-IA32 binaries)
 grub-efi-ia32-dbg - GRand Unified Bootloader, version 2 (EFI-IA32 debug files)
 grub-efi-ia64 - GRand Unified Bootloader, version 2 (IA64 version)
 grub-efi-ia64-bin - GRand Unified Bootloader, version 2 (IA64 binaries)
 grub-efi-ia64-dbg - GRand Unified Bootloader, version 2 (IA64 debug files)
 grub-emu   - GRand Unified Bootloader, version 2 (emulated version)
 grub-emu-dbg - GRand Unified Bootloader, version 2 (emulated debug files)
 grub-firmware-qemu - GRUB firmware image for QEMU
 grub-ieee1275 - GRand Unified Bootloader, version 2 (Open Firmware version)
 grub-ieee1275-bin - GRand Unified Bootloader, version 2 (Open Firmware binaries)
 grub-ieee1275-dbg - GRand Unified Bootloader, version 2 (Open Firmware debug files)
 grub-linuxbios - GRand Unified Bootloader, version 2 (dummy package)
 grub-mount-udeb - export GRUB filesystems using FUSE (udeb)
 grub-pc    - GRand Unified Bootloader, version 2 (PC/BIOS version)
 grub-pc-bin - GRand Unified Bootloader, version 2 (PC/BIOS binaries)
 grub-pc-dbg - GRand Unified Bootloader, version 2 (PC/BIOS debug files)
 grub-rescue-pc - GRUB bootable rescue images, version 2 (PC/BIOS version)
 grub-theme-starfield - GRand Unified Bootloader, version 2 (starfield theme)
 grub-uboot - GRand Unified Bootloader, version 2 (ARM U-Boot version)
 grub-uboot-bin - GRand Unified Bootloader, version 2 (ARM U-Boot binaries)
 grub-uboot-dbg - GRand Unified Bootloader, version 2 (ARM U-Boot debug files)
 grub-xen   - GRand Unified Bootloader, version 2 (Xen version)
 grub-xen-bin - GRand Unified Bootloader, version 2 (Xen binaries)
 grub-xen-dbg - GRand Unified Bootloader, version 2 (Xen debug files)
 grub-xen-host - GRand Unified Bootloader, version 2 (Xen host version)
 grub-yeeloong - GRand Unified Bootloader, version 2 (Yeeloong version)
 grub-yeeloong-bin - GRand Unified Bootloader, version 2 (Yeeloong binaries)
 grub-yeeloong-dbg - GRand Unified Bootloader, version 2 (Yeeloong debug files)
 grub2      - GRand Unified Bootloader, version 2 (dummy package)
 grub2-common - GRand Unified Bootloader (common files for version 2)
Closes: 781333 782552 782580
Changes:
 grub2 (2.02~beta2-23) unstable; urgency=medium
 .
   [ Debconf translations ]
   * [da] Danish (Joe Dalton; closes: #781333).
 .
   [ Felix Zielcke ]
   * Run the tests with LC_MESSAGES=C.UTF-8. Some tests fail with non
     english locale. (Closes: #782580)
 .
   [ Mathieu Trudel-Lapierre ]
   * Backport from upstream:
     - arp, icmp: Fix handling in case of oversized or invalid packets.
       (LP: #1428005)
 .
   [ Robie Basak ]
   * Change the default GRUB_RECORDFAIL_TIMEOUT to 30, so interactive users
     still get the opporunity to intervene after a real boot failure, but
     headless users will not end up stuck after boot failures that were
     really power failures (closes: #782552, LP: #1443735).
Checksums-Sha1:
 3cc73cd9c17839966faf9dea9efaf98960ad24db 6436 grub2_2.02~beta2-23.dsc
 d1712c12c143a06e5d1dec38fa0d67ce5dd777ee 1016308 grub2_2.02~beta2-23.debian.tar.xz
Checksums-Sha256:
 7ebb82571831748a53db6bb388d376497d1cc77dd39728c96afea564c8db00c6 6436 grub2_2.02~beta2-23.dsc
 60f3c4ac40f9c0daf69699ed1882565312c96cdfa2df56e27236a74f041a2941 1016308 grub2_2.02~beta2-23.debian.tar.xz
Files:
 d60a62270ec3a450f2935bced1ed837f 6436 admin extra grub2_2.02~beta2-23.dsc
 f34b2523c27f35aad5259df597bd815a 1016308 admin extra grub2_2.02~beta2-23.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBVVS9Hjk1h9l9hlALAQhohA//bD3I32jvrid6qNNh51BAkSiNCgZFLwJE
BOpZy/amuC1blBas24H0VTbRJWtEp+KjoXYzfW2QPNaIL1P1OYfa4u0VCKrVfMFY
pCpfJK7xb2izAdO1P5tsaBXkXfjxjSRo89PPIIlTL/RlePsUELVDhEm+3tnZTMzd
OVfcb4T0FXVp/YG603q425ooiJiDU6mZg1xa5iPMoRjnYhJYE+o3cI7wjsgChnuK
LS+w5bAPEXyoi7b9CA5bpuaO/X/4pdOcOozNtUDrSJtBQy/+uckKL0Fg7jsXqHrs
k/qfaHTkZgM5SC2JEo3CikgNlcTnMjCs75JUC/CHFwuPokhXRKTnKQbDh06e48Ob
/schq0cdx3dkl3Bg58t8FmgfoOGZ0yroxxg1ol3RGpRdjYW0kS5odc9qgI9zrqcE
DsSdZi5/2X9tOKdqOv9JIFQTB3KeU50kn5yYohiuSNMDu2gSDd/yiiKtvhgA/Ej7
1XbIcqfBsA/p5UCxKHvyCLUOCgDMJ8IMnTlju+MEpneuLokdUcKL5FFvqVkymscp
CQ1IjOi+rS8xrArtNBQtgheSbUEis/Wg+cQbVtfv0EPH3S5e1zwIzHBzcuqIgVKc
9NyRuJ1+9V6gD4hHcuf5PP7RRPE2cTSweIns5R+KoRLXm/4xE/MX7LKT5J+wjY/V
Hj/UL+fO2VQ=
=fhJk
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.