Debian Bug report logs - #782137
gnumeric: preinst script bails out too easily

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <geissert@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: gnumeric: preinst script bails out too easily

Date: Wed, 8 Apr 2015 12:43:01 +0200

Package: gnumeric
Severity: important

Hi,

The preinst script prevents gnumeric from being installed in cases such as:
- a debug instance running from a local directory,
- with piuparts, while an instance of gnumeric is running

If the problem that the preinst attempts to avoid is that of the
gnumeric/$version/ directories being removed on upgrade, it should
*really* limit itself to testing for such scenarios. E.g. it does not
make sense to bail out when it is a new installation, or when
upgrading from x.y.z-1 to x.y.z-2, does it?

I question myself about the severity, as in some regards it could be
considered an RC bug.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Message #10 received at 782137@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <geissert@debian.org>

To: 782137@bugs.debian.org

Subject: Re: Bug#782137: gnumeric: preinst script bails out too easily

Date: Tue, 14 Apr 2015 12:24:05 +0200

[Message part 1 (text/plain, inline)]

Hi,

What do you think about the attached diff?

Granted, it doesn't handle the upgrade in chroot while a
package-installed process is running, case, but it at least should
allow some installation and upgrade scenarios to be done smoothly.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

[782137.diff.gz (application/x-gzip, attachment)]

Message #15 received at 782137@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@debian.org>

To: Raphael Geissert <geissert@debian.org>, 782137@bugs.debian.org

Subject: Re: Bug#782137: gnumeric: preinst script bails out too easily

Date: Wed, 15 Apr 2015 12:06:16 +1000

[Message part 1 (text/plain, inline)]

Hi Raphael,

On Tue, 14 Apr 2015 12:24:05 Raphael Geissert wrote:
> What do you think about the attached diff?
> 
> Granted, it doesn't handle the upgrade in chroot while a
> package-installed process is running, case, but it at least should
> allow some installation and upgrade scenarios to be done smoothly.

Thank you very much for helping me with this issue. I inherited original
preinst code from previous maintainer and I've never hand a chance to
investigate how it works...

I tried your diff but it failed on upgrade as follows:

    /var/lib/dpkg/tmp.ci/preinst: 11: /var/lib/dpkg/tmp.ci/preinst: Bad substitution

Besides I think in this case I'd prefer to upload any changes to "preinst"
to "experimental". At least I need more time to scratch my head over this
code and to test it...

-- 
Regards,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

The Santa myth is one of the most effective means ever devised for
intimidating children, eroding their self-esteem, twisting their
behavior, warping their values, and slowing their development of
critical thinking skills.
        -- Tom Flynn, "The Trouble with Christmas"

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 782137-submitter@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@member.fsf.org>

To: 782137-submitter@bugs.debian.org

Subject: Bug#782137 tagged as pending

Date: Wed, 15 Apr 2015 02:06:52 +0000

tag 782137 pending
--

We believe that the bug #782137 you reported has been fixed in the Git
repository. You can see the commit message below and/or inspect the
commit contents at:

    http://anonscm.debian.org/cgit/collab-maint/gnumeric.git/diff/?id=610e5e5

(This message was generated automatically by
 'git-post-receive-tag-pending-commitmsg' hook).
---
commit 610e5e5 (HEAD, master)
Author: Raphael Geissert <raphael-externe.geissert@edf.fr>
Date:   Tue Apr 14 10:55:08 2015

    Add some sanity checks to the preinst to prevent it from bailing out too easily (Closes: #782137)

Message #25 received at 782137@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <geissert@debian.org>

To: Dmitry Smirnov <onlyjob@debian.org>

Cc: 782137@bugs.debian.org

Subject: Re: Bug#782137: gnumeric: preinst script bails out too easily

Date: Wed, 15 Apr 2015 14:43:30 +0200

Hi Dmitry,

On 15 April 2015 at 04:06, Dmitry Smirnov <onlyjob@debian.org> wrote:
> Thank you very much for helping me with this issue. I inherited original
> preinst code from previous maintainer and I've never hand a chance to
> investigate how it works...
>
> I tried your diff but it failed on upgrade as follows:
>
>     /var/lib/dpkg/tmp.ci/preinst: 11: /var/lib/dpkg/tmp.ci/preinst: Bad substitution

Gah, apologies for that; the colon right after the 2 should not be
there. The code should work once that's been fixed.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Message #30 received at 782137-close@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@debian.org>

To: 782137-close@bugs.debian.org

Subject: Bug#782137: fixed in gnumeric 1.12.22-1

Date: Mon, 27 Apr 2015 01:04:18 +0000

Source: gnumeric
Source-Version: 1.12.22-1

We believe that the bug you reported is fixed in the latest version of
gnumeric, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 782137@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Smirnov <onlyjob@debian.org> (supplier of updated gnumeric package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 26 Apr 2015 18:02:16 +1000
Source: gnumeric
Binary: gnumeric gnumeric-common gnumeric-doc gnumeric-plugins-extra gir1.2-gnumeric
Architecture: source amd64 all
Version: 1.12.22-1
Distribution: unstable
Urgency: low
Maintainer: Dmitry Smirnov <onlyjob@debian.org>
Changed-By: Dmitry Smirnov <onlyjob@debian.org>
Description:
 gir1.2-gnumeric - GObject introspection data for the Gnumeric spreadsheet
 gnumeric   - spreadsheet application for GNOME - main program
 gnumeric-common - spreadsheet application for GNOME - common files
 gnumeric-doc - spreadsheet application for GNOME - documentation
 gnumeric-plugins-extra - spreadsheet application for GNOME - additional plugins
Closes: 782137
Changes:
 gnumeric (1.12.22-1) unstable; urgency=low
 .
   [ Dmitry Smirnov ]
   * New upstream release [April 2015].
   * Build-Depends:
     + libgoffice-0.10-dev (>= 0.10.22)
     + libgsf-1-dev (>= 1.14.33)
     + gobject-introspection
   * Added "--with gir" to populate "${gir:Depends}".
   * Upload to unstable.
 .
   [ Raphael Geissert ]
   * Add some sanity checks to the preinst to prevent it from bailing out
     too easily (Closes: #782137).
Checksums-Sha1:
 ddbdcd31559fb449765846032b279c0c17fbacd3 2532 gnumeric_1.12.22-1.dsc
 276d01bb76cae4f59cf8a22bb0e213ec7f595dc6 18541384 gnumeric_1.12.22.orig.tar.xz
 da3acd644c0af0764e04d5316d0c630cc932fe60 41612 gnumeric_1.12.22-1.debian.tar.xz
 2ba37ac8d6a05501a5684bb4fc72ab390b31fd0c 2350906 gnumeric_1.12.22-1_amd64.deb
 c793e660bea062d660df937ac4b2343d47d8ec50 2430134 gnumeric-common_1.12.22-1_all.deb
 428d249137d8960fe39ee1d09713b730197b8f54 11337834 gnumeric-doc_1.12.22-1_all.deb
 4df09a794d3bb445232f3a812a54b7fab5c4301d 92934 gnumeric-plugins-extra_1.12.22-1_amd64.deb
 0dc0941c7730499923fd535a5914922aba30a262 225156 gir1.2-gnumeric_1.12.22-1_amd64.deb
Checksums-Sha256:
 51543a42575ea3f7eebb5bed380024b18700034b90fb1731c03638770c9271e0 2532 gnumeric_1.12.22-1.dsc
 3908cfd6520b599eefefe222aadeaa5126394b54d9a9a7f5e0f938eb674dcf47 18541384 gnumeric_1.12.22.orig.tar.xz
 15e0400526814a8c6062b3f1b70f71f22ceb8cddf6895d7a1f4f7fcb3f14cb20 41612 gnumeric_1.12.22-1.debian.tar.xz
 a8f5535e3c62fafc2ab526da93eb55a0891f73eb0c1a13812e4ea221bf4b0af1 2350906 gnumeric_1.12.22-1_amd64.deb
 78696f14e5135f884b39bdb4dcbfb270624b425c7240b48e61058291847bca6a 2430134 gnumeric-common_1.12.22-1_all.deb
 a9e405ac4477c1c9bda1ebb7dd68359124cbfceee0d56186480fbde4ae801a53 11337834 gnumeric-doc_1.12.22-1_all.deb
 3cdeeacdf84cc881822bb72231102b5798ee8979e1aa82aa767db49409fbf77a 92934 gnumeric-plugins-extra_1.12.22-1_amd64.deb
 3f8906f069211e2d7bf1c9b2cd7bb92f55ee9cd2e616b61c4b0cb2c7f255d288 225156 gir1.2-gnumeric_1.12.22-1_amd64.deb
Files:
 9085bb17f288b736b4507524f73fd4e5 2532 math optional gnumeric_1.12.22-1.dsc
 84e39df0028b3b6091ca55a3b538070e 18541384 math optional gnumeric_1.12.22.orig.tar.xz
 00d579525a2a2f044a72ca6446070dfc 41612 math optional gnumeric_1.12.22-1.debian.tar.xz
 0eebf645da35d9d5e811b95cecc9a889 2350906 math optional gnumeric_1.12.22-1_amd64.deb
 a7766b058548aedca0d8d6ba9e6356c5 2430134 math optional gnumeric-common_1.12.22-1_all.deb
 32322395a708b4f09094c4ff191178b1 11337834 doc optional gnumeric-doc_1.12.22-1_all.deb
 e8a6990917e6a7c2089dac18ca4412c3 92934 math optional gnumeric-plugins-extra_1.12.22-1_amd64.deb
 d86d8958156262133495c5bd99a00a8c 225156 introspection optional gir1.2-gnumeric_1.12.22-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVPYRkAAoJEFK2u9lTlo0bCxMQALymbpAofFeH6VLyb4MDE2F5
ts72hOCyijyBtyH+qkRG48WHexn5D7tAsjRSJCvsEKWH5UslMV6k+hX0ee9HAwA7
N9eNdFfXFU0l2x1EiF0z/hJGoEjC7NC8w4lgMi95YHdKNFtLAPHAo3abTI8MYn0Q
BPrsbGVQB60irXIoLqZB6xsSSIeYjuWTb1ICjTumfpLKeaIoMJ/tQFyeezSKrZdM
lJuxgKHKnA6kC15TDLt4QOyEMoIf37Mi4ydsZ3Jjn8qspTbDDfINYGkwuw0mykns
801uwXW33GwNSrr/XZODYZli3o5yHEgu4XGqfY9ZARgRFlFv+bNCM+csB3LQF4vU
pdra8zmhVn1grIdvwJ8iCtC/e9Cxyjyc4UhSrpgLLt5lK2EWXfcSwWYxNaw9Ntvi
1yDcsK58/vp0y22sWIVdZqKO3T+ThMuNgyHyPEaLTXdt966TXbtBPjgrIMzhaVe4
lxKw0EYUP02cJ4iFalaQKIfnGa8wRgWRaJ9go3lVbBCfXWafqc9CGLXEreB6pjk1
SUQgPvGbkiFpDkXw+EnUF5uw53wZKSno8eqoom55A0d9pfVAnHZpRwYV96SrmDqJ
W2oXnZEUdmK2NHtG9SR4lSDBGZOy54YlR6DJ306GMxmhTWnNAVGkuBXXu8wpuGwF
K6a6DhwiBMjTk4+6Had3
=dEVQ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.