Debian Bug report logs - #780373
Add the ability to set preferred auto IM by locale

version graph

Package: src:im-config; Maintainer for src:im-config is Debian Input Method Team <debian-input-method@lists.debian.org>;

Reported by: Aron Xu <aron@debian.org>

Date: Thu, 12 Mar 2015 21:39:01 UTC

Severity: wishlist

Tags: patch

Fixed in version im-config/0.28-1

Done: Osamu Aoki <osamu@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Osamu Aoki <osamu@debian.org>:
Bug#780373; Package src:im-config. (Thu, 12 Mar 2015 21:39:06 GMT) (full text, mbox, link).


Acknowledgement sent to Aron Xu <aron@debian.org>:
New Bug report received and forwarded. Copy sent to Osamu Aoki <osamu@debian.org>. (Thu, 12 Mar 2015 21:39:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Add the ability to set preferred auto IM by locale
Date: Fri, 13 Mar 2015 05:34:33 +0800
[Message part 1 (text/plain, inline)]
Package: src:im-config
Severity: wishlist
Tags: patch

Users of different locales may have their preferred default IM,
attached patch adds the ability of setting an IM that's preferred when
"auto" is selected (which is the default), managed by locale.

Thanks,
Aron
[01_preferred-im-by-locale.patch (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Osamu Aoki <osamu@debian.org>:
Bug#780373; Package src:im-config. (Fri, 13 Mar 2015 09:15:04 GMT) (full text, mbox, link).


Acknowledgement sent to Aron Xu <happyaron.xu@gmail.com>:
Extra info received and forwarded to list. Copy sent to Osamu Aoki <osamu@debian.org>. (Fri, 13 Mar 2015 09:15:04 GMT) (full text, mbox, link).


Message #10 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <happyaron.xu@gmail.com>
To: 780373@bugs.debian.org
Subject: Re: Add the ability to set preferred auto IM by locale
Date: Fri, 13 Mar 2015 17:11:25 +0800
[Message part 1 (text/plain, inline)]
Updated patch, really filters out commented lines.

I'm thinking whether we want to make it a conffile, so local
administrator can override it themselves, what do you think?

Thanks,
Aron
[01_preferred-im-by-locale.patch (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#780373; Package src:im-config. (Fri, 13 Mar 2015 14:09:08 GMT) (full text, mbox, link).


Acknowledgement sent to Osamu Aoki <osamu@debian.org>:
Extra info received and forwarded to list. (Fri, 13 Mar 2015 14:09:08 GMT) (full text, mbox, link).


Message #15 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: Aron Xu <happyaron.xu@gmail.com>, 780373@bugs.debian.org
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Fri, 13 Mar 2015 23:04:22 +0900
Hi,

I think it is good timing to design a new functionality for the 
post-release :-)

On Fri, Mar 13, 2015 at 05:11:25PM +0800, Aron Xu wrote:
> Updated patch, really filters out commented lines.
> 
> I'm thinking whether we want to make it a conffile, so local
> administrator can override it themselves, what do you think?

Yes.  Overridability is the *required* feature for the new im-config
functionality.  But why not make existance of
/etc/im-config/locale_prefs overrides /usr/share/im-config/locale_prefs
or something similar.  /etc/* are all conffiles without decaring them.

> From 5fb66297a70e4afcfcb1c9893fc8e660da397aaf Mon Sep 17 00:00:00 2001
> From: Aron Xu <aron@debian.org>
> Date: Fri, 13 Mar 2015 04:25:58 +0800
> Subject: [PATCH] Add the ability to set preferred auto IM by locale
> 
> Users of different locales may have their preferred default IM,
> this adds the ability of setting an IM that's preferred when
> "auto" is selected (which is the default), managed by locale.

Let's not change the existing behavior of "auto".  It may be registered
in use's ~/.xinputrc.
Let's add a new mode such as "autolocale" and set it as the new default
in the /etc/defaulkt/im-config .

I guess you are thinking to set like, e.g.:
/etc/im-config/locale_prefs
en_US ibus
ja_JP uim
zh_CN fcitx

Then, I wonder why not have another entry in /etc/default/im-config
specifying this new "autolocale" setting and not to introduce a new
configuration file.

IM_CONFIG_DEFAULT_MODE=auto
IM_CONFIG_AUTOLOCALE="en_US,ibus:ja_JP,uim:zh_CN,fcitx:*,auto"

Regards,

Osamu



Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#780373; Package src:im-config. (Tue, 17 Mar 2015 15:21:04 GMT) (full text, mbox, link).


Acknowledgement sent to Osamu Aoki <osamu@debian.org>:
Extra info received and forwarded to list. (Tue, 17 Mar 2015 15:21:04 GMT) (full text, mbox, link).


Message #20 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: Aron Xu <happyaron.xu@gmail.com>, 780373@bugs.debian.org
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Wed, 18 Mar 2015 00:18:28 +0900
Hi Aron,

Can you tell me what exactly you wish to do.

Was my previous mail properly depict it/

Let me know.

Regards,

Osamu
 About https://bugs.debian.org/780373



Information forwarded to debian-bugs-dist@lists.debian.org, Osamu Aoki <osamu@debian.org>:
Bug#780373; Package src:im-config. (Wed, 18 Mar 2015 09:03:04 GMT) (full text, mbox, link).


Acknowledgement sent to Aron Xu <happyaron.xu@gmail.com>:
Extra info received and forwarded to list. Copy sent to Osamu Aoki <osamu@debian.org>. (Wed, 18 Mar 2015 09:03:04 GMT) (full text, mbox, link).


Message #25 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <happyaron.xu@gmail.com>
To: Osamu Aoki <osamu@debian.org>
Cc: 780373@bugs.debian.org
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Wed, 18 Mar 2015 17:01:15 +0800
On Tue, Mar 17, 2015 at 11:18 PM, Osamu Aoki <osamu@debian.org> wrote:
> Hi Aron,
>
> Can you tell me what exactly you wish to do.
>
> Was my previous mail properly depict it/
>
> Let me know.
>
> Regards,
>
> Osamu
>  About https://bugs.debian.org/780373

We are trying to make Fcitx default for Chinese locales in Ubuntu
15.04, as a transition of making it default for everyone in the next.
im-config needs the ability of setting a default in a per-locale case,
and fallback to existing mechanism when needed.

I think the proposed way in your last email can fulfill my need, I
didn't follow up quickly just because I haven't yet gotten a proper
updated patch that align to the described behavior, :)

Thanks,
Aron



Set Bug forwarded-to-address to 'https://bugs.php.net/bug.php?id=62596'. Request was from Lior Kaplan <kaplan@debian.org> to control@bugs.debian.org. (Wed, 18 Mar 2015 15:39:25 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#780373; Package src:im-config. (Thu, 19 Mar 2015 15:39:04 GMT) (full text, mbox, link).


Acknowledgement sent to Osamu Aoki <osamu@debian.org>:
Extra info received and forwarded to list. (Thu, 19 Mar 2015 15:39:04 GMT) (full text, mbox, link).


Message #32 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: Aron Xu <happyaron.xu@gmail.com>
Cc: 780373@bugs.debian.org
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Fri, 20 Mar 2015 00:36:10 +0900
Hi,

On Wed, Mar 18, 2015 at 05:01:15PM +0800, Aron Xu wrote:
> On Tue, Mar 17, 2015 at 11:18 PM, Osamu Aoki <osamu@debian.org> wrote:
> > Hi Aron,
> >
> > Can you tell me what exactly you wish to do.
> >
> > Was my previous mail properly depict it/
> >
> > Let me know.
> >
> > Regards,
> >
> > Osamu
> >  About https://bugs.debian.org/780373
> 
> We are trying to make Fcitx default for Chinese locales in Ubuntu
> 15.04, as a transition of making it default for everyone in the next.
> im-config needs the ability of setting a default in a per-locale case,
> and fallback to existing mechanism when needed.
> 
> I think the proposed way in your last email can fulfill my need, I
> didn't follow up quickly just because I haven't yet gotten a proper
> updated patch that align to the described behavior, :)

I think there could be many ways to impliment your request.

I just do not want to make maze nor make complicated transition.

I now think your patch maybe OK considering other trade-off.

Your patch will cause some confusion if people configure system via GUI
im-config command, though.  That is why I am not going quick on Debian.

Let me have some time for Debian update.

In the mean time, please go ahead applying your patch to Ubuntu.

Osamu



Unset Bug forwarded-to-address Request was from Ondřej Surý <ondrej@debian.org> to control@bugs.debian.org. (Fri, 20 Mar 2015 11:15:08 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#780373; Package src:im-config. (Fri, 20 Mar 2015 15:33:04 GMT) (full text, mbox, link).


Acknowledgement sent to Osamu Aoki <osamu@debian.org>:
Extra info received and forwarded to list. (Fri, 20 Mar 2015 15:33:04 GMT) (full text, mbox, link).


Message #39 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: Aron Xu <happyaron.xu@gmail.com>
Cc: 780373@bugs.debian.org
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Sat, 21 Mar 2015 00:29:39 +0900
Hi,

On Wed, Mar 18, 2015 at 05:01:15PM +0800, Aron Xu wrote:
> On Tue, Mar 17, 2015 at 11:18 PM, Osamu Aoki <osamu@debian.org> wrote:
> We are trying to make Fcitx default for Chinese locales in Ubuntu
> 15.04, as a transition of making it default for everyone in the next.
> im-config needs the ability of setting a default in a per-locale case,
> and fallback to existing mechanism when needed.

FYI: The current im-config package build for Ubuntu has fcitx over ibus
as I understand.  See there is a hackish fix for this in debian/rules.
 
> I think the proposed way in your last email can fulfill my need, I
> didn't follow up quickly just because I haven't yet gotten a proper
> updated patch that align to the described behavior, :)

I think I made a correct fix.  Please check ithe uploaded experimental
package how it works.  I also updated VCS.

Your review is most appreciated.

Osamu




Reply sent to Osamu Aoki <osamu@debian.org>:
You have taken responsibility. (Fri, 20 Mar 2015 15:39:13 GMT) (full text, mbox, link).


Notification sent to Aron Xu <aron@debian.org>:
Bug acknowledged by developer. (Fri, 20 Mar 2015 15:39:13 GMT) (full text, mbox, link).


Message #44 received at 780373-close@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: 780373-close@bugs.debian.org
Subject: Bug#780373: fixed in im-config 0.28-1
Date: Fri, 20 Mar 2015 15:34:22 +0000
Source: im-config
Source-Version: 0.28-1

We believe that the bug you reported is fixed in the latest version of
im-config, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 780373@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Osamu Aoki <osamu@debian.org> (supplier of updated im-config package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 20 Mar 2015 22:04:14 +0900
Source: im-config
Binary: im-config
Architecture: source all
Version: 0.28-1
Distribution: experimental
Urgency: medium
Maintainer: Osamu Aoki <osamu@debian.org>
Changed-By: Osamu Aoki <osamu@debian.org>
Description:
 im-config  - Input method configuration framework
Closes: 767007 767483 780373
Changes:
 im-config (0.28-1) experimental; urgency=medium
 .
   * Merge Debian jessie patch to main branch.
   * Fix path error in debian/rules for Ubuntu. Closes: #767007
   * unset TEXTDOMAIN and TEXTDOMAINDIR.  Closes: #767483
   * Locale dependent override control via IM_CONFIG_PREFERRED_RULE.
     Inspired by Aron's patch. Closes: #780373
   * Really fix chenge for LP: #1375089 in 0.27-1.
Checksums-Sha1:
 0353dce3bbc65c72c57b92891c46738c6a0d6a20 1775 im-config_0.28-1.dsc
 cb19d96283bf976c63758efdb1c9f6d7df6272f7 52392 im-config_0.28.orig.tar.gz
 cea740bdb38b5c3eaf98ac7820522d6ecde4251b 7696 im-config_0.28-1.debian.tar.xz
 b3dee9746022ca26270e7192fb4180a29f7b2a19 54334 im-config_0.28-1_all.deb
Checksums-Sha256:
 33fbff102ee88b49d3b89845b2b9ef0176960d549b0b195b94ca2997fae2a9b2 1775 im-config_0.28-1.dsc
 3ee754d716d0a293db30af124bd395288a615e04d8c5ec21d2776e0efbfe3af5 52392 im-config_0.28.orig.tar.gz
 5bea6a86e34257e28738ba7efff33824d41246c96d627b23fdb10253eb51c67b 7696 im-config_0.28-1.debian.tar.xz
 a3b9447481933b853439d14408333efa2b07ef6f42f2bdfeb65d06ec1b44111f 54334 im-config_0.28-1_all.deb
Files:
 3a5f566bfa11b07542bdc38bf873fa84 1775 x11 optional im-config_0.28-1.dsc
 51c76909ea08ab6643a15028ea30a5ce 52392 x11 optional im-config_0.28.orig.tar.gz
 e7ee30b22c63fd4a93151d3330d496ce 7696 x11 optional im-config_0.28-1.debian.tar.xz
 55cc4bde272f25345d95f3e91d623131 54334 x11 optional im-config_0.28-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVDDlsAAoJEB4TVogd2NeRPqEP+wYyjGbhjLaf2IqKYeti7EU+
Y0aBPtQqWd+7wEUkWZXh4FZZSzLAhSt3SmMIvUDETNss5NKZxzvWku8YDkBhu5Zm
xXUNU72I9AnxHRH69nmndWlrEo14GDkFBy9jryHjnxj8fvme4taurhcXdjR4mLXu
maRFP1OcUoA8lAo6tCNs+zNWDcmg2ACFhzGAAb0tkKcpTTFmNdHFg7lbXw137Wa7
Jc1MthfzBXeOua8YoolsOXSGqdQUA6iu4ixwxXvOCCTNVg0eCv5x2lpcoP0cgR6d
nTG3UHPCryU68ziRc0KqVbiW5TqAo/4fzqIv7tgBtXUmRd+jkCmaFOHXaI5mVJwJ
wlpGcklMRRvJwtT8uDrDnQ4gEnRy2HcIj3fdN2RAHICmGA++PBx99JNdMScDQI4U
dUuBgh9+CKw2q3PuDmNcAGhLeBk0eIN460glqyMRvU7mYflVLJ0InIw1X+2XCCiV
SByP6mbQ4Pu+p2nhGuhvrhhkxrdOKkWwK1EimILXcU0Jn7v8LF2um7y6SUcl5SiU
LS0KdIjq0rDjVOXpso5MCQdKibxapeWT1eH4s+XWYCgQj3S4fAl3CaioSHR6mZg+
WMaUGBr0MDmvR/ndTlkrLTr9oYDrIrHZbkBoYzKXEsAGwiLzKBDYQMBUDbzssPAA
DYVKFqD4IMZNSh9WuRnd
=lGKh
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, Osamu Aoki <osamu@debian.org>:
Bug#780373; Package src:im-config. (Sat, 21 Mar 2015 01:48:05 GMT) (full text, mbox, link).


Acknowledgement sent to Gunnar Hjalmarsson <gunnarhj@ubuntu.com>:
Extra info received and forwarded to list. Copy sent to Osamu Aoki <osamu@debian.org>. (Sat, 21 Mar 2015 01:48:05 GMT) (full text, mbox, link).


Message #49 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Gunnar Hjalmarsson <gunnarhj@ubuntu.com>
To: Osamu Aoki <osamu@debian.org>
Cc: 780373@bugs.debian.org, Aron Xu <happyaron.xu@gmail.com>
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Sat, 21 Mar 2015 02:39:31 +0100
[Message part 1 (text/plain, inline)]
Hi Osamu!

On 2015-03-20 16:29, Osamu Aoki wrote:
> On Wed, Mar 18, 2015 at 05:01:15PM +0800, Aron Xu wrote:
>> On Tue, Mar 17, 2015 at 11:18 PM, Osamu Aoki <osamu@debian.org> wrote:
>> We are trying to make Fcitx default for Chinese locales in Ubuntu
>> 15.04, as a transition of making it default for everyone in the next.
>> im-config needs the ability of setting a default in a per-locale case,
>> and fallback to existing mechanism when needed.
> 
> FYI: The current im-config package build for Ubuntu has fcitx over ibus
> as I understand.  See there is a hackish fix for this in debian/rules.

Right. That hack should be dropped, i.e. the only Ubuntuish thing left
in debian/rules should be the extra line in the .desktop file.

> I think I made a correct fix.  Please check ithe uploaded experimental
> package how it works.

I noticed one thing, which has been corrected in the Ubuntu patch. If
LC_CTYPE is set explicitly, its value is not surrounded by quotes in the
output from the locale command. Please see the attached diff.

-- 
Gunnar Hjalmarsson
https://launchpad.net/~gunnarhj
[im-config-lc-ctype.diff (text/x-diff, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#780373; Package src:im-config. (Sat, 21 Mar 2015 01:57:05 GMT) (full text, mbox, link).


Acknowledgement sent to Osamu Aoki <osamu@debian.org>:
Extra info received and forwarded to list. (Sat, 21 Mar 2015 01:57:05 GMT) (full text, mbox, link).


Message #54 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: Gunnar Hjalmarsson <gunnarhj@ubuntu.com>
Cc: 780373@bugs.debian.org, Aron Xu <happyaron.xu@gmail.com>
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Sat, 21 Mar 2015 10:53:03 +0900
Hi,

On Sat, Mar 21, 2015 at 02:39:31AM +0100, Gunnar Hjalmarsson wrote:
> Hi Osamu!
> I noticed one thing, which has been corrected in the Ubuntu patch. If
> LC_CTYPE is set explicitly, its value is not surrounded by quotes in the
> output from the locale command. Please see the attached diff.

Good point!

Thanks.

Osamu
> --- a/share/xinputrc.common.in	2015-03-20 16:12:30.000000000 +0100
> +++ b/share/xinputrc.common.in	2015-03-21 02:10:29.453713955 +0100
> @@ -21,7 +21,7 @@
>  if [ -r $IM_CONFIG_DEFAULT ]; then
>      . $IM_CONFIG_DEFAULT
>  fi
> -IM_CONFIG_LC_CTYPE=$(locale | sed -nr 's/LC_CTYPE=\"([a-zA-Z_]*).*\"/\1/p')
> +IM_CONFIG_LC_CTYPE=$(locale | sed -nr 's/LC_CTYPE=\"?([a-zA-Z_]*).*/\1/p')
>  IM_CONFIG_PREFERRED=$(echo "$IM_CONFIG_PREFERRED_RULE"| sed -rn "s/(^|.*:)${IM_CONFIG_LC_CTYPE},([^:]*)($|:.*$)/\2/p")
>  #############################################################
>  # Common functions used by im-config hook script (any mode)




Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#780373; Package src:im-config. (Sat, 21 Mar 2015 16:27:04 GMT) (full text, mbox, link).


Acknowledgement sent to Osamu Aoki <osamu@debian.org>:
Extra info received and forwarded to list. (Sat, 21 Mar 2015 16:27:04 GMT) (full text, mbox, link).


Message #59 received at 780373@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>
To: Gunnar Hjalmarsson <gunnarhj@ubuntu.com>
Cc: 780373@bugs.debian.org, Aron Xu <happyaron.xu@gmail.com>
Subject: Re: Bug#780373: Add the ability to set preferred auto IM by locale
Date: Sun, 22 Mar 2015 01:23:41 +0900
Hi,

On Sat, Mar 21, 2015 at 02:39:31AM +0100, Gunnar Hjalmarsson wrote:
...
> I noticed one thing, which has been corrected in the Ubuntu patch. If
> LC_CTYPE is set explicitly, its value is not surrounded by quotes in the
> output from the locale command. Please see the attached diff.

Great! Fixed in 0.29-1

FYI: -m option print out more lines.  See manpage for explanation.
       -m      List configuration values to STDOUT:
               ·   active configuration (system)
               ·   active configuration (user)
               ·   automatic configuration for the current locale
               ·   override configuration for the current locale
               ·   automatic configuration for most locales
               If the active configuration is custom, the user made a custom
               configuration and im-config should not change it.
First 3 are the same.  But now with override, automatic configuration for the
current locale may be the overide provided one.

Osamu



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Wed, 20 Jul 2016 07:33:10 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jul 2 03:45:31 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.