Debian Bug report logs - #779831
beanstalkd: FTBFS with binutils-gold

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Debian BTS Submit <submit@bugs.debian.org>

Subject: beanstalkd: FTBFS with binutils-gold

Date: Thu, 5 Mar 2015 11:40:20 +0100

[Message part 1 (text/plain, inline)]

Package: beanstalkd
Version: 1.10-1
User: peter.fritzsche@gmx.de
Usertags: no-add-needed

Hello,

beanstalkd FTBFS with binutils-gold, in particular due to some wrong
or insufficient linking with --no-add-needed (see
https://wiki.debian.org/ToolChain/DSOLinking for details):

| $ LDFLAGS='-Wl,--no-add-needed' sbuild -d sid -j4 beanstalkd_1.10-1.dsc
| [...]
| cc -Wl,--no-add-needed  -o beanstalkd linux.o conn.o file.o heap.o job.o ms.o net.o primes.o prot.o serv.o time.o tube.o util.o vers.o walg.o main.o 
| net.o: In function `make_server_socket':
| /«PKGBUILDDIR»/net.c:29: undefined reference to `sd_listen_fds'
| /«PKGBUILDDIR»/net.c:39: undefined reference to `sd_is_socket_inet'
| util.o: In function `warn_systemd_ignored_option':
| /«PKGBUILDDIR»/util.c:95: undefined reference to `sd_listen_fds'
| /«PKGBUILDDIR»/util.c:95: undefined reference to `sd_listen_fds'
| collect2: error: ld returned 1 exit status

Indeed the linker call contains no shared libraries whatsoever?

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 779831@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <martin.pitt@ubuntu.com>

To: 779831@bugs.debian.org

Subject: Re: beanstalkd: FTBFS with binutils-gold

Date: Thu, 5 Mar 2015 11:52:19 +0100

[Message part 1 (text/plain, inline)]

Hello again,

Martin Pitt [2015-03-05 11:40 +0100]:
> beanstalkd FTBFS with binutils-gold, in particular due to some wrong
> or insufficient linking with --no-add-needed (see
> https://wiki.debian.org/ToolChain/DSOLinking for details):
> 
> | $ LDFLAGS='-Wl,--no-add-needed' sbuild -d sid -j4 beanstalkd_1.10-1.dsc
> | [...]
> | cc -Wl,--no-add-needed  -o beanstalkd linux.o conn.o file.o heap.o job.o ms.o net.o primes.o prot.o serv.o time.o tube.o util.o vers.o walg.o main.o 

Sorry, I just realized that this is problematic by itself: Setting
LDFLAGS seems to override this bit of debian/rules:

ifeq ($(DEB_HOST_ARCH_OS), linux)
……………………export DEB_LDFLAGS_MAINT_APPEND = -lsystemd

> | net.o: In function `make_server_socket':
> | /«PKGBUILDDIR»/net.c:29: undefined reference to `sd_listen_fds'
> | /«PKGBUILDDIR»/net.c:39: undefined reference to `sd_is_socket_inet'
> | util.o: In function `warn_systemd_ignored_option':
> | /«PKGBUILDDIR»/util.c:95: undefined reference to `sd_listen_fds'
> | /«PKGBUILDDIR»/util.c:95: undefined reference to `sd_listen_fds'
> | collect2: error: ld returned 1 exit status
> 
> Indeed the linker call contains no shared libraries whatsoever?

Without setting $LDFLAGS the linker line looks like

cc -Wl,-z,relro -lsystemd  -o beanstalkd linux.o conn.o file.o heap.o job.o ms.o net.o primes.o prot.o serv.o time.o tube.o util.o vers.o walg.o main.o 

Which at least has the necessary library. But it needs to come _after_
the object files, as the linker processes the files in order. And if
you put -lsystemd first, there is nothing yet which needs -lsystemd
and it just gets discarded.

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 779831@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <martin.pitt@ubuntu.com>

To: 779831@bugs.debian.org

Subject: Re: Bug#779831: Info received (beanstalkd: FTBFS with binutils-gold)

Date: Thu, 5 Mar 2015 11:59:21 +0100

Control: tag -1 patch
Control: user ubuntu-devel@lists.ubuntu.com
Control: usertag -1 origin-ubuntu ubuntu-patch vivid

Hello again,

attached debdiff fixes both the build, and also unbreaks setting
$LDFLAGS.

Thanks for considering,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Message #22 received at 779831-close@bugs.debian.org (full text, mbox, reply):

From: Apollon Oikonomopoulos <apoikos@debian.org>

To: 779831-close@bugs.debian.org

Subject: Bug#779831: fixed in beanstalkd 1.10-2

Date: Tue, 26 Jan 2016 15:49:56 +0000

Source: beanstalkd
Source-Version: 1.10-2

We believe that the bug you reported is fixed in the latest version of
beanstalkd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 779831@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Apollon Oikonomopoulos <apoikos@debian.org> (supplier of updated beanstalkd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 26 Jan 2016 16:36:30 +0200
Source: beanstalkd
Binary: beanstalkd
Architecture: source amd64
Version: 1.10-2
Distribution: unstable
Urgency: medium
Maintainer: Gregory Potamianos <greg.potamianos@gmail.com>
Changed-By: Apollon Oikonomopoulos <apoikos@debian.org>
Description:
 beanstalkd - simple, in-memory, workqueue service
Closes: 779831
Changes:
 beanstalkd (1.10-2) unstable; urgency=medium
 .
   * d/control: set priority to optional
   * d/control: use HTTPS in Vcs-* and Homepage fields
   * Bump standards to 3.9.6; no changes needed
   * d/rules: use LDLIBS for libsystemd - change obtained from Ubuntu
     (closes: #779831)
Checksums-Sha1:
 c58ac8575a29717764efdd6c955574fbd799d579 1980 beanstalkd_1.10-2.dsc
 769866dd19f40580b3754c96666d4b10c9381054 10052 beanstalkd_1.10-2.debian.tar.xz
 5db3043250f848973cd5c8dd7ec1e4bfc848c024 68046 beanstalkd-dbgsym_1.10-2_amd64.deb
 769893df5f1ba6f5e222e50108e524afbec8ab67 43328 beanstalkd_1.10-2_amd64.deb
Checksums-Sha256:
 935b07fb965858c94c3089c31920d957a6ad6385c6b8ac58fccfd711dae1c5ae 1980 beanstalkd_1.10-2.dsc
 577f2740029ec1df235d9c5d7d9e453e26f8dff3bfa768093e36ad5e7d442032 10052 beanstalkd_1.10-2.debian.tar.xz
 50bbfed97b03e84a12bb9599cd2a61f7078c13e19a6f20ddf019840cae3103ba 68046 beanstalkd-dbgsym_1.10-2_amd64.deb
 42e8eda2438c9327424beb533351a12b9ea31a8a0856ddc4a88a60ca47cb899b 43328 beanstalkd_1.10-2_amd64.deb
Files:
 8d0e7bbc5f24fb085a29e2a15d183da6 1980 net optional beanstalkd_1.10-2.dsc
 496782b417caafb4eae5189d4110d62e 10052 net optional beanstalkd_1.10-2.debian.tar.xz
 6f361e5d7b0f1e9a1aae2403900215de 68046 debug extra beanstalkd-dbgsym_1.10-2_amd64.deb
 b6e18179ee800ce7f688a97d802b7b01 43328 net optional beanstalkd_1.10-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWp4bRAAoJENutyevup8YOMUcP/0UmhHfeVmMMBtcJlWHYelvD
lzXfUgRDKt7Q4UZR71jCoAfhUYcE9jjLD7D2g8/60UhMrzTdLMd2LlDtlxhrzmW2
vr0pOM2Izk879U4hmlMFxwDoJgjw/OQxqPlJ6GvzFh7i8nrh2sr4tkYES/3YnE0r
ZXBUcdrKqbCmfJQEdeR36SKXYZTwINz4Xy6R6ByoLCRdEF+60qzbDAANsVY0MutW
IFhpyk6NwgRNHRt2HEVQYEWb8iijmVXtt2CoHhoYx08xAivCJ/oqwCR1/HPcJ6C2
6G4XpkksoUCSGWJ71zKV4UVoHzW9aQWX4WW8C3BkWIV7lAMhQ7IlAoSrsOmPIUyh
Jh0FGebwjQpHkFP8FW0k7tBcIfH8u9/fns6Tkt/yC4msMdFXr2udQMsR7pe2dlFC
LuWxR5KmPynzqLtCboww+Z0y0QgdNLv8+JY/yJqdwWC8/XjK7V1RiQfmJpzDZBsR
RrAKeeZ/romAPWd+w0/+BDDiioVDvXngE0i6Qw+D1ylSPDqXh34nDxa+R3mglBRT
ihKWBpkDF9z1DRRE5sg/vAasxJtNK8RpePpcPo90tw/vs7AlqjnNFpzohMN96lBK
BeqJeKixok8rsmkMRxp/aEKpCXr6ehC1XHMXdXQPrRqOYexrWYS4ipd0mequyadG
3z26wl0XAwzy8zxM0kBp
=AaZs
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.