Debian Bug report logs - #778470
xscreensaver: Add support for lighdm "new login" feature.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexander Gerasiov <gq@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: xscreensaver: Add support for lighdm "new login" feature.

Date: Sun, 15 Feb 2015 17:32:28 +0300

[Message part 1 (text/plain, inline)]

Package: xscreensaver
Version: 5.30-1+b1
Severity: minor
Tags: patch

Please add support for "new login" feature lightdm (dm-tool) provide.
Patch os attached.

-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (680, 'testing'), (670, 'stable'), (600, 'unstable'), (550, 'experimental'), (500, 'testing-updates')
Architecture: i386 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=ru_RU.utf8, LC_CTYPE=ru_RU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xscreensaver depends on:
ii  libatk1.0-0          2.14.0-1
ii  libc6                2.19-13
ii  libcairo2            1.14.0-2.1
ii  libfontconfig1       2.11.0-6.3
ii  libfreetype6         2.5.2-2
ii  libgdk-pixbuf2.0-0   2.31.1-2+b1
ii  libglade2-0          1:2.6.4-2
ii  libglib2.0-0         2.42.1-1
ii  libgtk2.0-0          2.24.25-1
ii  libice6              2:1.0.9-1+b1
ii  libpam0g             1.1.8-3.1
ii  libpango-1.0-0       1.36.8-3
ii  libpangocairo-1.0-0  1.36.8-3
ii  libpangoft2-1.0-0    1.36.8-3
ii  libsm6               2:1.2.2-1+b1
ii  libx11-6             2:1.6.2-3
ii  libxext6             2:1.3.3-1
ii  libxi6               2:1.7.4-1+b2
ii  libxinerama1         2:1.1.3-1+b1
ii  libxml2              2.9.1+dfsg1-4
ii  libxmu6              2:1.1.2-1
ii  libxpm4              1:3.5.11-1+b1
ii  libxrandr2           2:1.4.2-1+b1
ii  libxrender1          1:0.9.8-1+b1
ii  libxt6               1:1.1.4-1+b1
ii  libxxf86vm1          1:1.1.3-1+b1
ii  xscreensaver-data    5.30-1+b1

Versions of packages xscreensaver recommends:
ii  libjpeg-turbo-progs [libjpeg-progs]  1:1.3.1-11
ii  miscfiles [wordlist]                 1.4.2.dfsg.1-9.1
ii  perl [perl5]                         5.20.1-5

Versions of packages xscreensaver suggests:
ii  chromium [www-browser]   40.0.2214.91-1
pn  fortune                  <none>
pn  gdm3 | kdm-gdmcompat     <none>
ii  iceweasel [www-browser]  31.4.0esr-1
ii  konqueror [www-browser]  4:4.14.2-1
ii  lynx-cur [www-browser]   2.8.9dev1-2+b1
pn  qcam | streamer          <none>
pn  xdaliclock               <none>
pn  xfishtank                <none>
pn  xscreensaver-gl          <none>

-- no debconf information

[xscreensaver-lightdm.patch (text/x-diff, attachment)]

Message #10 received at 778470@bugs.debian.org (full text, mbox, reply):

From: Tormod Volden <debian.tormod@gmail.com>

To: 778470@bugs.debian.org

Subject: xscreensaver: Add support for lighdm "new login" feature.

Date: Mon, 20 Jul 2015 23:57:13 +0200

> Please add support for "new login" feature lightdm (dm-tool) provide.
> Patch os attached.

Hi, thanks for the report and patch. But if both dm-tool and
gdmflexiserver are installed on the machine, how do you know which one
should be called? Is there a way to know we are in a session started
by lightdm?

Best regards,
Tormod

Message #15 received at 778470@bugs.debian.org (full text, mbox, reply):

From: Tormod Volden <debian.tormod@gmail.com>

To: Alexander Gerasiov <gq@debian.org>, 778470@bugs.debian.org

Subject: Re: Bug#778470: xscreensaver: Add support for lighdm "new login" feature.

Date: Tue, 21 Jul 2015 00:08:45 +0200

> Please add support for "new login" feature lightdm (dm-tool) provide.
> Patch os attached.

Hi, thanks for the report and patch. But if both dm-tool and
gdmflexiserver are installed on the machine, how do you know which one
should be called? Is there a way to know we are in a session started
by lightdm?

Best regards,
Tormod

Message #20 received at 778470@bugs.debian.org (full text, mbox, reply):

From: Alexander Gerasiov <gq@cs.msu.su>

To: Tormod Volden <debian.tormod@gmail.com>, 778470@bugs.debian.org

Subject: Re: Bug#778470: xscreensaver: Add support for lighdm "new login" feature.

Date: Tue, 21 Jul 2015 16:40:08 +0300

Hello Tormod,

On Tue, 21 Jul 2015 00:08:45 +0200
Tormod Volden <debian.tormod@gmail.com> wrote:

> > Please add support for "new login" feature lightdm (dm-tool)
> > provide. Patch os attached.
> 
> Hi, thanks for the report and patch. But if both dm-tool and
> gdmflexiserver are installed on the machine, how do you know which one
> should be called? Is there a way to know we are in a session started
> by lightdm?

Good question. Well, I see 2 ways:
1st. Analyze environment
Pro.
	easy
	fast
	tells us about current running dm
Cons.
	As there is no direct info, it's some kind of hack (and dm
	authors could break this in the future)

2nd. Analyze system settings as DMs do themselves
Pro.
	not so hackish
Cons.
	Tells us about current config, not about running DM (well it's
	not really often situation, when config differs from running DM)
	A little bit harder to implement (just a little bit)
	Debian specific (is not a real problem)


1st way:
In lightdm I see additional variable is set:
XDG_GREETER_DATA_DIR=/var/lib/lightdm/data/gq
So you could write something like

if [ -n "$GDMSESSION" ];then
	case "$XDG_GREETER_DATA_DIR" in
		/var/lib/lightdm*)
			which dm-tool > /dev/null && echo "XScreenSaver.newLoginCommand: dm-tool switch-to-greeter" | xrdb -merge;;
		*)
			which gdmflexiserver > /dev/null && echo "XScreenSaver.newLoginCommand: gdmflexiserver -ls" | xrdb -merge;;
	esac
fi


2nd way:
Analyze content of /etc/X11/default-display-manager
could be /usr/sbin/lightdm for lightdm
/usr/sbin/gdm3 for gdm
/usr/bin/kdm for kdm

So you could use something like
DM="$(cat /etc/X11/default-display-manager)"
case "$DM" in
	*lightdm)	...;;
	*kdm)		...;;
	*gdm3)		...;;
esac

-- 
Best regards,
 Alexander Gerasiov

 Contacts:
 e-mail: gq@cs.msu.su  Homepage: http://gerasiov.net  Skype: gerasiov
 PGP fingerprint: 04B5 9D90 DF7C C2AB CD49  BAEA CA87 E9E8 2AAC 33F1

Message #25 received at 778470@bugs.debian.org (full text, mbox, reply):

From: Tormod Volden <debian.tormod@gmail.com>

To: Alexander Gerasiov <gq@cs.msu.su>

Cc: 778470@bugs.debian.org

Subject: Re: Bug#778470: xscreensaver: Add support for lighdm "new login" feature.

Date: Tue, 21 Jul 2015 16:32:27 +0200

> Good question. Well, I see 2 ways:
> 1st. Analyze environment
> Pro.
>         easy
>         fast
>         tells us about current running dm
> Cons.
>         As there is no direct info, it's some kind of hack (and dm
>         authors could break this in the future)
>
> 2nd. Analyze system settings as DMs do themselves
> Pro.
>         not so hackish
> Cons.
>         Tells us about current config, not about running DM (well it's
>         not really often situation, when config differs from running DM)
>         A little bit harder to implement (just a little bit)
>         Debian specific (is not a real problem)

This script is a hack anyway, and I much prefer alternative 1.

The only proper way to solve this is what I have been preaching for
long: The DM that starts the screensaver daemon should itself declare
how to switch sessions. It could be some standardized environment
variable (e.g. DM_SWITCH_SESSION_CMD) for all screensaver daemons to
pick up, or only for xscreensaver they could merge in the
newLoginCommand resource and everything would be fine. For
xscreensaver to figure this out after the fact is solving the problem
in the wrong end. Never mind. Grumble grumble.

> 1st way:
> In lightdm I see additional variable is set:
> XDG_GREETER_DATA_DIR=/var/lib/lightdm/data/gq

Yeah, I noticed this one on one of my system. Was hoping there would
be something better :)

> So you could write something like
>
> if [ -n "$GDMSESSION" ];then
>         case "$XDG_GREETER_DATA_DIR" in
>                 /var/lib/lightdm*)
>                         which dm-tool > /dev/null && echo "XScreenSaver.newLoginCommand: dm-tool switch-to-greeter" | xrdb -merge;;
>                 *)
>                         which gdmflexiserver > /dev/null && echo "XScreenSaver.newLoginCommand: gdmflexiserver -ls" | xrdb -merge;;
>         esac
> fi

Thanks, I will do the above, matching for "*lightdm*" simply. I have
no idea if gdmflexiserver is still around on current Debian systems,
but it doesn't cost much to throw it in as a possible fallback.

> 2nd way:
> Analyze content of /etc/X11/default-display-manager

Here the question would be, does this actual screen where the session
is running on use the default DM, and so on.

Regards,
Tormod

Message #32 received at 778470-close@bugs.debian.org (full text, mbox, reply):

From: Tormod Volden <debian.tormod@gmail.com>

To: 778470-close@bugs.debian.org

Subject: Bug#778470: fixed in xscreensaver 5.33-1

Date: Mon, 17 Aug 2015 00:49:36 +0000

Source: xscreensaver
Source-Version: 5.33-1

We believe that the bug you reported is fixed in the latest version of
xscreensaver, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 778470@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tormod Volden <debian.tormod@gmail.com> (supplier of updated xscreensaver package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 28 Jul 2015 00:41:06 +0200
Source: xscreensaver
Binary: xscreensaver xscreensaver-data xscreensaver-data-extra xscreensaver-gl xscreensaver-gl-extra xscreensaver-screensaver-webcollage xscreensaver-screensaver-bsod
Architecture: source amd64
Version: 5.33-1
Distribution: unstable
Urgency: low
Maintainer: Tormod Volden <debian.tormod@gmail.com>
Changed-By: Tormod Volden <debian.tormod@gmail.com>
Description:
 xscreensaver - Screensaver daemon and frontend for X11
 xscreensaver-data - Screen saver modules for screensaver frontends
 xscreensaver-data-extra - Extra screen saver modules for screensaver frontends
 xscreensaver-gl - GL(Mesa) screen saver modules for screensaver frontends
 xscreensaver-gl-extra - Extra GL(Mesa) screen saver modules for screensaver frontends
 xscreensaver-screensaver-bsod - BSOD screen saver module from XScreenSaver
 xscreensaver-screensaver-webcollage - Webcollage screen saver module from XScreenSaver
Closes: 180775 661174 766880 767019 774539 778470
Changes:
 xscreensaver (5.33-1) unstable; urgency=low
 .
   * New upstream release 5.33, changes since 5.30:
     - New hacks, `geodesicgears', `binaryring', `cityflow', `splitflap'
       and `romanboy'.
     - UTF-8 text support (instead of only Latin1) and antialiased text
       on X11 with Xft (instead of only on OSX/iOS) in `fontglide',
       `noseguy', `fliptext', `starwars', and `winduprobot'.
       The other text-displaying hacks (`apple2', `phosphor', `xmatrix',
       and `gltext') also now accept UTF-8 input, though they convert it
       to Latin1 or ASCII. (Closes: #180775)
     - `glplanet' now has both day and night maps, and a sharp terminator.
     - Fixed a transparency glitch in `winduprobot'.
     - Better detection of user activity on modern GNOME systems.
   * xscreensaver*.postrm/postinst/preinst: Remove obsolete parts used in
     lenny->squeeze and potato->woody transitions
   * Do not overwrite user-configured /etc/X11/app-defaults/XScreenSaver
     Thanks to Bastien Roucariès for initial patch (Closes: #767019)
   * Replace GNOME with MATE in desktop files stub (Closes: #766880, #774539)
   * debian/copyright: Use unique short names for "other" licenses
   * xscreensaver-wrapper.sh: Detect if launched from lightdm session
     Thanks to Alexander Gerasiov for patch (Closes: #778470)
   * debian/control: Recommend libgnomeui-0 package for xscreensaver-demo
     Thanks to Michael Gilbert for patch (Closes: #661174)
   * debian/rules: Hardcode app-defaults dir for configure
Checksums-Sha1:
 ab856869b9a1a672fa29533a4b5a69ef26bad5c9 2738 xscreensaver_5.33-1.dsc
 99f69ff0bef5e13ab0c84dcb1312605db485bafd 10725482 xscreensaver_5.33.orig.tar.gz
 599fe1040cd164d75c6361c2bffa249c5db4cc5e 79562 xscreensaver_5.33-1.diff.gz
 b0fe7ea39d018acedfe907d6728e8d56769daa58 1027674 xscreensaver-data-extra_5.33-1_amd64.deb
 fe7471ef7826579d0bbba2e6cf1ad4f217a6bfca 312010 xscreensaver-data_5.33-1_amd64.deb
 00289a356540226540e1ac61455b3ddcc400f10e 1869132 xscreensaver-gl-extra_5.33-1_amd64.deb
 0fbc52c6baaa8f01aa485eca41b372d269223598 1192302 xscreensaver-gl_5.33-1_amd64.deb
 4ba40735248841519bf5dff0a25c83770c58a12f 165264 xscreensaver-screensaver-bsod_5.33-1_amd64.deb
 18e103bae4b440796cc81cf9e402027e14a5b3ed 62814 xscreensaver-screensaver-webcollage_5.33-1_amd64.deb
 8b16844b2ee960703361f498c5cd8b700f8def76 560300 xscreensaver_5.33-1_amd64.deb
Checksums-Sha256:
 bb501397272dda9fe963106809c764566364fbe646e2f4de6fe34bb71a808336 2738 xscreensaver_5.33-1.dsc
 d4a0c1619219f2843fa8b68d4ae337ab0e9fcb79a6d231540adeb16b3d313f4d 10725482 xscreensaver_5.33.orig.tar.gz
 2dfb31bdd76d68d7dc4ba5c3f1523592a21e4a3d223da45270a5dcb47019f589 79562 xscreensaver_5.33-1.diff.gz
 e8b45b05129cd426bde1d439df9ae787a97a0e26ba9359bd458eda627cf55871 1027674 xscreensaver-data-extra_5.33-1_amd64.deb
 1248cca3a1eecb1db366751b97aabbb0d91337d2cd10e35d1013a5dae016025d 312010 xscreensaver-data_5.33-1_amd64.deb
 2d779e0468e281d07163f5a517d7b79036b83f33d4660215ba3b3b5e6d3ff7af 1869132 xscreensaver-gl-extra_5.33-1_amd64.deb
 8d96984920e11088e213a17464ac1f64c8c83008a642127908cb5fdf3554ac8b 1192302 xscreensaver-gl_5.33-1_amd64.deb
 c068040500eed6dd0c25c4196eb13e1f3d8c54f851178d04f3a5493ea81d14f4 165264 xscreensaver-screensaver-bsod_5.33-1_amd64.deb
 238415c43b117e3af702dfc9ce2bf026b64d2c891f46bb26b2abe6a5509ef984 62814 xscreensaver-screensaver-webcollage_5.33-1_amd64.deb
 82af33dfcdb5a8ea4ba546b7e853bd690b6c7a09ed984cc3ac76b06f4a7762c5 560300 xscreensaver_5.33-1_amd64.deb
Files:
 b6009288cef6714d9d4c21665c197366 2738 x11 optional xscreensaver_5.33-1.dsc
 a005cb46edb0ac9f3bac2fabbfbb11e0 10725482 x11 optional xscreensaver_5.33.orig.tar.gz
 d7ab5941673e2d51f7852509578b5f42 79562 x11 optional xscreensaver_5.33-1.diff.gz
 b37c2f5f84f97d82d5ffb5aee1eec920 1027674 x11 optional xscreensaver-data-extra_5.33-1_amd64.deb
 ad1446ef9a19050c1a602831e58a1450 312010 x11 optional xscreensaver-data_5.33-1_amd64.deb
 e5e3d1b790fea18c049e42121d9a86a3 1869132 x11 optional xscreensaver-gl-extra_5.33-1_amd64.deb
 35345eff7d40acb45e2258d8151c0eea 1192302 x11 optional xscreensaver-gl_5.33-1_amd64.deb
 16866cd3d2b0da3544d34ea0636803d3 165264 x11 optional xscreensaver-screensaver-bsod_5.33-1_amd64.deb
 068faeafd05832bd181cddea278ce85f 62814 x11 optional xscreensaver-screensaver-webcollage_5.33-1_amd64.deb
 9b312bcbe572672467e49f9c24e4f676 560300 x11 optional xscreensaver_5.33-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJV0SdtAAoJEPAe+gXRgGsPTX4P/05hDcdgZj/igtL4xWAZgCJZ
35U9JNo8TVWQs7f66BPa5oJUKTlkABzB8uu+GMcZJuvUV5j1kRp0wvhyIQz/KORn
cOblc7kfaLnRNyfqBPtVZ7y672BVlXjUnDq26Bn9QmOX6dn9zDuOeiuGFfo+rDxm
D+/jR7UOlFAnUyrG2XQCLWO0+WwmjMLLlz3KHc4FeGJFMZ2ZElr3Fls9YABsV97o
t01FgGMY387DarJsK9Huzdzp1cZBK0JDt8M1229rgLIURy6IXcq09qm+IUGZlCBA
TRB4skNn5mbCAqWhNe8snC6apofYYKQUlQcbOCL3pBTmIT4MWm1yDNP9ecVRdXdM
90KTRD2ptQ85/7aoebapFgZ0wM8JUqGsWfTMMXerzrN2LPvLE+US+Ri9V5NthuAt
grG1Y5lECpG2qYD2KKlel6MCIxOV2BokxrXXyPnrWBxT9i57vw0nuJhgi414sR3K
8cqgHYoJFIP4qax4lQwnrXnj4zJhTx+DGEByV2hvvlkHbxP5/4qnt9M0DbcbDvKv
NZ7IUrHP0XZfRd5ifG+4hi0h+fQ+ZfY6fTvgdn3fgl7f8UhKHAIHefAsI52q9Hay
H9/MQtKtQhzgGhhjCuho9m65PwfuVMJ70SfWo7O0ru+gXEnh3DUtaY7iJLwwO5G2
Fv3KyFKiPj/3FplIuNkv
=v18Z
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.