Debian Bug report logs - #778176
x11-xserver-utils: ftbfs with GCC-5

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: maintonly@bugs.debian.org

Subject: x11-xserver-utils: ftbfs with GCC-5

Date: Thu, 12 Feb 2015 10:38:00 +0000

Package: src:x11-xserver-utils
Version: 7.7+3
Severity: normal
Tags: sid stretch
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-5

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-5/g++-5, but succeeds to build with gcc-4.9/g++-4.9. The
severity of this report may be raised before the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc5-20150205/x11-xserver-utils_7.7+3_unstable_gcc5.log
The last lines of the build log are at the end of this report.

To build with GCC 5, either set CC=gcc-5 CXX=g++-5 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t experimental install g++ 

Common build failures are C11 as the default C mode, new warnings
resulting in build failures with -Werror turned on, or new/dropped
symbols in Debian symbols files.  For other C/C++ related build failures
see the porting guide at http://gcc.gnu.org/gcc-5/porting_to.html

[...]
   ^
gcc -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall  -Wl,-z,relro -o iceauth iceauth.o process.o -lICE  
make[4]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/iceauth-build'
make[3]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/iceauth-build'
make[2]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/iceauth-build'
>stampdir/build-iceauth
mkdir -p stampdir
dh_auto_build -Drgb -Brgb-build
make[2]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build'
make  all-recursive
make[3]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build'
Making all in man
make[4]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build/man'
/bin/sed -e 's|__vendorversion__|"rgb 1.0.5" "X Version 11"|' 	-e 's|__xorgversion__|"rgb 1.0.5" "X Version 11"|' 	-e 's|__xservername__|Xorg|g' 	-e 's|__xconfigfile__|xorg.conf|g' 	-e 's|__projectroot__|/usr|g' 	-e 's|__apploaddir__||g' 	-e 's|__appmansuffix__|1|g' 	-e 's|__drivermansuffix__|4|g' 	-e 's|__adminmansuffix__|8|g' 	-e 's|__libmansuffix__|3|g' 	-e 's|__miscmansuffix__|7|g' 	-e 's|__filemansuffix__|5|g' -e 's|__RGB_DB__|/usr/share/X11/rgb|g' -e 's|__RGB_DB_DIR__|/usr/share/X11|g' -e 's|__RGB_DB_TYPE__|text|g' -e 's|__RGB_DB_FILES__||g' < ../../rgb/man/showrgb.man > showrgb.1
make[4]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build/man'
make[4]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build'
gcc -DHAVE_CONFIG_H -I. -I../rgb   -D_FORTIFY_SOURCE=2  -DRGB_DB=\"/usr/share/X11/rgb\" -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o showrgb.o ../rgb/showrgb.c
gcc  -DRGB_DB=\"/usr/share/X11/rgb\" -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall  -Wl,-z,relro -o showrgb showrgb.o  
make[4]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build'
make[3]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build'
make[2]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/rgb-build'
>stampdir/build-rgb
mkdir -p stampdir
dh_auto_build -Dsessreg -Bsessreg-build
make[2]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/sessreg-build'
make  all-recursive
make[3]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/sessreg-build'
Making all in man
make[4]: Entering directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/sessreg-build/man'
gcc -E -DHAVE_CONFIG_H   \
    -I.. -I../../sessreg -D_FORTIFY_SOURCE=2 ../../sessreg/man/filenames.sed.c | \
    grep 's|__' > filenames.sed
/bin/sed -e 's|__vendorversion__|"sessreg 1.0.8" "X Version 11"|' 	-e 's|__xorgversion__|"sessreg 1.0.8" "X Version 11"|' 	-e 's|__xservername__|Xorg|g' 	-e 's|__xconfigfile__|xorg.conf|g' 	-e 's|__projectroot__|/usr|g' 	-e 's|__apploaddir__||g' 	-e 's|__appmansuffix__|1|g' 	-e 's|__drivermansuffix__|4|g' 	-e 's|__adminmansuffix__|8|g' 	-e 's|__libmansuffix__|3|g' 	-e 's|__miscmansuffix__|7|g' 	-e 's|__filemansuffix__|5|g' -f filenames.sed < ../../sessreg/man/sessreg.man > sessreg.1
/bin/sed: file filenames.sed line 2: unterminated `s' command
make[4]: *** [sessreg.1] Error 1
Makefile:491: recipe for target 'sessreg.1' failed
make[4]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/sessreg-build/man'
make[3]: *** [all-recursive] Error 1
Makefile:501: recipe for target 'all-recursive' failed
make[3]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/sessreg-build'
make[2]: *** [all] Error 2
Makefile:372: recipe for target 'all' failed
make[2]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3/sessreg-build'
dh_auto_build: make -j10 returned exit code 2
make[1]: *** [stampdir/build-sessreg] Error 2
debian/rules:50: recipe for target 'stampdir/build-sessreg' failed
make[1]: Leaving directory '/«BUILDDIR»/x11-xserver-utils-7.7+3'
make: *** [build-arch] Error 2
debian/rules:28: recipe for target 'build-arch' failed
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2

Message #10 received at 778176@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@ubuntu.com>

To: 778176@bugs.debian.org

Subject: add patch

Date: Fri, 06 Mar 2015 18:15:58 +0100

Control: tags -1 + patch

diff -Nru x11-xserver-utils-7.7+2ubuntu1/debian/changelog
x11-xserver-utils-7.7+2ubuntu2/debian/changelog
--- x11-xserver-utils-7.7+2ubuntu1/debian/changelog	2014-02-14
10:06:10.000000000 +0000
+++ x11-xserver-utils-7.7+2ubuntu2/debian/changelog	2015-03-06
16:51:48.000000000 +0000
@@ -1,3 +1,9 @@
+x11-xserver-utils (7.7+2ubuntu2) vivid; urgency=medium
+
+  * Fix build with GCC 5.
+
+ -- Matthias Klose <doko@ubuntu.com>  Fri, 06 Mar 2015 17:51:25 +0100
+
 x11-xserver-utils (7.7+2ubuntu1) trusty; urgency=low

   * Add breaks/replaces on the lts packages. (LP: #1280155)
diff -Nru x11-xserver-utils-7.7+2ubuntu1/debian/rules
x11-xserver-utils-7.7+2ubuntu2/debian/rules
--- x11-xserver-utils-7.7+2ubuntu1/debian/rules	2014-02-14 09:42:44.000000000 +0000
+++ x11-xserver-utils-7.7+2ubuntu2/debian/rules	2015-03-06 16:57:36.000000000 +0000
@@ -24,6 +24,8 @@
 LDFLAGS = `dpkg-buildflags --get LDFLAGS`
 CPPFLAGS = `dpkg-buildflags --get CPPFLAGS`

+export CPP := $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)-gcc -E -P
+
 %:
 	dh $@ --with autoreconf,quilt --parallel

Message #17 received at 778176@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Matthias Klose <doko@ubuntu.com>, 778176@bugs.debian.org

Subject: Re: Bug#778176: add patch

Date: Sat, 7 Mar 2015 08:57:48 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 - patch

On Fri, Mar  6, 2015 at 18:15:58 +0100, Matthias Klose wrote:

> diff -Nru x11-xserver-utils-7.7+2ubuntu1/debian/rules
> x11-xserver-utils-7.7+2ubuntu2/debian/rules
> --- x11-xserver-utils-7.7+2ubuntu1/debian/rules	2014-02-14 09:42:44.000000000 +0000
> +++ x11-xserver-utils-7.7+2ubuntu2/debian/rules	2015-03-06 16:57:36.000000000 +0000
> @@ -24,6 +24,8 @@
>  LDFLAGS = `dpkg-buildflags --get LDFLAGS`
>  CPPFLAGS = `dpkg-buildflags --get CPPFLAGS`
> 
> +export CPP := $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)-gcc -E -P
> +
>  %:
>  	dh $@ --with autoreconf,quilt --parallel
> 
I don't think that's an acceptable way to fix this.

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 778176@bugs.debian.org (full text, mbox, reply):

From: Daniel Schepler <dschepler@gmail.com>

To: 778176@bugs.debian.org

Cc: 778176-submitter@bugs.debian.org

Subject: Revised gcc-5 patch for x11-xserver-utils

Date: Sat, 18 Jul 2015 09:39:03 -0700

[Message part 1 (text/plain, inline)]

On Sat, 7 Mar 2015 08:57:48 +0100, Julien Cristau wrote:
> I don't think that's an acceptable way to fix this.

How about this?  (This is a patch to be directly quilt imported, not a 
debdiff.)
-- 
Daniel Schepler

[03_gcc-5-fix.diff (text/x-patch, inline)]

Index: x11-xserver-utils-7.7+4/sessreg/man/Makefile.am
===================================================================
--- x11-xserver-utils-7.7+4.orig/sessreg/man/Makefile.am
+++ x11-xserver-utils-7.7+4/sessreg/man/Makefile.am
@@ -10,7 +10,7 @@ SUFFIXES = .$(APP_MAN_SUFFIX) .man
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir)
 filenames.sed: filenames.sed.c
 	$(AM_V_GEN)$(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) \
-	    $(AM_CPPFLAGS) $(CPPFLAGS) $(srcdir)/filenames.sed.c | \
+	    $(AM_CPPFLAGS) $(CPPFLAGS) -P $(srcdir)/filenames.sed.c | \
 	    $(SED) -n -e '/s|__/ p' -e '/^\/__/ p' > $@
 
 # String replacements in MAN_SUBSTS now come from xorg-macros.m4 via configure

Message #36 received at 778176@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Daniel Schepler <dschepler@gmail.com>, 778176@bugs.debian.org

Cc: 778176-submitter@bugs.debian.org

Subject: Re: Bug#778176: Revised gcc-5 patch for x11-xserver-utils

Date: Sat, 18 Jul 2015 22:34:33 +0200

[Message part 1 (text/plain, inline)]

On Sat, Jul 18, 2015 at 09:39:03 -0700, Daniel Schepler wrote:

> On Sat, 7 Mar 2015 08:57:48 +0100, Julien Cristau wrote:
> > I don't think that's an acceptable way to fix this.
> 
> How about this?  (This is a patch to be directly quilt imported, not a 
> debdiff.)

How portable is -P?  What change in gcc makes this necessary?  What does
the output without -P look like with cpp 5 vs 4.9?

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #44 received at 778176@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: Julien Cristau <jcristau@debian.org>, Daniel Schepler <dschepler@gmail.com>, 778176@bugs.debian.org

Subject: Re: Bug#778176: Revised gcc-5 patch for x11-xserver-utils

Date: Sun, 19 Jul 2015 12:51:05 +0200

On 07/18/2015 10:34 PM, Julien Cristau wrote:
> On Sat, Jul 18, 2015 at 09:39:03 -0700, Daniel Schepler wrote:
> 
>> On Sat, 7 Mar 2015 08:57:48 +0100, Julien Cristau wrote:
>>> I don't think that's an acceptable way to fix this.
>>
>> How about this?  (This is a patch to be directly quilt imported, not a 
>> debdiff.)
> 
> How portable is -P?  What change in gcc makes this necessary?  What does
> the output without -P look like with cpp 5 vs 4.9?

hmm, maybe check it out yourself? or read
https://gcc.gnu.org/gcc-5/porting_to.html "Preprocessor issues" (linked from the
GCC 5 wiki page)?

anyway, here is another approach:
https://github.com/tsuna/boost.m4/commit/32553aaf4d5090da19aa0ec33b936982c685009f

clang seems to support -P as well. I don't know about other compilers.

Message #49 received at 778176@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: Matthias Klose <doko@debian.org>, 778176@bugs.debian.org

Cc: Daniel Schepler <dschepler@gmail.com>

Subject: Re: Bug#778176: Revised gcc-5 patch for x11-xserver-utils

Date: Sun, 19 Jul 2015 18:30:47 +0200

[Message part 1 (text/plain, inline)]

On Sun, Jul 19, 2015 at 12:51:05 +0200, Matthias Klose wrote:

> clang seems to support -P as well. I don't know about other compilers.
> 
sun^Woracle studio seems to have a -P, too.
http://docs.oracle.com/cd/E37069_01/html/E37074/bjapp.html#OSSCGbjarx

Cheers,
Julien

[signature.asc (application/pgp-signature, inline)]

Message #58 received at 778176-close@bugs.debian.org (full text, mbox, reply):

From: Julien Cristau <jcristau@debian.org>

To: 778176-close@bugs.debian.org

Subject: Bug#778176: fixed in x11-xserver-utils 7.7+5

Date: Sat, 12 Sep 2015 10:50:11 +0000

Source: x11-xserver-utils
Source-Version: 7.7+5

We believe that the bug you reported is fixed in the latest version of
x11-xserver-utils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 778176@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Cristau <jcristau@debian.org> (supplier of updated x11-xserver-utils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 12 Sep 2015 12:16:27 +0200
Source: x11-xserver-utils
Binary: x11-xserver-utils
Architecture: source
Version: 7.7+5
Distribution: unstable
Urgency: high
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Julien Cristau <jcristau@debian.org>
Description:
 x11-xserver-utils - X server utilities
Closes: 778176
Changes:
 x11-xserver-utils (7.7+5) unstable; urgency=high
 .
   * High urgency upload for RC bug fix.
   * sessreg: fix FTBFS with gcc 5 (closes: #778176).  Thanks to Matthias
     Klose, Daniel Schepler and Aurélien Jarno.
Checksums-Sha1:
 766867e509271e04e30dbe77a675fe09c5d7f7c8 1937 x11-xserver-utils_7.7+5.dsc
 41849672099c22c10bfe69543618867c29848349 2571920 x11-xserver-utils_7.7+5.tar.gz
Checksums-Sha256:
 00e1a6063144be6a293deff788b5d986e6e0c9f30f72fcdc2e83882416740eaa 1937 x11-xserver-utils_7.7+5.dsc
 7ee4bf884fa77adc8a9d16430dda6cb44cf5842d6be2af4adeffba6c68c27b7b 2571920 x11-xserver-utils_7.7+5.tar.gz
Files:
 61baac94fa19b01fe0bbc42a9a40cac4 1937 x11 optional x11-xserver-utils_7.7+5.dsc
 358184c80692ce15dd8ea7b60ef9e93e 2571920 x11 optional x11-xserver-utils_7.7+5.tar.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJV8/5gAAoJEDEBgAUJBeQMKPIP/2srf1lv/PJ9uUg9cZ2rVipw
+mmXRd1OpIX2Mv1ZI8y4ytUSsVwoKyncSIzGkPfG9wbLNkN+B7zk0mxbjIAcqD4o
y1L+dDvT2fskMAgoPOL4cZeswSOE/1yCXoz4wrxSz0YJBD0Idtdl2ptym2MomM1t
3PNUNrCNz+M3UczlG1n0l3I6yartv76WPIhi7gKwxebTMVO09u+UIq0nU4W0j55+
FZvzLdAF/Gny+weOyPxId/4AuUFbKRSKjXB+6G0E2S6dNzN/+cc7u+sbEyp/9jLs
aDVlYuVDuixluPO1xRu8v5hDW2+bGWSApeT1e9yznKfD1AWKGuu98a5W/NVXQxAy
FhI9t7MoE6w2AGnrAVsUaBr9WWTtxsCrXvmXd2jZ6/j4+fUrFTcl8f7bY8zXfsjr
a7PscAD3MBZf/5+GrpHjMgqAlc2EoNLV1NysJQg34FlH29OKZBHYHJc6O9yGvXuR
lf97ex0twzSZXpj8JHyU8YiVOdKI8+nDLGzzIXvtIB1e7cOs88TkGEPpbynWOJXV
2LlVOisWweHVGff9BcnTdzRTk+MtlE/j5SBXfz/mJVYwP0dGenS888oEFwUzYLH/
tu7TWVSbLXWSmMJ4Cu+0q9RAZV3A7n6G5CfGH1iLMKv8fBwnXGExg1YswyssgagY
ka6ERW63JB64eMaA+ZgZ
=e4Sb
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.