Debian Bug report logs - #778039
oolite: ftbfs with GCC-5

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: maintonly@bugs.debian.org

Subject: oolite: ftbfs with GCC-5

Date: Thu, 12 Feb 2015 10:35:13 +0000

Package: src:oolite
Version: 1.77.1-3
Severity: normal
Tags: sid stretch
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-5

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-5/g++-5, but succeeds to build with gcc-4.9/g++-4.9. The
severity of this report may be raised before the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc5-20150205/oolite_1.77.1-3_unstable_gcc5.log
The last lines of the build log are at the end of this report.

To build with GCC 5, either set CC=gcc-5 CXX=g++-5 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t experimental install g++ 

Common build failures are C11 as the default C mode, new warnings
resulting in build failures with -Werror turned on, or new/dropped
symbols in Debian symbols files.  For other C/C++ related build failures
see the porting guide at http://gcc.gnu.org/gcc-5/porting_to.html

[...]
make[5]: *** Waiting for unfinished jobs....
/usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj/oolite.obj/Entity.m.o' failed
src/Core/Entities/PlayerEntityLegacyScriptEngine.m: In function '-[PlayerEntity(Scripting) setFuelLeak:]':
src/Core/Entities/PlayerEntityLegacyScriptEngine.m:2148:3: error: format not a string literal and no format arguments [-Werror=format-security]
   OOLog(kOOLogNoteFuelLeak, @"FUEL LEAK activated!");
   ^
src/Core/Entities/PlayerEntityLegacyScriptEngine.m: In function '-[PlayerEntity(Scripting) debugOn]':
src/Core/Entities/PlayerEntityLegacyScriptEngine.m:2333:2: error: format not a string literal and no format arguments [-Werror=format-security]
  OOLog(kOOLogDebugOnOff, @"SCRIPT debug messages ON");
  ^
src/Core/Entities/PlayerEntityLegacyScriptEngine.m: In function '-[PlayerEntity(Scripting) debugOff]':
src/Core/Entities/PlayerEntityLegacyScriptEngine.m:2339:2: error: format not a string literal and no format arguments [-Werror=format-security]
  OOLog(kOOLogDebugOnOff, @"SCRIPT debug messages OFF");
  ^
src/Core/Entities/PlayerEntityLegacyScriptEngine.m: In function '-[PlayerEntity(Scripting) setGalacticHyperspaceFixedCoordsTo:]':
src/Core/Entities/PlayerEntityLegacyScriptEngine.m:2863:3: error: format not a string literal and no format arguments [-Werror=format-security]
   OOLog(@"player.setGalacticHyperspaceFixedCoords.invalidInput",
   ^
src/Core/Entities/PlayerEntityLoadSave.m: In function '-[PlayerEntity(LoadSave) quicksavePlayer]':
src/Core/Entities/PlayerEntityLoadSave.m:188:3: error: format not a string literal and no format arguments [-Werror=format-security]
   OOLog(@"quickSave.failed.noName", @"ERROR no file name returned by [[gameView gameController] playerFileToLoad]");
   ^
cc1obj: some warnings being treated as errors
make[5]: *** [obj/oolite.obj/PlanetEntity.m.o] Error 1
/usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj/oolite.obj/PlanetEntity.m.o' failed
cc1obj: some warnings being treated as errors
make[5]: *** [obj/oolite.obj/PlayerEntityLoadSave.m.o] Error 1
/usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj/oolite.obj/PlayerEntityLoadSave.m.o' failed
cc1obj: some warnings being treated as errors
make[5]: *** [obj/oolite.obj/PlayerEntityLegacyScriptEngine.m.o] Error 1
/usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj/oolite.obj/PlayerEntityLegacyScriptEngine.m.o' failed
cc1obj: some warnings being treated as errors
make[5]: *** [obj/oolite.obj/PlayerEntityControls.m.o] Error 1
/usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj/oolite.obj/PlayerEntityControls.m.o' failed
cc1obj: some warnings being treated as errors
make[5]: *** [obj/oolite.obj/PlayerEntity.m.o] Error 1
/usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj/oolite.obj/PlayerEntity.m.o' failed
make[4]: *** [internal-objc_program-all_] Error 2
/usr/share/GNUstep/Makefiles/Instance/objc.make:64: recipe for target 'internal-objc_program-all_' failed
make[3]: *** [oolite.all.objc-program.variables] Error 2
/usr/share/GNUstep/Makefiles/Master/rules.make:298: recipe for target 'oolite.all.objc-program.variables' failed
make[2]: *** [internal-all] Error 2
/usr/share/GNUstep/Makefiles/Master/objc.make:36: recipe for target 'internal-all' failed
make[2]: Leaving directory '/«PKGBUILDDIR»'
make[1]: *** [oolite.app] Error 2
debian/rules:90: recipe for target 'oolite.app' failed
make[1]: Leaving directory '/«PKGBUILDDIR»'
make: *** [build-arch] Error 2
debian/rules:28: recipe for target 'build-arch' failed
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2

Message #14 received at 778039@bugs.debian.org (full text, mbox, reply):

From: Josh Gadeken <josh.gadeken@hp.com>

To: 778039@bugs.debian.org

Subject: Patch for GCC 5 build issue

Date: Thu, 16 Jul 2015 13:30:40 -0600

[Message part 1 (text/plain, inline)]

tags 778039 + patch
thanks

Here's a fix for the GCC 5 build issue. I added 
"-Wno-error=format-security" to the GNUmakefile. The package 
successfully builds and links using GCC 5 with this change.

It looks like GCC 5 / gobjc 5 sets "-Werror=format-security" by default. 
Please see the "Environment variables" section at
https://wiki.debian.org/Hardening#Environment_variables for more info.

-- 
Josh Gadeken
Linux for HP Helion OpenStack, Hewlett-Packard

[oolite.gcc5.patch (text/x-patch, attachment)]

Message #21 received at 778039@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Josh Gadeken <josh.gadeken@hp.com>, 778039@bugs.debian.org

Subject: Re: Bug#778039: Patch for GCC 5 build issue

Date: Sat, 18 Jul 2015 21:25:29 +0200

[Message part 1 (text/plain, inline)]

On Thu, 16 Jul 2015 13:30:40 -0600, Josh Gadeken wrote:

> Here's a fix for the GCC 5 build issue. I added "-Wno-error=format-security"
> to the GNUmakefile. The package successfully builds and links using GCC 5
> with this change.

I don't think that's the best way forward. Since this is
security-relevant I think we should rather fix the problem than
ignoring the errors. And I remember that in some previous mass fix
campaign in Debian we already fixed quite a few
"-Werror=format-security" issues.
 
Please note that dpkg-buildflags sets "-Werror=format-security" by
default:

% dpkg-buildflags 
CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security
[..]


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Rolling Stones: She's A Rainbow (45 version)/She's a Rainbow - 2

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 778039@bugs.debian.org (full text, mbox, reply):

From: Nicolas Boulenguez <nicolas@debian.org>

To: 778039@bugs.debian.org

Subject: Re: Bug#778039: Patch for GCC 5 build issue

Date: Sun, 19 Jul 2015 01:03:28 +0200

Package: src:oolite
Followup-For: Bug #778039

> > Here's a fix for the GCC 5 build issue. I added -Wno-error=format-security

> I don't think that's the best way forward. Since this is
> security-relevant I think we should rather fix the problem than
> ignoring the errors.

Fully agreed. However, thanks reporting

> > The package successfully builds and links using GCC 5 with this change.

because it shows that gcc-5 will not expose any other problem.

Message #31 received at 778039@bugs.debian.org (full text, mbox, reply):

From: Chris Morris <cim@oolite.org>

To: 778039@bugs.debian.org

Subject: Re: Bug#778039: Patch for GCC 5 build issue

Date: Sun, 9 Aug 2015 12:58:03 +0100 (BST)

Hello

The following commit should fix the build warnings
https://github.com/OoliteProject/oolite/commit/80835961e0d0fad8c9dd1bfbd26706808360c66f

The commit is to 1.82's version of the files but other than which lines 
are being patched there shouldn't be any difference to what's needed for 
1.77.1

I don't believe this to actually be a security issue - in all five lines 
the format string is an NSString literal which should be just as safe as a 
C-string literal.

Thanks

-- 
Chris

Message #36 received at 778039-close@bugs.debian.org (full text, mbox, reply):

From: Nicolas Boulenguez <nicolas@debian.org>

To: 778039-close@bugs.debian.org

Subject: Bug#778039: fixed in oolite 1.82-1

Date: Thu, 03 Sep 2015 17:22:23 +0000

Source: oolite
Source-Version: 1.82-1

We believe that the bug you reported is fixed in the latest version of
oolite, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 778039@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicolas Boulenguez <nicolas@debian.org> (supplier of updated oolite package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 03 Sep 2015 01:35:02 +0200
Source: oolite
Binary: oolite oolite-doc oolite-data oolite-data-sounds
Architecture: all source
Version: 1.82-1
Distribution: unstable
Urgency: medium
Maintainer: Nicolas Boulenguez <nicolas@debian.org>
Changed-By: Nicolas Boulenguez <nicolas@debian.org>
Closes: 749453 755994 778039
Description: 
 oolite-data-sounds - space sim game, inspired by Elite (sounds)
 oolite-data - space sim game, inspired by Elite (data files)
 oolite-doc - space sim game, inspired by Elite (documentation)
 oolite     - space sim game, inspired by Elite
Changes:
 oolite (1.82-1) unstable; urgency=medium
 .
   * New upstream release, splitting sound and images. License update.
   * Drop unneeded build dependency on gnustep-core-devel. Closes: #749453.
   * gnustep >= 2.6.6-1 does not need let_gnustep_handle_cflags.diff anymore.
   * watch: upstream migrated to github. Closes: #755994.
   * Repackage with Files-Excluded instead of cleaner script and git branch.
   * Reactivate libespeak support, see #591717.
   * Standards-Version: 3.9.6 (no changes).
   * debian/README: web page snippets that may be useful for users.
   * Provide a writable XDG_CONFIG_HOME to libreoffice when converting .odt
     to PDF, lowering the severity of #730893.
   * allow -Werror=format-security, default with gcc-5. Closes: #778039.
   * patches/avoid_date_cpp_macro.diff: for reproducible builds.
   * patches/avoid_infinite_recursion_in_verify_descriptions.diff.
Checksums-Sha1: 
 10e9967f54f1647c050b924db675938f44c24ca0 2548 oolite_1.82-1.dsc
 517bd79a7383365b7441ab46d9e5fe65190547b0 96658494 oolite_1.82.orig-binary-resources.tar.gz
 a5108430f83011e8e1f3c863e1175b8a7cbcab17 9865000 oolite_1.82.orig.tar.gz
 1a4e61e9688514b90d04494e1e9d4ddcb9eee9db 34224 oolite_1.82-1.debian.tar.xz
 836a178f91d7ed14f247e716d64637f8ac20c2f4 8301782 oolite-data-sounds_1.82-1_all.deb
 0a71b68114a93febaae427462737e3fc43054866 88471722 oolite-data_1.82-1_all.deb
 4082164e1cb5c1af623e663f563e9597e4b66adf 1326324 oolite-doc_1.82-1_all.deb
Checksums-Sha256: 
 4b099ee7c0360183c8d839e532b79283f1dc202005723eeef2e08e4d022b093d 2548 oolite_1.82-1.dsc
 c1d32fdfe2a2ca5e76cd35aaa71cbbc944bc948b832c3df601a2f31256966ec6 96658494 oolite_1.82.orig-binary-resources.tar.gz
 7aba862db19873ce6ff1d0442d31f5f886316b2e43339ca470512b93c191bc2d 9865000 oolite_1.82.orig.tar.gz
 9991f9b05eb2d9450270cfe819558b95ccf2ad9575ba45f3410b74370a45f106 34224 oolite_1.82-1.debian.tar.xz
 5cb7c5ce83c02fe139c5740e5b912571728e46b7b2427e6608ffdd3231d01c3d 8301782 oolite-data-sounds_1.82-1_all.deb
 c3e848ebefd5a456dc026e5ecb536f2a613df6046649f2bb88d51181a7ca8ca9 88471722 oolite-data_1.82-1_all.deb
 9ebfc3ac34dc5840238093df0a94a934410ffcc1d21e27d1f602a2859fae9e7f 1326324 oolite-doc_1.82-1_all.deb
Files: 
 aebe2db59ce540d3e298802b50be7582 2548 games optional oolite_1.82-1.dsc
 82cc899314bf36865f4e48bf6c7961bd 96658494 games optional oolite_1.82.orig-binary-resources.tar.gz
 ff26300f82183698cf8fabef6e1de1a8 9865000 games optional oolite_1.82.orig.tar.gz
 1d7143c97e10744149c2da9aa40f7e93 34224 games optional oolite_1.82-1.debian.tar.xz
 55c5312328efd3c68291d167c776faf9 8301782 games optional oolite-data-sounds_1.82-1_all.deb
 c3804fda3c53c5e799649514d7845aa8 88471722 games optional oolite-data_1.82-1_all.deb
 f162206358253e96c9b077207e1e2b28 1326324 doc optional oolite-doc_1.82-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJV6HjvAAoJELUqnPRJDfyNRbMP/0XEgGPAUH1G0u8hLJJcanYN
wuADUnQiZXYO0vYlH0TiBGckd6yVhDH4eWSdKhh/DwstL1saiM4Qnl+du7gg5skI
J8kEi0eyhN665H/mSdzHu8a1g3IBfbUzKZfglNWhgRVTQL1cEDCEqJ8rB+Hai19E
fSIQAglfcI2HxzIC3BNRZ8lbp6ShHjQ00P9UnTPyVZQWTZlHVZSmKGafULPtC0gx
HPN8Zu1ziBknVD43lCbmEcalE6mlSe/eVAHkZaTFVH7pYI5Sc7bYURkRnemjki6O
eP81iGe8/kyIVkLVOGy3TpCrG7gDt+kXfFi/9Omb6Ny07nc3FzwZGTQGqyV8IwRZ
wNNMNqM3UIGc84jQrUnGa29u7vdtYFhN/n+y2ITzu7cdGCg/39xI8ztm6gMo3m4u
CAPURfWV5gx5AZ7nlhH03kXNbCjYNjXxK2xe1pmkUOfUk4OQcfhCX3c93sGpdMf1
AIuYW6aX9gg0zbRqTjwDlr5JX6KhcVk6ppHhedIqXEZWpTGiopQ6GWC2CdvBsbxF
+oEwGWnDEeUXVq/NfLGfZYtQDzC+dL5W6Nu6GXea1s9y9uV0aRjFeiQsAkNybzmb
PhtTqrNLXv4CDtnXmACxZH7+qWT6slqIpw1nsVoPJ80hx4v8UhHtcGCgThvdrR0m
VbmiVsAQkhzV6VdUFX5z
=UdhY
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.