Debian Bug report logs - #777651
RFS: syncterm/1.0+dfsg-1 [ITP] -- BBS terminal program from Synchronet

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ragnarok <ragnarok@docksud.com.ar>

To: submit@bugs.debian.org

Subject: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Wed, 11 Feb 2015 02:16:59 -0300

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "syncterm"

Package name    : syncterm
Version         : 20141022+dfsg-1
Upstream Author : Deuce <sysop@nix.synchro.net>
URL             : http://syncterm.bbsdev.net/
License         : LGPL
Section         : comm

It builds those binary packages:

  syncterm   - BBS terminal program from Synchronet
  syncterm-dbg - BBS terminal program from Synchronet (debug symbols)

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/syncterm


Alternatively, one can download the package with dget using this command:

    dget -x
http://mentors.debian.net/debian/pool/main/s/syncterm/syncterm_20141022+dfsg-1.dsc

Changes since the last upload:

   Initial release (Closes: #739035)

Hi all!, im search again for sponsor, last guy sems to be very busy, he
help me very much to make this package, but at this time lost connection
with that person.

Saludos!

-- 
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #10 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Antti Järvinen <antti.jarvinen@katiska.org>

To: 777651@bugs.debian.org

Cc: ragnarok@docksud.com.ar

Subject: Re: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Fri, 20 Mar 2015 21:54:44 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ragnarok wrote:
> I am looking for a sponsor for my package "syncterm"

Great. I'm no DD so I can't sponsor your package but I can give
comments nonetheless. So, I have following things I don't understand:
 - Is there specific need to list libncurses etc. dependencies in 
   debian/control, should ${shlibs:Depends} take care of that? Or 
   you want a very specific version? Ncurses is still fairly standard
   stuff. 
 - The zmodem license is interesting as they say "don't distributed
   modifications" -> does a patch count as modification? As a sw 
   developer I would say "yes" but someone else needs to clarify
   that. Anyway, if they say "no modifications" and then we find 
   urgent need to patch zmodem (say, a serious security flaw) then
   the options are to remove zmodem or remove whole package? .. is
   zmodem still in active development? I remember having used that
   after x- and ymodem protocols went out of fashion some ~20 years ago :)
 - Good: watch file is present
   Bad: according to "uscan --report" it points to no sw version

In addition to that, nothing big plugs my eye. Sw even builds, too bad
my supramodem2400 is out of service so I can't really really try it
out.

- --
Antti, former sysop of costellobox+several others

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFVDHrpUTdja+nNMWMRAtxuAJwLoOjqjPC1nzAqEHRdNw7FghY7JQCggCMO
22MI+KjyGOoq5OxVlwGQBR0=
=fNUu
-----END PGP SIGNATURE-----

Message #15 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Ragnarok <ragnarok@docksud.com.ar>

To: Antti Järvinen <antti.jarvinen@katiska.org>, 777651@bugs.debian.org

Subject: Re: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Sat, 21 Mar 2015 13:34:32 -0300

El 20/03/15 a las 16:54, Antti Järvinen escibió:
> Ragnarok wrote:
>> I am looking for a sponsor for my package "syncterm"
> 
> Great. I'm no DD so I can't sponsor your package but I can give
> comments nonetheless. So, I have following things I don't understand:
>  - Is there specific need to list libncurses etc. dependencies in 
>    debian/control, should ${shlibs:Depends} take care of that? Or 
>    you want a very specific version? Ncurses is still fairly standard
>    stuff. 
Ok. i just add the depends that upstream say, i'm sure that can change
to ${shlibs:Depends} i will fix

>  - The zmodem license is interesting as they say "don't distributed
>    modifications" -> does a patch count as modification? As a sw 
>    developer I would say "yes" but someone else needs to clarify
>    that. Anyway, if they say "no modifications" and then we find 
>    urgent need to patch zmodem (say, a serious security flaw) then
>    the options are to remove zmodem or remove whole package? .. is
>    zmodem still in active development? I remember having used that
>    after x- and ymodem protocols went out of fashion some ~20 years ago :

I think that this code will never change anymore.

>  - Good: watch file is present
>    Bad: according to "uscan --report" it points to no sw version
> 
Yes im package a daily snapshoot until the mayor release 1.0 (soon) will
piblished.

> In addition to that, nothing big plugs my eye. Sw even builds, too bad
> my supramodem2400 is out of service so I can't really really try it
> out.
You can test syncterm and connect using the telnet protocol to many bbs
that are still online =)

thanks for your review, i will working on your suggests!


-- 
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #30 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Ragnarok <ragnarok@docksud.com.ar>

To: 777651@bugs.debian.org

Subject: Re: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Sat, 27 Jun 2015 16:57:18 -0300

i just upload a new version on mentors:

https://mentors.debian.net/package/syncterm

i apreciated any comments

-- 
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #39 received at 777651-done@bugs.debian.org (full text, mbox, reply):

From: Bart Martens <bartm@quantz.debian.org>

To: 777651-done@bugs.debian.org

Subject: closing RFS: syncterm/20150627+dfsg-1 [ITP] -- BBS terminal program from Synchronet

Date: Sun, 15 Nov 2015 04:27:51 +0000

Package syncterm has been removed from mentors.

Message #42 received at 777651-submitter@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 777651-submitter@bugs.debian.org

Subject: Re: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Sun, 15 Nov 2015 10:42:40 +0100

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Fernando,

On Sat, 27 Jun 2015 16:57:18 -0300 Ragnarok <ragnarok@docksud.com.ar>
wrote:
> i just upload a new version on mentors:
> 
> https://mentors.debian.net/package/syncterm
> 
> i apreciated any comments
> 

are you still interested in this package?

cheers,

G.

> -- Dock Sud BBS http://bbs.docksud.com.ar 
> telnet://bbs.docksud.com.ar
> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWSFOQAAoJEPNPCXROn13Zp90P/1DWH2TknsNL3lJbxAS443uA
VXmePuYqKrQuyRWTsJ6TOWIu0rgtj4OfvjFlN8SwAe6Iuf0BLtvpI6U78j+sjOBb
UPSDLQidnSTHzsDuXKjPksYC+W5rK+Ep3MQJjwcW3vi9xsp8odu2EGM2yJcbQm+7
WK8s+GvY4Dc1PQE38DWeKMd3pkLvLVpCR7uVKbQRLWQvLriBCDPTGZe+blM1lqG4
i8HL6NjkullB8damC1lsLMyu5KwrZgzOlwxVCTs92q4GAUwN4bSRBqODhitRxpVL
ALm6TmHGBWkIPzbpxxSblbtNiSqtx0kkLh/WjxZLyeJSYl390FlQatX7Ih7XuV9b
oZvqiB9DjgOhhV7KH3Id4WY3EzjFOwHV/9BbgCH0ruxFOTMlKoYu2y3ESmWxYSt7
ooghNsDv35OwbhlueL0K07hxZxVaiYLI9+Q+KraDzb+a4UL+3FLoTCcOthK+LMVD
+ssnyOV5Qtr8/TywyrqMWh4PqoFkkqc6rwzkuh6HjDh9ujM9qrqTCQjXW2v2HPe8
u4OsuaThQR+a4BDh7dTbBkuPhsKDr8xaGv/fSK5y9ghjfP/nXkcB+ZDFmF33wSZv
F+tM41gtp8sCgYvkMDe8QNllEj5AzjvuG9QzercMKgWiPWEFghimoUC3ESHQUsVe
TAXDucexKJRE/ChFQfAE
=W9hx
-----END PGP SIGNATURE-----

Message #47 received at 777651-quiet@bugs.debian.org (full text, mbox, reply):

From: Fernando Toledo <ftoledo@docksud.com.ar>

To: Gianfranco Costamagna <locutusofborg@debian.org>, 777651-quiet@bugs.debian.org

Subject: Re: Bug#777651: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Sun, 15 Nov 2015 18:09:49 -0300

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

El 15/11/15 a las 06:42, Gianfranco Costamagna escribió:
> Hi Fernando,
> 
> On Sat, 27 Jun 2015 16:57:18 -0300 Ragnarok
> <ragnarok@docksud.com.ar> wrote:
>> i just upload a new version on mentors:
> 
>> https://mentors.debian.net/package/syncterm
> 
>> i apreciated any comments
> 
> 
> are you still interested in this package?
> 
> cheers,
> 
> G.
> 
>> -- Dock Sud BBS http://bbs.docksud.com.ar 
>> telnet://bbs.docksud.com.ar
> 
> 
Yes!

I have news, i get contact withe the zmodem.* files author.

So why the package was removed from mentor, is it expired or the
license issue?

I can re-upload the latest version if you need.

- -- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlZI9J0ACgkQrka4e4h7i+OMAwCfVu+IMl6pcA/ZiFcXf0ZvjTxW
1ZIAoLNQIPoDZc3yRNJ03mz0lmGs5prx
=Dtf7
-----END PGP SIGNATURE-----

Message #52 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Paul Wise <pabs@debian.org>

To: Fernando Toledo <ftoledo@docksud.com.ar>, 777651@bugs.debian.org

Cc: Gianfranco Costamagna <locutusofborg@debian.org>

Subject: Re: Bug#777651: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Mon, 16 Nov 2015 10:24:21 +0800

On Mon, Nov 16, 2015 at 5:09 AM, Fernando Toledo wrote:

> So why the package was removed from mentor, is it expired or the
> license issue?

Packages are removed from mentors automatically after a period of
inactivity. It has been months since the last upload of syncterm so
probably you hit the limit.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Message #57 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Fernando Toledo <ftoledo@docksud.com.ar>

To: 777651@bugs.debian.org

Subject: Re: Bug#777651: RFS: syncterm/20141022+dfsg-1 [ITP]

Date: Thu, 19 Nov 2015 17:31:58 -0300

On Mon, 16 Nov 2015 10:24:21 +0800 Paul Wise <pabs@debian.org> wrote:
> On Mon, Nov 16, 2015 at 5:09 AM, Fernando Toledo wrote:
> 
> > So why the package was removed from mentor, is it expired or the
> > license issue?
> 
> Packages are removed from mentors automatically after a period of
> inactivity. It has been months since the last upload of syncterm so
> probably you hit the limit.
> 
> -- 
> bye,
> pabs
> 
> https://wiki.debian.org/PaulWise
> 
> 
Ok. i have good news! i received good response for the zmodem files owner.

Jacques Mattheij do transfer the copyright to SyncTerm developers.

http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/zmodem.c?revision=1.119&view=markup

http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/zmodem.h?revision=1.54&view=markup

i hope that this notice avoid this copyright issue.

I will working on update the package and re-upload to mentors on few days.

thanks.

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #62 received at 777651@bugs.debian.org (full text, mbox, reply):

From: John Goerzen <jgoerzen@complete.org>

To: 777651@bugs.debian.org

Subject: Willing to help

Date: Wed, 02 Dec 2015 13:04:44 -0600

Hi,

I'm a DD that is willing to review/test this, but I don't see a current
package out there.  Can you try again?

John

Message #65 received at 777651-submitter@bugs.debian.org (full text, mbox, reply):

From: John Goerzen <jgoerzen@complete.org>

To: 777651-submitter@bugs.debian.org

Subject: Fwd: Willing to help

Date: Wed, 02 Dec 2015 13:07:37 -0600

[Message part 1 (text/plain, inline)]

-------- Forwarded Message --------
Subject: 	Willing to help
Date: 	Wed, 02 Dec 2015 13:04:44 -0600
From: 	John Goerzen <jgoerzen@complete.org>
To: 	777651@bugs.debian.org



Hi,

I'm a DD that is willing to review/test this, but I don't see a current
package out there.  Can you try again?

John

[Message part 2 (text/html, inline)]

Message #80 received at 777651-done@bugs.debian.org (full text, mbox, reply):

From: Bart Martens <bartm@quantz.debian.org>

To: 777651-done@bugs.debian.org

Subject: closing RFS: syncterm/1.0+dfsg-1 [ITP] -- BBS terminal program from Synchronet

Date: Tue, 26 Jul 2016 04:33:09 +0000

Package syncterm has been removed from mentors.

Message #85 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 777651@bugs.debian.org, jgoerzen@complete.org, ftoledo@docksud.com.ar

Subject: Re: closing RFS: syncterm/1.0+dfsg-1 [ITP] -- BBS terminal program from Synchronet

Date: Tue, 26 Jul 2016 17:31:21 +0200

[Message part 1 (text/plain, inline)]

control: reopen -1
control: unarchive -1
control: owner -1 jgoerzen@complete.org

On Tue, 26 Jul 2016 04:33:09 +0000 Bart Martens <bartm@quantz.debian.org> wrote:
> Package syncterm has been removed from mentors.

lets try to cc everybody :)

thanks

G.

[signature.asc (application/pgp-signature, attachment)]

Message #94 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Fernando Toledo <ftoledo@docksud.com.ar>

To: Gianfranco Costamagna <locutusofborg@debian.org>, 777651@bugs.debian.org, jgoerzen@complete.org

Subject: Re: Bug#777651: closing RFS: syncterm/1.0+dfsg-1 [ITP] -- BBS terminal program from Synchronet

Date: Wed, 27 Jul 2016 15:26:03 -0300

El 26/07/16 a las 12:31, Gianfranco Costamagna escribió:
> control: reopen -1
> control: unarchive -1
> control: owner -1 jgoerzen@complete.org
> 
> On Tue, 26 Jul 2016 04:33:09 +0000 Bart Martens <bartm@quantz.debian.org> wrote:
>> Package syncterm has been removed from mentors.
> 
> lets try to cc everybody :)
> 
> thanks
> 
> G.
>
Thanks!

I just upload again to mentors. I still search for sponsor

Saludos!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #99 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Fernando Toledo <ftoledo@docksud.com.ar>

To: debian-mentors@lists.debian.org, 777651@bugs.debian.org

Subject: RFS: syncterm/1.0+dfsg-1 [ITP]

Date: Tue, 9 Aug 2016 15:12:02 -0300

Hi all!!! i'm still search for sponsor for Syncterm!

  Dear mentors,

  I am looking for a sponsor for my package "syncterm"

 * Package name    : syncterm
   Version         : 1.0+dfsg-1
   Upstream Author : Deuce <sysop@nix.synchro.net>
 * URL             : http://syncterm.bbsdev.net/
 * License         : LGPL
   Section         : comm

  It builds those binary packages:

    syncterm   - BBS terminal program from Synchronet

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/syncterm

  Alternatively, one can download the package with dget using this command:

    dget -x
https://mentors.debian.net/debian/pool/main/s/syncterm/syncterm_1.0+dfsg-1.dsc

  More information about syncterm package can be obtained from

  https://github.com/ftoledo/pkg-syncterm

  Changes since the last upload:

   * Initial release (Closes: #739035)


Thanks all!!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #104 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 777651@bugs.debian.org

Subject: Re: RFS: syncterm/1.0+dfsg-1 [ITP]

Date: Tue, 16 Aug 2016 14:15:29 +0200

[Message part 1 (text/plain, inline)]

control: tags -1 moreinf

Hi,

>    * Initial release (Closes: #739035)
lets try a review:

1) std-version is 3.9.8 now

2) debhelper (>= 9), libncurses5-dev (>= 5.9),
 unzip (>= 6.0), libsdl2-dev (>= 2.0.2), libsdl1.2-dev (>= 1.2.15),
 gcc (>= 4:4.9)


do you really need both sdl1.2 and sdl2?
do you really need the version constraints for each dependency?
why gcc is listed here?

please  drop versions when already satisfied in jessie, or wheezy in case you want to try
a backport-sloppy (I would really avoid that)

3)
Architecture: i386 amd64
Depends: ${shlibs:Depends}, ${misc:Depends}, libncurses5 (>= 5.9),
 libsdl2-2.0-0 (>= 2.0.2), libsdl1.2debian (>= 1.2.15)

why only two architectures? why aren't the runtime dependencies picked up with shlibs:Depends?
ldd debian/syncterm/usr/bin/syncterm 
	linux-vdso.so.1 =>  (0x00007ffeca745000)
	libutil.so.1 => /lib/x86_64-linux-gnu/libutil.so.1 (0x00007efc98d79000)
	libncurses.so.5 => /lib/x86_64-linux-gnu/libncurses.so.5 (0x00007efc98b57000)
	libtinfo.so.5 => /lib/x86_64-linux-gnu/libtinfo.so.5 (0x00007efc9892d000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007efc98729000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007efc98420000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007efc98202000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007efc97e39000)
	/lib64/ld-linux-x86-64.so.2 (0x0000560b91261000)


at least they seems to be mostly not linked at runtime.

4) rules: to understand the platform you are building, I suggest to use dpkg-architecture
dpkg-architecture -qDEB_TARGET_*

5) override_dh_strip:
        dh_strip --dbg-package=syncterm-dbg


please avoid dbg packages, they are auto generated now


6) ls src/
build  comio  conio  sbbs3  smblib  syncterm  uifc  xpdev

some (most) of them looks like embedded libraries

7) disabled_cryptlib needs to end in .patch (also in series file you should change it)
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

this seems useless

8) the license is non dfsg

 The files sbbs3/zmodem.h and sbbs3/zmodem.c are derived from the
 zmtx/zmrx package available at
 ftp://ftp.netsw.org/net/modem/protocols/zmodem/zmtx-zmrx/
 .
 The licence contained in the archive is:
 .
 MCS allows you to use and copy/modify this source under the following
 conditions:
 .
  - MCS or Jacques Mattheij shall not be liable for any damages arising
    from the use of this code
  - the archive must be distributed as a whole leaving version numbers intact.
    please do not distribute modifications; mail them back to us for inclusion
    in the next release which should follow each other fairly quickly in
    the beginning
  - you will not use this software for commercial purposes.
    (commercial licenses are available contact us for info)
 .
 As such, this program may not be redistributable.  YOU HAVE BEEN WARNED!
 .
 If anyone can put me (shurd@sasktel.net) in contact with the authours,
 that would be greatly appreciated.


9) LGPL with no versioning is wrong.

10) many missing licenses: e.g. BSD-4-clause
11) many missing copyrights, e.g.
grep copyright . -Ri

stopping here the review, because of 8, that needs to be fixed upstream I think


automatic checks from check-all-the-things:

$ env PERL5OPT=-m-lib=. cme check dpkg
[lots]
$ codespell --quiet-level=3
[lots]
$ cppcheck -j1 --quiet -f .
[lots]
$ find -type f -iname '*.desktop' -exec desktop-file-validate {} \;
[some]
$ fdupes -q -r . | grep -vE '/(\.(git|svn|bzr|hg|sgdrawer)|_(darcs|FOSSIL_)|CVS)(/|$)' | cat -s
[lots]
$ flawfinder -Q -c .
[some]

and so on
$ suspicious-source
./src/uifc/uifc.c
./src/syncterm/ooii.c

# Prevents reproducible builds: https://reproducible-builds.org/
$ grep -rE ' __DATE__|__TIME__|__TIMESTAMP__' .
./src/xpdev/xptime.c:	printf("Rev %s Built " __DATE__ " " __TIME__ " with %s\n\n", revision, str);

$ grep -r '/tmp/' .
./src/xpdev/dirwrap.h:	#define _PATH_TMP			"/tmp/"

$ grep -riE 'fixme|todo|hack|xxx+|broken' .
./.pc/disabled_cryptlib/src/build/Common.gmake:  CFLAGS    += -D_THREAD_SUID_BROKEN
./3rdp/build/js_src_jsnativestack_cpp.patch:      * FIXME: this function is non-portable;
./src/xpdev/sdlfuncs.c:		 * This ugly hack attempts to prevent this... of course, remote X11
./src/xpdev/SDL_win32_main.c:/* Special Dynamic/Static hackery */
./src/xpdev/SDL_win32_main.c:	   keep them open.  This is a hack.. hopefully it will be fixed 
./src/xpdev/sockwrap.h:// Borland C++ builder 6 comes with a broken ws2tcpip.h header for GCC.
./src/xpdev/sockwrap.h:#define sendsocket		write		/* FreeBSD send() is broken */
./src/xpdev/xpdatetime.c:/* TODO: adjust times in 24:xx:xx format */
./src/xpdev/xpprintf.c:					 * ToDo this is a signed type of same size
./src/xpdev/xpprintf.c:					 * ToDo this is an unsigned type of same size
...

$ test -d ./debian &&
! grep -s -q native debian/source/format &&
! test -e debian/upstream/metadata &&
echo 'Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata'
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata

$ env PERL5OPT=-m-lib=. uscan --report-status --no-verbose
uscan: Newest version of syncterm on remote site is 1.0, local version is 1.0+dfsg


I think that's all for a first review.

G.

[signature.asc (application/pgp-signature, attachment)]

Message #111 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Fernando Toledo <ftoledo@docksud.com.ar>

To: Gianfranco Costamagna <locutusofborg@debian.org>, 777651@bugs.debian.org

Subject: Re: Bug#777651: RFS: syncterm/1.0+dfsg-1 [ITP]

Date: Wed, 17 Aug 2016 10:14:03 -0300

El 16/08/16 a las 09:15, Gianfranco Costamagna escribió:
> control: tags -1 moreinf
> 
> Hi,
> 
>>    * Initial release (Closes: #739035)
> lets try a review:
> 
> 1) std-version is 3.9.8 now
> 
> 2) debhelper (>= 9), libncurses5-dev (>= 5.9),
>  unzip (>= 6.0), libsdl2-dev (>= 2.0.2), libsdl1.2-dev (>= 1.2.15),
>  gcc (>= 4:4.9)

Gianfranco!! Thanks you very much for your detailed review! =)

I will working on fix on next week!

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #116 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Fernando Toledo <ftoledo@docksud.com.ar>

To: Gianfranco Costamagna <locutusofborg@debian.org>, 777651@bugs.debian.org

Subject: Re: Bug#777651: RFS: syncterm/1.0+dfsg-1 [ITP]

Date: Mon, 5 Sep 2016 22:31:44 -0300

El 16/08/16 a las 09:15, Gianfranco Costamagna escribió:
> control: tags -1 moreinf
> 
> Hi,
> 
>>    * Initial release (Closes: #739035)
> lets try a review:

Hi gianfranco! lets go:
> 
> 1) std-version is 3.9.8 now

fixed.

> 
> 2) debhelper (>= 9), libncurses5-dev (>= 5.9),
>  unzip (>= 6.0), libsdl2-dev (>= 2.0.2), libsdl1.2-dev (>= 1.2.15),
>  gcc (>= 4:4.9)
> 
> 
> do you really need both sdl1.2 and sdl2?
> do you really need the version constraints for each dependency?
> why gcc is listed here?
> please  drop versions when already satisfied in jessie, or wheezy in case you want to try
> a backport-sloppy (I would really avoid that)

remove gcc,
let sdl 1.2 (remove unused sdl2)
update versions from unstable

fixed.

> 
> 3)
> Architecture: i386 amd64
> Depends: ${shlibs:Depends}, ${misc:Depends}, libncurses5 (>= 5.9),
>  libsdl2-2.0-0 (>= 2.0.2), libsdl1.2debian (>= 1.2.15)

>why only two architectures? why aren't the runtime dependencies picked up with shlibs:Depends?
> ldd debian/syncterm/usr/bin/syncterm 
> 	linux-vdso.so.1 =>  (0x00007ffeca745000)
> 	libutil.so.1 => /lib/x86_64-linux-gnu/libutil.so.1 (0x00007efc98d79000)
> 	libncurses.so.5 => /lib/x86_64-linux-gnu/libncurses.so.5 (0x00007efc98b57000)
> 	libtinfo.so.5 => /lib/x86_64-linux-gnu/libtinfo.so.5 (0x00007efc9892d000)
> 	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007efc98729000)
> 	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007efc98420000)
> 	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007efc98202000)
> 	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007efc97e39000)
> 	/lib64/ld-linux-x86-64.so.2 (0x0000560b91261000)
> 
> 
> at least they seems to be mostly not linked at runtime.

fixed.
i only can test in these archs, but i changed it to =>  any


> 
> 4) rules: to understand the platform you are building, I suggest to use dpkg-architecture
> dpkg-architecture -qDEB_TARGET_*
> 
im cleanup the code and use dpkg-architecture now. Great!
fixed

> 5) override_dh_strip:
>         dh_strip --dbg-package=syncterm-dbg
> 
> 
> please avoid dbg packages, they are auto generated now

true! i remove it. fixed
> 
> 
> 6) ls src/
> build  comio  conio  sbbs3  smblib  syncterm  uifc  xpdev
> 
> some (most) of them looks like embedded libraries

it's part of uptream source. can i do something to make it better?
> 
> 7) disabled_cryptlib needs to end in .patch (also in series file you should change it)

fixed.

> ---
> The information above should follow the Patch Tagging Guidelines, please
> checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
> are templates for supplementary fields that you might want to add:
> 
> this seems useless

fixed too

> 
> 8) the license is non dfsg
> 
>  The files sbbs3/zmodem.h and sbbs3/zmodem.c are derived from the
>  zmtx/zmrx package available at
>  ftp://ftp.netsw.org/net/modem/protocols/zmodem/zmtx-zmrx/
>  .
>  The licence contained in the archive is:
>  .
>  MCS allows you to use and copy/modify this source under the following
>  conditions:
>  .
>   - MCS or Jacques Mattheij shall not be liable for any damages arising
>     from the use of this code
>   - the archive must be distributed as a whole leaving version numbers intact.
>     please do not distribute modifications; mail them back to us for inclusion
>     in the next release which should follow each other fairly quickly in
>     the beginning
>   - you will not use this software for commercial purposes.
>     (commercial licenses are available contact us for info)
>  .
>  As such, this program may not be redistributable.  YOU HAVE BEEN WARNED!
>  .
>  If anyone can put me (shurd@sasktel.net) in contact with the authours,
>  that would be greatly appreciated.
> 
this was fixed.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777651#57

You can check the  zmodem.* header file on cvs
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/zmodem.h?revision=1.54&view=markup

Unfortunately, this was after 1.0 release date, and it was made through
my work to contact everyone involved and good response from them.

> 
> 9) LGPL with no versioning is wrong.

fixed

> 
> 10) many missing licenses: e.g. BSD-4-clause
> 11) many missing copyrights, e.g.
> grep copyright . -Ri
> 
> stopping here the review, because of 8, that needs to be fixed upstream I think
> 

I think that can parse file by file to fine copyright settings.
i update it, please check,
I want to the package fit the debian legal requeriments, the code is
gpl, lgpl and some files bsd. i think that all are dfsg
The non-dfsg part was cryplib and was removed via patch (the app can be
used without that lib)

> automatic checks from check-all-the-things:
> 
> $ env PERL5OPT=-m-lib=. cme check dpkg
> [lots]
> $ codespell --quiet-level=3
> [lots]
> $ cppcheck -j1 --quiet -f .
> [lots]
> $ find -type f -iname '*.desktop' -exec desktop-file-validate {} \;
> [some]
> $ fdupes -q -r . | grep -vE '/(\.(git|svn|bzr|hg|sgdrawer)|_(darcs|FOSSIL_)|CVS)(/|$)' | cat -s
> [lots]
> $ flawfinder -Q -c .
> [some]
> 
> and so on
> $ suspicious-source
> ./src/uifc/uifc.c

check-all-the-things are cool tool! I did not know
I will use now it for every package!

i upload again to mentors:

https://mentors.debian.net/debian/pool/main/s/syncterm/syncterm_1.0+dfsg-1.dsc


thanks, I really very apprecited your review.

-- 
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar

Message #121 received at 777651@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: Fernando Toledo <ftoledo@docksud.com.ar>, "777651@bugs.debian.org" <777651@bugs.debian.org>

Subject: Re: Bug#777651: RFS: syncterm/1.0+dfsg-1 [ITP]

Date: Wed, 7 Sep 2016 14:38:04 +0000 (UTC)

control: tags -1 moreinfo

Hi
>remove gcc,
>let sdl 1.2 (remove unused sdl2)
>update versions from unstable

oh... no sdl2 ready code?

>>fixed.
>>i only can test in these archs, but i changed it to =>  any
>

>Depends: ${shlibs:Depends}, ${misc:Depends}, libsdl1.2 (>= 1.2.15)


libsdl1.2 explicit runtime dependency might be "droppable", did you test it?
just do a build, and open the deb file section debian/control


why libsdl1.2 is not picked up?

>> some (most) of them looks like embedded libraries
>
>it's part of uptream source. can i do something to make it better?

>

yes, remove them, repack the source (debian/copyright has a nice Files-Excluded feature)
and drop them from copyright.
and package them separately if not yet in debian (and useful outside this package)

>http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/zmodem.h?revision=1.54&view=markup
>
>Unfortunately, this was after 1.0 release date, and it was made through
>my work to contact everyone involved and good response from them.


ok, you might package an upstream snapshot, or clarify this in copyright file

>I think that can parse file by file to fine copyright settings.
>i update it, please check,
>I want to the package fit the debian legal requeriments, the code is
>gpl, lgpl and some files bsd. i think that all are dfsg
>The non-dfsg part was cryplib and was removed via patch (the app can be
>used without that lib)


ok


let me know how you want to proceed with the above points

cheers,

G.

Message #126 received at 777651-done@bugs.debian.org (full text, mbox, reply):

From: Bart Martens <bartm@quantz.debian.org>

To: 777651-done@bugs.debian.org

Subject: closing RFS: syncterm/1.0+dfsg-1 [ITP] -- BBS terminal program from Synchronet

Date: Wed, 25 Jan 2017 04:29:09 +0000

Package syncterm has been removed from mentors.

Message #131 received at 777651@bugs.debian.org (full text, mbox, reply):

From: comilfo\ \(тариф\ 2300р\;\ начало\ хостинга\ 23.04\) <comilfo2@fortunastudio.ru>

To: 777651@bugs.debian.org

Subject: Please recheck your delivery address (UPS parcel 005363799)

Date: Mon, 20 Feb 2017 06:52:49 +0300

[Message part 1 (text/plain, inline)]

Dear Customer,

Your parcel was successfully delivered February 19 to UPS Station, but our courier cound not contact you.

You can download the shipment label attached!

With thanks and appreciation,
Walter Olsen,
UPS Parcels Delivery Manager.

[UPS-Delivery-Details-005363799.zip (application/zip, attachment)]

Send a report that this bug log contains spam.