Debian Bug report logs - #776134
rng-tools: Patch to fix the broken FIPS 140-2 runs test

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ron <ron@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: rng-tools: Patch to fix the broken FIPS 140-2 runs test

Date: Sat, 24 Jan 2015 20:46:02 +1030

[Message part 1 (text/plain, inline)]

Package: rng-tools
Version: 2-unofficial-mt.14-1
Severity: normal
Tags: patch

Hi,

So I recently wrote some code to do the FIPS 140 tests, and though test
suites are good and all that, for something like this I also wanted to
run it against an independent implementation as a cross correlation on
sanity, and found the code in rng-tools which looked like it would be a
good candidate for that ...

Except they disagreed on a small, but large enough to be disturbing,
number of blocks for the Runs and Poker tests.  At first glance we did
appear to be using the same thresholds, so clearly Something Was Wrong.

Happily (for me :), it turns out that my code was correct.
Also happily (for you, I hope ;), I've attached a patch that fixes two
bugs in the Runs test in rng-tools (which broke both tests).

You can pull it from here:
http://anonscm.debian.org/cgit/users/ron/rng-tools.git/commit/?id=27c260ae79e3b02f81062328497648b1e5f46613

And if reportbug --attach actually worked, the git-format-patch export
should be included in this mail.  There's a full description of the
bugs in the commit message of it.

This might be a good one to also push upstream, if they haven't found
and fixed it already.  I've only looked at the code in your fork so far.

  Cheers,
  Ron

[0001-Fix-the-broken-FIPS-140-2-runs-test.patch (text/x-diff, attachment)]

Message #14 received at 776134-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 776134-close@bugs.debian.org

Subject: Bug#776134: fixed in rng-tools-debian 2.2

Date: Wed, 11 Nov 2020 02:41:48 +0000

Source: rng-tools-debian
Source-Version: 2.2
Done: Thorsten Glaser <tg@mirbsd.de>

We believe that the bug you reported is fixed in the latest version of
rng-tools-debian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 776134@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thorsten Glaser <tg@mirbsd.de> (supplier of updated rng-tools-debian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA384

Format: 1.8
Date: Wed, 11 Nov 2020 02:10:22 +0100
Source: rng-tools-debian
Architecture: source
Version: 2.2
Distribution: unstable
Urgency: medium
Maintainer: Thorsten Glaser <tg@mirbsd.de>
Changed-By: Thorsten Glaser <tg@mirbsd.de>
Closes: 444326 542599 776134 825872
Changes:
 rng-tools-debian (2.2) unstable; urgency=medium
 .
   [ Ron ]
   * Fix the broken FIPS 140-2 runs test (Closes: #776134)
 .
   [ Nicholas D Steeves ]
   * Mention tpm-rng in the README (Closes: #825872) (Closes: #542599)
 .
   [ Thorsten Glaser ]
   * Fix installation of NEWS{.Debian,}
   * rngtest: better linewrap of startup blurb
   * init script: improve logic determining device to use:
     - when autodetecting, test-read from the device before considering
       it; note in syslog if that fails (manually set HRNGDEVICE will
       be used as-is if the character device exists)
     - syslog if no device was found but don’t exit with errorlevel ≠ 0
       any more
     - when (re‑)starting the service during package installation or
       upgrade, output informative message if no usable device was found
   * Run HRNGSELECT before checking the devices
   * Update documentation and package descriptions
   * Add option controlling periodical statistics syslog (Closes: #444326)
   * Modernise packaging (dh 13, Policy 4.5.0, LDFLAGS, lintian, etc.)
   * Prepare rng-tools takeover
   * Ask users in multiple places that any modules should be loaded early
Checksums-Sha1:
 e85bba84fabd3a7cc8804d9c0ca5a5d0b26b5ac0 1738 rng-tools-debian_2.2.dsc
 9104a36505953abae725ab66dd57e0888b580121 52600 rng-tools-debian_2.2.tar.xz
Checksums-Sha256:
 7e1b6b1bff2d8679cc797dc5a3a4a8e5f4748b1660e4b54bcf0b1aab4bcd3b31 1738 rng-tools-debian_2.2.dsc
 d9480006ad1babbeb5adc10140189151c9e056bddcdc8f4fe2064329f01dc02b 52600 rng-tools-debian_2.2.tar.xz
Files:
 0a028b02bdb66ca3d7a5bc528db689ce 1738 utils optional rng-tools-debian_2.2.dsc
 3cf2a0957bbc146b0afca13cdf15bd3f 52600 utils optional rng-tools-debian_2.2.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (MirBSD)
Comment: ☃ ЦΤℱ—８　☕☂☄

iQIcBAEBCQAGBQJfq0THAAoJEHa1NLLpkAfgUX8QAITP+7JgR16lqTDeybYatwL6
fkHhzz5oG2TOl/5QqhhV+gA/FxYqB1Q1MAh8IeRU4+DNVUqj64jDr1l2ZoaLbCnM
VWhoJutUzD/+IMDEUy7Su8Gq7XowuTkOR4BZyUUqDbdaEWlXSxMYnyEvErClL4rb
UnOT5YsOS6mEbP8p3glZmTjOz+AwIcll8HwKQWtLlxnL1RODIyaJOg3O4wz+04jz
HEUwFHcErEu9n6OgYBZylDf4oiFhVvIpsXb49MZ9aakWL03ypYgvA+bRgp/ZxmHf
Dtt2YZpqkFTdITU2rR1/RLEAmodEihDjfQpsmsf+ca06wZcpTW2hijNxTvax98lI
A8JHz6Du90SwSZcHcX1EFLj0yCwy2IvBnMbY26KjOQ1oAMXBfjvOwdWRXtEHctPn
N5Bdn7Kp58U2h2xDDj6OTQ9pUrrnGDspWL5HlNtT//l1kxPCQbzcHDLchDJcgQhx
hmrmpykhCNYYsNa4t4qwV1NwI7LpYMk7/M2CbaloHnGJWLoJ7a//i7mYs8EsHQX+
wS4m8a3Auk0NdzNpzSTUzqhTd+m80ClVYuWvlLCAPWv5nPmkSz2nM0c/Qvkw8O+k
K3Lb7M/C+Q4TywT9C5OcFsR5gMg+e07pWsOPdiq+yBO1uiOtm3RdKo1xnS8k6QAc
f/zVrJ9pJjmVWg3oY4oJ
=5/Gd
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.