Debian Bug report logs - #775414
redis-server: redis-sentinel has no init or other startup script

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Dent <chris.dent@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: redis-server: redis-sentinel has no init or other startup script

Date: Thu, 15 Jan 2015 12:18:20 +0000

Package: redis-server
Version: 2:2.8.4-2
Severity: normal

Dear Maintainer,

While experimenting with adding sentinel support to puppet-redis it
became clear that there was no separate startup script for redis-sentinel[1].
Having such a thing is handy when running sentinel as a separate process
(a likely scenario).

It seems like the easiest thing to do would be to duplicate and slightly
modify the existing init script for redis-server, but pointing to the
redis-sentinel binary and to a redis-sentinel.conf.

Note that though I am doing my testing on Ubuntu and with a slightly older
redis package, I have inspected the latest unstable package[2] and see that
the tarball linked there doesn't address this issue.

Thanks!

[1] https://github.com/arioch/puppet-redis/issues/18
[2] https://packages.debian.org/source/unstable/redis

-- System Information:
Debian Release: jessie/sid
  APT prefers trusty-updates
  APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 'trusty')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13.0-44-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages redis-server depends on:
ii  adduser       3.113+nmu3ubuntu3
ii  libc6         2.19-0ubuntu6.5
ii  libjemalloc1  3.5.1-2
ii  redis-tools   2:2.8.4-2

redis-server recommends no packages.

redis-server suggests no packages.

-- no debconf information

Message #10 received at 775414@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Chris Dent <chris.dent@gmail.com>

Cc: 775414@bugs.debian.org

Subject: Re: Bug#775414: redis-server: redis-sentinel has no init or other startup script

Date: Thu, 15 Jan 2015 20:46:33 +0000

Hi Chris,

> It seems like the easiest thing to do would be to duplicate and slightly
> modify the existing init script for redis-server, but pointing to the
> redis-sentinel binary and to a redis-sentinel.conf.

Sure, although "duplicate" would actually imply making a
separate/additional redis-sentinel binary package.

Would that work for you?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 775414@bugs.debian.org (full text, mbox, reply):

From: chris.dent@gmail.com

To: Chris Lamb <lamby@debian.org>

Cc: 775414@bugs.debian.org

Subject: Re: Bug#775414: redis-server: redis-sentinel has no init or other startup script

Date: Thu, 15 Jan 2015 21:14:05 +0000 (GMT)

On Thu, 15 Jan 2015, Chris Lamb wrote:

>> It seems like the easiest thing to do would be to duplicate and slightly
>> modify the existing init script for redis-server, but pointing to the
>> redis-sentinel binary and to a redis-sentinel.conf.
>
> Sure, although "duplicate" would actually imply making a
> separate/additional redis-sentinel binary package.
>
> Would that work for you?

I'm agnostic on how things are resolved. The important part for me is
that redis-server and redis-sentinel have different init scripts that
start the different binaries and configurations.

Is it not possible to have two init scripts in one package? Since
there are already separate redis and redis-sentinel binaries in the
same package it seems to make sense there be a corresponding two
initscripts?

For reference, the fedora rpm for redis packages up separate systemd
unit files for redis and redis-sentinel.

I'm happy to help however I can, just let me know.

-- 
Chris Dent                                   http://burningchrome.com/
                                [...]

Message #20 received at 775414@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: chris.dent@gmail.com

Cc: 775414@bugs.debian.org

Subject: Re: Bug#775414: redis-server: redis-sentinel has no init or other startup script

Date: Thu, 15 Jan 2015 21:18:00 +0000

> Is it not possible to have two init scripts in one package?

Possibly, but because daemons start by default in Debian, someone
installing "redis" (in an informal sense) will suddenly be running
redis-sentinel..which would be unexpected at the very least. Some might
call it antisocial!

The redis-sentinel binary would move to this other package.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #25 received at 775414@bugs.debian.org (full text, mbox, reply):

From: chris.dent@gmail.com

To: Chris Lamb <lamby@debian.org>

Cc: 775414@bugs.debian.org

Subject: Re: Bug#775414: redis-server: redis-sentinel has no init or other startup script

Date: Thu, 15 Jan 2015 21:35:30 +0000 (GMT)

On Thu, 15 Jan 2015, Chris Lamb wrote:

>> Is it not possible to have two init scripts in one package?
>
> Possibly, but because daemons start by default in Debian, someone
> installing "redis" (in an informal sense) will suddenly be running
> redis-sentinel..which would be unexpected at the very least. Some might
> call it antisocial!

Ah, I did not realize that. Yes, "antisocial" is a good way to put it.

Like I said, I'm agnostic about how it is resolved. But for the sake
of providing a bit more context:

The reason I was after another initscript was so that puppet can
effectively manage redis-sentinel as a service of some kind (meaning
it can locate a initscript, upstart file, or systemd file). This is in
an existing redis puppet module. It fails to work properly for
redis-sentinel due to the lack of a way to manage the service. Adding
an initscript within puppet will resolve the problem. Having an
additional package would also resolve the problem, but in a different
way (it would need to be cognizant of the two packages and packaging
differences between rpm and deb-based systems).

For the time being I'll go ahead and create the required init script
and will watch this bug to see how things go.

-- 
Chris Dent                                   http://burningchrome.com/
                                [...]

Message #30 received at 775414@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: chris.dent@gmail.com

Cc: 775414@bugs.debian.org

Subject: Re: Bug#775414: redis-server: redis-sentinel has no init or other startup script

Date: Fri, 16 Jan 2015 18:32:07 +0000

> For the time being I'll go ahead and create the required init script
> and will watch this bug to see how things go.

Fixed in Git, pending upload.

(Making another package was much nicer, as it means sentinel can have
separate logs, systemd entry, logrotate entries, etc.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #35 received at 775414-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 775414-close@bugs.debian.org

Subject: Bug#775414: fixed in redis 2:3.0.0~rc2-1

Date: Sat, 28 Feb 2015 16:00:20 +0000

Source: redis
Source-Version: 2:3.0.0~rc2-1

We believe that the bug you reported is fixed in the latest version of
redis, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 775414@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated redis package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 16 Jan 2015 10:55:28 +0000
Source: redis
Binary: redis-server redis-tools redis-sentinel
Architecture: source amd64
Version: 2:3.0.0~rc2-1
Distribution: experimental
Urgency: low
Maintainer: Chris Lamb <lamby@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 redis-sentinel - Persistent key-value database with network interface (monitoring)
 redis-server - Persistent key-value database with network interface
 redis-tools - Persistent key-value database with network interface (client)
Closes: 775414
Changes:
 redis (2:3.0.0~rc2-1) experimental; urgency=low
 .
   * New upstream RC release.
     - Sync debian/redis.conf.
   * Renable testsuite.
   * Add --oknodo to initscript "start" action to ensure correct return code if
     is already running.
   * Split redis-sentinel into its own package (Closes: #775414)
     - Move /usr/bin/redis-sentinel symlink to new package.
     - Fork ./sentinel.conf -> debian/sentinel.conf for own changes.
     - Add logrotate stanza.
     - Override permissions of /etc/redis/sentinel.conf with dpkg-statoverride -
       needs to be writable by Sentinel itself.
Checksums-Sha1:
 240b8456061f769cf9c88209129e0264c19da98f 1956 redis_3.0.0~rc2-1.dsc
 9ef2193b44ec46be1ce78e5361c0f9426d395895 1356667 redis_3.0.0~rc2.orig.tar.gz
 95b3bd56f4704b7d6e44864651171c1e0990983f 27532 redis_3.0.0~rc2-1.debian.tar.xz
 9126df76b49594c7f2933d08c3590e0b0c47dc49 344108 redis-server_3.0.0~rc2-1_amd64.deb
 f1d78dd87ebfd6f188063cd0b15954dbe004c780 80070 redis-tools_3.0.0~rc2-1_amd64.deb
 a252bdbde87d73d354c8a1703bd5a437d0fb5a46 13136 redis-sentinel_3.0.0~rc2-1_amd64.deb
Checksums-Sha256:
 9e72cdfd80fba22d2ee2470e82b63f8af377a2057effdf174f4c7401f62267e4 1956 redis_3.0.0~rc2-1.dsc
 3713194850e1b75fa01f17249a69e67636c1ad3f148fd15950d08d7a87bcf463 1356667 redis_3.0.0~rc2.orig.tar.gz
 78b0b312a4068d7bc7a6ef3938668eea8c018cf3adc502b6b905eb018c60035f 27532 redis_3.0.0~rc2-1.debian.tar.xz
 814078b4d08f96cf86152ca74ecd34b70756c35ee3eb3db250089a483b24026f 344108 redis-server_3.0.0~rc2-1_amd64.deb
 e93512234633871d4cec12bbebaf4d3ff1ce0d483c71f53ae43ec78e52962411 80070 redis-tools_3.0.0~rc2-1_amd64.deb
 ffd9b0999e32553e0c50dde5584aaa9ec3b3a35f83249f42d8a089269d978620 13136 redis-sentinel_3.0.0~rc2-1_amd64.deb
Files:
 65769c4b17784174563ed1ca14d189fd 344108 database optional redis-server_3.0.0~rc2-1_amd64.deb
 7c65e571cd0660b765f2e087d4272544 80070 database optional redis-tools_3.0.0~rc2-1_amd64.deb
 74b692972d458b01fac16b87426a5b47 13136 database optional redis-sentinel_3.0.0~rc2-1_amd64.deb
 820f7c284a5ef49fe257930c3a811292 1956 database optional redis_3.0.0~rc2-1.dsc
 0bc4d576eec06311ee2318fe2bea4592 1356667 database optional redis_3.0.0~rc2.orig.tar.gz
 e59f8471dd3c7dd2bbf6604d2c6006aa 27532 database optional redis_3.0.0~rc2-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBVLkUa6FIn+KrmaIaAQIEgw//YkADSVXGNAjyOBYrb8bpPGRkf7GSV8OC
5gUER7VDF8mnIGLUZ+hQtNjdpj0t82qHTSyWbGsDV5ZZiY73T1JVrZixXbCbiZP/
l5FLWwunKWRTPLC8BPv6o4dbb9GlY5MskEVTh9QaeolAHkol+Sp5NjFIJo8ANtHf
nwYMGuejEnq05zirDw7KLlydqaYPttnz3M/pzO5EnYAhlTp1ahQ1T4NgmiY/sjvd
v9C0/qFrqjvGHyDLsxGXsbaHdPNiaZ63/v88VEl/IKa/V2tf6aOMlOAEiMxEXYvP
zEclJTSjX7vnBNLAz7DhB25Gnr6sJr20petdfOl23zPQqnc0o1nrjDDjbtzFPjWc
qM++osjKzH5ezJA7Bs6OTvJHzfk9xYmnYgLSdS07AgIwnnysP8jh4N9rH5dG+JC5
+HTmM+BSW5yFQry/HgQUfjOm81oJcq6cTHMQBELYxV+dRe2OvxzG352HIhWkzcev
VZzJQsOO2lIzfBS9VXkMEBPEIJLezQnLP81ranZTohZLy+ZijAegUPpOo+yIa0gP
/x28LYQodzFkWAgeXAr/fJ1vcuvrLRr4Ti6E14nZrnOvw155zZ7fPu+/lx7dM0+C
ndUeutuLHA7/H70paNFJnfMf6e09ECOAEUd0qW2hLu2rhDtmVe7j+AuoT7037bM8
gb+UbVcXTPU=
=/QGm
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.