Debian Bug report logs - #773539
ifupdown: Please return exit status 1 when up command fails (unconfigured interface affects network-manager)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: David Mohr <bugs@da.mcbf.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ifupdown: Please return exit status 1 when up command fails (unconfigured interface affects network-manager)

Date: Fri, 19 Dec 2014 09:34:34 -0700

Package: ifupdown
Version: 0.7.50
Severity: normal

Dear Maintainer,

please consider returning exit status 1 when the up command of an
interface fails. Since the interface is not marked as configured,
network-manager will think there is no connectivity and programs
interacting with NM won't work (for example pidgin).

My situation was that I wanted to turn on jumbo frames for my network
bridge, and I mistakenly added the up commands in the wrong order:
    up ifconfig br0 mtu 9000
    up ifconfig eth0 mtu 9000

Now on the next reboot network-manager thought I was offline. The reason
for that was a little difficult to debug because systemd thought
everything was just fine: no error was reported from
/etc/init.d/networking. Since my computer boots up too fast to watch the
initialization messages, I didn't notice the error there either. And I
did not suspect ifup as the culprit because I did have a working network
access.

Yes, the man page mentions that this is expected behavior. But given
that it is difficult to debug, and there is real breakage when
network-manager is used, I think that it would be preferable to actually
return an error.

Thanks,
~David

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages ifupdown depends on:
ii  adduser      3.113+nmu3
ii  initscripts  2.88dsf-58
ii  iproute      1:3.16.0-2
ii  iproute2     3.16.0-2
ii  libc6        2.19-13
ii  lsb-base     4.1+Debian13+nmu1

Versions of packages ifupdown recommends:
ii  isc-dhcp-client [dhcp-client]  4.3.1-5

Versions of packages ifupdown suggests:
ii  net-tools  1.60-26+b1
ii  ppp        2.4.6-3
pn  rdnssd     <none>

-- no debconf information

Message #10 received at 773539@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: David Mohr <bugs@da.mcbf.net>, 773539@bugs.debian.org

Subject: Re: Bug#773539: ifupdown: Please return exit status 1 when up command fails (unconfigured interface affects network-manager)

Date: Wed, 14 Jan 2015 09:14:31 +0100

Hello ifupdown maintainers,

David Mohr [2014-12-19  9:34 -0700]:
> please consider returning exit status 1 when the up command of an
> interface fails.

Seconded. This is rather awkward for propagating success/failure
upwards the stack. E. g. systemd's ifup@<iface>.service always
succeeds even if the specified interface does not exist (yet). Thus we
can't sensibly implement an "all auto interfaces are up" target
either.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Message #15 received at 773539-close@bugs.debian.org (full text, mbox, reply):

From: Guus Sliepen <guus@debian.org>

To: 773539-close@bugs.debian.org

Subject: Bug#773539: fixed in ifupdown 0.8

Date: Tue, 01 Dec 2015 22:19:53 +0000

Source: ifupdown
Source-Version: 0.8

We believe that the bug you reported is fixed in the latest version of
ifupdown, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 773539@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guus Sliepen <guus@debian.org> (supplier of updated ifupdown package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 01 Dec 2015 23:09:54 +0100
Source: ifupdown
Binary: ifupdown
Architecture: source amd64
Version: 0.8
Distribution: unstable
Urgency: medium
Maintainer: Guus Sliepen <guus@debian.org>
Changed-By: Guus Sliepen <guus@debian.org>
Description:
 ifupdown   - high level tools to configure network interfaces
Closes: 231197 246771 762388 773539 791444 792896 799257 804978 806673
Changes:
 ifupdown (0.8) unstable; urgency=medium
 .
   [ Guus Sliepen ]
   * Add per-interface state files with locking.
     - Also detects and aborts on recursion. Closes: #231197
   * Break up main() in smaller functions.
   * Return a non-zero exit code when (de)configuring an interface fails.
     Closes: 773539
   * Add blank lines around examples in interfaces(5). Closes: #791444
   * Enable RFC 4361 DDNS support when using dhclient, as suggested by
     Nicolas Cuissard. Closes: #799257
   * Lock parent interface when configuration VLAN interfaces.
   * Apply fixes for issues found by AddressSanitizer and Clang Static
     Analyzer.
   * Drop the versioned dependency on initscripts. Closes: #804978
   * Check for errors when running mapping scripts. Closes: #246771
   * Wait for an IPv6 link-local address before starting a DHCPv6 client.
     Closes: 806673
   * Add a systemd service file.
 .
   [ Andrew Shadura ]
   * Implement interface inheritance using the "inherits" keyword.
 .
   [ Jérémy Bobbio ]
   * Output methods in stable order when generating C code to make
     builds reproducible. Closes: #762388
 .
   [ Javier Barroso ]
   * Fix detection of curlftpfs mounts. Closes: #792896
Checksums-Sha1:
 5c2007559a0154927ebf3e07bd508e33374c880a 1516 ifupdown_0.8.dsc
 d97fbccfc71ac4f6e9c0bb608cfd966c3bc7450e 68032 ifupdown_0.8.tar.xz
 ed85f73df09e81561e2141f899ab9bb3dac37033 68950 ifupdown_0.8_amd64.deb
Checksums-Sha256:
 809c992402fa5011bab06484e4ad04db48c5bab6b28407b358d9b7be89bc9ccd 1516 ifupdown_0.8.dsc
 e11d8adfc5eadb564722b997b73dd4dcebc1ca13d30955a351ecbe8d3477497a 68032 ifupdown_0.8.tar.xz
 8d6766f00c5638b48352940c212d80c23537de412991696e62ee6e076fb50d4d 68950 ifupdown_0.8_amd64.deb
Files:
 075d0f793175dfdd838fda4e528a3a1d 1516 admin important ifupdown_0.8.dsc
 bb17d8c37ef857e3423d25adea7a320f 68032 admin important ifupdown_0.8.tar.xz
 8370af3b3831e2a01af5e976ecfb8a27 68950 admin important ifupdown_0.8_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWXhsMAAoJED9JDeuHHvn6ZBoP/iE7RxNhg0l6ix6J6Sz2NUPJ
xorXt2hnlr/UPrXTyw3MSDX31mfz8PC0XcCKd0JVPH22e6OvoCS2qO3+PvawWOua
vQGnNEu1HtWLtZ7XKQ3J8Rc7sgOqJEbioXk4wG0EFCf8kISxazN8W2sgLB/MFYEp
l+QVcrjiRloFWLCKVW9YVNLARXAcPFRDf1Kqvlh21PdJ52n8FA5aA0CXwAJVRtAu
zFEQl3EVpxZq0GrIR6t96qc2QGmKiQy1wu244jsEhbdqsINrY6o+x9568WQgJd4V
fWMeogYxY+HJpdTZZ1RKq5YUwVuZfPmDQVSwzEK1W8M5j7r/iH6PEjtjirsstRB3
mJhI7BN8E8qnmjK1a+XVDwDzru8/Q62hhcULZLMjX+c2XLJ9eI1zvY2dix77e2yj
4hMAqw2gkG9HihryDQjTM/QP6RUW04zqb4QCEHDR8pBbFapZBnYeUoGkEj8rLZN9
nLrVRgdpRuJTCzpc9nxlPy4wjg9GCW5efGLrDWJyJkvgetg8fLKDqz+cYdFDwia+
ZH3lbGZYoXjX7Ri3CcmVZRenYs7NuV0BrOAOIZpAa9ur4Kg4hhEZTNACJ7YLAQQo
djxOCEja+nZYDfzotSHlwKlS2i8I8rmWt/WQS+7gSpwms0IgAcHKYEPGER7RqwGG
lcwjSk+FUuiYUutyffOz
=Lgx1
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.