Debian Bug report logs - #772422
Fails to receive /?° host key on ABNT2 (brazilian keyboard layout)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "R. Lemos" <rslemos@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Fails to receive /?° host key on ABNT2 (brazilian keyboard layout)

Date: Sat, 6 Dec 2014 16:04:01 -0200

Package: qemu
Version: 2.1+dfsg-7+b1
Severity: important

Dear Maintainer,

when host X Window System is configured for ABNT2 keyboard layout (gnome
says just "Portuguese (Brazil)", but Xorg.0.log outputs: rules: evdev,
model: pc105, layout: br, variant: abnt2) qemu simply does not recognize
a single key, right of AltGr (which happens to be the right Alt), that
displays three symbols: / (slash), ? (question mark) and ° (degree).

Since this key is the only one with a slash, it is virtually impossible
to use linux console inside qemu running on these hosts.

This situation doesn't change even if qemu is invoked with "-k pt-br".



Additional info regarding the key itself: under a properly configured
console (the key behaves correcly on a console outside X), I've been
presented with the following output:
- showkey -s: 0x73 (down) and 0xf3 (up)
- showkey -k: 89 (upon press or release)
- showkey -a (unmodified): /  47 0057 0x2f
- showkey -a (shift):      ?  63 0077 0x3f
- showkey -a (AltGr):      ° 194 0302 0xc2
                             176 0260 0xb0
(yes, AltGr+/?° outputs two lines repeatedly for as long as both keys
are pressed)

Under X Window System, xev reports:

- (unmodified) single keypress:

KeyPress event, serial 34, synthetic NO, window 0x1c00001,
    root 0x83, subw 0x0, time 69270523, (992,297), root:(1032,402),
    state 0x0, keycode 97 (keysym 0x2f, slash), same_screen YES,
    XLookupString gives 1 bytes: (2f) "/"
    XmbLookupString gives 1 bytes: (2f) "/"
    XFilterEvent returns: False

KeyRelease event, serial 37, synthetic NO, window 0x1c00001,
    root 0x83, subw 0x0, time 69270582, (992,297), root:(1032,402),
    state 0x0, keycode 97 (keysym 0x2f, slash), same_screen YES,
    XLookupString gives 1 bytes: (2f) "/"
    XFilterEvent returns: False


- (holding left shift) single keypress:

KeyPress event, serial 37, synthetic NO, window 0x1c00001,
    root 0x83, subw 0x0, time 69384268, (380,360), root:(420,465),
    state 0x1, keycode 97 (keysym 0x3f, question), same_screen YES,
    XLookupString gives 1 bytes: (3f) "?"
    XmbLookupString gives 1 bytes: (3f) "?"
    XFilterEvent returns: False

KeyRelease event, serial 37, synthetic NO, window 0x1c00001,
    root 0x83, subw 0x0, time 69384398, (380,360), root:(420,465),
    state 0x1, keycode 97 (keysym 0x3f, question), same_screen YES,
    XLookupString gives 1 bytes: (3f) "?"
    XFilterEvent returns: False


- (holding AltGr) single keypress:

KeyPress event, serial 37, synthetic NO, window 0x1c00001,
    root 0x83, subw 0x0, time 69447229, (377,78), root:(417,183),
    state 0x80, keycode 97 (keysym 0xb0, degree), same_screen YES,
    XLookupString gives 2 bytes: (c2 b0) "°"
    XmbLookupString gives 2 bytes: (c2 b0) "°"
    XFilterEvent returns: False

KeyRelease event, serial 37, synthetic NO, window 0x1c00001,
    root 0x83, subw 0x0, time 69447326, (377,78), root:(417,183),
    state 0x80, keycode 97 (keysym 0xb0, degree), same_screen YES,
    XLookupString gives 2 bytes: (c2 b0) "°"
    XFilterEvent returns: False


-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (900, 'testing'), (850, 'stable'), (800, 'unstable'),
(1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
armhf

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages qemu depends on:
ii  qemu-system  2.1+dfsg-7+b1
ii  qemu-user    2.1+dfsg-7+b1
ii  qemu-utils   2.1+dfsg-7+b1

qemu recommends no packages.

Versions of packages qemu suggests:
pn  qemu-user-static  <none>

-- no debconf information

Message #10 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "R. Lemos" <rslemos@gmail.com>

To: 772422@bugs.debian.org

Subject: Workaround patch for 1.6.0

Date: Sat, 6 Dec 2014 16:11:11 -0200

This patch used to work on qemu debian source package version
1.6.0+dsfg (no need to "-k pt-br").

Reading the 2.1+dsfg sources, I think it will cleanly apply.

I don't know if this patch destroys some other keyboard layout. Also,
I don't know how to confine the change to "-k pt-br" (so it would be
ok to mess with other otherwise working layouts, since "-k pt-br" is
actually for ***this*** layout).


Description: working ABNT2 keyboard
 Correctly handles the slash/question-mark key present in these brazilian
 keyboards.

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Author: Rodrigo Lemos <rslemos@gmail.com>
Bug: https://bugs.launchpad.net/qemu/+bug/1038136
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>

--- qemu-1.6.0+dfsg.orig/ui/x_keymap.c
+++ qemu-1.6.0+dfsg/ui/x_keymap.c
@@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_key
  */

 static const uint8_t evdev_keycode_to_pc_keycode[61] = {
-    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
+    0x73,      /*  97 EVDEV - /?°  (ABNT2 Keyboards) */
     0,         /*  98 EVDEV - KATA (Katakana) */
     0,         /*  99 EVDEV - HIRA (Hiragana) */
     0x79,      /* 100 EVDEV - HENK (Henkan) */

Message #15 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Michael Tokarev <mjt@tls.msk.ru>

To: "R. Lemos" <rslemos@gmail.com>, 772422@bugs.debian.org

Subject: Re: Bug#772422: Fails to receive /?° host key on ABNT2 (brazilian keyboard layout)

Date: Sat, 06 Dec 2014 21:41:41 +0300

Control: tag -1 + upstream confirmed
Control: forwarded -1 https://bugs.launchpad.net/qemu/+bug/1038136
Control: severity -1 normal
Control: found -1 1.1.2+dfsg-1

06.12.2014 21:04, R. Lemos wrote:
> Package: qemu
> Version: 2.1+dfsg-7+b1
> Severity: important
> 
> Dear Maintainer,
> 
> when host X Window System is configured for ABNT2 keyboard layout (gnome
> says just "Portuguese (Brazil)", but Xorg.0.log outputs: rules: evdev,
> model: pc105, layout: br, variant: abnt2) qemu simply does not recognize
> a single key, right of AltGr (which happens to be the right Alt), that
> displays three symbols: / (slash), ? (question mark) and ° (degree).
> 
> Since this key is the only one with a slash, it is virtually impossible
> to use linux console inside qemu running on these hosts.

What way do you use to iteract with qemu guest console?  Is it some
sort of vnc client, or sdl directly on X window, or something else?

As long as I understand, "proper" VNC client should not have any probs
with keyboard at all, sending just the keycodes to the VNC server
without any need to translate them or to use any keymaps etc.

There was a good writeup about this, but I can't find it right now,
will try to add an url when/if I'll find it.

Now, I've no idea really how keyboard mapping works in qemu, so
the info you provided is of no use to me.  Instead, that info might
be better added to the original launchpad bugreport -- I wont be
able to do anything besides whatever upstream will do.

Speaking of the patch you mentioned in the other email, ofcourse it
is not acceptable since it will break keyboard for everyone else.

Thanks, and please excuse me for being unconstructive.

Adding tags and setting appropriate level of priority.

Thanks,

/mjt

Message #28 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "R. Lemos" <rslemos@gmail.com>

To: Michael Tokarev <mjt@tls.msk.ru>

Cc: 772422@bugs.debian.org

Subject: Re: Bug#772422: Fails to receive /?° host key on ABNT2 (brazilian keyboard layout)

Date: Sat, 6 Dec 2014 16:51:11 -0200

> Thanks, and please excuse me for being unconstructive.
("unconstructive" to say the least)

> What way do you use to iteract with qemu guest console?  Is it some
> sort of vnc client, or sdl directly on X window, or something else?
I think qemu spawns an xterm for each virtual console created on the
guest. I don't know. It's qemu default for virtual consoles.

> As long as I understand, "proper" VNC client should not have any probs
> with keyboard at all, sending just the keycodes to the VNC server
> without any need to translate them or to use any keymaps etc.
No VNC involved. My guests do only have consoles, no graphic environment.

> Speaking of the patch you mentioned in the other email, ofcourse it
> is not acceptable since it will break keyboard for everyone else.
I hope someone can help and tidy it up so it is applicable (i.e. only
changes "-k pt-br" behavior).

Message #33 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Michael Tokarev <mjt@tls.msk.ru>

To: "R. Lemos" <rslemos@gmail.com>, 772422@bugs.debian.org

Subject: Re: Bug#772422: Fails to receive /?° host key on ABNT2 (brazilian keyboard layout)

Date: Sat, 06 Dec 2014 22:24:48 +0300

06.12.2014 21:51, R. Lemos wrote:
>> Thanks, and please excuse me for being unconstructive.
> ("unconstructive" to say the least)

Well, as I said, it is not my area. Another possibility was to just
ignore this bugreport, but I at least tried to outline my position
as the package maintainer.  I can just shut up if you dislike this.

>> What way do you use to iteract with qemu guest console?  Is it some
>> sort of vnc client, or sdl directly on X window, or something else?
> I think qemu spawns an xterm for each virtual console created on the
> guest. I don't know. It's qemu default for virtual consoles.

Okay.  Provided you're running qemu directly from command line and
not using libvirt or virsh, it is SDL console (if it's libvirt, it
uses VNC behind the scenes).

[]
>> Speaking of the patch you mentioned in the other email, ofcourse it
>> is not acceptable since it will break keyboard for everyone else.
> I hope someone can help and tidy it up so it is applicable (i.e. only
> changes "-k pt-br" behavior).

It a hack, not a solution.  Proper solution is to add the necessary
keycodes instead of modifying existing ones.

BTW, here's the article I mentioned before, which describes the fun
of keyboard handling in virtual environment --
https://www.berrange.com/posts/2010/07/04/more-than-you-or-i-ever-wanted-to-know-about-virtual-keyboard-handling/

Thanks,

/mjt

Message #44 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Michael Tokarev <mjt@tls.msk.ru>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Fri, 22 May 2015 16:10:31 +0300

22.05.2015 13:01, Gerd Hoffmann wrote:
> On Mi, 2015-05-20 at 14:44 +0300, Michael Tokarev wrote:
>> A (friendly) ping? :)
>>
>>> The solution appears to be trivial (see also some background
>>> at http://blog.nielshorn.net/2011/03/qemu-and-brazilian-keyboards/ ),
>>> but the problem is definitely still here.
>>>
>>> Maybe it's a time to address this finally? :)
>>>
>>> I don't pretend to understand any significant bit of input
>>> handling, so am asking people who are more knowlegeable in
>>> this area to take a look ;)
> 
> Anyone having such a keyboard and willing to run some tests?

Adding Cc's.  This has been reported to debian too,
http://bugs.debian.org/772422 (also in Cc).

Thanks,

/mjt

Message #49 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Michael Tokarev <mjt@tls.msk.ru>

Cc: qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Fri, 22 May 2015 15:20:09 +0200

  Hi,

> > Anyone having such a keyboard and willing to run some tests?
> 
> Adding Cc's.  This has been reported to debian too,
> http://bugs.debian.org/772422 (also in Cc).

Ok, so just replying should stick this into the debian bug tracker,
right?

Ok, instructions are here:

(a) Go grab https://www.kraxel.org/cgit/input/ please (could be there
    even is a debian package for this stuff).

(b) Use 'lsinput' to figure which input device is your keyboard (on
    the host machine).

(c) Then use 'input-events <device-number>' to get a input event log
    printed to the terminal.  Type each missing key once.

(d) Send me the log (with annotation which key is which).

thanks,
  Gerd

Message #54 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Michael Tokarev <mjt@tls.msk.ru>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Fri, 22 May 2015 16:39:24 +0300

22.05.2015 16:20, Gerd Hoffmann wrote
>   Hi,
> 
>>> Anyone having such a keyboard and willing to run some tests?
>>
>> Adding Cc's.  This has been reported to debian too,
>> http://bugs.debian.org/772422 (also in Cc).
> 
> Ok, so just replying should stick this into the debian bug tracker, right?

Exactly, yes.

> Ok, instructions are here:
> 
> (a) Go grab https://www.kraxel.org/cgit/input/ please (could be there
>     even is a debian package for this stuff).

The package on debian is named `input-utils'.

> (b) Use 'lsinput' to figure which input device is your keyboard (on
>     the host machine).
> 
> (c) Then use 'input-events <device-number>' to get a input event log
>     printed to the terminal.  Type each missing key once.
> 
> (d) Send me the log (with annotation which key is which).
> 
> thanks,
>   Gerd

Thank you very much for looking at this!

/mjt

Message #59 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>

To: "Michael Tokarev" <mjt@tls.msk.ru>

Cc: "Gerd Hoffmann" <kraxel@redhat.com>, "qemu-devel" <qemu-devel@nongnu.org>, 772422@bugs.debian.org, "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Fri, 22 May 2015 12:03:44 -0300

> 22.05.2015 13:01, Gerd Hoffmann wrote:

[...]

>>>> The solution appears to be trivial (see also some background
>>>> at http://blog.nielshorn.net/2011/03/qemu-and-brazilian-keyboards/ ),
>>>> but the problem is definitely still here.

This is the patch that works:

--- ui/x_keymap.c~
+++ ui/x_keymap.c
@@ -94,7 +94,7 @@
  */

 static const uint8_t evdev_keycode_to_pc_keycode[61] = {
-    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
+    0x73,      /*  97 EVDEV - /?° (ABNT2 Keyboards) */
     0,         /*  98 EVDEV - KATA (Katakana) */
     0,         /*  99 EVDEV - HIRA (Hiragana) */
     0x79,      /* 100 EVDEV - HENK (Henkan) */
@@ -126,7 +126,7 @@
     0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
     0,         /* 127 EVDEV - PAUS */
     0,         /* 128 EVDEV - ???? */
-    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
+    0x34,      /* 129 abnt2 KP-period */
     0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
     0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
     0x7d,      /* 132 AE13 (Yen)*/


[...]

>> Anyone having such a keyboard and willing to run some tests?

I have this keyboard and I can run tests.

Joao Luis.

Message #64 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>

To: "Gerd Hoffmann" <kraxel@redhat.com>

Cc: "Michael Tokarev" <mjt@tls.msk.ru>, "qemu-devel" <qemu-devel@nongnu.org>, 772422@bugs.debian.org, "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Fri, 22 May 2015 13:10:45 -0300

>> > Anyone having such a keyboard and willing to run some tests?

[...]

> (c) Then use 'input-events <device-number>' to get a input event log
>     printed to the terminal.  Type each missing key once.
>
> (d) Send me the log (with annotation which key is which).

There are two missing keys: / (which is also ? with shift) in the normal
keyboard and . in the numpad.

Here are the logs for two ABNT2 keyboards:

First keyboard:

/dev/input/event0
   bustype : BUS_USB
   vendor  : 0x45e
   product : 0x750
   version : 273
   name    : "Microsoft Wired Keyboard 600"
   phys    : "usb-0000:00:1d.1-1/input0"
   uniq    : ""
   bits ev : EV_SYN EV_KEY EV_MSC EV_LED EV_REP

waiting for events
12:44:00.341645: EV_MSC MSC_SCAN 458792 <== RETURN released when
input-events was run
12:44:00.341645: EV_KEY KEY_ENTER (0x1c) released
12:44:00.341645: EV_SYN code=0 value=0
12:44:02.389552: EV_MSC MSC_SCAN 458887 <== Here, / was pressed
12:44:02.389552: EV_KEY KEY_RO (0x59) pressed
12:44:02.389552: EV_SYN code=0 value=0
/12:44:02.517537: EV_MSC MSC_SCAN 458887 <== Here, / was released
12:44:02.517537: EV_KEY KEY_RO (0x59) released
12:44:02.517537: EV_SYN code=0 value=0
12:44:04.253486: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was pressed
12:44:04.253486: EV_KEY KEY_KPCOMMA (0x79) pressed
12:44:04.253486: EV_SYN code=0 value=0
.12:44:04.381484: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was
released
12:44:04.381484: EV_KEY KEY_KPCOMMA (0x79) released
12:44:04.381484: EV_SYN code=0 value=0

Second keyboard:

/dev/input/event15
   bustype : BUS_USB
   vendor  : 0x4f3
   product : 0x103
   version : 272
   name    : "HID 04f3:0103"
   phys    : "usb-0000:00:1d.3-2/input0"
   uniq    : ""
   bits ev : EV_SYN EV_KEY EV_MSC EV_LED EV_REP

waiting for events
13:00:00.686312: EV_MSC MSC_SCAN 458792 <== RETURN released when
input-events was run
13:00:00.686312: EV_KEY KEY_ENTER (0x1c) released
13:00:00.686312: EV_SYN code=0 value=0
13:00:03.182228: EV_MSC MSC_SCAN 458887 <== Here, / was pressed
13:00:03.182228: EV_KEY KEY_RO (0x59) pressed
13:00:03.182228: EV_SYN code=0 value=0
/13:00:03.254226: EV_MSC MSC_SCAN 458887 <== Here, / was released
13:00:03.254226: EV_KEY KEY_RO (0x59) released
13:00:03.254226: EV_SYN code=0 value=0
13:00:04.942163: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was pressed
13:00:04.942163: EV_KEY KEY_KPCOMMA (0x79) pressed
13:00:04.942163: EV_SYN code=0 value=0
.13:00:05.030163: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was
released
13:00:05.030163: EV_KEY KEY_KPCOMMA (0x79) released
13:00:05.030163: EV_SYN code=0 value=0

Both keys are fixed with the following patch that I sent previously:

--- ui/x_keymap.c~
+++ ui/x_keymap.c
@@ -94,7 +94,7 @@
  */

 static const uint8_t evdev_keycode_to_pc_keycode[61] = {
-    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
+    0x73,      /*  97 EVDEV - /?<C2><B0> (ABNT2 Keyboards) */
     0,         /*  98 EVDEV - KATA (Katakana) */
     0,         /*  99 EVDEV - HIRA (Hiragana) */
     0x79,      /* 100 EVDEV - HENK (Henkan) */
@@ -126,7 +126,7 @@
     0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
     0,         /* 127 EVDEV - PAUS */
     0,         /* 128 EVDEV - ???? */
-    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
+    0x34,      /* 129 abnt2 KP-period */
     0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
     0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
     0x7d,      /* 132 AE13 (Yen)*/



Thank you,
Joao Luis.

Message #69 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Tue, 26 May 2015 09:58:40 +0200

  Hi,

> 12:44:02.389552: EV_MSC MSC_SCAN 458887 <== Here, / was pressed
> 12:44:02.389552: EV_KEY KEY_RO (0x59) pressed

'RO'.  Hmm, not very descriptive.  Any idea what this could stand for?

> 12:44:04.253486: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was pressed
> 12:44:04.253486: EV_KEY KEY_KPCOMMA (0x79) pressed

Ok.  Is there a key with ',' too in your numpad?

cheers,
  Gerd

Message #74 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: qemu-devel@nongnu.org

Cc: gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, 772422@bugs.debian.org, Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

Subject: [PATCH 1/2] kbd: add brazil kbd keys to qemu

Date: Tue, 26 May 2015 15:58:04 +0200

The brazilian computer keyboard layout has two extra keys (compared to
the usual 105-key intl ps/2 keyboard).  This patch makes these two keys
known to qemu.

For historic reasons qemu has two ways to specify a key:  A QKeyCode
(name-based) or a number (ps/2 scancode based).  Therefore we have to
update multiple places to make new keys known to qemu:

  (1) The QKeyCode definition in qapi-schema.json
  (2) The QKeyCode <-> number mapping table in ui/input-keymap.c

This patch does just that.  With this patch applied you can send those
two keys to the guest using the send-key monitor command.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qapi-schema.json  | 4 +++-
 ui/input-keymap.c | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index f97ffa1..25df463 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -2784,6 +2784,7 @@
 # Since: 1.3.0
 #
 # 'unmapped' and 'pause' since 2.0
+# 'ro' and 'kp_comma' since 2.4
 ##
 { 'enum': 'QKeyCode',
   'data': [ 'unmapped',
@@ -2801,7 +2802,8 @@
             'kp_9', 'less', 'f11', 'f12', 'print', 'home', 'pgup', 'pgdn', 'end',
             'left', 'up', 'down', 'right', 'insert', 'delete', 'stop', 'again',
             'props', 'undo', 'front', 'copy', 'open', 'paste', 'find', 'cut',
-             'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause' ] }
+            'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause', 'ro',
+            'kp_comma' ] }
 
 ##
 # @KeyValue
diff --git a/ui/input-keymap.c b/ui/input-keymap.c
index 5d29935..2e09177 100644
--- a/ui/input-keymap.c
+++ b/ui/input-keymap.c
@@ -128,6 +128,10 @@ static const int qcode_to_number[] = {
 
     [Q_KEY_CODE_INSERT] = 0xd2,
     [Q_KEY_CODE_DELETE] = 0xd3,
+
+    [Q_KEY_CODE_RO] = 0x73,
+    [Q_KEY_CODE_KP_COMMA] = 0xf0,
+
     [Q_KEY_CODE_MAX] = 0,
 };
 
-- 
1.8.3.1

Message #79 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: qemu-devel@nongnu.org

Cc: gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, 772422@bugs.debian.org, Gerd Hoffmann <kraxel@redhat.com>

Subject: [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Tue, 26 May 2015 15:58:05 +0200

This patch adds the two extra brazilian keys to the evdev keymap for
X11.  This patch gets the two keys going with the gtk and sdl1 UIs.

With vnc (remote-viewer) only one of the two works correctly.
Probably a client-side issue.  Not investigated in detail though.

The SDL2 library complains it doesn't know these keys, so the SDL2
library must be fixed before we can update ui/sdl2-keymap.h

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/x_keymap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/x_keymap.c b/ui/x_keymap.c
index b9b0944..4e899b4 100644
--- a/ui/x_keymap.c
+++ b/ui/x_keymap.c
@@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
  */
 
 static const uint8_t evdev_keycode_to_pc_keycode[61] = {
-    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
+    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
     0,         /*  98 EVDEV - KATA (Katakana) */
     0,         /*  99 EVDEV - HIRA (Hiragana) */
     0x79,      /* 100 EVDEV - HENK (Henkan) */
@@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
     0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
     0,         /* 127 EVDEV - PAUS */
     0,         /* 128 EVDEV - ???? */
-    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
+    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
     0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
     0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
     0x7d,      /* 132 AE13 (Yen)*/
-- 
1.8.3.1

Message #84 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Tue, 26 May 2015 16:01:06 +0200

>  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> +    0x73,      /*  97 EVDEV - /?<C2><B0> (ABNT2 Keyboards) */

That one looks good.

> -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> +    0x34,      /* 129 abnt2 KP-period */

That is the *other* dot key, outside keypad.

Patches just sent via git-send-email, test results are welcome.

thanks,
  Gerd

Message #89 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "R. Lemos" <rslemos@gmail.com>

To: Gerd Hoffmann <kraxel@redhat.com>, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org

Subject: Re: ABNT2 keys again

Date: Tue, 26 May 2015 15:52:21 +0000

[Message part 1 (text/plain, inline)]

I've tested an unpatched QEMU 2.3.0 (x86_64) with "-k pt_br" option and the
"/?°" key works perfectly.

I have not tested the numpad ".", but I can inform that ABNT2 keyboard does
have "." (dot) and "," (comma) as separate keys: comma (numlock on)
combined with delete (numlock off).

But I found another key that is not working: the "<," ("less than"
"comma"). Right now I cannot give details about its scancode, nor make any
further test.


Em ter, 26 de mai de 2015 às 11:01, Gerd Hoffmann <kraxel@redhat.com>
escreveu:

> >  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > +    0x73,      /*  97 EVDEV - /?<C2><B0> (ABNT2 Keyboards) */
>
> That one looks good.
>
> > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > +    0x34,      /* 129 abnt2 KP-period */
>
> That is the *other* dot key, outside keypad.
>
> Patches just sent via git-send-email, test results are welcome.
>
> thanks,
>   Gerd
>
>
>

[Message part 2 (text/html, inline)]

Message #94 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>

To: "Gerd Hoffmann" <kraxel@redhat.com>

Cc: "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>, "Michael Tokarev" <mjt@tls.msk.ru>, "qemu-devel" <qemu-devel@nongnu.org>, 772422@bugs.debian.org, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Tue, 26 May 2015 17:51:23 -0300

Hello,

>> 12:44:02.389552: EV_MSC MSC_SCAN 458887 <== Here, / was pressed
>> 12:44:02.389552: EV_KEY KEY_RO (0x59) pressed
>
> 'RO'.  Hmm, not very descriptive.  Any idea what this could stand for?

RO stands for Romaji, which is japanese with roman letters (transliteration).

>
>> 12:44:04.253486: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was
>> pressed
>> 12:44:04.253486: EV_KEY KEY_KPCOMMA (0x79) pressed
>
> Ok.  Is there a key with ',' too in your numpad?

Yes, there is a separated ',' in the numpad, and when I press it I get

17:48:47.878881: EV_MSC MSC_SCAN 458851
17:48:47.878881: EV_KEY KEY_KPDOT (0x53) pressed
17:48:47.878881: EV_SYN code=0 value=0
^[[3~17:48:47.966876: EV_MSC MSC_SCAN 458851
17:48:47.966876: EV_KEY KEY_KPDOT (0x53) released
17:48:47.966876: EV_SYN code=0 value=0

Apparently the codes are exchanged in ABNT2 numpad.

Thanks,
Joao Luis.

Message #99 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>

To: "R. Lemos" <rslemos@gmail.com>

Cc: "Gerd Hoffmann" <kraxel@redhat.com>, "Joao Luis Meloni Assirati" <jlma@nonada.if.usp.br>, "Michael Tokarev" <mjt@tls.msk.ru>, "qemu-devel" <qemu-devel@nongnu.org>, 772422@bugs.debian.org

Subject: Re: ABNT2 keys again

Date: Tue, 26 May 2015 18:24:28 -0300

Hello,

> I've tested an unpatched QEMU 2.3.0 (x86_64) with "-k pt_br" option and
> the
> "/?°" key works perfectly.

From the manpage of qemu:

-k language
   Use keyboard layout language (for example "fr" for French). This option
is only needed where it is not easy to get raw PC keycodes (e.g. on
Macs, with some X11 servers or with a VNC display). You don't normally
need to use it on PC/Linux or PC/Windows hosts.

Do you think that using the -k option is the right solution to this problem?

>
> I have not tested the numpad ".", but I can inform that ABNT2 keyboard
> does
> have "." (dot) and "," (comma) as separate keys: comma (numlock on)
> combined with delete (numlock off).
>
> But I found another key that is not working: the "<," ("less than"
> "comma"). Right now I cannot give details about its scancode, nor make any
> further test.
>
>
> Em ter, 26 de mai de 2015 às 11:01, Gerd Hoffmann <kraxel@redhat.com>
> escreveu:
>
>> >  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
>> > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
>> > +    0x73,      /*  97 EVDEV - /?<C2><B0> (ABNT2 Keyboards) */
>>
>> That one looks good.
>>
>> > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
>> > +    0x34,      /* 129 abnt2 KP-period */
>>
>> That is the *other* dot key, outside keypad.
>>
>> Patches just sent via git-send-email, test results are welcome.
>>
>> thanks,
>>   Gerd
>>
>>
>>
>

Message #104 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

Cc: gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, 772422@bugs.debian.org

Subject: Re: [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 06:27:58 -0300

On 26-05-2015 10:58, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
>
> With vnc (remote-viewer) only one of the two works correctly.
> Probably a client-side issue.  Not investigated in detail though.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can update ui/sdl2-keymap.h
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   ui/x_keymap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> index b9b0944..4e899b4 100644
> --- a/ui/x_keymap.c
> +++ b/ui/x_keymap.c
> @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
>    */
>   
>   static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
>       0,         /*  98 EVDEV - KATA (Katakana) */
>       0,         /*  99 EVDEV - HIRA (Hiragana) */
>       0x79,      /* 100 EVDEV - HENK (Henkan) */
> @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
>       0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
>       0,         /* 127 EVDEV - PAUS */
>       0,         /* 128 EVDEV - ???? */
> -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
>       0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
>       0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
>       0x7d,      /* 132 AE13 (Yen)*/

With this patch, the / key now works. Unfortunately, the numpad period 
does not work. Note that /usr/share/qemu/keymaps/pt-br lists 0x34 for 
KP_Decimal (this is the code my patch was using), instead of 0xf0.

Thanks,
João Luis.

Message #109 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Markus Armbruster <armbru@redhat.com>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 13:19:06 +0200

Gerd Hoffmann <kraxel@redhat.com> writes:

> This patch adds the two extra brazilian keys to the evdev keymap for
> X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
>
> With vnc (remote-viewer) only one of the two works correctly.
> Probably a client-side issue.  Not investigated in detail though.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can update ui/sdl2-keymap.h
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  ui/x_keymap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> index b9b0944..4e899b4 100644
> --- a/ui/x_keymap.c
> +++ b/ui/x_keymap.c
> @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
>   */
>  
>  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
>      0,         /*  98 EVDEV - KATA (Katakana) */
>      0,         /*  99 EVDEV - HIRA (Hiragana) */
>      0x79,      /* 100 EVDEV - HENK (Henkan) */
> @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
>      0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
>      0,         /* 127 EVDEV - PAUS */
>      0,         /* 128 EVDEV - ???? */
> -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
>      0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
>      0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
>      0x7d,      /* 132 AE13 (Yen)*/

The two patches together associate

    name        number      evdev
    ro          0x73        97
    kp_comma    0xf0        129

If I understand things correctly, we can freely choose number (we choose
it to match PS/2 scancodes, however), but evdev is externally defined.
Correct?

My /usr/share/X11/xkb/keycodes/evdev has

	// Keys that are generated on Japanese keyboards
	<AB11> = 97;	// backslash/underscore
	//<RO>   =  97;	// Romaji

and

	// Extended keys that may be generated on "Internet" keyboards.
	// evdev has standardize names for these.
	<I129> = 129;	// #define KEY_KPCOMMA             121

I guess this is where you got the name 'ro'.  Okay.

I'm pretty ignorant about evdev, so please excuse if my questions are
stupid:

1. Can you explain why you picked <RO> over <AB11>?

2. Should the comment in your second hunk be changed from

        EVDEV - I129 ("Internet" Keyboards)

   to something mentioning KPCOMMA?

Message #114 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Daniel P. Berrange" <berrange@redhat.com>

To: Markus Armbruster <armbru@redhat.com>

Cc: Gerd Hoffmann <kraxel@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org, 772422@bugs.debian.org, qemu-devel@nongnu.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 12:35:49 +0100

On Wed, May 27, 2015 at 01:19:06PM +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
> > This patch adds the two extra brazilian keys to the evdev keymap for
> > X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
> >
> > With vnc (remote-viewer) only one of the two works correctly.
> > Probably a client-side issue.  Not investigated in detail though.
> >
> > The SDL2 library complains it doesn't know these keys, so the SDL2
> > library must be fixed before we can update ui/sdl2-keymap.h
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  ui/x_keymap.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> > index b9b0944..4e899b4 100644
> > --- a/ui/x_keymap.c
> > +++ b/ui/x_keymap.c
> > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
> >   */
> >  
> >  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
> >      0,         /*  98 EVDEV - KATA (Katakana) */
> >      0,         /*  99 EVDEV - HIRA (Hiragana) */
> >      0x79,      /* 100 EVDEV - HENK (Henkan) */
> > @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> >      0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
> >      0,         /* 127 EVDEV - PAUS */
> >      0,         /* 128 EVDEV - ???? */
> > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
> >      0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
> >      0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
> >      0x7d,      /* 132 AE13 (Yen)*/
> 
> The two patches together associate
> 
>     name        number      evdev
>     ro          0x73        97
>     kp_comma    0xf0        129
> 
> If I understand things correctly, we can freely choose number (we choose
> it to match PS/2 scancodes, however), but evdev is externally defined.
> Correct?
> 
> My /usr/share/X11/xkb/keycodes/evdev has
> 
> 	// Keys that are generated on Japanese keyboards
> 	<AB11> = 97;	// backslash/underscore
> 	//<RO>   =  97;	// Romaji
> 
> and
> 
> 	// Extended keys that may be generated on "Internet" keyboards.
> 	// evdev has standardize names for these.
> 	<I129> = 129;	// #define KEY_KPCOMMA             121
> 
> I guess this is where you got the name 'ro'.  Okay.
> 
> I'm pretty ignorant about evdev, so please excuse if my questions are
> stupid:
> 
> 1. Can you explain why you picked <RO> over <AB11>?

/usr/include/linux/input.h calls it KEY_RO - not sure why
X11 would use AB11 for that keycode instead, but I figure
it is better for use to use the Linux names here.

> 
> 2. Should the comment in your second hunk be changed from
> 
>         EVDEV - I129 ("Internet" Keyboards)
> 
>    to something mentioning KPCOMMA?

Yeah, I think it would make sense.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Message #119 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Daniel P. Berrange" <berrange@redhat.com>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 12:40:25 +0100

On Tue, May 26, 2015 at 03:58:05PM +0200, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
> 
> With vnc (remote-viewer) only one of the two works correctly.
> Probably a client-side issue.  Not investigated in detail though.

The gtk-vnc keymaps.csv file has entries for both these key codes.

For EVDEV_RO it maps to XT KBD code 115 (0x73 in decimal) which matches
your patch.

For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
does not match your patch.  I'm not sure where I got that mapping
from originally - probably from the Linux kernel's XT <-> evdev
keymapping tables.

So presumably you were finding the KPCOMMA one was broken in
remote-viewer ?  It'll be broken in SPICE too, since that shares
the same keymaps.csv file

>  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
>      0,         /*  98 EVDEV - KATA (Katakana) */
>      0,         /*  99 EVDEV - HIRA (Hiragana) */
>      0x79,      /* 100 EVDEV - HENK (Henkan) */
> @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
>      0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
>      0,         /* 127 EVDEV - PAUS */
>      0,         /* 128 EVDEV - ???? */
> -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
>      0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
>      0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
>      0x7d,      /* 132 AE13 (Yen)*/

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Message #124 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org, "R. Lemos" <rslemos@gmail.com>

Subject: Re: ABNT2 keys again

Date: Wed, 27 May 2015 16:11:24 +0200

  Hi,

> >> 12:44:04.253486: EV_MSC MSC_SCAN 458885 <== Here, . in the numpad was
> >> pressed
> >> 12:44:04.253486: EV_KEY KEY_KPCOMMA (0x79) pressed
> >
> > Ok.  Is there a key with ',' too in your numpad?
> 
> Yes, there is a separated ',' in the numpad, and when I press it I get
> 
> 17:48:47.878881: EV_MSC MSC_SCAN 458851
> 17:48:47.878881: EV_KEY KEY_KPDOT (0x53) pressed
> 17:48:47.878881: EV_SYN code=0 value=0
> ^[[3~17:48:47.966876: EV_MSC MSC_SCAN 458851
> 17:48:47.966876: EV_KEY KEY_KPDOT (0x53) released
> 17:48:47.966876: EV_SYN code=0 value=0
> 
> Apparently the codes are exchanged in ABNT2 numpad.

No, abnt2 has an additional numpad key.  Most keyboards have only one,
which is KPDOT.  In US kbd layout this actually maps to a dot.  On other
layouts (german for example) it maps to comma.  Probably because
different countries use different chars as decimal separator.  abnt2 is
unique here, it has both comma and dot.

cheers,
  Gerd

Message #129 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: "R. Lemos" <rslemos@gmail.com>, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel <qemu-devel@nongnu.org>, 772422@bugs.debian.org

Subject: Re: ABNT2 keys again

Date: Wed, 27 May 2015 16:18:55 +0200

On Di, 2015-05-26 at 18:24 -0300, Joao Luis Meloni Assirati wrote:
> Hello,
> 
> > I've tested an unpatched QEMU 2.3.0 (x86_64) with "-k pt_br" option and
> > the
> > "/?°" key works perfectly.
> 
> From the manpage of qemu:
> 
> -k language
>    Use keyboard layout language (for example "fr" for French). This option
> is only needed where it is not easy to get raw PC keycodes (e.g. on
> Macs, with some X11 servers or with a VNC display). You don't normally
> need to use it on PC/Linux or PC/Windows hosts.
> 
> Do you think that using the -k option is the right solution to this problem?

General rule for -k:  If your keyboard layout is messed up try using -k,
otherwise don't bother.

When you use vnc -k might be needed, but whenever that is actually the
case depends on the vnc client.  There is a vnc extension to send raw
keycodes, if the vnc client supports that this gives best results, if it
doesn't you probably need -k for any non-us keyboard layout.

The usual virt-related clients (virt-manager, virt-viewer,
remote-viewer) support that vnc extension.

cheers,
  Gerd

Message #134 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: qemu-devel@nongnu.org, gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, 772422@bugs.debian.org

Subject: Re: [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 16:32:00 +0200

On Mi, 2015-05-27 at 06:27 -0300, Joao Luis Meloni Assirati wrote:
> On 26-05-2015 10:58, Gerd Hoffmann wrote:
> > This patch adds the two extra brazilian keys to the evdev keymap for
> > X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
> >
> > With vnc (remote-viewer) only one of the two works correctly.
> > Probably a client-side issue.  Not investigated in detail though.
> >
> > The SDL2 library complains it doesn't know these keys, so the SDL2
> > library must be fixed before we can update ui/sdl2-keymap.h
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >   ui/x_keymap.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> > index b9b0944..4e899b4 100644
> > --- a/ui/x_keymap.c
> > +++ b/ui/x_keymap.c
> > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
> >    */
> >   
> >   static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
> >       0,         /*  98 EVDEV - KATA (Katakana) */
> >       0,         /*  99 EVDEV - HIRA (Hiragana) */
> >       0x79,      /* 100 EVDEV - HENK (Henkan) */
> > @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> >       0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
> >       0,         /* 127 EVDEV - PAUS */
> >       0,         /* 128 EVDEV - ???? */
> > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
> >       0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
> >       0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
> >       0x7d,      /* 132 AE13 (Yen)*/
> 
> With this patch, the / key now works.


> Unfortunately, the numpad period 
> does not work. Note that /usr/share/qemu/keymaps/pt-br lists 0x34 for 
> KP_Decimal (this is the code my patch was using), instead of 0xf0.

Which ui is this?  vnc?

What happens if you change KP_Decimal to 0xf0 in the pt-br keymap?

cheers,
  Gerd

Message #139 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Markus Armbruster <armbru@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 16:39:47 +0200

On Mi, 2015-05-27 at 13:19 +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
> > This patch adds the two extra brazilian keys to the evdev keymap for
> > X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
> >
> > With vnc (remote-viewer) only one of the two works correctly.
> > Probably a client-side issue.  Not investigated in detail though.
> >
> > The SDL2 library complains it doesn't know these keys, so the SDL2
> > library must be fixed before we can update ui/sdl2-keymap.h
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  ui/x_keymap.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> > index b9b0944..4e899b4 100644
> > --- a/ui/x_keymap.c
> > +++ b/ui/x_keymap.c
> > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
> >   */
> >  
> >  static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
> >      0,         /*  98 EVDEV - KATA (Katakana) */
> >      0,         /*  99 EVDEV - HIRA (Hiragana) */
> >      0x79,      /* 100 EVDEV - HENK (Henkan) */
> > @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> >      0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
> >      0,         /* 127 EVDEV - PAUS */
> >      0,         /* 128 EVDEV - ???? */
> > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
> >      0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
> >      0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
> >      0x7d,      /* 132 AE13 (Yen)*/
> 
> The two patches together associate
> 
>     name        number      evdev
>     ro          0x73        97
>     kp_comma    0xf0        129
> 
> If I understand things correctly, we can freely choose number (we choose
> it to match PS/2 scancodes, however), but evdev is externally defined.
> Correct?

Almost.  The ps/2 keyboard implementation (and probably others too)
assumes "number" are actually ps/2 scancodes.  But, yes, in theory we
could change this.

> 
> My /usr/share/X11/xkb/keycodes/evdev has
> 
> 	// Keys that are generated on Japanese keyboards
> 	<AB11> = 97;	// backslash/underscore
> 	//<RO>   =  97;	// Romaji
> 
> and
> 
> 	// Extended keys that may be generated on "Internet" keyboards.
> 	// evdev has standardize names for these.
> 	<I129> = 129;	// #define KEY_KPCOMMA             121
> 
> I guess this is where you got the name 'ro'.  Okay.

/usr/include/linux/input.h names this "KEY_RO' too.

> 2. Should the comment in your second hunk be changed from
> 
>         EVDEV - I129 ("Internet" Keyboards)
> 
>    to something mentioning KPCOMMA?

Makes sense indeed.

cheers,
  Gerd

Message #144 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: "Daniel P. Berrange" <berrange@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 16:42:58 +0200

  Hi,

> For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> does not match your patch.  I'm not sure where I got that mapping
> from originally - probably from the Linux kernel's XT <-> evdev
> keymapping tables.
> 
> So presumably you were finding the KPCOMMA one was broken in
> remote-viewer ?

Yes.

FYI: https://www.kraxel.org/cgit/input/ recently got a 'emulate-key'
utility which sends key events via uinput.  This allows to test this
kind of stuff without actually having a physical brazilian keyboard.

cheers,
  Gerd

Message #149 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, 772422@bugs.debian.org

Subject: Re: [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Wed, 27 May 2015 16:04:25 -0300

On 27-05-2015 11:32, Gerd Hoffmann wrote:
> On Mi, 2015-05-27 at 06:27 -0300, Joao Luis Meloni Assirati wrote:
>> On 26-05-2015 10:58, Gerd Hoffmann wrote:
>>> This patch adds the two extra brazilian keys to the evdev keymap for
>>> X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
>>>
>>> With vnc (remote-viewer) only one of the two works correctly.
>>> Probably a client-side issue.  Not investigated in detail though.
>>>
>>> The SDL2 library complains it doesn't know these keys, so the SDL2
>>> library must be fixed before we can update ui/sdl2-keymap.h
>>>
>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>> ---
>>>    ui/x_keymap.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/ui/x_keymap.c b/ui/x_keymap.c
>>> index b9b0944..4e899b4 100644
>>> --- a/ui/x_keymap.c
>>> +++ b/ui/x_keymap.c
>>> @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
>>>     */
>>>    
>>>    static const uint8_t evdev_keycode_to_pc_keycode[61] = {
>>> -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
>>> +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
>>>        0,         /*  98 EVDEV - KATA (Katakana) */
>>>        0,         /*  99 EVDEV - HIRA (Hiragana) */
>>>        0x79,      /* 100 EVDEV - HENK (Henkan) */
>>> @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
>>>        0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
>>>        0,         /* 127 EVDEV - PAUS */
>>>        0,         /* 128 EVDEV - ???? */
>>> -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
>>> +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
>>>        0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
>>>        0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
>>>        0x7d,      /* 132 AE13 (Yen)*/
>> With this patch, the / key now works.
>
>> Unfortunately, the numpad period
>> does not work. Note that /usr/share/qemu/keymaps/pt-br lists 0x34 for
>> KP_Decimal (this is the code my patch was using), instead of 0xf0.
> Which ui is this?  vnc?

No, it is the SDL ui.


>
> What happens if you change KP_Decimal to 0xf0 in the pt-br keymap?

It makes no difference. And it should make no difference, as I am not 
using the -k switch.

João Luis.

Message #154 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: "Daniel P. Berrange" <berrange@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 08:24:04 +0200

  Hi,

> For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> does not match your patch.  I'm not sure where I got that mapping
> from originally - probably from the Linux kernel's XT <-> evdev
> keymapping tables.

Did some more testing, 0x7e seems to be the correct one.  Everything is
consistent with that one:  vnc client, input_event_key_* trace event,
input-events reporting within the guest.  So no change needed in
gtk-vnc, I'll update the qemu patch.

cheers,
  Gerd

Message #159 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: qemu-devel@nongnu.org

Cc: gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, 772422@bugs.debian.org, Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

Subject: [PATCH v2 1/2] kbd: add brazil kbd keys to qemu

Date: Thu, 28 May 2015 09:40:44 +0200

The brazilian computer keyboard layout has two extra keys (compared to
the usual 105-key intl ps/2 keyboard).  This patch makes these two keys
known to qemu.

For historic reasons qemu has two ways to specify a key:  A QKeyCode
(name-based) or a number (ps/2 scancode based).  Therefore we have to
update multiple places to make new keys known to qemu:

  (1) The QKeyCode definition in qapi-schema.json
  (2) The QKeyCode <-> number mapping table in ui/input-keymap.c

This patch does just that.  With this patch applied you can send those
two keys to the guest using the send-key monitor command.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qapi-schema.json  | 4 +++-
 ui/input-keymap.c | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index f97ffa1..25df463 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -2784,6 +2784,7 @@
 # Since: 1.3.0
 #
 # 'unmapped' and 'pause' since 2.0
+# 'ro' and 'kp_comma' since 2.4
 ##
 { 'enum': 'QKeyCode',
   'data': [ 'unmapped',
@@ -2801,7 +2802,8 @@
             'kp_9', 'less', 'f11', 'f12', 'print', 'home', 'pgup', 'pgdn', 'end',
             'left', 'up', 'down', 'right', 'insert', 'delete', 'stop', 'again',
             'props', 'undo', 'front', 'copy', 'open', 'paste', 'find', 'cut',
-             'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause' ] }
+            'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause', 'ro',
+            'kp_comma' ] }
 
 ##
 # @KeyValue
diff --git a/ui/input-keymap.c b/ui/input-keymap.c
index 5d29935..7635cb0 100644
--- a/ui/input-keymap.c
+++ b/ui/input-keymap.c
@@ -128,6 +128,10 @@ static const int qcode_to_number[] = {
 
     [Q_KEY_CODE_INSERT] = 0xd2,
     [Q_KEY_CODE_DELETE] = 0xd3,
+
+    [Q_KEY_CODE_RO] = 0x73,
+    [Q_KEY_CODE_KP_COMMA] = 0x7e,
+
     [Q_KEY_CODE_MAX] = 0,
 };
 
-- 
1.8.3.1

Message #164 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: qemu-devel@nongnu.org

Cc: gtk-vnc-list@gnome.org, Michael Tokarev <mjt@tls.msk.ru>, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, 772422@bugs.debian.org, Gerd Hoffmann <kraxel@redhat.com>

Subject: [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 09:40:45 +0200

This patch adds the two extra brazilian keys to the evdev keymap for
X11.  This patch gets the two keys going with the vnc, gtk and sdl1
UIs.

The SDL2 library complains it doesn't know these keys, so the SDL2
library must be fixed before we can update ui/sdl2-keymap.h

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/x_keymap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/x_keymap.c b/ui/x_keymap.c
index b9b0944..1a77317 100644
--- a/ui/x_keymap.c
+++ b/ui/x_keymap.c
@@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
  */
 
 static const uint8_t evdev_keycode_to_pc_keycode[61] = {
-    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
+    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
     0,         /*  98 EVDEV - KATA (Katakana) */
     0,         /*  99 EVDEV - HIRA (Hiragana) */
     0x79,      /* 100 EVDEV - HENK (Henkan) */
@@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
     0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
     0,         /* 127 EVDEV - PAUS */
     0,         /* 128 EVDEV - ???? */
-    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
+    0x7e,      /* 129 EVDEV - KP_COMMA (brazilian) */
     0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
     0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
     0x7d,      /* 132 AE13 (Yen)*/
-- 
1.8.3.1

Message #169 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Markus Armbruster <armbru@redhat.com>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 10:49:40 +0200

Gerd Hoffmann <kraxel@redhat.com> writes:

> This patch adds the two extra brazilian keys to the evdev keymap for
> X11.  This patch gets the two keys going with the vnc, gtk and sdl1
> UIs.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can update ui/sdl2-keymap.h
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Message #174 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Daniel P. Berrange" <berrange@redhat.com>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 09:52:24 +0100

On Thu, May 28, 2015 at 08:24:04AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> > does not match your patch.  I'm not sure where I got that mapping
> > from originally - probably from the Linux kernel's XT <-> evdev
> > keymapping tables.
> 
> Did some more testing, 0x7e seems to be the correct one.  Everything is
> consistent with that one:  vnc client, input_event_key_* trace event,
> input-events reporting within the guest.  So no change needed in
> gtk-vnc, I'll update the qemu patch.

Ah excellant, thanks for letting me know.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Message #179 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Daniel P. Berrange" <berrange@redhat.com>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, Markus Armbruster <armbru@redhat.com>, 772422@bugs.debian.org, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH v2 1/2] kbd: add brazil kbd keys to qemu

Date: Thu, 28 May 2015 09:53:37 +0100

On Thu, May 28, 2015 at 09:40:44AM +0200, Gerd Hoffmann wrote:
> The brazilian computer keyboard layout has two extra keys (compared to
> the usual 105-key intl ps/2 keyboard).  This patch makes these two keys
> known to qemu.
> 
> For historic reasons qemu has two ways to specify a key:  A QKeyCode
> (name-based) or a number (ps/2 scancode based).  Therefore we have to
> update multiple places to make new keys known to qemu:
> 
>   (1) The QKeyCode definition in qapi-schema.json
>   (2) The QKeyCode <-> number mapping table in ui/input-keymap.c
> 
> This patch does just that.  With this patch applied you can send those
> two keys to the guest using the send-key monitor command.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Message #184 received at 772422@bugs.debian.org (full text, mbox, reply):

From: "Daniel P. Berrange" <berrange@redhat.com>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: qemu-devel@nongnu.org, 772422@bugs.debian.org, Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>, Michael Tokarev <mjt@tls.msk.ru>, gtk-vnc-list@gnome.org

Subject: Re: [Qemu-devel] [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 09:54:11 +0100

On Thu, May 28, 2015 at 09:40:45AM +0200, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11.  This patch gets the two keys going with the vnc, gtk and sdl1
> UIs.
> 
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can update ui/sdl2-keymap.h
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Message #189 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Gerd Hoffmann <kraxel@redhat.com>

To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

Cc: 772422 <772422@bugs.debian.org>

Subject: Re: [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 12:18:35 +0200

  Hi,

> With this patch, the gtk and sdl UIs are working fine.

Good.

> Under the vnc UI, 
> a lot of keys don't work, unless the option -k is used. According to the 
> manpage, this options is needed for the vnc UI:
> 
> -k language
>             Use keyboard layout language (for example "fr" for French). 
> This option is only needed where it is not easy to get raw PC keycodes 
> (e.g. on Macs, with some X11 servers or with a VNC display). You don't 
> normally need to use it on PC/Linux or PC/Windows hosts.

Which vnc client is this?
Tried remote-viewer?

> However, using -k pt-br, the numpad period key generates a comma and not 
> a period (without -k pt-br, it also generates a comma). I think that 
> your patch does not cover the vnc UI, as it requires the option -k, 
> which is controlled by the file /usr/share/qemu/keymaps/pt-br.

Well, I think this is a pretty fundamental and unfixable issue:

In case the vnc client does *not* support the extension to send raw
keycodes qemu tries to figure the raw keycode using the symbol (i.e.
'.') it got from the vnc client and the keymap configured
(/usr/share/qemu/keymaps/pt-br in your case).

In case there are two keys generating the same symbol it is impossible
to figure which of the two keys was actually pressed.  And exactly that
is the case here:  There are two keys generating '.':  The one on the
numpad and the other one outside the numpad.

[ adding debian bug back to Cc: to make this visible for others ]

> A question: why do you call key 129 as KP_COMMA in the comment? Wouldn't 
> KP_period be more adequate?

Using the linux input layer naming (see /usr/include/linux/input.h).

cheers,
  Gerd

Message #194 received at 772422@bugs.debian.org (full text, mbox, reply):

From: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>

To: Gerd Hoffmann <kraxel@redhat.com>

Cc: 772422 <772422@bugs.debian.org>

Subject: Re: [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map

Date: Thu, 28 May 2015 08:34:27 -0300

Hello, Gerd.

On 28-05-2015 07:18, Gerd Hoffmann wrote:
>    Hi,
>
>> With this patch, the gtk and sdl UIs are working fine.
> Good.
>
>> Under the vnc UI,
>> a lot of keys don't work, unless the option -k is used. According to the
>> manpage, this options is needed for the vnc UI:
>>
>> -k language
>>              Use keyboard layout language (for example "fr" for French).
>> This option is only needed where it is not easy to get raw PC keycodes
>> (e.g. on Macs, with some X11 servers or with a VNC display). You don't
>> normally need to use it on PC/Linux or PC/Windows hosts.
> Which vnc client is this?
> Tried remote-viewer?

Remote-viewer works perfectly. It is recommended also because it tracks 
correctly the mouse position. Thanks for the tip.

>
>> However, using -k pt-br, the numpad period key generates a comma and not
>> a period (without -k pt-br, it also generates a comma). I think that
>> your patch does not cover the vnc UI, as it requires the option -k,
>> which is controlled by the file /usr/share/qemu/keymaps/pt-br.
> Well, I think this is a pretty fundamental and unfixable issue:
>
> In case the vnc client does *not* support the extension to send raw
> keycodes qemu tries to figure the raw keycode using the symbol (i.e.
> '.') it got from the vnc client and the keymap configured
> (/usr/share/qemu/keymaps/pt-br in your case).
>
> In case there are two keys generating the same symbol it is impossible
> to figure which of the two keys was actually pressed.  And exactly that
> is the case here:  There are two keys generating '.':  The one on the
> numpad and the other one outside the numpad.
>
> [ adding debian bug back to Cc: to make this visible for others ]
>
>> A question: why do you call key 129 as KP_COMMA in the comment? Wouldn't
>> KP_period be more adequate?
> Using the linux input layer naming (see /usr/include/linux/input.h).

Thank you for all the work and information,
João Luis.

Message #203 received at 772422-close@bugs.debian.org (full text, mbox, reply):

From: Michael Tokarev <mjt@tls.msk.ru>

To: 772422-close@bugs.debian.org

Subject: Bug#772422: fixed in qemu 1:2.3+dfsg-5

Date: Wed, 03 Jun 2015 16:23:25 +0000

Source: qemu
Source-Version: 1:2.3+dfsg-5

We believe that the bug you reported is fixed in the latest version of
qemu, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 772422@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Tokarev <mjt@tls.msk.ru> (supplier of updated qemu package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 03 Jun 2015 17:18:58 +0300
Source: qemu
Binary: qemu qemu-system qemu-block-extra qemu-system-common qemu-system-misc qemu-system-arm qemu-system-mips qemu-system-ppc qemu-system-sparc qemu-system-x86 qemu-user qemu-user-static qemu-user-binfmt qemu-utils qemu-guest-agent qemu-kvm libcacard0 libcacard-dev libcacard-tools
Architecture: source
Version: 1:2.3+dfsg-5
Distribution: unstable
Urgency: high
Maintainer: Debian QEMU Team <pkg-qemu-devel@lists.alioth.debian.org>
Changed-By: Michael Tokarev <mjt@tls.msk.ru>
Description:
 libcacard-dev - Virtual Common Access Card (CAC) Emulator (development files)
 libcacard-tools - Virtual Common Access Card (CAC) Emulator (tools)
 libcacard0 - Virtual Common Access Card (CAC) Emulator (runtime library)
 qemu       - fast processor emulator
 qemu-block-extra - extra block backend modules for qemu-system and qemu-utils
 qemu-guest-agent - Guest-side qemu-system agent
 qemu-kvm   - QEMU Full virtualization on x86 hardware
 qemu-system - QEMU full system emulation binaries
 qemu-system-arm - QEMU full system emulation binaries (arm)
 qemu-system-common - QEMU full system emulation binaries (common files)
 qemu-system-mips - QEMU full system emulation binaries (mips)
 qemu-system-misc - QEMU full system emulation binaries (miscelaneous)
 qemu-system-ppc - QEMU full system emulation binaries (ppc)
 qemu-system-sparc - QEMU full system emulation binaries (sparc)
 qemu-system-x86 - QEMU full system emulation binaries (x86)
 qemu-user  - QEMU user mode emulation binaries
 qemu-user-binfmt - QEMU user mode binfmt registration for qemu-user
 qemu-user-static - QEMU user mode emulation binaries (static version)
 qemu-utils - QEMU utilities
Closes: 772422 787547
Changes:
 qemu (1:2.3+dfsg-5) unstable; urgency=high
 .
   * slirp-use-less-predictable-directory-name-in-tmp-CVE-2015-4037.patch
     (Closes: CVE-2015-4037)
   * 11 patches for XEN PCI pass-through issues
     (Closes: #787547 CVE-2015-4103 CVE-2015-4104 CVE-2015-4105 CVE-2015-4106)
   * kbd-add-brazil-kbd-keys-*.patch, adding two keys found on Brazilian
     keyboards (Closes: #772422)
Checksums-Sha1:
 43faa255f2a14f55d487a8aa0eb961011af47b9d 6040 qemu_2.3+dfsg-5.dsc
 550cfa1784ea6af7d2e7d415c884a041918aa5e3 81820 qemu_2.3+dfsg-5.debian.tar.xz
Checksums-Sha256:
 858468f6e692f75bea6c72ae89bae7ff208a006100dd71e9ed7e399e84f41d19 6040 qemu_2.3+dfsg-5.dsc
 a9c355ba0c723aa3ac0f945df16ca77ab3fd7b25fad076c0c1082eb210cdd5f5 81820 qemu_2.3+dfsg-5.debian.tar.xz
Files:
 92da4413ed53697c89fd7d9562212fa3 6040 otherosfs optional qemu_2.3+dfsg-5.dsc
 40c80a3758a66257673220e5ede646ea 81820 otherosfs optional qemu_2.3+dfsg-5.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVbxobAAoJEL7lnXSkw9fbnlkIAK1QuOHi6AAs3VYsfUKCb0K3
/bmVJP686FWLPIzbRhfhE9kTrMXsdgqhYcjZu4wF3x36ABGWvTIkHmvvnNboKMUJ
oqJ34tsJWWf11PwJWr01x9xc2NB2I69uZXDxxCwqR0bQxZr0qllGdSrzsNxll78k
YubCCwThKVz3U1ZvK/N8Qz3s/pbhvYBNQ0iZN9Ku+K+Wb9vzp5qF0mU1CKv1/lWG
3kN7h8hXip/gzDFXpuQzIqK7UgCZIHVBrZEfZc9aUh+SKCYJbh/DYoWKLm8ggzau
BcIUJ8z4yWatmtjiZITRQHqM0OlRGHJanlytgvNULOWnTa6JW23UZj+vPVGkGNU=
=cpEE
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.