Debian Bug report logs - #772352
pcp-testsuite: bashism in /bin/sh script

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <atomo64@gmail.com>

To: maintonly@bugs.debian.org

Subject: pcp-testsuite: bashism in /bin/sh script

Date: Sat, 06 Dec 2014 15:18:11 +0100

Package: pcp-testsuite
Severity: important
Version: 3.10.1
User: debian-release@lists.debian.org
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".

checkbashisms' output:
> possible bashism in ./var/lib/pcp/testsuite/751 line 19 (echo -e):
>     echo -e 'log mandatory on once {
> possible bashism in ./var/lib/pcp/testsuite/751 line 42 (echo -e):
> echo -e "\nold -> new changes"
> possible bashism in ./var/lib/pcp/testsuite/180 line 72 (time):
> (time pmval -z -n $tmp.pmns -a $arch -t $DELTA foo) >$tmp.out 2>$tmp.err
> possible bashism in ./var/lib/pcp/testsuite/180 line 82 (time):
> (time pmval -z -i 4653127 -n $tmp.pmns -a $arch -t $DELTA foo) >$tmp.out
> 2>$tmp.err


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert

Message #10 received at 772352-maintonly@bugs.debian.org (full text, mbox, reply):

From: "Ken McDonell" <kenj@internode.on.net>

To: "'Raphael Geissert'" <atomo64@gmail.com>, <772352-maintonly@bugs.debian.org>

Subject: RE: [pcp] Bug#772352: pcp-testsuite: bashism in /bin/sh script

Date: Wed, 10 Dec 2014 09:25:52 +1100

Thanks Raphael.

These mis-uses of bashisms are confined to the PCP QA suite scripts, so they
do not impact the normal PCP user.

But I'll fix 'em.

Send a report that this bug log contains spam.