Debian Bug report logs - #771363
oggenc --raw segfaults

Toggle useless messages

Message #3 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: oggenc --raw segfaults

Date: Fri, 28 Nov 2014 21:01:13 +0100

Package: vorbis-tools
Version: 1.4.0-5

oggenc --raw seems to always segfault:
| $ true > empty.raw
| $ oggenc --raw empty.raw
| Encoding "empty.raw" to
|          "empty.ogg"
| at quality 3.00
|
|
| Done encoding file "empty.ogg"
|
|         File length:  0m 00.0s
|         Elapsed time: 0m 00.0s
|         Rate:         0.0000
|         Average bitrate: inf kb/s
|
| Segmentation fault

Backtrace:

#0  0x00000000 in ?? ()
#1  0x0804a687 in main (argc=3, argv=0xffffd864) at oggenc.c:449


-- System Information:
Debian Release: jessie/sid
 APT prefers unstable
 APT policy: (990, 'unstable'), (500, 'experimental')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages vorbis-tools depends on:
ii  libao4           1.1.0-3
ii  libc6            2.19-13
ii  libcurl3-gnutls  7.38.0-3
ii  libflac8         1.3.0-3
ii  libogg0          1.3.2-1
ii  libspeex1        1.2~rc1.2-1
ii  libvorbis0a      1.3.4-2
ii  libvorbisenc2    1.3.4-2
ii  libvorbisfile3   1.3.4-2

-- 
Jakub Wilk

Message #8 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 771363@bugs.debian.org, control@bugs.debian.org

Cc: Jakub Wilk <jwilk@debian.org>

Subject: Re: Bug#771363: oggenc --raw segfaults

Date: Fri, 28 Nov 2014 22:02:36 +0100

tags 771363 confirmed
thanks


Jakub Wilk wrote:
> Package: vorbis-tools
> Version: 1.4.0-5
>
> oggenc --raw seems to always segfault:

Thanks for the bug report, Jakub!

I can reproduce this bug in 1.4.0-5 and several older versions, so this 
isn't something we broke recently. And it doesn't only crash on empty 
files (like in your example), but also on every other raw file I've 
tried. I can look into it this weekend. The valgrind report seems pretty 
helpful:

| Use of uninitialised value of size 8
|    at 0x403392: main (oggenc.c:449)
|
| Jump to the invalid address stated on the next line
|    at 0x1C8: ???
|    by 0x403394: main (oggenc.c:449)
|  Address 0x1c8 is not stack'd, malloc'd
|  or (recently) free'd


The crash only happens when using optimization during compilation.

However, I'm afraid this comes too late to be fixed for Jessie. The 
first phase of the freeze (with "important" bugs accepted) is over on 
5th December and even if we upload right now, the package won't make it 
into "testing" in time. Or am I misreading the Freeze Policy and the 5th 
December applies to the "unblock" (instead of the actual migration to 
"testing")? Getting it into Jessie during the second phase of the freeze 
doesn't seem to be viable either, at first sight this doesn't seem to be 
an RC bug.

Cheers,
Martin

Message #13 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 771363@bugs.debian.org

Subject: Re: Bug#771363: oggenc --raw segfaults

Date: Fri, 28 Nov 2014 22:12:41 +0100

Hi Martin!

Thanks for the prompt reply.

* Martin Steghöfer <martin@steghoefer.eu>, 2014-11-28, 22:02:
>I'm afraid this comes too late to be fixed for Jessie. The first phase 
>of the freeze (with "important" bugs accepted) is over on 5th December 
>and even if we upload right now, the package won't make it into 
>"testing" in time. Or am I misreading the Freeze Policy and the 5th 
>December applies to the "unblock" (instead of the actual migration to 
>"testing")?

The Release Team's announcement[0] reads:

"For the avoidance of doubt, packages in this category must be unblocked 
before 5th December. They can migrate in the days following."

So there's still time for fixing this for Jessie without violating the 
freeze policy. :-)

[0] https://lists.debian.org/20141125194607.E96A1302@thykier.net

-- 
Jakub Wilk

Message #18 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Martin Steghöfer <martin@steghoefer.eu>, 771363@bugs.debian.org

Cc: Jakub Wilk <jwilk@debian.org>

Subject: Re: Bug#771363: oggenc --raw segfaults

Date: Fri, 28 Nov 2014 22:17:41 +0100

[Martin Steghöfer]
> However, I'm afraid this comes too late to be fixed for Jessie. The 
> first phase of the freeze (with "important" bugs accepted) is over on 
> 5th December and even if we upload right now, the package won't make it 
> into "testing" in time. Or am I misreading the Freeze Policy and the 5th 
> December applies to the "unblock" (instead of the actual migration to 
> "testing")? Getting it into Jessie during the second phase of the freeze 
> doesn't seem to be viable either, at first sight this doesn't seem to be 
> an RC bug.

I believe the 5th is the upload and unblock deadline, not the testing
propagation deadline.  So there might be time to get a fix into Jessie.

-- 
Happy hacking
Petter Reinholdtsen

Message #23 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 771363@bugs.debian.org

Cc: Jakub Wilk <jwilk@debian.org>

Subject: Re: Bug#771363: oggenc --raw segfaults

Date: Fri, 28 Nov 2014 23:32:36 +0100

[Message part 1 (text/plain, inline)]

Jakub Wilk wrote:
> The Release Team's announcement[0] reads:
>
> "For the avoidance of doubt, packages in this category must be 
> unblocked before 5th December. They can migrate in the days following."
>
> So there's still time for fixing this for Jessie without violating the 
> freeze policy. :-)

Petter Reinholdtsen wrote:
> I believe the 5th is the upload and unblock deadline, not the testing
> propagation deadline.  So there might be time to get a fix into Jessie.

Cool, that's good news. Thanks for the clarification to both of you! I 
will look into this tomorrow and see what I can do. From what I've seen 
so far, I'm confident that the issue has an easy fix.

Cheers,
Martin

[smime.p7s (application/pkcs7-signature, attachment)]

Message #30 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: control@bugs.debian.org, 771363@bugs.debian.org

Subject: Fixed in git; severity "important"

Date: Sat, 29 Nov 2014 11:26:23 +0100

severity 771363 important
thanks


Fixed in git.

I'm changing the severity of this to "important": Even though the crash 
happens *after* correctly encoding the file, it prevents posterior files 
from being encoded and makes batch encoding impossible.

This severity probably qualifies the fix to go into Jessie during the 
first freeze phase. I will file an unblock request as soon as the 
package is uploaded.

Cheers,
Martin

Message #37 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 771363@bugs.debian.org, 763338@bugs.debian.org

Cc: Petter Reinholdtsen <pere@hungry.com>

Subject: Get #763338 and #771363 into Jessie

Date: Fri, 05 Dec 2014 00:32:22 +0100

If we want to get this into Jessie, we probably need to act now. Could 
you try getting this uploaded, Petter?

Cheers,
Martin

Message #42 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Martin Steghöfer <martin@steghoefer.eu>, 771363@bugs.debian.org, 763338@bugs.debian.org

Subject: Re: Get #763338 and #771363 into Jessie

Date: Fri, 05 Dec 2014 07:31:59 +0100

[Martin Steghöfer]
> If we want to get this into Jessie, we probably need to act now. Could 
> you try getting this uploaded, Petter?

I could.

Did you ask for pre-approval?  I have not been able to pay attention,
but I believe it is a good idea to increase the chance of getting fixes
accepted.

-- 
Happy hacking
Petter Reinholdtsen

Message #47 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 771363@bugs.debian.org, 763338@bugs.debian.org

Cc: Petter Reinholdtsen <pere@hungry.com>

Subject: Re: Get #763338 and #771363 into Jessie

Date: Fri, 05 Dec 2014 17:38:19 +0100

Petter Reinholdtsen wrote:
> Did you ask for pre-approval?

No, I was hoping we would have something uploaded before I asked for 
unblock. Finally I sent in a debdiff this morning [1]. Let's see if 
someone attends to it in time.

Cheers,
Martin

[1] https://bugs.debian.org/772137

Message #52 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 771363@bugs.debian.org, 763338@bugs.debian.org

Cc: Petter Reinholdtsen <pere@hungry.com>

Subject: Re: Bug#771363: Get #763338 and #771363 into Jessie

Date: Sat, 06 Dec 2014 18:24:38 +0100

-------- Forwarded message --------
Subject: 	Re: Bug#772137: unblock: vorbis-tools/1.4.0-6 (fixing crash 
and faulty parameter parsing)
Date: 	Sat, 6 Dec 2014 18:16:34 +0100
From: 	Ivo De Decker <ivodd@debian.org>
To: 	Martin Steghöfer <martin@steghoefer.eu>, 772137@bugs.debian.org


Control: tags -1 confirmed

Hi,

On Sat, Dec 06, 2014 at 06:09:30PM +0100, Martin Steghöfer wrote:
> Ivo De Decker wrote:
> >This package is not in unstable, so it can't be unblocked.
>
> Thanks for the reply!
>
> The changes are in our git repository, but I don't have upload
> permissions and the only member of our team who does hasn't gotten
> around to uploading it yet. So I tried to get the changes approved
> before the 5th December deadline. Can it be preapproved?

If the package is uploaded before Monday Dec 8th, it can still be unblocked.
Otherwise, it's too late for jessie.

Remove the moreinfo tag once it's in unstable.

Cheers,

Ivo

Message #57 received at 771363@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Martin Steghöfer <martin@steghoefer.eu>, 771363@bugs.debian.org, 763338@bugs.debian.org

Subject: Re: Bug#771363: Get #763338 and #771363 into Jessie

Date: Sun, 07 Dec 2014 23:14:51 +0100

Thank you Martin for pushing this through.  I just uploaded vorbis-tools
version 1.4.0-6.

-- 
Happy hacking
Petter Reinholdtsen

Message #62 received at 771363-close@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@debian.org>

To: 771363-close@bugs.debian.org

Subject: Bug#771363: fixed in vorbis-tools 1.4.0-6

Date: Sun, 07 Dec 2014 22:19:01 +0000

Source: vorbis-tools
Source-Version: 1.4.0-6

We believe that the bug you reported is fixed in the latest version of
vorbis-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 771363@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated vorbis-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 07 Dec 2014 23:10:56 +0100
Source: vorbis-tools
Binary: vorbis-tools vorbis-tools-dbg
Architecture: source amd64
Version: 1.4.0-6
Distribution: unstable
Urgency: low
Maintainer: Debian Xiph.org Maintainers <pkg-xiph-maint@lists.alioth.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description:
 vorbis-tools - several Ogg Vorbis tools
 vorbis-tools-dbg - several Ogg Vorbis tools (debug files)
Closes: 763338 771363
Changes:
 vorbis-tools (1.4.0-6) unstable; urgency=low
 .
   [ Martin Steghöfer ]
   * Fix oggenc crash on closing raw input files by backporting r19117 from upstream
     (Closes: #771363)
   * Fix vorbistagedit: Correctly process input files containing spaces
     (Closes: #763338)
Checksums-Sha1:
 e0cedf710f757cba35cb7ceb5d5868677b27e1f6 1620 vorbis-tools_1.4.0-6.dsc
 816aeed6abf883d95a97583274ae245fb8d960a3 16280 vorbis-tools_1.4.0-6.debian.tar.xz
 50f14edf4e8755ebe730c8a47dbc9f3eb5124a4b 186898 vorbis-tools_1.4.0-6_amd64.deb
 6cbbec756c3187fefc03a95ef80998f1cbf06944 257484 vorbis-tools-dbg_1.4.0-6_amd64.deb
Checksums-Sha256:
 aff284e580a51f9003755ea0073a9e5dd55f4d1140b6c89f6f6fc1fac3796a3c 1620 vorbis-tools_1.4.0-6.dsc
 f82858311369ff57ec41d08d23c169e7b9fc092428e5d333141ad9d5c6d74ce5 16280 vorbis-tools_1.4.0-6.debian.tar.xz
 58d50b32fad88ea0452343583925bf5cf2a5a8c1d3b793386171d636a3fafa13 186898 vorbis-tools_1.4.0-6_amd64.deb
 d70e11dcade59e24806d04c03fbfdcf3ec272db789b60b5ce171941e826d58e5 257484 vorbis-tools-dbg_1.4.0-6_amd64.deb
Files:
 22f0f80482cb04a8d664eba337c0919e 1620 sound optional vorbis-tools_1.4.0-6.dsc
 d567ed69e0221f50b37b2d5db3d505fb 16280 sound optional vorbis-tools_1.4.0-6.debian.tar.xz
 c1783eafd0d0675ca97f3113c6c91051 186898 sound optional vorbis-tools_1.4.0-6_amd64.deb
 c81845c23cd5c75bdcfeec0fc4643696 257484 debug extra vorbis-tools-dbg_1.4.0-6_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlSE0RMACgkQ20zMSyow1ykwpACghnS/FPSqetHndQ01CZX66FTx
bgQAn32U/STDYz7MkrBgDBmSq0ikzmuB
=6xDr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.