Debian Bug report logs - #769830
[subsurface] Some sources are not included in your package

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Bastien ROUCARIES <roucaries.bastien@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: [subsurface] Some sources are not included in your package

Date: Sun, 16 Nov 2014 22:18:29 +0100

Package: src:subsurface
Version:4.2-5
user: lintian-maint@debian.org
usertags: source-is-missing
severity: serious
X-Debbugs-CC: ftpmaster@debian.org

Hi,

Your package seems to include some files that lack sources
in prefered forms of modification:

theme/jquery.min.js

According to Debian Free Software Guidelines [1] (DFSG) #2:
 "The program must include source code, and must allow distribution
  in source code as well as compiled form.".

This could also constitute a license violation for some copyleft
licenses such as the GNU GPL.

In order to solve this problem, you could:
1. repack the origin tarball adding the missing source to it.
2  add the source files to "debian/missing-sources" directory

Both way satisfies the requirement that we ship the source. Second option
might be preferable due to the following reasons [2]:
 - Upstream can do it too and you could even supply a patch to them,
thus full filling our social contract [3], see particularly §2.
 - If source and non-source are in different locations, ftpmasters may
   miss the source and (needlessly) reject the package.
 - The source isn't duplicated in every .diff.gz/.debian.tar.* (though
   this only really matters for larger sources).

You could also ask debian-qa@lists.debian.org or #debian-qa for more
guidance.

Note that using at install time like you do a link is not sufficient
to solve this kind of problem.

[1] https://www.debian.org/social_contract.en.html#guidelines
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736873#8
[3] https://www.debian.org/social_contract

Message #10 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Bastien ROUCARIES <roucaries.bastien@gmail.com>, 769830@bugs.debian.org

Subject: Re: Bug#769830: [subsurface] Some sources are not included in your package

Date: Sat, 22 Nov 2014 21:34:25 +0000

On Sun, 16 Nov 2014 at 22:18:29 +0100, Bastien ROUCARIES wrote:
> Package: src:subsurface
[...]
> Your package seems to include some files that lack sources
> in prefered forms of modification:
> 
> theme/jquery.min.js

This appears to be a virtually unmodified jquery 1.6.4: it only differs from
https://code.jquery.com/jquery-1.6.4.min.js by one trailing space.
So downloading https://code.jquery.com/jquery-1.6.4.js (or getting it
from the appropriate Debian package) and adding it to debian/missing-sources/
would be sufficient to address that.

However, there is other minified JS in the same directory which is
less well-known than jquery, and should get the same treatment.

Regards,
    S

Message #15 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Salvo Tomaselli <tiposchi@tiscali.it>

To: 769830@bugs.debian.org

Date: Tue, 25 Nov 2014 13:54:02 +0100

source is included for these minified javascripts, in the debian directory.


-- 
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di 
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
                -- Galileo Galilei

                http://ltworf.github.io/ltworf/

Message #20 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Salvo Tomaselli <tiposchi@tiscali.it>

To: 769830@bugs.debian.org, sylvestre@debian.org

Subject: fix

Date: Thu, 27 Nov 2014 21:39:59 +0100

[Message part 1 (text/plain, inline)]

Hello,

I attach the fix I made. I've downloaded and added the missing source within 
the debian/ directory.

If the maintainer doesn't respond within 3 days, I will ask another DD to 
sponsor an nmu with the fix.

I've also removed 2 useless build dependencies, vestiges from when the project 
was based on GTK.

I'm signing the attached file.

Best
-- 
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di 
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
                -- Galileo Galilei

                http://ltworf.github.io/ltworf/

[subsurface_4.2-5.1.debian.tar.xz (application/x-xz-compressed-tar, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Christian PERRIER <bubulle@debian.org>

To: Salvo Tomaselli <tiposchi@tiscali.it>, 769830@bugs.debian.org

Cc: sylvestre@debian.org

Subject: Re: [Pkg-running-devel] Bug#769830: fix

Date: Fri, 28 Nov 2014 07:28:25 +0100

[Message part 1 (text/plain, inline)]

Quoting Salvo Tomaselli (tiposchi@tiscali.it):
> Hello,
> 
> I attach the fix I made. I've downloaded and added the missing source within 
> the debian/ directory.
> 
> If the maintainer doesn't respond within 3 days, I will ask another DD to 
> sponsor an nmu with the fix.
> 
> I've also removed 2 useless build dependencies, vestiges from when the project 
> was based on GTK.
> 
> I'm signing the attached file.

Hello Salvo, thanks for the patch and analysis.

Please leave me a chance to try fixing the issue by a maintainer
upload. I'm not the usual uploader for subsurface (Sylvestre is) and
then I left him priority to fix that RC bug. But, well, as team
member, I still feel the duty of fixing our RC bugs and would then
prefer a maintainer upload. Is one week delay OK for you (there are
chances I look at this during the week-end) ?

I would prefer *not* dropping the build dependencies as they're not
strictly required to fix the RC issue is I understand well, and would
then maybe not qulify for a freeze exception. Do I misunderstand
something?

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Salvo Tomaselli <tiposchi@tiscali.it>

To: 769830@bugs.debian.org

Cc: Christian PERRIER <bubulle@debian.org>

Subject: Re: [Pkg-running-devel] Bug#769830: fix

Date: Fri, 28 Nov 2014 08:37:45 +0100

[Message part 1 (text/plain, inline)]

On Fri, 28 Nov 2014 07:28:25 +0100 Christian PERRIER <bubulle@debian.org> 
wrote:
> Please leave me a chance to try fixing the issue by a maintainer
> upload. I'm not the usual uploader for subsurface (Sylvestre is) and
> then I left him priority to fix that RC bug. But, well, as team
> member, I still feel the duty of fixing our RC bugs and would then
> prefer a maintainer upload. Is one week delay OK for you (there are
> chances I look at this during the week-end) ?
Yes this is okay for me.
It's just that I've contributed upstream and in Debian, and I wouldn't want 
the package to be dropped from testing.


> I would prefer *not* dropping the build dependencies as they're not
> strictly required to fix the RC issue is I understand well, and would
> then maybe not qulify for a freeze exception. Do I misunderstand
> something?
The dependencies were uninstallable on my system, but I contribute upstream 
and I can compile and use it just fine, so I dropped them rather than spending 
time to convince them to install.
Perhaps it is just a local version problem, but to avoid the build to fail, I 
thought it was a desiderable action.

Best
-- 
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di 
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
                -- Galileo Galilei

                http://ltworf.github.io/ltworf/

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Christian PERRIER <bubulle@debian.org>

To: Salvo Tomaselli <tiposchi@tiscali.it>

Cc: 769830@bugs.debian.org

Subject: Re: [Pkg-running-devel] Bug#769830: fix

Date: Fri, 28 Nov 2014 18:39:39 +0100

[Message part 1 (text/plain, inline)]

Quoting Salvo Tomaselli (tiposchi@tiscali.it):
> On Fri, 28 Nov 2014 07:28:25 +0100 Christian PERRIER <bubulle@debian.org> 
> wrote:
> > Please leave me a chance to try fixing the issue by a maintainer
> > upload. I'm not the usual uploader for subsurface (Sylvestre is) and
> > then I left him priority to fix that RC bug. But, well, as team
> > member, I still feel the duty of fixing our RC bugs and would then
> > prefer a maintainer upload. Is one week delay OK for you (there are
> > chances I look at this during the week-end) ?
> Yes this is okay for me.
> It's just that I've contributed upstream and in Debian, and I wouldn't want 
> the package to be dropped from testing.


Given that the package is team-maintained and you are interested in
the package itself, how about joining the pkg-running team (OK, the
name is now not well adapted as we also maintain other sport-related
software but your get the point, of course.....so, in short, you don't
have to run in order to join the team..:-))

That would indeed also fit my goal of this needed upload to be done
from the package's git repo.

[signature.asc (application/pgp-signature, inline)]

Message #42 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Sylvestre Ledru <sylvestre@debian.org>

To: Christian PERRIER <bubulle@debian.org>, Salvo Tomaselli <tiposchi@tiscali.it>, 769830@bugs.debian.org

Subject: Re: [Pkg-running-devel] Bug#769830: fix

Date: Fri, 28 Nov 2014 22:33:08 +0100

[Message part 1 (text/plain, inline)]

On 28/11/2014 07:28, Christian PERRIER wrote:
> Quoting Salvo Tomaselli (tiposchi@tiscali.it):
>> Hello,
>>
>> I attach the fix I made. I've downloaded and added the missing source within 
>> the debian/ directory.
>>
>> If the maintainer doesn't respond within 3 days, I will ask another DD to 
>> sponsor an nmu with the fix.
>>
>> I've also removed 2 useless build dependencies, vestiges from when the project 
>> was based on GTK.
>>
>> I'm signing the attached file.
> Hello Salvo, thanks for the patch and analysis.
>
> Please leave me a chance to try fixing the issue by a maintainer
> upload. I'm not the usual uploader for subsurface (Sylvestre is) and
> then I left him priority to fix that RC bug. But, well, as team
> member, I still feel the duty of fixing our RC bugs and would then
> prefer a maintainer upload. Is one week delay OK for you (there are
> chances I look at this during the week-end) ?
>
> I would prefer *not* dropping the build dependencies as they're not
> strictly required to fix the RC issue is I understand well, and would
> then maybe not qulify for a freeze exception. Do I misunderstand
> something?
>
>
I am in holidays. I will take care of this next week.
As Christian said, please update the patch to only fix the rc.
Also, please do not compress the patch.

> If the maintainer doesn't respond within 3 days,

Please respect the NMU rules (and my work). There is no rush. The
autoremoval is planned in more than 2 weeks.

Regards,
Sylvestre

[signature.asc (application/pgp-signature, attachment)]

Message #47 received at 769830@bugs.debian.org (full text, mbox, reply):

From: Salvo Tomaselli <tiposchi@tiscali.it>

To: Sylvestre Ledru <sylvestre@debian.org>

Cc: Christian PERRIER <bubulle@debian.org>, 769830@bugs.debian.org

Subject: Re: [Pkg-running-devel] Bug#769830: fix

Date: Sat, 29 Nov 2014 00:33:30 +0100

[Message part 1 (text/plain, inline)]

> I am in holidays. I will take care of this next week.
> As Christian said, please update the patch to only fix the rc.
Okay grat! But I will be busy from next week, for about 10 days.

> Also, please do not compress the patch.
It's not a patch to apply to the upstream package, it's just an added file in 
the debian/ directory, plus changelog entry.

> Please respect the NMU rules (and my work). There is no rush. The
> autoremoval is planned in more than 2 weeks.
I have been sending you emails about this already, in the past days.


Best

-- 
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di 
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
                -- Galileo Galilei

                http://ltworf.github.io/ltworf/

[signature.asc (application/pgp-signature, inline)]

Message #52 received at 769830-close@bugs.debian.org (full text, mbox, reply):

From: Salvo 'LtWorf' Tomaselli <tiposchi@tiscali.it>

To: 769830-close@bugs.debian.org

Subject: Bug#769830: fixed in subsurface 4.2-6~exp1

Date: Mon, 08 Dec 2014 11:34:17 +0000

Source: subsurface
Source-Version: 4.2-6~exp1

We believe that the bug you reported is fixed in the latest version of
subsurface, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 769830@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvo 'LtWorf' Tomaselli <tiposchi@tiscali.it> (supplier of updated subsurface package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 27 Nov 2014 21:24:03 +0100
Source: subsurface
Binary: subsurface subsurface-data
Architecture: source amd64 all
Version: 4.2-6~exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian running development group <pkg-running-devel@lists.alioth.debian.org>
Changed-By: Salvo 'LtWorf' Tomaselli <tiposchi@tiscali.it>
Description:
 subsurface - Logbook program for scuba divers
 subsurface-data - Shared data files for Subsurface
Closes: 769830
Changes:
 subsurface (4.2-6~exp1) experimental; urgency=medium
 .
   * Add missing source for the minified jquery (Closes: #769830)
   * Removed libgconf2-dev libsoup2.4-dev from build-dep
Checksums-Sha1:
 a9f3c2a9cd0dbef41e3347d30b307a0bc3f6a747 2220 subsurface_4.2-6~exp1.dsc
 f594825690d83fda2ab575874827236caf4f439f 147724 subsurface_4.2-6~exp1.debian.tar.xz
 d789094316e69f0b8a5a87c93aa4918a2ce06391 686550 subsurface_4.2-6~exp1_amd64.deb
 0f834d031fcc15fbea82d42b6595f9b0971649fa 2578672 subsurface-data_4.2-6~exp1_all.deb
Checksums-Sha256:
 6c186b371ea84d09236c0aebd8b522bfd8f94d2fec1bf22b761bf3dd0fecff43 2220 subsurface_4.2-6~exp1.dsc
 4eb161fed374927bb57626c10b946492a13b28ef7e4027dc9122eb8aa9b51ec0 147724 subsurface_4.2-6~exp1.debian.tar.xz
 b6d54f3fc9e39142fbb3168292d2b1c1aa547e5ca963421ea3508129854ea323 686550 subsurface_4.2-6~exp1_amd64.deb
 de79a42038d9e5853040b937476e54c550338ef96ee9bebc10931dae2ae4731b 2578672 subsurface-data_4.2-6~exp1_all.deb
Files:
 1a155d6d45565dc2cfb379229cc32676 2220 utils optional subsurface_4.2-6~exp1.dsc
 768d46598846e6aac903f4125b616ed4 147724 utils optional subsurface_4.2-6~exp1.debian.tar.xz
 027635b6b8c26b409a21085a22ceeb65 686550 utils optional subsurface_4.2-6~exp1_amd64.deb
 cc7d8c76450cc56e2bc14a6e5386c8ad 2578672 utils optional subsurface-data_4.2-6~exp1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUhYqrAAoJEH5lKNp1LxvhNdAP/RdfR+d7lJuMyenqxdbSInKt
8LJTejD1gH457dRa0/yXiIk7VLClHuJbU96jFb1Zr++IUUvuWW25vi29SDCrCXRm
F3TMBsy7YOXX0g7Nfi/c+n19F1Wu8G/08h1gErT/BVmfg88j49JdZ95vkBrPqUeh
IW9+tgvPApBWyvEaBsd0MG5metrN4ukgf+W3yXxGcI1nXKJ0UJrsynzyFM58Q918
opylOAbCW7MnfCwsWBIzspVyaCfp5ArItYjMgjZo+Z3ThnQ3HiiZH+VbyiOl4028
rjm0UX4IUnk2tTu+HAVVupoPg+7nt40Nhi4HQqR+ocg5xZhqnXIO4FCIW4crwf0L
ylcalMQrtmqcUJagls3c+5zKdV34p36CrSuwd3u7SU3Ujk1/oNM/KPlHkNM2DcpK
ukbjlIdGxIbJQeMwdMXTNyUDctVMIMEJMV9/S1/RyP8yyehRyNDU2VOzggHfoep+
m7lzcbM+sgT4rwy+MmTvTbQ+69eASY+Jgur/vSOYSJ3CTIOW4w49ssKqHwxfd2AJ
9fBUY3rGBvGglqO8421TtQSqJc5t+dmrPgCh6viDmWDq7sIH+IARnr8vKGcMvlJr
3knKVwATdNwUQLpgbT2Zhxj+W3h6IuFpfQwd6S3ehYnqQNDg+ydVxsJG3DbK0QwP
Zi/TrhTh8rFXADoHRwEW
=nPVb
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.