Debian Bug report logs - #765065
ltsp-client-core: fails to stop some unneeded services on thin clients anymore

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Wolfgang Schweer <wschweer@arcor.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: ltsp-client-core: fails to stop some unneeded services on thin clients anymore

Date: Mon, 13 Oct 2014 11:10:57 +0200

[Message part 1 (text/plain, inline)]

Package: ltsp-client-core
Version: 5.5.3-1
Severity: normal
User: debian-edu@lists.debian.org
Usertags: debian-edu 


Hi.

When testing Debian Edu based on jessie, we found that modemmanager and 
cups-browsed were running on thin clients. 

While cups-browsed could be stopped by simply adding it to 
50-rm-system-services, modemmanager fails to be stopped from running.

Renaming modemmanager to ModemManager (this being the systemd service 
file name) and using the systemd tool 'systemctl' seems to do the job.


--- 50-rm-system-services.orig	2014-10-13 10:42:10.893092219 +0200
+++ 50-rm-system-services	2014-10-13 10:32:11.977456101 +0200
@@ -25,7 +25,7 @@
 exim4                 # exim4 Mail Transport Agent
 grub-common           # Record successful boot for GRUB
 lightdm               # Light Display Manager
-modemmanager          # Modem manager
+ModemManager          # Modem manager
 nbd-client            # Network Block Device client (we use nbd-disconnect)
 plymouth-stop         # Hide the splash screen
 rfkill-store          # Store software rfkill state
@@ -51,6 +51,7 @@
 bluetooth             # Bluetooth daemon
 brltty                # Braille terminal driver
 cups                  # CUPS Printing spooler and server
+cups-browsed          # CUPS browse daemon
 kerneloops            # Collects and submits kernel crash signatures
 network-manager       # Network connection manager
 ufw                   # Uncomplicated Firewall
@@ -83,5 +84,5 @@
 fi
 
 for service in $rm_services; do
-    rm -f /etc/rc?.d/???"$service" "/etc/init.d/$service" "/etc/init/$service.conf"
+    systemctl disable $service.service
 done



Wolfgang

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 765065@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: Wolfgang Schweer <wschweer@arcor.de>, 765065@bugs.debian.org

Subject: Re: Bug#765065: ltsp-client-core: fails to stop some unneeded services on thin clients anymore

Date: Mon, 13 Oct 2014 15:10:16 -0700

[Message part 1 (text/plain, inline)]

On 2014-10-13, Wolfgang Schweer wrote:
> When testing Debian Edu based on jessie, we found that modemmanager and 
> cups-browsed were running on thin clients. 
...
> --- 50-rm-system-services.orig	2014-10-13 10:42:10.893092219 +0200
> +++ 50-rm-system-services	2014-10-13 10:32:11.977456101 +0200
> @@ -25,7 +25,7 @@
>  exim4                 # exim4 Mail Transport Agent
>  grub-common           # Record successful boot for GRUB
>  lightdm               # Light Display Manager
> -modemmanager          # Modem manager
> +ModemManager          # Modem manager
>  nbd-client            # Network Block Device client (we use nbd-disconnect)
>  plymouth-stop         # Hide the splash screen
>  rfkill-store          # Store software rfkill state
> @@ -51,6 +51,7 @@
>  bluetooth             # Bluetooth daemon
>  brltty                # Braille terminal driver
>  cups                  # CUPS Printing spooler and server
> +cups-browsed          # CUPS browse daemon
>  kerneloops            # Collects and submits kernel crash signatures
>  network-manager       # Network connection manager
>  ufw                   # Uncomplicated Firewall
> @@ -83,5 +84,5 @@
>  fi
>  
>  for service in $rm_services; do
> -    rm -f /etc/rc?.d/???"$service" "/etc/init.d/$service" "/etc/init/$service.conf"
> +    systemctl disable $service.service
>  done

Thanks for the patch!

This seems like three separate, though related issues:

* Adding cups-browsed to the list of removed services.

* Fixing the case for ModemManager so it removes the correct service
  (although simply adding another line might be good, in case older
  versions or other distros ship it without the CamelCase).

* Using systemctl to disable systemd related services.

How well does this last bit work if systemctl isn't installed? Would
simply removing the files (.service) that systemctl uses be sufficient?
Are there too many possible locations /etc/systemd/system/,
/lib/systemd/system/, /usr/lib/systemd/system, and subdirs of each of
those?

I'll try and pose some questions to the systemd maintainers about this
as well.

live well,
  vagrant

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 765065@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 765065@bugs.debian.org

Cc: Wolfgang Schweer <wschweer@arcor.de>

Subject: Re: [Pkg-ltsp-devel] Bug#765065: ltsp-client-core: fails to stop some unneeded services on thin clients anymore

Date: Tue, 14 Oct 2014 07:26:19 +0200

[Vagrant Cascadian]
> How well does this last bit work if systemctl isn't installed? Would
> simply removing the files (.service) that systemctl uses be
> sufficient?  Are there too many possible locations
> /etc/systemd/system/, /lib/systemd/system/, /usr/lib/systemd/system,
> and subdirs of each of those?

I am currently testing a function like this in our
/usr/share/ltsp/init-ltsp.d/60-edu-client file, which might address
some of your questions:

service_disable() {
    service="$1"
    if [ -d  /run/systemd/system ] \
       && [ -f /lib/systemd/system/gdm3.service ] ; then
        systemctl disable ${service}.service
    else
        update-rc.d $service disable || true
    fi
}

-- 
Happy hacking
Petter Reinholdtsen

Message #20 received at 765065@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 765065@bugs.debian.org

Subject: Re: [Pkg-ltsp-devel] Bug#765065: Bug#765065: ltsp-client-core: fails to stop some unneeded services on thin clients anymore

Date: Wed, 15 Oct 2014 10:39:54 +0200

[Petter Reinholdtsen]
> I am currently testing a function like this in our
> /usr/share/ltsp/init-ltsp.d/60-edu-client file, which might address
> some of your questions:

That approach did not work, because /run/systemd/system is not yet
created when the init-ltsp.d scripts are executed.  This on the other
hand do work:

  if grep -q systemd /sbin/init ; then
    BOOTSYSTEM=systemd
  else
    BOOTSYSTEM=sysvinit
  fi

  service_disable() {
    service="$1"
    if [ systemd = "$BOOTSYSTEM" ] \
        && [ -f /lib/systemd/system/${service}.service ] ; then
        systemctl disable ${service}.service
    else
        update-rc.d $service disable || true
    fi
  }
-- 
Happy hacking
Petter Reinholdtsen

Message #25 received at 765065@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: Petter Reinholdtsen <pere@hungry.com>, 765065@bugs.debian.org, 765065-submitter@bugs.debian.org, 761891-quiet@bugs.debian.org

Subject: Re: Bug#765065: ltsp-client-core: fails to stop some unneeded services on thin clients anymore

Date: Wed, 15 Oct 2014 16:49:06 -0700

[Message part 1 (text/plain, inline)]

Control: reopen 761891
Control: tags -1 pending fixed-upstream

Committed some fixes upstream to address these issues, and tested to
work with both systemd and sysvinit:

  https://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltsp-trunk/revision/2604
  https://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltsp-trunk/revision/2605
  https://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltsp-trunk/revision/2606

live well,
  vagrant

[Message part 2 (application/pgp-signature, inline)]

Message #35 received at 765065-close@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>

To: 765065-close@bugs.debian.org

Subject: Bug#765065: fixed in ltsp 5.5.4-1

Date: Wed, 22 Oct 2014 07:04:54 +0000

Source: ltsp
Source-Version: 5.5.4-1

We believe that the bug you reported is fixed in the latest version of
ltsp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 765065@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated ltsp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 21 Oct 2014 23:32:58 -0700
Source: ltsp
Binary: ltsp-server ltsp-server-standalone ltsp-client-core ltsp-client ltsp-client-builder
Architecture: source all
Version: 5.5.4-1
Distribution: unstable
Urgency: medium
Maintainer: LTSP Debian Maintainers <pkg-ltsp-devel@lists.alioth.debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Description:
 ltsp-client - complete LTSP client environment
 ltsp-client-builder - build an LTSP environment in the installer target (udeb)
 ltsp-client-core - basic LTSP client environment
 ltsp-server - basic LTSP server environment
 ltsp-server-standalone - complete LTSP server environment
Closes: 761891 765065 765443 765694
Changes:
 ltsp (5.5.4-1) unstable; urgency=medium
 .
   * New upstream version:
     - Support for disabling systemd services with RM_SYSTEM_SERVICES.
       (Closes: #765065)
 .
     - Disable cups-browsed and ModemManager services by default.
       (Closes: #761891, #765065).
 .
     - Set up hostname.domain in /etc/hosts (LP: #1093088).
 .
     - Fix use of SHUTDOWN_TIME with LDM to use ltsp-logout-action instead.
       (LP: #604908).
 .
     - Fix ssh, xdmcp and telnet screen scripts by checking for empty
       argument (LP: #1020113, #1175618).
 .
     - Default to "server" in ssh screen script so that ssh_known_hosts
       file generated by ltsp-update-sshkeys will match.
 .
     - ltsp-build-client: Do not use full path to libeatmydata.so.
       (Closes: #765694)
 .
     - Unset temporary directory variables to avoid problems when directory
       is missing inside the chroot (Closes: #765443).
 .
     - update-kernels: Update ARM code to generate a generic bootscript.
 .
   * debian/control:
     - Add u-boot-tools to ltsp-client-core Depends on armhf/armel.
     - Update Standards-Version to 3.9.6, no changes needed.
Checksums-Sha1:
 c8d0fd4ed31ee1dc89d7f951a3680362689b07c7 2285 ltsp_5.5.4-1.dsc
 a1cebda26315ebd3d3dbbc16753a6e60cb349fec 311424 ltsp_5.5.4.orig.tar.xz
 e60ea122eaa866b49876063cb30b5cda15cd8625 73860 ltsp_5.5.4-1.debian.tar.xz
 7c8c57c7704bb25bc5cfddcfab0396e817fd77fb 266194 ltsp-server_5.5.4-1_all.deb
 5d7c29217dad4155abf746ecf5372a67be592b4e 145910 ltsp-server-standalone_5.5.4-1_all.deb
 92ff52f2a81b26c5e1be9c9f5565bb591d2b6d06 11124 ltsp-client-builder_5.5.4-1_all.udeb
Checksums-Sha256:
 1ba43a010e7f6e94e492fc3a1cb944f9aebd23ef69b7373c500025d1fa0bb0d5 2285 ltsp_5.5.4-1.dsc
 48104820c6beecf6017d5a287521ea32239179a78a30361af77b0bef72a728f3 311424 ltsp_5.5.4.orig.tar.xz
 bbca8fbaef2b3a7c48200a6f796507589096aef2179e022f5e586e4b6e540dcd 73860 ltsp_5.5.4-1.debian.tar.xz
 7e003538dd627e1a919466bb336f72c7a6e74788c2419ef5e560b8c8d4808c6a 266194 ltsp-server_5.5.4-1_all.deb
 ff712bf03387c6e061d68c040eacdc3179a6abf2b89304551ef66e8bb1a7cbb3 145910 ltsp-server-standalone_5.5.4-1_all.deb
 db8e27f48355443a7c8a6dc03ee3e216103cc1431ffc4a1a5d15efe9d4612bf3 11124 ltsp-client-builder_5.5.4-1_all.udeb
Files:
 78fa9f6d4ab028ae6a3ccf6da47778ad 2285 misc extra ltsp_5.5.4-1.dsc
 e7e37c2cb1b471e09e31280d9c4f85cb 311424 misc extra ltsp_5.5.4.orig.tar.xz
 471fb08f52ad33b98f670232988cbec5 73860 misc extra ltsp_5.5.4-1.debian.tar.xz
 dd2bd33f28be7c10372e1e32481ef850 266194 misc extra ltsp-server_5.5.4-1_all.deb
 fbf87330a329f0ecd6c75338dce562aa 145910 misc extra ltsp-server-standalone_5.5.4-1_all.deb
 063d87b89edb652455e9b034b794109d 11124 debian-installer extra ltsp-client-builder_5.5.4-1_all.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJUR1LeAAoJELeLgtSBS5G2rVAP/jUhOkiNdz55bjxf2WpP9YUF
0flE/GV4g46UHZUIhakkUC3exOaMOR//lnyZGEmmlNDUn0+dO2Opzr7C8wTMdbOS
4QMMFfcRivlYKhtNwlSfhiW9wtHxi3V6MT6culSlp5v453CKggFPbkwuh2voqbcu
KKGeRIcFfE7Cw3iL1slZwae9mXcMQ7QKOiu9rACHWQoAAy3ceJFk5TGXtID0OYrj
/4L7nvE2nujN2XeeBIoHlwPX4b01OPaH+siDShB/BRICc6tykgzQ5KFQJXP3z420
pT8x7uoN+jluyfFC+S+tCg0UNI+XPfNRlYQUFGfsTsRIMKTr2nA8k/mwHyrFtU5E
zHG83Q79S1jhrCDGaZ4sAH9FrlZ8HuqHfwJDC9lAqoRCYuH+E7+bYaslj+AocVvn
xuvv/cW6LPxdvDOhV5vHDl1ZwR+fTJOY+k+w5IC5cASJCiBloT6vdXgnnRKotGzs
YaAWk8Sa0GqF0QYIHewq9j22bvTEgAbqDyTRDNKteXbT7asTmyC84MzRJyPJjYZa
zo7PkgB9ClIhAVy7pyeyBYBdOL29GPIk+fUXGy3gCB9nQPRS8VLB7tYyN0dmj1GG
e155iss1hP1Dzyz0EDaq/fBd6ZVv97hmx34YbDoaKSinN+DU32HFpUrW+1eadwh/
gAJsfk2TMZ8F0aNBe3lE
=BZBw
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.