Debian Bug report logs - #764206
dpkg-source: Broken source unpacking when applying patches

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: submit@bugs.debian.org

Subject: dpkg-source: Broken source unpacking when applying patches

Date: Mon, 6 Oct 2014 12:49:36 +0200

Package: dpkg-dev
Version: 1.17.14
Severity: serious

Hi!

There's a regression in dpkg-source when unpacking source packages and
applying patches. This was reported by Helmut Grohne.

I'm preparing a quick fix, and will be doing the upload right away.

Thanks,
Guillem

Message #10 received at 764206-submitter@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 764206-submitter@bugs.debian.org

Subject: Bug#764206 marked as pending

Date: Mon, 06 Oct 2014 11:47:58 +0000

tag 764206 pending
thanks

Hello,

Bug #764206 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=09b0ee8

---
commit 09b0ee85aea1767a3f980be4fe7d77eabef6f549
Author: Guillem Jover <guillem@debian.org>
Date:   Mon Oct 6 13:04:21 2014 +0200

    Dpkg::Source::Patch: Switch remaining topic to named variable in analyze()
    
    The loop in the function was expecting $line to be filled by its last
    part, and by working on the topic variable it was not getting updated.
    Switch all topic variable usages in that funtion so that we can restore
    working source unpacking.
    
    Regression introduced in commmit 0d5e17af7391fb0d3a3c695dac40f8df41f8b11c.
    
    Closes: #764206
    
    Addresses BuiltinFunctions::ProhibitUselessTopic.
    
    Warned-by: perlcritic

diff --git a/debian/changelog b/debian/changelog
index c4eecb0..38abedc 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,9 @@
 dpkg (1.17.16) UNRELEASED; urgency=low
 
   * Set the copyright holder in the po4a calls for man pages.
+  * Switch remaining topic to named variable in Dpkg::Source::Patch:analyze(),
+    otherwise the loop was expecting values in one variable but storing them
+    in another. Regression introduced in dpkg 1.17.14. Closes: #764206
 
  -- Guillem Jover <guillem@debian.org>  Mon, 06 Oct 2014 03:37:15 +0200
 

Message #15 received at 764206-close@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 764206-close@bugs.debian.org

Subject: Bug#764206: fixed in dpkg 1.17.16

Date: Mon, 06 Oct 2014 12:04:26 +0000

Source: dpkg
Source-Version: 1.17.16

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 764206@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <guillem@debian.org> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 06 Oct 2014 13:29:17 +0200
Source: dpkg
Binary: libdpkg-dev dpkg dpkg-dev libdpkg-perl dselect
Architecture: source all
Version: 1.17.16
Distribution: unstable
Urgency: low
Maintainer: Dpkg Developers <debian-dpkg@lists.debian.org>
Changed-By: Guillem Jover <guillem@debian.org>
Description:
 dpkg       - Debian package management system
 dpkg-dev   - Debian package development tools
 dselect    - Debian package management front-end
 libdpkg-dev - Debian package management static library
 libdpkg-perl - Dpkg perl modules
Closes: 764171 764206
Changes:
 dpkg (1.17.16) unstable; urgency=low
 .
   * Set the copyright holder in the po4a calls for man pages.
   * Switch remaining topic to named variable in Dpkg::Source::Patch:analyze(),
     otherwise the loop was expecting values in one variable but storing them
     in another. Regression introduced in dpkg 1.17.14. Closes: #764206
   * Set umask to 0 when creating symlinks in tar test case, to normalize
     results. POSIX specifies that symlinks have undefined permissions in
     their mode, so their setting is system dependent. Linux does not honor
     the umask for symlinks, other systems like Hurd or kFreeBSD do.
     Regression introduced in dpkg 1.17.14. Closes: #764171
Checksums-Sha1:
 ad178f0289098be6d863825ccf1c286101882c76 2057 dpkg_1.17.16.dsc
 0745d21e06a5775d9d059bd325558de69dc2f291 4299248 dpkg_1.17.16.tar.xz
 fb4d3478abd5fdbe35c7f2e4f2c6926dafced41e 1487554 dpkg-dev_1.17.16_all.deb
 8e1fe4e3ac877ceafd9e20b6d7697ca040893396 1015212 libdpkg-perl_1.17.16_all.deb
Checksums-Sha256:
 a2708cb0b15870c5e6a49545e91a8781b63237c9455de8991e2270453fd638b9 2057 dpkg_1.17.16.dsc
 3bb58a197ad6e8fe80a2063de70ec737a486b1f6cafd9a481a92ce5411c90fe0 4299248 dpkg_1.17.16.tar.xz
 3c80801ce9dff190d13aab1af947606c164d020c6d2204ab8023da1656d62efb 1487554 dpkg-dev_1.17.16_all.deb
 fe25ebd960ac0f530b1b1700020593042f4cd7a568522d42155cc8962ebf02ff 1015212 libdpkg-perl_1.17.16_all.deb
Files:
 30a7639713a523e7daae70c49dcd899f 2057 admin required dpkg_1.17.16.dsc
 62381b83a86ef40c33df8a07034e0f0e 4299248 admin required dpkg_1.17.16.tar.xz
 99a84952f0868f833ff9e3b8cf19f2a6 1487554 utils optional dpkg-dev_1.17.16_all.deb
 0da59a4095bfaa46e11c9d4773b8b769 1015212 perl optional libdpkg-perl_1.17.16_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJUMoDTAAoJELlyvz6krlejThYP/2AX9WBauniPqz44rm34puKR
OW/SDTcCo9L72VHzuqVWABB40H5IITSgmNYS4l5UedhTaiFLrHRwLb3veyLj/spJ
mvPPG5mqV929RD5W1eSr+enMv2BDVP6M2kwgHUzmv7bhZaHRFDoVMee8fY6Nrg+S
dfCVckka2SynRAUxapYECSrT0eMGS3ddVfawzpgWW+JRVOPFl0YDor/oJc9Cv72K
ibFnRVjJRCFE8AvtEYZHduiACsyO+tik2wtj+tHURMxBX9v0/ffaHH9lJBqCDQi+
S/xFipc7xfnlBb1gZEpagq4YTb9wdyuAdu4R1iqj8tw+u35SCRM908snS61X91gu
odkIdeMB3sBJnHMaj//FswHruxpz6CevsU4gy/oiGJz31B5QebaRaWYp8i8Jl90P
N//HTwhukCXhGSQtnGxy/aZo5YGZ+Cgwsn9XL6Pr46ygpgQJN1xUHyAHUjA3LO3X
i/CgUIEd5syvCjig3FxkFog4QvdH9RZp1l5LcdPuCjBZGfDCHQayFrUoqlktD5F5
XzWjP3cAbj1v+t/IpKFu/lEO1u3vQRVvx/dx2hgX3JYwknLFWXHdEO6xs4ImeAMO
sG4yjufBcLvH5uSo/aTT7O6bNn9QHZVCLsIT29wyarpZpJngd/8oBg9s8OQLPPMD
GLxBHaVKjk+izpwHU88p
=Npp4
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.