Debian Bug report logs - #757758
dkms: moduleconfig_update_obsoletes calls sed without options

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Bernd Zeimetz <bzed@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dkms: moduleconfig_update_obsoletes calls sed without options

Date: Mon, 11 Aug 2014 08:28:40 +0200

Package: dkms
Version: 2.2.0.3-1.2
Severity: important

For the current open-vm-tools-dkms package, dkms calls
its own function moduleconfig_update_obsoletes(), but it does
not produce a proper sed command in the upper part, so that sed
fails more or less badly later.

+ moduleconfig_update_obsoletes /etc/modprobe.d/dkms.conf
/etc/modprobe.d/dkms /etc/modules.conf /etc/modprobe.conf
/etc/modprobe.d/open-vm-tools.conf /etc/sysconfig/kernel
+ [[ -n   ]]
+ local mod_diff
+ (( index=0 ))
+ (( index < 2 ))
+ [[ -n '' ]]
+ continue
+ (( index++ ))
+ (( index < 2 ))
+ [[ -n '' ]]
+ continue
+ (( index++ ))
+ (( index < 2 ))
+ for file in '"$@"'
+ [[ -n /etc/modprobe.d/dkms.conf ]]
+ [[ -w /etc/modprobe.d/dkms.conf ]]
+ [[ /etc/modprobe.d/dkms.conf = /etc/sysconfig/kernel ]]
+ sed /etc/modprobe.d/dkms.conf
sed: -e expression #1, char 6: unknown command: `m'


[.....]





-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dkms depends on:
ii  build-essential    11.6
ii  coreutils          8.21-1.2
ii  dpkg-dev           1.17.10
ii  gcc                4:4.9.1-1
ii  make               4.0-8
ii  module-init-tools  18-1
ii  patch              2.7.1-5

Versions of packages dkms recommends:
ii  fakeroot             1.20.1-1
ii  linux-headers-amd64  3.14+59
pn  linux-image          <none>
ii  menu                 2.1.47
ii  sudo                 1.8.9p5-1

dkms suggests no packages.

-- Configuration Files:
/etc/modprobe.d/dkms.conf changed [not included]

-- no debconf information

Message #10 received at 757758@bugs.debian.org (full text, mbox, reply):

From: Pedro Beja <althaser@gmail.com>

To: 757758@bugs.debian.org

Cc: bzed@debian.org

Subject: RE: #757758 - dkms: moduleconfig_update_obsoletes calls sed without options

Date: Mon, 11 Aug 2014 14:58:15 +0100

[Message part 1 (text/plain, inline)]

Hey,

I confirm this issue while installing the latest linux-headers:

"
Setting up linux-headers-3.16-trunk-common (3.16-1~exp1) ...

Setting up linux-kbuild-3.16 (3.16~rc7-1~exp1) ...
Setting up linux-headers-3.16-trunk-amd64 (3.16-1~exp1) ...
Examining /etc/kernel/header_postinst.d.
run-parts: executing /etc/kernel/header_postinst.d/dkms 3.16-trunk-amd64
sed: -e expression #1, char 6: unknown command: `m'

"


Version: 2.2.0.3-1.2


thanks
regards
althaser

[Message part 2 (text/html, inline)]

Message #17 received at 757758@bugs.debian.org (full text, mbox, reply):

From: François Grand <fgrand@igmm.cnrs.fr>

To: 757758@bugs.debian.org

Subject: probable bug location

Date: Mon, 25 Aug 2014 16:56:39 +0200

Looking for the problem source, I found a line in /usr/sbin/dkms, around 
line 765 :

sed "${sa_sck_o[@]}" "$file" > "$temp_dir_name/${file##*/}.new"

which produces the following output :

+ [[ -w /etc/modprobe.d/dkms.conf ]]
+ [[ /etc/modprobe.d/dkms.conf = /etc/sysconfig/kernel ]]
+ sed /etc/modprobe.d/dkms.conf
sed: -e expression #1, char 6: unknown command: `m'

Hope this helps.
Francois

Message #22 received at 757758@bugs.debian.org (full text, mbox, reply):

From: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>

To: 758485@bugs.debian.org, 757758@bugs.debian.org

Subject: Re: dkms: "sed: -e expression #1, char 6: unknown command: `m'" when installing nvidia

Date: Sun, 14 Sep 2014 15:34:07 +0200 (CEST)

[Message part 1 (text/plain, inline)]

Package: dkms
Version: 2.2.0.3-1.3
Tags: patch
Followup-For: Bug #758485

This is a Followup-For: Bug #757758 too.

The attached patch attempts to correct the error(s) and adds some
small code improvement.

The bottom line is the arrays 'sa_mc_o' and 'sa_sck_o' are empty and
`sed' is run without a script.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages dkms depends on:
ii  build-essential  11.7
ii  coreutils        8.23-2
ii  dpkg-dev         1.17.13
ii  gcc              4:4.9.1-4
ii  kmod             18-1
ii  make             4.0-8
ii  patch            2.7.1-6

Versions of packages dkms recommends:
ii  fakeroot             1.20.1-1.1
ii  linux-headers-amd64  3.16+60
pn  linux-image          <none>
ii  menu                 2.1.47
ii  sudo                 1.8.9p5-1

dkms suggests no packages.

-- Configuration Files:
/etc/modprobe.d/dkms.conf changed:


-- no debconf information

-- debsums errors found:
debsums: changed file /usr/sbin/dkms (from dkms package)


Cheers,

-- 
Cristian

[dkms.patch (text/x-diff, attachment)]

Message #27 received at 757758@bugs.debian.org (full text, mbox, reply):

From: James McCoy <jamessan@debian.org>

To: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>, 757758@bugs.debian.org

Subject: Re: Bug#757758: dkms: "sed: -e expression #1, char 6: unknown command: `m'" when installing nvidia

Date: Thu, 18 Sep 2014 22:15:27 -0400

[Message part 1 (text/plain, inline)]

Control: tag -1 patch
# system fails to fully boot due to built, but not installed modules
Control: severity -1 serious

On Sun, Sep 14, 2014 at 03:34:07PM +0200, Cristian Ionescu-Idbohrn wrote:
> The attached patch attempts to correct the error(s) and adds some
> small code improvement.
> 
> The bottom line is the arrays 'sa_mc_o' and 'sa_sck_o' are empty and
> `sed' is run without a script.

Thanks for the patch, Cristian.  I had a system that was booting into
maintenance mode because it couldn't find dkms-built modules and this
got things working again.

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan@debian.org>

[signature.asc (application/pgp-signature, inline)]

Message #36 received at 757758@bugs.debian.org (full text, mbox, reply):

From: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>

To: James McCoy <jamessan@debian.org>

Cc: 757758@bugs.debian.org, pkg-dkms-maint@lists.alioth.debian.org

Subject: Re: Bug#757758: dkms: sed: -e expression #1, char 6: unknown command: m when installing nvidia

Date: Fri, 19 Sep 2014 09:26:34 +0200 (CEST)

On Fri, 19 Sep 2014, James McCoy wrote:
>
> Control: tag -1 patch
> # system fails to fully boot due to built, but not installed modules
> Control: severity -1 serious
>
> On Sun, Sep 14, 2014 at 03:34:07PM +0200, Cristian Ionescu-Idbohrn wrote:
> > The attached patch attempts to correct the error(s) and adds some
> > small code improvement.
> >
> > The bottom line is the arrays 'sa_mc_o' and 'sa_sck_o' are empty and
> > `sed' is run without a script.
>
> Thanks for the patch, Cristian.  I had a system that was booting into
> maintenance mode because it couldn't find dkms-built modules and this
> got things working again.

You're most welcome James.  I'm glad the patch did help.

Let's hope the maintainers will soonish correct that dkms bug so that
noone else will have to experience the problems you did.
Unfortunately, things are moving slowly out there :(  And judging from
what `apt-get policy dkms' shows, both testing and unstable seem
affected.


Cheers,

-- 
Cristian

Message #43 received at 757758@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Iuculano <iuculano@debian.org>

To: 757758@bugs.debian.org,control@bugs.debian.org,757758-submitter@bugs.debian.org

Subject: [9064776] Fix for Bug#757758 committed to git

Date: Sat, 04 Oct 2014 17:30:02 +0000

tags 757758 + pending
thanks

Hello,

     The following change has been committed for this bug by
 Giuseppe Iuculano <iuculano@debian.org> on Sat, 4 Oct 2014 19:28:19 +0200.
 The fix will be in the next upload. 
=========================================================================
Fixed "sed without options" issue.

Closes: #757758
Thanks: Cristian Ionescu-Idbohrn
=========================================================================

You can check the diff of the fix at:

    ;a=commitdiff;h=9064776

Message #53 received at 757758-close@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Iuculano <iuculano@debian.org>

To: 757758-close@bugs.debian.org

Subject: Bug#757758: fixed in dkms 2.2.0.3-2

Date: Sat, 04 Oct 2014 18:18:37 +0000

Source: dkms
Source-Version: 2.2.0.3-2

We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 757758@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Giuseppe Iuculano <iuculano@debian.org> (supplier of updated dkms package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 04 Oct 2014 19:51:23 +0200
Source: dkms
Binary: dkms
Architecture: source all
Version: 2.2.0.3-2
Distribution: unstable
Urgency: low
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Giuseppe Iuculano <iuculano@debian.org>
Description:
 dkms       - Dynamic Kernel Module Support Framework
Closes: 659672 693634 735181 757758 761728 763929
Changes:
 dkms (2.2.0.3-2) unstable; urgency=low
 .
   * [49fccbc] Depends on kmod | kldutils (Closes: #761728)
   * [9064776] Fixed "sed without options" issue.
     Thanks to Cristian Ionescu-Idbohrn (Closes: #757758, 763929)
   * [1fa1a31] fixes have_one_kernel for non-zero return code.
     Thanks to Mario Limonciello (Closes: #659672, #735181)
   * [ba6140d] Added Multi-Arch: foreign.
     Thanks to Ben Hutchings (Closes: #693634)
Checksums-Sha1:
 0f2ca9be46e6dbc7fd923b1689f6b0327a687234 1957 dkms_2.2.0.3-2.dsc
 3505cf358926700f5a92bee9ee8541d9016b1f90 15132 dkms_2.2.0.3-2.debian.tar.xz
 8819f15ee9d70b89e8d833d200e09dbd94f3ab8d 70904 dkms_2.2.0.3-2_all.deb
Checksums-Sha256:
 d6b8d4fc98f017696f74fb78fabf324b36d307b6e6ddb6c96c50e80552c86512 1957 dkms_2.2.0.3-2.dsc
 fae90aa33ac8ec783ef1ee7d44e1dc4e337c5738b6f0ff0684218852a00c2fbb 15132 dkms_2.2.0.3-2.debian.tar.xz
 86e60e515d9f797bfb7baf1bebe41cbedd2b6d9569f3dfff51f55f49af54989f 70904 dkms_2.2.0.3-2_all.deb
Files:
 a86e1e553d28914fd36d16db80c213dd 70904 kernel optional dkms_2.2.0.3-2_all.deb
 fd6b2de9fdeacd304302353c478d8cef 1957 kernel optional dkms_2.2.0.3-2.dsc
 c521f0084dc8a0be0cac6198fabbb0b6 15132 kernel optional dkms_2.2.0.3-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUMDbBAAoJEI9hzo2UfbET8+QQAKZcejVmTwpYLxq/s5iqf2hu
fbyVsEt/LlmioEALTO1F3KvzHvw4DJq+faRwy1kP8T4twYMqvHWNHHCw9F8UqI2Z
Wi0etxwnqbZjb34YXGcLEcQizVcq2PKcAPVmI2it/O8Yg0zIM65hCiDaH8GsQEqc
laIbGECh6Hdf7eHKjIgjswvn2j1Vl87cqSkOvz+uodL4LonnaRIgABsb6iTcXkmk
npWxHfDCvQxaflOHjKtSlPOReqYW+Zc7CPeTRmDHwCcX35o0WQlyeVm/NsEjC38M
eXqkKJF3CuKO2EdsNsHzkz0dnCekZDK8C0txvg+PTUXysgTQagYVvmdPhyKEs8kt
KteC/GWPtGP+1cRC2MTA4RfRS28tnnGul6saTHhV6aS/tZYp1Akb1r9d3bfgBXpg
3JNVwTWTmvh7UIEF78N0+vANLnH/adQThAAY4kq6QfA2h5WExrIlRi7o6cxR7e7j
kAml7DwKhoIlKQ8HcGqBw2ikihE3Bdp9UoMHKs4S9fgxBhGz0sAGbaDM+pOzyeh6
Hz6a+K4NNo3WGAbnFY2YZHXj+yShVnKG+XFHQ4B0p+r5e+T1tUN1GtFuJ3D+6QpC
leRxjPK1UqwZLxUiEYxNlrNHOhmQyFNJbxvIZyuCSaskOgy6uVAKU2KA+PF0r2x2
9Du0sVckNAd/EATltg+H
=/z47
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.