Debian Bug report logs - #752845
policyd-weight: recent libnet-dns-perl upgrade has broken policyd-weight.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: James Cloos <cloos@jhcloos.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: policyd-weight: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Thu, 26 Jun 2014 22:22:38 +0000

Package: policyd-weight
Version: 0.1.15.2-7
Severity: grave
Justification: renders package unusable

Policyd started generating bogus scores.  After a restart it generates errors
like this:

postfix/policyd-weight[26689]: warning: child: err: Undefined subroutine &main::dn_expand called at /usr/sbin/policyd-weight line 3590, <GEN33> line 26.#012

that results in the mail getting refused.

main::dn_expand is from:
use Net::DNS::Packet qw(dn_expand);

The dn_expand() in /usr/lib/perl5/Net/DNS/Packet.pm is commented out.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages policyd-weight depends on:
ii  adduser                  3.113+nmu3
ii  libio-socket-inet6-perl  2.72-1
ii  libnet-dns-perl          0.77-3
ii  libnet-ip-perl           1.26-1
ii  lsb-base                 4.1+Debian13
ii  perl                     5.18.2-4

Versions of packages policyd-weight recommends:
ii  perl [libsys-syslog-perl]  5.18.2-4

policyd-weight suggests no packages.

-- no debconf information

Message #10 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Ondřej Surý <ondrej@debian.org>

To: Werner Detter <werner@aloah-from-hell.de>, 752845@bugs.debian.org

Subject: Re: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Fri, 27 Jun 2014 09:05:52 +0200

Hi Werner,

Yes, dn_expand is netdns_dn_expand, but the renaming happened in 0.51_02
in 2005.

> Fix rt.cpan.org 13243 and 13191
> 
>    The escaped characters test failed on some system because the
>     the systems dn_expand instead of the supplied dn_expand
>     was used after the makemaker magic linked DNS.xs.
> 
>     This was fixed by renaming the dn_expand that comes with the
>     library to netdns_dn_expand.

When you provide a fixed version of policyd-weight, please, supply
me with fixed version and I'll add appropriate Breaks: to
libnet-dns-perl
package, so users won't get broken package on partial upgrades.

Cheers,
Ondrej

On Fri, Jun 27, 2014, at 08:24, Werner Detter wrote:
> Hi,
> 
> seems like as if dn_expand has been renamed to netdns_dn_expand
> 
> Regards,
> Werner
> 
> Am 27.06.14 08:18, schrieb Werner Detter:
> > Hi,
> > 
> > you've recently updated the libnet-dns-perl package which has broken
> > policyd-weight in unstable:
> > 
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752845
> > 
> > Could you please check. policyd-weight uses dn_expand which is
> > commented out in /usr/lib/perl5/Net/DNS/Packet.pm
> > 
> > Thanks for your reply,
> > Werner Detter
> > 
> 


-- 
Ondřej Surý <ondrej@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server

Message #15 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: Ondřej Surý <ondrej@debian.org>, 752845@bugs.debian.org

Subject: Re: Bug#752845: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Fri, 27 Jun 2014 15:54:50 +0200

Hi Ondřej,

thanks for your response. I'll get back to you as soon as I've got a
fixed package with usage of netdns_dn_expand instead of dn_expand
ready.

Thanks,
Werner


Am 27.06.14 09:05, schrieb Ondřej Surý:
> Hi Werner,
> 
> Yes, dn_expand is netdns_dn_expand, but the renaming happened in 0.51_02
> in 2005.
> 
>> Fix rt.cpan.org 13243 and 13191
>>
>>    The escaped characters test failed on some system because the
>>     the systems dn_expand instead of the supplied dn_expand
>>     was used after the makemaker magic linked DNS.xs.
>>
>>     This was fixed by renaming the dn_expand that comes with the
>>     library to netdns_dn_expand.
> 
> When you provide a fixed version of policyd-weight, please, supply
> me with fixed version and I'll add appropriate Breaks: to
> libnet-dns-perl
> package, so users won't get broken package on partial upgrades.
> 
> Cheers,
> Ondrej
> 
> On Fri, Jun 27, 2014, at 08:24, Werner Detter wrote:
>> Hi,
>>
>> seems like as if dn_expand has been renamed to netdns_dn_expand
>>
>> Regards,
>> Werner
>>
>> Am 27.06.14 08:18, schrieb Werner Detter:
>>> Hi,
>>>
>>> you've recently updated the libnet-dns-perl package which has broken
>>> policyd-weight in unstable:
>>>
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752845
>>>
>>> Could you please check. policyd-weight uses dn_expand which is
>>> commented out in /usr/lib/perl5/Net/DNS/Packet.pm
>>>
>>> Thanks for your reply,
>>> Werner Detter
>>>
>>
> 
> 

Message #20 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: Ondřej Surý <ondrej@debian.org>, 752845@bugs.debian.org

Subject: Re: Bug#752845: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Fri, 27 Jun 2014 21:10:20 +0200

Hi everybody, 

I've tried to build a new package with the mentioned replacement function 
"netdns_dn_expand", but unfortunately I still get the same error: 

Jun 27 20:23:31 smaint postfix/policyd-weight[19518]: warning: child: err: Undefined subroutine &main::netdns_dn_expand called at /usr/sbin/policyd-weight line 3590, <GEN9> line 26.#012

So, this indicates that there is no such function available. I've digged a 
little deeper into this and it seems like dn_expand is gone since Net-DNS-0.73,
relased on 29th November 2003, the changelog[1] mentiones:

-- cut --
Fix rt.cpan.org 13243 and 13191 

    The escaped characters test failed on some system because the 
    the systems dn_expand instead of the supplied dn_expand 
    was used after the makemaker magic linked DNS.xs.

    This was fixed by renaming the dn_expand that comes with the
    library to netdns_dn_expand.
-- cut --

It seems like upstream authors of Net-DNS removed dn_expand but did not add the
replacement function to the netdns_dn_expand to the perl module. 

*) dn_expand available:
http://search.cpan.org/~nlnetlabs/Net-DNS-0.72/lib/Net/DNS/Packet.pm

*) dn_expand not available, nor netdns_dn_expand
http://search.cpan.org/~nlnetlabs/Net-DNS-0.73/lib/Net/DNS/Packet.pm

This makes it hart to add a fix to policyd-weight :)

@Ondřej
Could you please ask upstream/report the issue? 

Thank you,
Werner Detter

[1] Changelog
http://cpansearch.perl.org/src/NLNETLABS/Net-DNS-0.73/Changes

[2] Version Overview
http://search.cpan.org/~nlnetlabs/Net-DNS-0.72/
http://search.cpan.org/~nlnetlabs/Net-DNS-0.73/

Message #25 received at 752845@bugs.debian.org (full text, mbox, reply):

From: James Cloos <cloos@jhcloos.com>

To: Werner Detter <werner@aloah-from-hell.de>

Cc: 752845@bugs.debian.org

Subject: Re: Bug#752845: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Fri, 27 Jun 2014 18:01:34 -0400

I see that there is a dn_expand_PP method; perhaps having policyd-weight
call that explicitly might work?

The dn_expand method in /usr/lib/perl5/Net/DNS/Packet.pm is:

sub dn_expand {
#FYI    my ($packet, $offset) = @_;
        return dn_expand_XS(@_) if $Net::DNS::HAVE_XS;
#       warn "USING PURE PERL dn_expand()\n";
        return dn_expand_PP(@_, {} );   # $packet, $offset, anonymous hash
}

so it should work, albeit slower than it used to.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6

Message #30 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: James Cloos <cloos@jhcloos.com>, 752845@bugs.debian.org

Subject: Re: Bug#752845: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Sat, 28 Jun 2014 09:55:53 +0200

Hi,

I've prepared a new package, please test:

wget http://www.werner-detter.de/policyd-weight_0.1.15.2-8_all.deb

Cheers,
Werner

Message #35 received at 752845@bugs.debian.org (full text, mbox, reply):

From: James Cloos <cloos@jhcloos.com>

To: Werner Detter <werner@aloah-from-hell.de>

Cc: 752845@bugs.debian.org

Subject: Re: Bug#752845: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Sat, 28 Jun 2014 08:55:44 -0400

>>>>> "WD" == Werner Detter <werner@aloah-from-hell.de> writes:

WD> I've prepared a new package, please test:
WD> wget http://www.werner-detter.de/policyd-weight_0.1.15.2-8_all.deb

It works.

Your patch matches what I tried after sending my last note.

It is slow for un-cached senders, but those tend to be more rare than
repeat senders.  And I'd have to bring up a test box to see whether
using the XS version, as it used to, also was slow for un-cached.

I guess "ship it" is the idiom of the day. ;^)

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6

Message #40 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: James Cloos <cloos@jhcloos.com>, 752845@bugs.debian.org

Subject: Re: Bug#752845: recent libnet-dns-perl upgrade has broken policyd-weight.

Date: Sat, 28 Jun 2014 17:59:39 +0200

Hi JimC,

> It works.

I've just created a new RFS request, policyd-weight package should be
uploaded soon. Thanks for your bugreport and testing.

Cheers,
Werner

Message #45 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Willem Toorop <willem@nlnetlabs.nl>

To: 752845@bugs.debian.org

Subject: decode Net::DNS::DomainName

Date: Tue, 01 Jul 2014 22:11:39 +0200

Hi Werner,

Net::DNS::DomainName::decode is the "official" replacement for
Net::DNS::Packet::dn_expand:

  $object = decode Net::DNS::DomainName( \$buffer, $offset, $hash );

( $object, $next ) = decode Net::DNS::DomainName(
                                         \$buffer, $offset, $hash );

Creates a domain name object which represents the DNS domain name
identified by the wire-format data at the indicated offset within the
data buffer.

The argument list consists of a reference to a scalar containing the
wire-format data and specified offset. The optional reference to a hash
table provides improved efficiency of decoding compressed names by
exploiting already cached compression pointers.

The returned offset value indicates the start of the next item in the
data buffer.

Cheers,

-- Willem

PS.  You might want to subscribe to our users list at
http://nlnetlabs.nl/mailman/listinfo/net-dns-users .  We announce
release candidates for Net::DNS and Net::DNS::SEC on it so you can try
them out and make sure backwards compatibility isn't broken.

Message #50 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: Willem Toorop <willem@nlnetlabs.nl>, 752845@bugs.debian.org

Subject: Re: Bug#752845: decode Net::DNS::DomainName

Date: Wed, 02 Jul 2014 20:57:35 +0200

Hi Willem, 

thanks for your answer/reply on this issue and pointing out the "offical"
replacement for "dn_expand()". In the long run it probably would make sense
using Net::DNS::DomainName::decode but this requires some more changes to 
policyd-weight. I've replaced obsolete "dh_expand()" function with 
"Net::DNS::Packet::dn_expand_PP()" which fixes problems in policyd-weight
for the latest libnet-dns-perl package.

Cheers,
Werner

Message #55 received at 752845@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: 752845@bugs.debian.org

Subject: RFS - policyd-weight/0.1.15.2-8 (fixes broken policyd-weight in unstable/testing rc bug #752845)

Date: Sat, 05 Jul 2014 09:52:11 +0200

Package: sponsorship-requests
Severity: important

Hi everybody,

currently, policyd-weight is broken in unstable/testing due to recent libnet-dns-perl upgrade,
technically speaking policyd-weight used Net::DNS::Packet function dh_expand() which does not exist 
anymore. This upgrade fixes policyd-weight, policyd-weight now uses Net::DNS::Packet function 
dh_expand_PP().

 * Package name    : policyd-weight
   Version         : 0.1.15.2-8
   Upstream Author : Robert Felber
 * URL             : www.policyd-weight.org
 * License         : GPL-2+
   Section         : mail

Changes:

  * Add 10_replace_net_dns_dn_expand.patch which replaces Net::DNS::Packet
    function dh_expand() with dh_expand_PP() (Closes: #752845)
  * Fixed description in 09_fix_net_dns_usage.patch

It builds those binary packages:
policyd-weight - Perl policy daemon for the Postfix MTA

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/policyd-weight

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/p/policyd-weight/policyd-weight_0.1.15.2-8.dsc

It would be great if you could upload this package for me.

Cheers,
Werner Detter

Message #60 received at 752845-close@bugs.debian.org (full text, mbox, reply):

From: Werner Detter <werner@aloah-from-hell.de>

To: 752845-close@bugs.debian.org

Subject: Bug#752845: fixed in policyd-weight 0.1.15.2-8

Date: Sun, 13 Jul 2014 18:34:22 +0000

Source: policyd-weight
Source-Version: 0.1.15.2-8

We believe that the bug you reported is fixed in the latest version of
policyd-weight, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 752845@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Werner Detter <werner@aloah-from-hell.de> (supplier of updated policyd-weight package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 28 Jun 2014 09:28:19 +0100
Source: policyd-weight
Binary: policyd-weight
Architecture: source all
Version: 0.1.15.2-8
Distribution: unstable
Urgency: low
Maintainer: Werner Detter <werner@aloah-from-hell.de>
Changed-By: Werner Detter <werner@aloah-from-hell.de>
Description:
 policyd-weight - Perl policy daemon for the Postfix MTA
Closes: 752845
Changes:
 policyd-weight (0.1.15.2-8) unstable; urgency=low
 .
   * Add 10_replace_net_dns_dn_expand.patch which replaces Net::DNS::Packet
     function dh_expand() with dh_expand_PP() (Closes: #752845)
   * Fixed description in 09_fix_net_dns_usage.patch
Checksums-Sha1:
 3d64d674f13b3948aba72fdb6bab25e50ecd6509 1766 policyd-weight_0.1.15.2-8.dsc
 6627b36735862372077cd0ba18ab7e308bb7b468 9888 policyd-weight_0.1.15.2-8.debian.tar.xz
 ba5eb8f99269185fee02af884d8d650587b9d7db 50732 policyd-weight_0.1.15.2-8_all.deb
Checksums-Sha256:
 1fb3fbfda8a3ecfac8c1de1d692d0347e6169a0a8fc4096966bed11066b081a6 1766 policyd-weight_0.1.15.2-8.dsc
 6e4ba4cf857e1290cb8f842ed09cb1d4f84a3b452d7785fa6391292ab38a4146 9888 policyd-weight_0.1.15.2-8.debian.tar.xz
 d383c8b59566fd76b183d4977e6443816d1f60026614c55e2706b8459552ed28 50732 policyd-weight_0.1.15.2-8_all.deb
Files:
 4de77c9dc2373cc9d5c2618f62777c39 50732 mail optional policyd-weight_0.1.15.2-8_all.deb
 91b2c1bf374f167680156d42ddc15d93 1766 mail optional policyd-weight_0.1.15.2-8.dsc
 0d9fc62dc13c31d3195f8a312f13bc12 9888 mail optional policyd-weight_0.1.15.2-8.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJTwtBaAAoJEMcrUe6dgPNtF+EQAIqS2QC7Zfh2diKon7CIrLvA
vXsry7FH7BbVQaeBhzQXhnMxGB+uisUkare1w4IfzUR1aULOLSFlfEP9jm+ecEkE
rUxfoXah5foa+xL16C275k1Ltjivo88JL7sJ95/R9duxJLKGCobhn6+o4XKuI7My
z/3soF0kw44CSaRbYPKIgdt96bAx8AgeM6T/uymGf+B54QKljgdn1remq4cJB9IB
71WrhUYuv4i8n6LPEdvz2Ob+Eeh6+jojzyzfdSNG4/YWnuq7MUJbPXhzmliOPDI5
wEgJ46zPzM9qJa0wgopdVtidCs2/G1HAVtcnZAtrv9DUobcN7t8+Uq5kD3rKDUSv
56IqwWO7Vl007An+H65F1nesqfOrET5uj6XxUwUVQfMke2/lnBLvgmv0eJUP3VbH
5EZpEwiD6fBqiWbUil8uz2015MKRnVHiya6pHtnU+dB25yiEonnuPRS8y52v4e22
W0HDTR7/tG/zG51XOvNH18S0K9PKHtxVHAwK3MdcILj7psZHcPEfltwiAVzI2IGs
WnDecMVUKqJswZme0sP1LHECrO6bDhcBhlWS1mNtzgS5xoEARGDwrXGO/Zz3inNR
aO13RsXOBkUumFtbaklgescsgHYx4VzoaiQp+GhD9yj15eXPAjNjgHJcQ9LpRVN0
HNNk2hKYCbtulyC7gXQU
=u+f6
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.