Debian Bug report logs - #751510
rott: Conflicting types of variable inverse_mouse to cause undefined behaviour

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Tautschnig <mt@debian.org>

To: submit@bugs.debian.org

Subject: rott: Conflicting types of variable inverse_mouse to cause undefined behaviour

Date: Fri, 13 Jun 2014 15:30:50 +0100

[Message part 1 (text/plain, inline)]

Package: rott
Version: 1.1.2-1
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
cc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -DDATADIR=\"/usr/share/games/rott/\" -Wno-pointer-sign -Wno-unused -Wall -Wno-unused -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -Wl,-z,relro  cin_actr.o cin_efct.o cin_evnt.o cin_glob.o cin_main.o cin_util.o dosutil.o engine.o isr.o modexlib.o rt_actor.o rt_battl.o rt_build.o rt_cfg.o rt_crc.o rt_com.o rt_debug.o rt_dmand.o rt_door.o rt_draw.o rt_floor.o rt_game.o rt_in.o rt_main.o rt_map.o rt_menu.o rt_msg.o rt_net.o rt_playr.o rt_rand.o rt_scale.o rt_sound.o rt_spbal.o rt_sqrt.o rt_stat.o rt_state.o rt_str.o rt_swift.o rt_ted.o rt_util.o rt_view.o rt_vid.o rt_err.o scriplib.o w_wad.o watcom.o z_zone.o byteordr.o dukemusc.o winrott.o audiolib/audiolib.a -L/usr/lib/x86_64-linux-gnu -lSDL -lSDL_mixer  -o rott-shareware

file rt_menu.c line 5362: error: conflicting types for variable "inverse_mouse"
old definition in module rt_cfg file rt_cfg.c line 113
signed int
new definition in module rt_menu file rt_menu.c line 5362
signed long int
Makefile:91: recipe for target 'rott-shareware' failed
make[2]: *** [rott-shareware] Error 64
make[2]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-rott/rott-1.1.2/rott'
dh_auto_build: make -j1 ROTT=rott-shareware returned exit code 2
debian/rules:10: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2

It seems the declaration here

http://sources.debian.net/src/rott/1.1.2-1/rott/rt_menu.c?hl=5362#L5362

should be adjusted to match the actual definition here:

http://sources.debian.net/src/rott/1.1.2-1/rott/rt_cfg.c?hl=113#L113

As is, any access to inverse_mouse in rt_menu.c will have undefined behaviour as
either the wrong bytes will be updated or invalid memory will be accessed.

Best,
Michael

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 751510@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: Michael Tautschnig <mt@debian.org>, 751510@bugs.debian.org

Cc: control <control@bugs.debian.org>

Subject: Re: Bug#751510: rott: Conflicting types of variable inverse_mouse to cause undefined behaviour

Date: Mon, 16 Jun 2014 10:00:16 +0200

tags 751510 +pending
thanks

Message #17 received at 751510@bugs.debian.org (full text, mbox, reply):

From: Fabian Greffrath <fabian@greffrath.com>

To: Michael Tautschnig <mt@debian.org>, 751510@bugs.debian.org

Cc: control <control@bugs.debian.org>

Subject: Re: Bug#751510: rott: Conflicting types of variable inverse_mouse to cause undefined behaviour

Date: Mon, 16 Jun 2014 10:26:00 +0200

forwarded 751510 https://svn.icculus.org/rott?view=rev&revision=278
thanks

Message #24 received at 751510-close@bugs.debian.org (full text, mbox, reply):

From: Stephen Kitt <skitt@debian.org>

To: 751510-close@bugs.debian.org

Subject: Bug#751510: fixed in rott 1.1.2-2

Date: Wed, 18 Jun 2014 05:33:43 +0000

Source: rott
Source-Version: 1.1.2-2

We believe that the bug you reported is fixed in the latest version of
rott, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 751510@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stephen Kitt <skitt@debian.org> (supplier of updated rott package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 18 Jun 2014 07:14:21 +0200
Source: rott
Binary: rott
Architecture: source amd64
Version: 1.1.2-2
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Stephen Kitt <skitt@debian.org>
Description:
 rott       - SDL-Port of Rise of the Triad
Closes: 700977 751510
Changes:
 rott (1.1.2-2) unstable; urgency=low
 .
   * Team upload.
 .
   [ Fabian Greffrath ]
   * Remove "Recommends: timidity" and the corresponding advice in
     debian/README.Debian. Installing any package containing a soundfont
     should be sufficient for music playback to work (see #498984).
   * Run "wrap-and-sort -asb".
   * Fix a segfault in the Darian level, original bug report and patch
     by Luc Habert (Closes: #700977).
   * Color crosshair by player health.
   * Replace the icon with a self-drawn alternative in three different
     formats and provide a reproduction rule in debian/rules.
   * Enable parallel builds.
   * Correctly append to CFLAGS in debian/rules.
   * Fix conflicting types in variable declarations (Closes: #751510),
     thanks Michael Tautschnig.
 .
   [ Stephen Kitt ]
   * Drop obsolete Lintian override; rott-sitelicense is no longer
     detected as an extra license file.
   * Use the canonical 1.0 copyright format URI.
   * Standards-Version 3.9.5, no further change required.
Checksums-Sha1:
 2c715e6b44b978e0501f3ea704a217b58e36466a 1965 rott_1.1.2-2.dsc
 8f6cb6c154646adc3856911f94e3ad26a8718420 14992 rott_1.1.2-2.debian.tar.xz
 a3b655738da69176cb4f70887c91d8b6fc16b838 486504 rott_1.1.2-2_amd64.deb
Checksums-Sha256:
 d7bf991055065c205febc54c0b90562865ee910a82198d903fb595ce659b45c0 1965 rott_1.1.2-2.dsc
 e488c8e5a92225f684e411f13ed877798ff81b82c2b044c7f8fab399784b8107 14992 rott_1.1.2-2.debian.tar.xz
 c67365649dd262a067b934f982a0691fb9fcd569c5aed0089932c8b2d74d746f 486504 rott_1.1.2-2_amd64.deb
Files:
 1a723c98dea26331ccc64678cec0ced5 486504 contrib/games optional rott_1.1.2-2_amd64.deb
 fb410d4a7558c4dec4225473a6f2dc19 1965 contrib/games optional rott_1.1.2-2.dsc
 baec2518f01031a2f9a82aba6ca19670 14992 contrib/games optional rott_1.1.2-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJToSEWAAoJEHWXeKmja0lP0eEQAJwFFVd1j/4NPoxnHUSjGMl2
VdTA2g9P9XXPm1oznmH3VrnF6/JXLLGCbsJG/F6sF8sQVou5IgAbDJub3aE9X1Nj
IpMtnup+ftd+Z42IvZVfMpPR6s0tk9/qPvxnC3T2OTocXXZAybdLtVq8MTaiTonz
rPjzRF7PRqvtlc4hiupnSDvjIjMfz2A2j/u/tPMRtycOhQEqjQXzSs6x9L6Ncua7
tmf0bJqcsD3OnnCh5uKwSKONZQ2ZFum84t0Cbui8VrLNuK3jVmgE6yk1haFSQVia
PA5s5UxjiNJLRa/VYNx0KzQaz4tGWEEKt3c8tB+m/Y0u+dYzBV8bsmpH9P0eniGm
r+nKdR56qO28er1g7JgrQptJSMIBMHKrJoZwylocPMK2ruPb7Sbmtm9HjN0+uF/t
spOc+SFMuxFCqrqdrnH92z59LHjJI9Irdto0golbEDIqoNsCYMFZEf2FIoxHVe/X
Giiu10cNMYdz/yaapx6Dwm9fPTyctqnp7NYyPgq7nZLT/W3A4qw4feOpX+DVgJO5
ZlJo0jQxkIo6N+KcqIN8nHBKFi/oNHaf/agOjjZn2dfCff93xmpWRRUMBZeneamo
qtYH5rPFk+GR6g0TsIu6tvgRn+iccTTGLGb+iX+p87HiRpR4g3ojrDzVEan+Uf1n
b0FATz7scnwTX55N1z+A
=1HYY
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.