Debian Bug report logs - #751121
Please fix "FIXME" statements in copyright file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Luca Falavigna <dktrkranz@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Please fix "FIXME" statements in copyright file

Date: Tue, 10 Jun 2014 16:40:39 +0200

Source: netatalk
Version 2.2.2-1
Severity: serious
Tags: jessie sid


Your debian/copyright file contains lots of FIXMEs.

For example there is an entry for
  distrib/initscripts/rc.atalk.suse.tmpl
but this file does not exist. The corresponding file
  distrib/initscripts/rc.atalk.suse-sysv.tmpl
contains just the line:
 Copyright (c) 1996-2001 SuSE GmbH Nuernberg, Germany.  All rights reserved.
How do you know that Debian is allowed to distribute it?

Message #14 received at 751121@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: 751121@bugs.debian.org

Subject: Re: Bug#751121: Please fix "FIXME" statements in copyright file

Date: Mon, 20 Oct 2014 19:55:35 +0200

[Message part 1 (text/plain, inline)]

tags 751121 -jessie -sid
seen 751121 2.1.2-2
thanks

Quoting Luca Falavigna (2014-06-10 16:40:39)
> Source: netatalk
> Version 2.2.2-1
> Severity: serious
> Tags: jessie sid
> 
> 
> Your debian/copyright file contains lots of FIXMEs.
> 
> For example there is an entry for
>   distrib/initscripts/rc.atalk.suse.tmpl
> but this file does not exist. The corresponding file
>   distrib/initscripts/rc.atalk.suse-sysv.tmpl
> contains just the line:
>  Copyright (c) 1996-2001 SuSE GmbH Nuernberg, Germany.  All rights reserved.
> How do you know that Debian is allowed to distribute it?

I agree that this is a problem.  It is not new, however - adjusting 
hints accordingly.

If this makes netatalk unfit for next stable release, then I believe the 
package should also be removed from older releases of Debian.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 751121@bugs.debian.org (full text, mbox, reply):

From: Emilio Pozuelo Monfort <pochu@debian.org>

To: 751121@bugs.debian.org, Jonas Smedegaard <dr@jones.dk>, Luca Falavigna <dktrkranz@debian.org>

Subject: Re: Please fix "FIXME" statements in copyright file

Date: Wed, 18 Nov 2015 16:26:17 +0100

On Tue, 10 Jun 2014 16:40:39 +0200 Luca Falavigna <dktrkranz@debian.org> wrote:
> Source: netatalk
> Version 2.2.2-1
> Severity: serious
> Tags: jessie sid
> 
> 
> Your debian/copyright file contains lots of FIXMEs.
> 
> For example there is an entry for
>   distrib/initscripts/rc.atalk.suse.tmpl
> but this file does not exist. The corresponding file
>   distrib/initscripts/rc.atalk.suse-sysv.tmpl
> contains just the line:
>  Copyright (c) 1996-2001 SuSE GmbH Nuernberg, Germany.  All rights reserved.
> How do you know that Debian is allowed to distribute it?

netatalk-3.1.7 ships rc.suse.tmpl, which no longer contains that sentence.

However I found a couple of files with similar sentences and no further licensing:

include/atalk/dsi.h
include/atalk/server_child.h

Those say:

 * Copyright (c) 1997 Adrian Sun (asun@zoology.washington.edu)
 * All rights reserved.

Everything else is either appropriately licensed, generated file, or contains no
claims at all.

Cheers,
Emilio

Message #34 received at 751121@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Emilio Pozuelo Monfort <pochu@debian.org>, 751121@bugs.debian.org

Cc: Luca Falavigna <dktrkranz@debian.org>

Subject: Re: [Pkg-netatalk-devel] Bug#751121: Please fix "FIXME" statements in copyright file

Date: Wed, 25 Nov 2015 20:06:40 +0100

[Message part 1 (text/plain, inline)]

Hi Emilio,

Thanks!  Your help addressing this issue is very much appreciated.

Quoting Emilio Pozuelo Monfort (2015-11-18 16:26:17)
> On Tue, 10 Jun 2014 16:40:39 +0200 Luca Falavigna <dktrkranz@debian.org> wrote:
>> Your debian/copyright file contains lots of FIXMEs.

Above is the issue tracked by this bugreport.

>> For example there is an entry for
>>   distrib/initscripts/rc.atalk.suse.tmpl

Above is a single _example_ of the larger issue.


> netatalk-3.1.7 ships rc.suse.tmpl, which no longer contains that 
> sentence.
>
> However I found a couple of files with similar sentences and no 
> further licensing:
> 
> include/atalk/dsi.h
> include/atalk/server_child.h
> 
> Those say:
> 
>  * Copyright (c) 1997 Adrian Sun (asun@zoology.washington.edu)
>  * All rights reserved.
> 
> Everything else is either appropriately licensed, generated file, or 
> contains no claims at all.

Your new analysis above now needs to be correlated with the existing 
analysis on which this bugreport was filed: The files marked in 
debian/copyright as "FIXME": 
https://codesearch.debian.net/results/FIXME%20package:netatalk%20path:debian%2Fcopyright$


Kind regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 751121@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: 751121@bugs.debian.org

Subject: Re: Bug#751121: Please fix "FIXME" statements in copyright file

Date: Fri, 26 Aug 2016 20:13:26 +0200

[Message part 1 (text/plain, inline)]

Quoting Luca Falavigna (2014-06-10 16:40:39)
> Your debian/copyright file contains lots of FIXMEs.

Status update: Most FIXMEs have been addressed now, through analysis of 
the history of those files (documented as comments for each file in 
debian/copyright).


Remaining are 2 FIXMEs.

One is this:

> For example there is an entry for
>   distrib/initscripts/rc.atalk.suse.tmpl
> but this file does not exist. The corresponding file
>   distrib/initscripts/rc.atalk.suse-sysv.tmpl
> contains just the line:
>  Copyright (c) 1996-2001 SuSE GmbH Nuernberg, Germany.  All rights reserved.
> How do you know that Debian is allowed to distribute it?

...which is dropped in later upstream releases, so will go away when we 
upgrade.

Last remaining issue is this: etc/afpd/fce_api.c

That one I have now passed upstream: 
https://github.com/Netatalk/Netatalk/issues/74


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

[signature.asc (application/pgp-signature, inline)]

Message #46 received at 751121-close@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: 751121-close@bugs.debian.org

Subject: Bug#751121: fixed in netatalk 2.2.5-2

Date: Tue, 10 Jan 2017 15:07:53 +0000

Source: netatalk
Source-Version: 2.2.5-2

We believe that the bug you reported is fixed in the latest version of
netatalk, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 751121@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <dr@jones.dk> (supplier of updated netatalk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 10 Jan 2017 15:29:57 +0100
Source: netatalk
Binary: netatalk netatalk-dbg
Architecture: source
Version: 2.2.5-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Netatalk team <pkg-netatalk-devel@lists.alioth.debian.org>
Changed-By: Jonas Smedegaard <dr@jones.dk>
Description:
 netatalk   - AppleTalk user binaries
 netatalk-dbg - Debug symbols for netatalk
Closes: 751121 760111 760112
Changes:
 netatalk (2.2.5-2) unstable; urgency=medium
 .
   [ Adrian Knoth ]
   * Add patch to source init functions in init.d script.
   * Bump debhelper compatibility level to 9.
 .
   [ Brian Campbell ]
   * Add myself to uploaders
 .
   [ Chris Boot ]
   * Add myself to uploaders
 .
   [ Jonas Smedegaard ]
   * Address most FIXMEs.
   * Update watch file:
     + Bump to version 4.
     + Track any release (not only 2.x).
     + Mention gpb --uscan in usage comment.
   * Stop track upstream source with CDBS (use gpb --uscan).
   * Update git-buildpackage config: Filter any .gitignore file.
   * Modernize CDBS:
     + Build-depend on licensecheck (not devscripts).
     + Tighten binary package relations to be package-specific.
   * Declare compliance with Debian Policy 3.9.8.
   * Update copyright info:
     + Resolve remaining FIXMEs.
       Closes: Bug#751121. Thanks to Luca Falavigna.
     + Use License-Grant and License-Reference fields.
       Thanks to Ben Finney.
     + Clarify vaguely ORed license pair.
     + Re-label to use SPDX license shortnames FSFUL FSFULLR X11.
     + Extend coverage of Debian packaging.
   * Add lintian override regarding license in License-Reference field.
     See bug#786450.
   * Drop example script to convert from netatalk 2.0.4~beta2-4 and
     earlier: needed package db4.2-util no longer available.
     Stop suggest db4.2-util.
   * Fix version in NEWS entry.
   * Add patches cherry-picked upstream, including ASP/DDP fixes.
     Closes: Bug#760111, #760112. Thanks to Vincent Duvert.
   * Fix stop build-depend on d-shlibs.
Checksums-Sha1:
 010ff916c2376f816ab0e3dbe1d8a44fac7cf2db 2262 netatalk_2.2.5-2.dsc
 866509bc8953d5613a1f1bcbd9d5937aa273b3b3 48124 netatalk_2.2.5-2.debian.tar.xz
Checksums-Sha256:
 4a608fb3850c872f1cf58ad0918283caa6c7583c49c6ac679e83f75245a84c95 2262 netatalk_2.2.5-2.dsc
 d118e7f894cb0ae9b4aed2f5d2545bd0fdf681bba25d45751efa6f4b36f7d64f 48124 netatalk_2.2.5-2.debian.tar.xz
Files:
 21b2ccca7b14de700015da24afd55055 2262 net extra netatalk_2.2.5-2.dsc
 950b3d9365c6b62f740e00210fe745c6 48124 net extra netatalk_2.2.5-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJYdPDxAAoJECx8MUbBoAEheIoP/3HmBpU1uQC+hgwtQmwDzYT+
A+XeRnyB3FGI14+h1nub0TpY6mLy0v8RvhFde2dMKIBNoQHXsNzO8VjraxhH5AXH
ZKVW5Gq8BRdbRj+IcD4sm3+T/yLDorGe0nYa7PafCO7M2L7aJBP+DzK33yY3IcWp
uFQe11hHKeaYA0i2uNsONzkCY2Dok9gs4GYwhquV1ZlV24AVswQnxiA5gpoiJjhf
Rz78m7v66wj3AN3hgwB3ul7uJRged4fyzyaE0nBWyyrltBK0DsE6Qyb9OKpaaTyh
UiVmpR3Z06aOXXi/yey+PNTCpwYC8QxwZfUVV23/ssgcJ9nCDj/1yaHN5L/MbFf6
KvPnMbsNQD139fKMPCqIKvQmH1aFCXynC/7AZ/glSJueyHfTtdosikriDqOiP+d7
Ydb4qr/LlJ+txx97sYo7GHxFtWzKgwf+rF8jQDkU1uFOYTARL1hB1evi5/DHHeRB
Qdd7UAIA05GHijyOJLDHh/KNP7ErCe8pqToJus2hKgJzjpryzh8anDHetG21thRw
G4QXgLlIcYda0SENvk8190jNtXS5dgfMVDAIhoDhG+gbLr/WWN03uKGi5nnYvtNH
KsNRagiYYwdIDmyIbA8piiskcWyLX8ZqY5v8nFZ+URBkua4ulKqIR6T0THGEnSFY
azYgSB9boS1xUOQICiTB
=TEpt
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.