Debian Bug report logs - #749659
audacity: Please update to use wxwidgets3.0

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: audacity: Please update to use wxwidgets3.0

Date: Thu, 29 May 2014 10:52:30 +1200

Source: audacity
Version: 2.0.5-1
Severity: normal
User: freewx-maint@lists.alioth.debian.org
Usertags: wx3.0
Control: block 748169 by -1

Dear maintainer,

We're aiming to migrate the archive to using wxwidgets3.0 instead of
wxwidgets2.8, and intend to drop wxwidgets2.8 before jessie is released.

I attempted to rebuild the current audacity package by updating the B-D
on libwxgtk2.8-dev to libwxgtk3.0-dev, but the upstream source assumes
that wxGenericFileDialog is available, which is no longer the case in
wxWidgets 3.0.

As far as I can make out, Audacity uses the generic implementation of
this dialog because it wants to add an extra button.  I've filed a bug
with wx upstream to ask about the removal of this class, as this change
isn't documented in the list of changes since 2.8.  Here's that ticket:

http://trac.wxwidgets.org/ticket/16300

I had a quick look at Audacity's SVN repo but couldn't see any obvious
work towards wx3.0 support.  Do you know if they have plans for when
wx3.0 support will be added?

Cheers,
    Olly

Message #12 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Debian Bug Tracking System <749659@bugs.debian.org>

Subject: Re: Bug#749659: audacity: Please update to use wxwidgets3.0

Date: Thu, 29 May 2014 11:37:46 +1200

On Thu, May 29, 2014 at 10:52:30AM +1200, Olly Betts wrote:
> As far as I can make out, Audacity uses the generic implementation of
> this dialog because it wants to add an extra button.  I've filed a bug
> with wx upstream to ask about the removal of this class, as this change
> isn't documented in the list of changes since 2.8.  Here's that ticket:
> 
> http://trac.wxwidgets.org/ticket/16300

wx upstream's impressively rapid response:

| I admit I haven't thought of anybody using the generic dialogs under GTK
| intentionally, in my mind the use of them for (very old) GTK+ version
| was nothing more than an implementation detail. I really don't think we
| want to add it back, and it's not even in wxMSW (although it is in wxOSX
| for some weird reason).
| 
| The advice would be to use wxFileDialog::SetExtraControlCreator() to add
| custom button to the native dialog, this works fine in wxGTK and is the
| best solution.
| 
| Otherwise they can always take filedlgg.cpp and link it with their
| sources.

Cheers,
    Olly

Message #21 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <benjamin@audacityteam.org>

To: Olly Betts <olly@survex.com>, 749659@bugs.debian.org

Cc: audacity-devel@lists.sourceforge.net

Subject: Re: Bug#749659: audacity: Please update to use wxwidgets3.0

Date: Sat, 31 May 2014 21:16:10 +0200

Hi Olly,

Am Donnerstag, den 29.05.2014, 10:52 +1200 schrieb Olly Betts:
> We're aiming to migrate the archive to using wxwidgets3.0 instead of
> wxwidgets2.8, and intend to drop wxwidgets2.8 before jessie is released.
> 
> I attempted to rebuild the current audacity package by updating the B-D
> on libwxgtk2.8-dev to libwxgtk3.0-dev, but the upstream source assumes
> that wxGenericFileDialog is available, which is no longer the case in
> wxWidgets 3.0.
> 
> As far as I can make out, Audacity uses the generic implementation of
> this dialog because it wants to add an extra button.  I've filed a bug
> with wx upstream to ask about the removal of this class, as this change
> isn't documented in the list of changes since 2.8.  Here's that ticket:
> 
> http://trac.wxwidgets.org/ticket/16300
> 
> I had a quick look at Audacity's SVN repo but couldn't see any obvious
> work towards wx3.0 support.  Do you know if they have plans for when
> wx3.0 support will be added?

There are discussions about supporting wx3.0 (and making it the
default), but no code changes has landed in SVN so far. I do not know
the current status and why there isn't any progress. Lack of
manpower/time or bugs? That's why I CCed audacity-devel to get some
feedback.

It's probably safe to say that help is appreciated and we are happy for
patches that add wx3.0 support (without removing wx2.8 support).

Cheers,
Benjamin

Message #26 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Benjamin Drung <benjamin@audacityteam.org>, 749659@bugs.debian.org

Cc: audacity-devel@lists.sourceforge.net

Subject: Re: Bug#749659: audacity: Please update to use wxwidgets3.0

Date: Sun, 1 Jun 2014 20:58:09 +1200

[Message part 1 (text/plain, inline)]

On Sat, May 31, 2014 at 09:16:10PM +0200, Benjamin Drung wrote:
> There are discussions about supporting wx3.0 (and making it the
> default), but no code changes has landed in SVN so far. I do not know
> the current status and why there isn't any progress. Lack of
> manpower/time or bugs? That's why I CCed audacity-devel to get some
> feedback.
> 
> It's probably safe to say that help is appreciated and we are happy for
> patches that add wx3.0 support (without removing wx2.8 support).

The attached is a simple start I made, and should work with both 2.8 and
3.0, though I didn't manage to actually test it compiles due to the
generic file dialog issue.  But I guess it's still useful to you.

BTW, I'd suggest there's no point keeping WXWIN_COMPATIBILITY_2_4 (only
used in one place, and wx2.4 is long long dead).  Also
WXWIN_COMPATIBILITY_2_6 seems to be defined but never used (and wx2.6 is
also long dead).

Cheers,
    Olly

[wx-fd-constants.patch (text/x-diff, attachment)]

Message #35 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 749659@bugs.debian.org

Subject: audacity + wxWidgets 3.0 — Proposing patch

Date: Wed, 20 Aug 2014 23:17:42 +0200

[Message part 1 (text/plain, inline)]

Thanks Olly, both for the initial patch (renaming of the constants) and 
for contacting both upstream teams (audacity and wxWidgets) to resolve 
the issues - the response of the wxWidgets guys has been very helpful to me.

Last weekend I was able to work on this bug. I managed to compile and 
run audacity with wxWidgets 3.0 successfully. However, there are still a 
few issues to resolve (mainly by wxWidgets upstream).

I tried to write code that works with both wx2.8 and wx3.0 without using 
preprocessor #ifdefs, but at some places it just couldn't be avoided.

As the patch has gotten way larger than I had expected, I feel the need 
to explain the changes:

Solved compilation issues:
* Allow wxWidgets 3.0 in various configure scripts.
* The file dialog was derived from an internal wx class that disappeared 
in wx3.0 (discussed in further detail below).
* In several places the types in interfaces changed between wxChar* and 
wxString. I've tried to modify the code so it works with both interfaces 
(thanks to implicit conversion; may look a bit weird in some places).
* Calls to "wxTheApp->SuspendIdleCallback()" are no longer supported. 
They were part of a workaround for a clipboard problem, which 
fortunately doesn't seem to be there any longer in wx3.0, so I 
deactivated it for wx3.0.
* AddPendingEvent() and ProcessEvent() now have the visibility 
"protected" in wxWindow. It has always been a bad idea to call them 
directly on a wxWindow object, but now it's explicitly forbidden. 
Instead, those functions should be called on the object returned by 
GetEventHandler().
* The class wxStandardPaths is now a singleton and has to be treated as 
such (no more explicit constructor calls).
* "wxLogWarning" is a macro now, so the "::" prefix doesn't work on it 
anymore.
* Several int types (which were actually used as enums) are now real 
enum types (e.g. wxRasterOperationMode, wxMouseButton) and have to be 
used as such.
* Apart from the FD constants (which have been fixed in Olly's patch 
already) there are some other constants which have received a prefix 
(e.g. wx* -> wxFONTFAMILY_*, wx* -> wxFONTSTYLE_*, wx* -> wxFONTWEIGHT_*).
* Signature changes in constructors of wxFlexGridSizer and wxIcon and 
wxSizeEvent
* Missing includes (missing header files were probably included 
indirectly in wx2.8 by chance)
* When deriving from the abstract class wxGridTableBase, different 
methods have to be implemented with wx3.0 (EndEdit with new signature 
and ApplyEdit) than before with wx2.8 (only EndEdit with old signature). 
Now both versions are implemented in parallel in the classes TimeEditor 
and ChoiceEditor (one version essentially being a wrapper of the other one).

Solved runtime issues:
* Segmentation fault: The LadspaEffectDialog receives EVT_TEXT events 
before it's properly initialized. To prevent this, a workaround was 
already in place, but was only active on Windows. It looks like this 
happens now on more platforms (including GTK). As the workaround doesn't 
do any harm, even if activated unnecessarily, I've simply activated it 
for all environments.
* GTK critical warning "IA__gtk_range_set_range: assertion 'min < max' 
failed" because of negative numbers as result of window size checking. 
Added a sanity check that straightens up the numbers in edge cases.
* GTK critical warning "IA__gdk_window_get_origin: assertion 
'GDK_IS_WINDOW (window)' failed": Received events of type wxSizeEvent on 
the main project window cause calls to "ClientToScreen" - which is not 
available until the window is first shown. So the class has to keep 
track of wxShowEvent events and inhibit those actions until the window 
is first shown. There should be a simpler way to do this, but neither 
IsShown() nor IsShownOnScreen() seem to help - both return true already 
before the window is actually created and before the ClientToScreen 
method starts working. I personally consider this a bug in wxWidgets 
(maybe I'm gonna file a bug report) - but nevertheless it's fixed in 
audacity now.
* The functions wxString::Format and wxString::Printf have become 
stricter about parameter types that don't match (format string vs. 
function parameters). So the bugs (that were already present in audacity 
before) become visible in wx3.0 as error messages. I've fixed all the 
ones that popped up during my testing, but there might be more of them 
that I just didn't happen to hit. At some point, all the calls to 
wxString::Format and wxString::Printf have to be checked systematically.

Some issues that I came across can be considered wxWidgets' "fault" 
(general problems with wxWidgets 3.0), but nevertheless affect 
audacity's functionality. I isolated them and reported them to the 
wxWidgets bug tracker:

Unresolved wxWidgets upstream issues:
* Dialog size: The Fit() method to resize a dialog to make all elements 
fit doesn't seem to work properly in wxWidgets 3.0 (GTK) on some Desktop 
Environments. This causes several audacity dialogs (e.g. the file 
recovery dialog on start-up) to lack elements. Reported to wxWidgets 
upstream: http://trac.wxwidgets.org/ticket/16440
* GTK critical warning "os_bar_hide: assertion 'OS_IS_BAR (bar)' failed" 
(and similar ones) when closing the program (affecting only downstream 
Ubuntu, not Debian sid): http://trac.wxwidgets.org/ticket/16438#ticket

Now, specifically about the issue with the wxFileDialog that has been 
discussed here previously: Unfortunately, different from what has been 
stated here before, it's not only about the added button - although that 
was the original intention of the copy. Since the moment the copy from 
wxWidgets was made, wxWidget's version and audacity's version have 
diverged further. This means that there is a conflict between a 
cleaner/more sustainable solution (by using only the proper wxWidgets 
interfaces) and maintaining all the functionality on all platforms (by 
keeping the copies - with the implication of having to add an additional 
copy of the outdated wxGenericFileDialog!!).

So I tried to figure out what exactly the real differences are. From the 
differences I guess that wxWidgets 2.6.3 was the base for the copy (it's 
the one with the least number of different lines overall). So I made a 
diff and (with the additional help of audacity's SVN) tried to figure 
out what purpose those changes serve. The good news is: For the GTK 
version we can go for the clean solution using only wxWidgets 
interfaces. All changes can either be re-done in a clean way (using only 
the interfaces) or are already built into wxWidgets 3.0:
* The extra button can be added via 
"wxFileDialog::SetExtraControlCreator()", as suggested in the wxWidgets 
upstream bug.
* Code that tries to expand all "expanders" before showing the dialog: I 
tried it and didn't see any difference between activated and deactivated 
the code. According to the comments I guess the original purpose was to 
expand the "Browse for other folders..." in older versions of the GTK 
FileChooser. But I haven't seen that old dialog version for ages, I 
don't think we have to worry about it.
* Fix of a memory leak in the original wxWidgets code: The leak is fixed 
in wx3.0 (they now use the wxGtkString that frees the strings received 
by GTK functions after its usage).
* Updated calls, variable names and macros to wx2.8 conventions: Nothing 
we have to worry about, if we use don't mess with wxWidgets internals.
* Deactivation of the automatic overwrite dialog: In wx3.0 that behavior 
can now be controlled via the wxFD_OVERWRITE_PROMPT style flag.
* Code that activates the "Enter" key as a way to execute the default 
action: This is done automatically in wx3.0.

The implementation in the attached patch provides a platform-independent 
file dialog that has all the features of the platform-specific old GTK 
version. Whether or not that implementation will be suitable for Windows 
and Mac is up to upstream, maybe they decide to stick with their own 
version for those platforms. I'm not completely done with interpreting 
all the changes, but it seems like the Windows version additionally 
tries to deal with some problems with long file filters that are not 
handled properly by the native Windows dialog prior to Windows 7 and the 
Mac version additionally tries to improve some accessibility features. 
In my opinion, if anywhere, those improvements should be in the 
wxWidgets code itself.

As I had to patch some "configure.in" files and those don't seem to be 
passed to "autoconf" automatically by the build system, I provided an 
additional patch for the "configure" files (output of "autoconf"). But 
maybe a better solution would be to generate those files automatically 
during the build by calling "autoconf".

Right now to build the package you have to apply all 3 patches (in this 
order): wx-fd-constants.patch, wx30.patch and wx30-autoconf-results.patch.

Cheers,
Martin

[wx30.patch (text/x-diff, attachment)]

[wx30-autoconf-results.patch (text/x-diff, attachment)]

Message #40 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Arkadiusz Miśkiewicz <arekm@maven.pl>

To: 749659@bugs.debian.org

Subject: build on other distro

Date: Fri, 29 Aug 2014 11:08:52 +0200

btw. I was testing your patches on other distro than Debian and unfortunately 
it fails to build here. Probably due to some differences between distros. Not 
sure if that matters in efforts of upstreaming wxwidgets 3.0 support.

http://sprunge.us/TDBI

-- 
Arkadiusz Miśkiewicz, arekm / maven.pl

Message #45 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Martin Steghöfer <martin@steghoefer.eu>, 749659@bugs.debian.org

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sat, 30 Aug 2014 13:58:58 -0300

Control: tags -1 + patch

On Wed, Aug 20, 2014 at 11:17:42PM +0200, Martin Steghöfer wrote:
> Last weekend I was able to work on this bug. I managed to compile and run
> audacity with wxWidgets 3.0 successfully. However, there are still a few
> issues to resolve (mainly by wxWidgets upstream).

Sounds great - sorry for not responding sooner, but I only just noticed
your message.  Be aware that the Debian BTS doesn't send replies to the
submitter of the bug by default (IMO, a complete misfeature).

> As the patch has gotten way larger than I had expected, I feel the need to
> explain the changes:

A lot of these changes are things I've seen needed in other packages.

Generally the patch looks good to me (I'm not familiar with the audacity
code, but I am quite familiar with porting code to wx3).

> --- a/src/widgets/FileHistory.cpp
> +++ b/src/widgets/FileHistory.cpp
> @@ -142,7 +142,7 @@
>     // Stored in reverse order
>     int n = mHistory.GetCount() - 1;
>     for (size_t i = 1; i <= mHistory.GetCount(); i++) {
> -      config.Write(wxString::Format(wxT("file%02d"), i), mHistory[n--]);
> +      config.Write(wxString::Format(wxT("file%02lld"), i), mHistory[n--]);

The amended code here assumes sizeof(size_t) == sizeof(long long) - that's not
true on all architectures (both i386 and armel have 4 vs 8, for example).  The
same assumption is made elsewhere in the patch.

At least in this case, since we're clearly not going to have billions of
history entries, I'd probably just cast to unsigned:

    config.Write(wxString::Format(wxT("file%02u"), (unsigned)i), mHistory[n--]);

Maintainers - let me know if you'd like me to NMU with these patches.

Cheers,
    Olly

Message #52 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 749659@bugs.debian.org

Cc: Olly Betts <olly@survex.com>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 31 Aug 2014 00:05:36 +0200

Hi Olly!


El 30/08/14 a les 18:58, Olly Betts ha escrit:
> The amended code here assumes sizeof(size_t) == sizeof(long long) - that's not
> true on all architectures (both i386 and armel have 4 vs 8, for example).

True that. I should have kept that in mind, I've seen the problem 
several times in other contexts: There is no printf format specifier 
that matches the size of the "size_t" type on all platforms. So casting 
it to something more "C-standard" is the only way to go, like you propose.

> At least in this case, since we're clearly not going to have billions of
> history entries, I'd probably just cast to unsigned:
>
>      config.Write(wxString::Format(wxT("file%02u"), (unsigned)i), mHistory[n--]);

Yep, agreed. If that doesn't work out in other cases (because of 
possible overflows), we can still always cast to "long long" and use the 
"ll" specifier.

Cheers,
Martin

Message #57 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Arkadiusz Miśkiewicz <arekm@maven.pl>

Cc: 749659@bugs.debian.org

Subject: Re: build on other distro

Date: Sun, 31 Aug 2014 00:09:05 +0200

Hi Arkadiusz!


On Fri, 29 Aug 2014 11:08:52 +0200 Arkadiusz =?utf-8?q?Mi=C5=9Bkiewicz?= 
<arekm@maven.pl> wrote:
>
> btw. I was testing your patches on other distro than Debian and 
unfortunately
> it fails to build here. Probably due to some differences between 
distros. Not
> sure if that matters in efforts of upstreaming wxwidgets 3.0 support.
>
> http://sprunge.us/TDBI

Thanks for the info! It is indeed relevant to upstream.

I see in your build log that the build tries to compile the *old* 
version of the FileDialog classes. I don't see, how distro-related 
differences could cause this. Did you maybe not start with a clean build 
directory? Or not reconfigure? Or not apply the autoconf-result patch? 
Could you

Cheers,
Martin

Message #62 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <bdrung@debian.org>

To: Martin Steghöfer <martin@steghoefer.eu>, 749659@bugs.debian.org

Cc: Olly Betts <olly@survex.com>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 31 Aug 2014 00:22:05 +0200

Am Sonntag, den 31.08.2014, 00:05 +0200 schrieb Martin Steghöfer:
> Hi Olly!
> 
> 
> El 30/08/14 a les 18:58, Olly Betts ha escrit:
> > The amended code here assumes sizeof(size_t) == sizeof(long long) - that's not
> > true on all architectures (both i386 and armel have 4 vs 8, for example).
> 
> True that. I should have kept that in mind, I've seen the problem 
> several times in other contexts: There is no printf format specifier 
> that matches the size of the "size_t" type on all platforms. So casting 
> it to something more "C-standard" is the only way to go, like you propose.

The C99 standard allows printing size_t with "%zu", but Microsoft Visual
Studio needs "%Iu" instead [1].

[1] http://msdn.microsoft.com/en-us/library/vstudio/tcxf1dw6.aspx

-- 
Benjamin Drung
Debian & Ubuntu Developer

Message #67 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Arkadiusz Miśkiewicz <arekm@maven.pl>

To: Martin Steghöfer <martin@steghoefer.eu>

Cc: 749659@bugs.debian.org

Subject: Re: build on other distro

Date: Sun, 31 Aug 2014 00:37:22 +0200

On Sunday 31 of August 2014, Martin Steghöfer wrote:

> 
> Thanks for the info! It is indeed relevant to upstream.
> 
> I see in your build log that the build tries to compile the *old*
> version of the FileDialog classes.

That hint was enough. I do not apply autoconf-result patch because I'm 
rebuilding these at build time... and I missed one place (lib-src/FileDialog).

Now it builds fine here, too.

Thanks,
-- 
Arkadiusz Miśkiewicz, arekm / maven.pl

Message #72 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Benjamin Drung <bdrung@debian.org>, 749659@bugs.debian.org

Cc: Olly Betts <olly@survex.com>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 31 Aug 2014 00:40:29 +0200

El 31/08/14 a les 00:22, Benjamin Drung ha escrit:
> The C99 standard allows printing size_t with "%zu", but Microsoft 
> Visual Studio needs "%Iu" instead [1]. [1] 
> http://msdn.microsoft.com/en-us/library/vstudio/tcxf1dw6.aspx 
Thanks for the hint! But unfortunately that's only C99, but neither 
C++11 nor C++03 mention it. GCC and Clang seem to support it in C++, but 
in the end of the day you'd depend on the goodwill of compiler 
vendors... :-(

Cheers,
Martin

Message #77 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@gmail.com>

To: Martin Steghöfer <martin@steghoefer.eu>, 749659@bugs.debian.org

Cc: Benjamin Drung <bdrung@debian.org>, Olly Betts <olly@survex.com>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Mon, 8 Sep 2014 22:12:37 -0400

Control: tag -1 -patch
Control: severity -1 normal

Hi,

I wonder what's the status of this bug. The most recent email did not
help to clarify, so I test-compiled wx3.0.patch as proposed in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749659#35, and can
confirm that the package builds fine. However, I noticed this in
configure.log:

checking for wx-config... /usr/bin/wx-config
configure: Checking that the chosen version of wxWidgets is 2.8.x or
3.0.x
Great, you're using wxWidgets 2.8.12!


I guess that is because the build dependencies needs updating. So I
guess given that the proposed patch to the package is incomplete at
best, I've removed the "patch" tag, as clearly more clarification is
needed.

Olly, I noticed that you raised the severity of this bug to "Serious"
without further explanation. Can you please elaborate here? This
situation claims that audacity should be removed from testing because
of this issue. Is this really your intention?

The wxwidgets transition tracking bug seems to be
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748169. Given that
the transition did not start before the September 5, I think it is
fair to assume that this transition is not going to happen for
Debian/jessie, and that it is also appropriate to downgrade the
severity of this bug.

Please correct me and clarify if I got something wrong, but AFAIUI,
there are no reason for pressing on this bug because jessie will ship
with wxWidgets 2.8.  Martin, may I recommend you getting in touch with
upstream about this patch?

Best,
Reinhard

Message #86 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Reinhard Tartler <siretart@gmail.com>, 749659@bugs.debian.org

Cc: Benjamin Drung <bdrung@debian.org>, Olly Betts <olly@survex.com>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Tue, 09 Sep 2014 12:43:26 +0200

Hi Reinhard!

Thanks for looking into this issue!


On 09/09/2014 04:12 AM, Reinhard Tartler wrote:
> I wonder what's the status of this bug. The most recent email did not
> help to clarify,

I'm sorry, I guess the side discussions didn't help to understand the 
situation, so here a quick summary:

The patches work fine on the tested platforms, although we agreed on 
making a slight modification to assure its cross-platform compatibility, 
proposed by Olly: Doing a cast instead of a modified format specifier in 
the wxString::Format changes.

So we're basically waiting for a maintainer to incorporate the patches 
(including the modification) in the package, update the build 
dependencies and upload the whole thing. Olly proposed to NMU the 
package, but there was no reaction from any of the maintainers so far.

If it helps, I can post a new version of the patch including Olly's 
proposed change. Would that help?

The maintainers should also decide if they want to accept the configure 
script patch or if they want to modify the package so autoconf 
automatically recreates them.

Bottom-line: The main work is done, but in order to move forward we need 
some attention from the maintainers.

> I guess that is because the build dependencies needs updating. So I guess given that the proposed patch to the package is incomplete at best

The patch is complete.

After applying the patch, the package can build with both wx2.8 and 
wx3.0. But, of course, if you want to build it against wx3.0 then you 
need the wx3.0 dev package installed, which you can assure by updating 
the build dependencies. But that's not part of a patch because we're not 
patching upstream code to do that. That's a modification in the 
debian/control file of the Debian package.

> Martin, may I recommend you getting in touch with
> upstream about this patch?

I am in touch. The transition to wx3.0 isn't a priority there at the 
moment, so this hasn't received a lot of attention, but a very quick 
review from their side approved the proposed patch for wxGTK. But as I 
elaborated in my first message in this bug report, for the Windows and 
Mac ports there's more to it. We're working on that (it requires a lot 
of attention from wxWidgets upstream), but that shouldn't be of interest 
for this issue in Debian.

I hope that helps to clarify the situation! :-)

Cheers,
Martin

Message #91 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Reinhard Tartler <siretart@gmail.com>

Cc: Martin Steghöfer <martin@steghoefer.eu>, 749659@bugs.debian.org, Benjamin Drung <bdrung@debian.org>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Tue, 9 Sep 2014 11:49:56 +0100

Control: severity -1 serious

On Mon, Sep 08, 2014 at 10:12:37PM -0400, Reinhard Tartler wrote:
> I wonder what's the status of this bug. The most recent email did not
> help to clarify, so I test-compiled wx3.0.patch as proposed in
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749659#35, and can
> confirm that the package builds fine. However, I noticed this in
> configure.log:
> 
> checking for wx-config... /usr/bin/wx-config
> configure: Checking that the chosen version of wxWidgets is 2.8.x or
> 3.0.x
> Great, you're using wxWidgets 2.8.12!
> 
> I guess that is because the build dependencies needs updating. So I
> guess given that the proposed patch to the package is incomplete at
> best, I've removed the "patch" tag, as clearly more clarification is
> needed.
> 
> Olly, I noticed that you raised the severity of this bug to "Serious"
> without further explanation. Can you please elaborate here?

Justification was in the mail which updated the severity:

# blocks the on-going wxwidgets3.0 transition
severity 749659 serious
thanks

You can see that from the BTS if you click on the "Full text" link:

https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=30;bug=749659

https://wiki.debian.org/Teams/ReleaseTeam/Transitions says to use
severity serious once the transition starts, which it officially
did on 2014-05-27:

https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=24;bug=748169

> This situation claims that audacity should be removed from testing
> because of this issue. Is this really your intention?

Very much so - the wxwidgets3.0 transition is close to complete and
audacity is one of the stragglers:

https://release.debian.org/transitions/html/wxwidgets3.0.html

In fact, it's the only one still in testing, which is only because it
is on the list which autorm won't touch due to popcon score.

Of those, grass has an somewhat bogus build dependency (it really
wants to check the wxPython version, so should do that directly)
and 5 more the maintainer has said to remove.  Of the remaining 8,
most have a fix in progress.

> The wxwidgets transition tracking bug seems to be
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748169. Given that
> the transition did not start before the September 5, I think it is
> fair to assume that this transition is not going to happen for
> Debian/jessie, and that it is also appropriate to downgrade the
> severity of this bug.

I don't see where you get September from - the last update to that
bug was in August...

As above, it officially started back in May, though I've been working on
it since October last year.

> Please correct me and clarify if I got something wrong, but AFAIUI,
> there are no reason for pressing on this bug because jessie will ship
> with wxWidgets 2.8.  Martin, may I recommend you getting in touch with
> upstream about this patch?

I suppose the release team have the final say, but my intention is that
jessie will not ship with wxwidgets2.8.  It is a large and complex
library, and now unmaintained upstream.  Even before 3.0 was released,
2.8 was neglected - the last release was 2011-03-28.  So by the time
jessie releases, wx2.8 will be close to 4 years old.  By the EOL of
jessie (assuming no LTS), it'll be close to 6 years old.

And given (thanks to Martin's superlative efforts) we have a patch for
audacity, why are we even having this discussion?

Cheers,
    Olly

Message #98 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Martin Steghöfer <martin@steghoefer.eu>

Cc: Reinhard Tartler <siretart@gmail.com>, 749659@bugs.debian.org, Benjamin Drung <bdrung@debian.org>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Tue, 9 Sep 2014 11:56:42 +0100

On Tue, Sep 09, 2014 at 12:43:26PM +0200, Martin Steghöfer wrote:
> So we're basically waiting for a maintainer to incorporate the
> patches (including the modification) in the package, update the
> build dependencies and upload the whole thing. Olly proposed to NMU
> the package, but there was no reaction from any of the maintainers
> so far.
> 
> If it helps, I can post a new version of the patch including Olly's
> proposed change. Would that help?

That would be very useful - then it will be clearer exactly what the
currently proposed changes are.

> The maintainers should also decide if they want to accept the
> configure script patch or if they want to modify the package so
> autoconf automatically recreates them.
> 
> Bottom-line: The main work is done, but in order to move forward we
> need some attention from the maintainers.

If the maintainers aren't actively working on this, we should NMU.
Getting the updated package uploaded soon means there's time for
shaking out any resulting issues before the freeze.  After the release
freeze, any fixes will have to get an explicit OK from the release
team.

Cheers,
    Olly

Message #103 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@gmail.com>

To: Olly Betts <olly@survex.com>

Cc: Martin Steghöfer <martin@steghoefer.eu>, 749659 <749659@bugs.debian.org>, Benjamin Drung <bdrung@debian.org>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Tue, 9 Sep 2014 07:19:59 -0400

On Tue, Sep 9, 2014 at 6:49 AM, Olly Betts <olly@survex.com> wrote:
> Control: severity -1 serious
>
> On Mon, Sep 08, 2014 at 10:12:37PM -0400, Reinhard Tartler wrote:
>> I wonder what's the status of this bug. The most recent email did not
>> help to clarify, so I test-compiled wx3.0.patch as proposed in
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749659#35, and can
>> confirm that the package builds fine. However, I noticed this in
>> configure.log:
>>
>> checking for wx-config... /usr/bin/wx-config
>> configure: Checking that the chosen version of wxWidgets is 2.8.x or
>> 3.0.x
>> Great, you're using wxWidgets 2.8.12!
>>
>> I guess that is because the build dependencies needs updating. So I
>> guess given that the proposed patch to the package is incomplete at
>> best, I've removed the "patch" tag, as clearly more clarification is
>> needed.
>>
>> Olly, I noticed that you raised the severity of this bug to "Serious"
>> without further explanation. Can you please elaborate here?
>
> Justification was in the mail which updated the severity:
>
> # blocks the on-going wxwidgets3.0 transition
> severity 749659 serious
> thanks
>
> You can see that from the BTS if you click on the "Full text" link:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=30;bug=749659
>
> https://wiki.debian.org/Teams/ReleaseTeam/Transitions says to use
> severity serious once the transition starts, which it officially
> did on 2014-05-27:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=24;bug=748169

Oh, that's the part I missed. Sorry.

>
>> This situation claims that audacity should be removed from testing
>> because of this issue. Is this really your intention?
>
> Very much so - the wxwidgets3.0 transition is close to complete and
> audacity is one of the stragglers:
>
> https://release.debian.org/transitions/html/wxwidgets3.0.html
>
> In fact, it's the only one still in testing, which is only because it
> is on the list which autorm won't touch due to popcon score.
>
> Of those, grass has an somewhat bogus build dependency (it really
> wants to check the wxPython version, so should do that directly)
> and 5 more the maintainer has said to remove.  Of the remaining 8,
> most have a fix in progress.

Thanks for the status update. It seems that audacity is really one of
the remaining packages blocking this transition. This was not clear to
when reading the bug. This transition has been going on for a really
unhealthy amount of time.

>> Please correct me and clarify if I got something wrong, but AFAIUI,
>> there are no reason for pressing on this bug because jessie will ship
>> with wxWidgets 2.8.  Martin, may I recommend you getting in touch with
>> upstream about this patch?
>
> I suppose the release team have the final say, but my intention is that
> jessie will not ship with wxwidgets2.8.  It is a large and complex
> library, and now unmaintained upstream.  Even before 3.0 was released,
> 2.8 was neglected - the last release was 2011-03-28.  So by the time
> jessie releases, wx2.8 will be close to 4 years old.  By the EOL of
> jessie (assuming no LTS), it'll be close to 6 years old.
>
> And given (thanks to Martin's superlative efforts) we have a patch for
> audacity, why are we even having this discussion?

Well, I would appreciate a patch that is a) uptodate and b) complete
(what changes to the packaging are required to satisfy this
transition).

Can you maybe attach a debdiff, please?

(BTW, I wouldn't mind a NMU)

-- 
regards,
    Reinhard

Message #108 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <bdrung@debian.org>

To: Olly Betts <olly@survex.com>

Cc: Martin Steghöfer <martin@steghoefer.eu>, Reinhard Tartler <siretart@gmail.com>, 749659@bugs.debian.org

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Wed, 10 Sep 2014 00:18:49 +0200

Hi,

Am Dienstag, den 09.09.2014, 11:56 +0100 schrieb Olly Betts:
> > The maintainers should also decide if they want to accept the
> > configure script patch or if they want to modify the package so
> > autoconf automatically recreates them.
> > 
> > Bottom-line: The main work is done, but in order to move forward we
> > need some attention from the maintainers.
> 
> If the maintainers aren't actively working on this, we should NMU.
> Getting the updated package uploaded soon means there's time for
> shaking out any resulting issues before the freeze.  After the release
> freeze, any fixes will have to get an explicit OK from the release
> team.

The 2.0.6 upstream release is coming. Various freezes are in effect and
only severe bugs will be fixed before the release. The upcoming release
includes the autotools changes which make dh-autoreconf work. I like to
either package an svn snapshot or wait for the release and then apply
the wx3.0 patch.

Sadly the wx3.0 patch needs adjustment to apply to svn head. Can you
update the patch to apply cleanly to svn head? Upstream will be happy
for this contribution after the 2.0.6 release.

-- 
Benjamin Drung
Debian & Ubuntu Developer

Message #113 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Reinhard Tartler <siretart@gmail.com>, Olly Betts <olly@survex.com>

Cc: 749659@bugs.debian.org, Benjamin Drung <bdrung@debian.org>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 14 Sep 2014 21:23:13 +0200

[Message part 1 (text/plain, inline)]

On 09/09/2014 12:56 PM, Olly Betts wrote:
> On Tue, Sep 09, 2014 at 12:43:26PM +0200, Martin Steghöfer wrote:
>> If it helps, I can post a new version of the patch including Olly's
>> proposed change. Would that help?
> That would be very useful - then it will be clearer exactly what the
> currently proposed changes are.

On 09/09/2014 01:19 PM, Reinhard Tartler wrote:
> Can you maybe attach a debdiff, please? (BTW, I wouldn't mind a NMU) 

Please find attached a debdiff including the currently proposed version 
of the patches, the necessary changes to the debian/control file and an 
updated changelog explaining both.

In the end I haven't included Olly's original patch (renaming of the FD 
constants) because it only patches the original FileDialog code that 
isn't used after applying my patch. I did, however, include my patching 
of the configure files because it seems that the solution to the 
dh_autoreconf problem will only be available after a new upstream Release.

Cheers,
Martin

[audacity_2.0.5-2.1.debdiff (text/plain, attachment)]

Message #118 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Benjamin Drung <bdrung@debian.org>

Cc: 749659@bugs.debian.org, Olly Betts <olly@survex.com>, Reinhard Tartler <siretart@gmail.com>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 14 Sep 2014 21:30:53 +0200

On 09/10/2014 12:18 AM, Benjamin Drung wrote:
> The upcoming release includes the autotools changes which make 
> dh-autoreconf work.

That's great news! :-)


> Sadly the wx3.0 patch needs adjustment to apply to svn head. Can you 
> update the patch to apply cleanly to svn head? Upstream will be happy 
> for this contribution after the 2.0.6 release. 

Working on it... I'll let you know!

Cheers,
Martin

Message #123 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@gmail.com>

To: Martin Steghöfer <martin@steghoefer.eu>

Cc: Olly Betts <olly@survex.com>, 749659 <749659@bugs.debian.org>, Benjamin Drung <bdrung@debian.org>

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 14 Sep 2014 16:14:59 -0400

On Sun, Sep 14, 2014 at 3:23 PM, Martin Steghöfer <martin@steghoefer.eu> wrote:
> On 09/09/2014 12:56 PM, Olly Betts wrote:
>>
>> On Tue, Sep 09, 2014 at 12:43:26PM +0200, Martin Steghöfer wrote:
>>>
>>> If it helps, I can post a new version of the patch including Olly's
>>> proposed change. Would that help?
>>
>> That would be very useful - then it will be clearer exactly what the
>> currently proposed changes are.
>
>
> On 09/09/2014 01:19 PM, Reinhard Tartler wrote:
>>
>> Can you maybe attach a debdiff, please? (BTW, I wouldn't mind a NMU)
>
>
> Please find attached a debdiff including the currently proposed version of
> the patches, the necessary changes to the debian/control file and an updated
> changelog explaining both.
>
> In the end I haven't included Olly's original patch (renaming of the FD
> constants) because it only patches the original FileDialog code that isn't
> used after applying my patch. I did, however, include my patching of the
> configure files because it seems that the solution to the dh_autoreconf
> problem will only be available after a new upstream Release.

Please remind me, what was the autoreconf problem, and how has it been
fixed upstream? I'm really not comfortable with uploading an about
500kb diff.

Benjamin, I wonder what your thoughts on this patch are?

Cheers,
Reinhard

Message #128 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Reinhard Tartler <siretart@gmail.com>, 749659@bugs.debian.org

Subject: Re: Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

Date: Sun, 21 Sep 2014 18:08:08 +0200

[Message part 1 (text/plain, inline)]

On 09/14/2014 10:14 PM, Reinhard Tartler wrote:
> Please remind me, what was the autoreconf problem, and how has it been 
> fixed upstream? I'm really not comfortable with uploading an about 
> 500kb diff.

I agree, having that patch in the actual package is not an option, it's 
huge, opaque and will break with a new upstream release (although the 
latter hopefully won't be an issue). The reason I posted that patch in 
the first place was so others could try and evaluate the other patch 
(wx30.patch), the one that was actually relevant. I was hoping that 
someone closer to the package would be able fix the dh_autoreconf issue 
(see my first post in this bug).

But since nobody spoke up, I've had a look myself. Turns out that 
autoreconf only recurses into subdirectories that are included via the 
AC_CONFIG_SUBDIRS macro using string literals (no variables) as 
argument. In audacity, however, AC_CONFIG_SUBDIRS is either called using 
variables as argument or not called at all (calling the configure script 
of the subdirectory explicitly instead).

With that knowledge I was able to find and backport two upstream commits 
that fix this. However, the fact that the autotools are now called on 
more subdirectories than before uncovered configuration script problems 
in those subdirectories. I fixed the errors and the most important 
warnings in an additional patch.

Please find attached a new debdiff including the mentioned changes.

Cheers,
Martin

[audacity_2.0.5-2.1.debdiff (text/plain, attachment)]

Message #133 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: 749659@bugs.debian.org

Cc: Reinhard Tartler <siretart@gmail.com>, Benjamin Drung <bdrung@debian.org>, Olly Betts <olly@survex.com>

Subject: audacity: Systematic check for Printf/Format mismatches

Date: Thu, 02 Oct 2014 22:42:07 +0200

[Message part 1 (text/plain, inline)]

Martin Steghöfer wrote:
> Please find attached a new debdiff including the mentioned changes.

Anyone still following this or have I put everyone to sleep with my 
lengthy patches? ;-)

Anyway, a last little update... In order to make things more solid, I 
did what I proposed in my first post:

> The functions wxString::Format and wxString::Printf
> have become stricter about parameter types that don't
> match (format string vs. function parameters). So the
> bugs (that were already present in audacity before)
> become visible in wx3.0 as error messages. I've fixed
> all the ones that popped up during my testing, but
> there might be more of them that I just didn't happen
> to hit. At some point, all the calls to
> wxString::Format and wxString::Printf have to be
> checked systematically.


I've done the systematic check. I manually inspected all 990 occurrences 
of Printf, wxPrintf, PrintfV, Format, FormatV, wxLogDebug and wxLogError 
and came up with some that still needed fixing. Most of them had not 
been hit during my first testing because they are used within error 
messages and are therefore harder to trigger. Whenever the "_" 
(underscore) macro was involved, I preferred casting the argument over 
modifying the specifier, in order to avoid screwing up the translations. 
Besides, to keep the patch size acceptable, I also didn't patch 
occurrences in code that's not used in Debian (unused debug code, 
unreachable code, #if 0, etc.). I fixed them in my git branch for 
upstream, however.

Find attached the (hopefully) final debdiff from my side. It's big, but 
relatively easy to review because most of the changes can be interpreted 
independently.

Cheers,
Martin

[audacity_2.0.5-3.debdiff (text/plain, attachment)]

Message #138 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Martin Steghöfer <martin@steghoefer.eu>

Cc: 749659@bugs.debian.org, Reinhard Tartler <siretart@gmail.com>, Benjamin Drung <bdrung@debian.org>

Subject: Re: audacity: Systematic check for Printf/Format mismatches

Date: Mon, 6 Oct 2014 02:33:34 +0100

On Thu, Oct 02, 2014 at 10:42:07PM +0200, Martin Steghöfer wrote:
> Find attached the (hopefully) final debdiff from my side. It's big,
> but relatively easy to review because most of the changes can be
> interpreted independently.

Thanks for all your work on this, Martin.

Is someone looking at this with an eye to getting an updated version of
audacity actually uploaded?

This is now the last package waiting for an upload in the wxwidgets3.0
transition, and the latest upload date to make it to testing before the
release freeze is now less than 3 weeks away (the freeze is November
5th, but an upload would need to age for 10 days).

I can NMU with this patch if need be, but if the package maintainers are
already on the case there's no point me duplicating their efforts.

Cheers,
    Olly

Message #143 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <bdrung@debian.org>

To: Olly Betts <olly@survex.com>

Cc: Martin Steghöfer <martin@steghoefer.eu>, 749659@bugs.debian.org, Reinhard Tartler <siretart@gmail.com>

Subject: Re: audacity: Systematic check for Printf/Format mismatches

Date: Thu, 09 Oct 2014 01:11:56 +0200

Hi all,

sorry for reacting too lazy.

Am Montag, den 06.10.2014, 02:33 +0100 schrieb Olly Betts:
> On Thu, Oct 02, 2014 at 10:42:07PM +0200, Martin Steghöfer wrote:
> > Find attached the (hopefully) final debdiff from my side. It's big,
> > but relatively easy to review because most of the changes can be
> > interpreted independently.
> 
> Thanks for all your work on this, Martin.
> 
> Is someone looking at this with an eye to getting an updated version of
> audacity actually uploaded?
> 
> This is now the last package waiting for an upload in the wxwidgets3.0
> transition, and the latest upload date to make it to testing before the
> release freeze is now less than 3 weeks away (the freeze is November
> 5th, but an upload would need to age for 10 days).
> 
> I can NMU with this patch if need be, but if the package maintainers are
> already on the case there's no point me duplicating their efforts.

I finally found time to import the upstream release 2.0.6, backport the
preliminary upstream changes for wxWidgets 3.0.1 from r13403, and pushed
everything to our git repository. Your patch needs to be forward ported,
which I will try to do when I have some spare time (knowing that it
should be done ASAP due to the nearing freeze). I would be happy to get
help forward porting the patch.

PS: I was reluctant to upload the debdiff because I liked to see the
patch for 2.0.6 (which has autoreconf fixed). Upstream want to get wx3.0
support in for 2.0.7 and is actively working on getting it in the svn
repository. So you could provide the missing bits and we will get
upstream to test your proposed changes (when I commit them to the
upstream repository).

-- 
Benjamin Drung
Debian & Ubuntu Developer

Message #148 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Olly Betts <olly@survex.com>

To: Benjamin Drung <bdrung@debian.org>

Cc: Martin Steghöfer <martin@steghoefer.eu>, 749659@bugs.debian.org, Reinhard Tartler <siretart@gmail.com>

Subject: Re: audacity: Systematic check for Printf/Format mismatches

Date: Fri, 10 Oct 2014 04:05:18 +0100

On Thu, Oct 09, 2014 at 01:11:56AM +0200, Benjamin Drung wrote:
> PS: I was reluctant to upload the debdiff because I liked to see the
> patch for 2.0.6 (which has autoreconf fixed). Upstream want to get wx3.0
> support in for 2.0.7 and is actively working on getting it in the svn
> repository. So you could provide the missing bits and we will get
> upstream to test your proposed changes (when I commit them to the
> upstream repository).

I'm assuming here that by "you" you mean Martin (just to make sure we
avoid misunderstandings, as I was the direct recipient of your message).

Cheers,
    Olly

Message #153 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Benjamin Drung <bdrung@debian.org>, 749659@bugs.debian.org, Olly Betts <olly@survex.com>

Cc: Reinhard Tartler <siretart@gmail.com>

Subject: Re: Bug#749659: audacity: Systematic check for Printf/Format mismatches

Date: Fri, 10 Oct 2014 12:28:08 +0200

[Message part 1 (text/plain, inline)]

El 09/10/14 a les 01:11, Benjamin Drung ha escrit:
> Your patch needs to be forward ported,

We already have a patch that fixes 2.0.6 for wxWidgets 3.0. Back when 
you asked me to forward-port my patch to the current svn head (in order 
to get the changes into upstream), I did. Apart from the porting it 
includes specific fixes for svn head. Fortunately, 2.0.6 isn't that 
different from what was svn head back then, so we have a patch for 
2.0.6, find it attached. To keep it small, I've removed everything that 
isn't relevant here (fixes of dead code or code that otherwise isn't 
relevant on Debian), but we will have that available for upstream. Be 
aware that this patch is by far not as well tested as my patch for 2.0.5!

> [...] backport the preliminary upstream changes for wxWidgets 3.0.1 from r13403 [...]
> [...]
> Upstream want to get wx3.0 support in for 2.0.7 and is actively working on getting it in the svn

"Actively working", yes, unfortunately. Why? Your messages sounded like 
upstream was aware of this being resolved already, especially with you 
being part of upstream (AFAIK). Not only was this a major duplication of 
effort, but now it also requires additional porting - which is mainly 
manual work here, given that different people have been working on 
similar issues and touching the same code, but in different ways. What 
we're doing here is really inefficient.


> So you could provide the missing bits and we will get
> upstream to test your proposed changes (when I commit them to the
> upstream repository).

So you're proposing to do the upstream integration first? I'd do it the 
other way round, given that for 2.0.6 we already have a patch and that 
the upstream integration has just gotten more complicated. We've already 
lost a lot of time. And before we just upload stuff to upstream, I'd 
also like to discuss the upstream integration with the person that has 
been working on wx3.0 there, especially as he has been fixing some code 
that I consider obsolete with wx3.0 and that I'd like to fix some things 
in a different way.

Cheers,
Martin

[audacity-2.0.6-with-wxWidgets-3.0.patch (text/x-diff, attachment)]

Message #158 received at 749659@bugs.debian.org (full text, mbox, reply):

From: Martin Steghöfer <martin@steghoefer.eu>

To: Benjamin Drung <bdrung@debian.org>, 749659@bugs.debian.org

Subject: Re: Bug#749659: audacity: Systematic check for Printf/Format mismatches

Date: Sat, 11 Oct 2014 02:38:05 +0200

Hi Benjamin!


Martin Steghöfer wrote:
> And before we just upload stuff to upstream, I'd also like to discuss 
> the upstream integration with the person that has been working on 
> wx3.0 there

Looking at the recent upstream activity, I've changed my mind about 
this: We should get this into upstream as soon as possible! Otherwise 
porting the fixes is just going to be even more difficult. Now that 
someone has made an initial commit about wxWidgets 3.0, people upgrade 
and try to fix things - but not always in the proper way.

Today's upstream commits alone justify being worried: 3 commits arrived 
upstream trying to fix wx3.0-related stuff: The first one removed 
functionality (!) in order to avoid the problems. The second one 
replaced one inadequate function call by another inadequate function 
call - which avoids the crash for the moment, but is equally wrong and 
may still crash with other compiler flags. The third one silenced a 
warning instead of fixing the underlying problem - which causes an 
invalid memory access and therefore a possible crash. With all those 
"fixes" in place, porting the patch won't only get harder (because of 
conflicts), but the diff will also become more cryptic (it's easier to 
understand a simple fix than to understand the fix of an existing fix).

So today I took the time to port my fixes (again) to the current svn 
head. I've got them sitting in my local git, divided in many commits, 
for better documentation (the Debian patch is huge and no one can tell 
any more, which change corresponds to which fix). I can send them all to 
you and you import them manually into svn. Or I can commit them directly 
to the svn - I've got git-svn set-up, I'd just need access to the 
repository. I can also send the patches to you first, for inspection 
(but it's mainly what you've seen here in the debdiff, just divided, 
ported and with non-Debian-relevant changes).

For the Debian package I still recommend the patch I've sent earlier 
today. Why bother with extra porting work and combining several patches 
(including additional porting work)?

Cheers,
Martin

Message #163 received at 749659-close@bugs.debian.org (full text, mbox, reply):

From: Benjamin Drung <bdrung@debian.org>

To: 749659-close@bugs.debian.org

Subject: Bug#749659: fixed in audacity 2.0.6-1

Date: Mon, 13 Oct 2014 23:49:11 +0000

Source: audacity
Source-Version: 2.0.6-1

We believe that the bug you reported is fixed in the latest version of
audacity, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 749659@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Benjamin Drung <bdrung@debian.org> (supplier of updated audacity package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 14 Oct 2014 01:28:54 +0200
Source: audacity
Binary: audacity audacity-data audacity-dbg
Architecture: source amd64 all
Version: 2.0.6-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Benjamin Drung <bdrung@debian.org>
Description:
 audacity   - fast, cross-platform audio editor
 audacity-data - fast, cross-platform audio editor (data)
 audacity-dbg - fast, cross-platform audio editor (debug)
Closes: 749659 757531
Changes:
 audacity (2.0.6-1) unstable; urgency=medium
 .
   * New upstream release.
   * Update debian/watch to point to FossHub.
   * Bump Standards-Version to 3.9.6 (no changes required)
   * Drop all patches (all included in new upstream release) and the
     libnyquist autoreconf workaround
   * Disable tests (they fail to build, because they are bitrotten)
   * Fix autoreconf for the minimal audacity source tarball.
   * Compile audacity against wxWidgets 3.0. Thanks to Martin Steghöfer for
     this enormous patch (Closes: #749659)
   * Fix FTBFS with clang. Thanks to Arthur Marble. (Closes: #757531)
Checksums-Sha1:
 d6489ba254872bc52708a18672cf2173f51999b6 2795 audacity_2.0.6-1.dsc
 320a6c05a075de88c5897d704d122de26a52e468 6556636 audacity_2.0.6.orig.tar.xz
 331094e96e76684684c763612a06f96c4963b851 31452 audacity_2.0.6-1.debian.tar.xz
 ee354b8ea7077fbca53fa47e1937a6bb9e82a2ff 2838716 audacity_2.0.6-1_amd64.deb
 a69a98586c4b8451377c71a725ecd58c9d037f54 1380910 audacity-data_2.0.6-1_all.deb
 60ef771a00cbd325bfd66fbd4152d98234c2d960 30276264 audacity-dbg_2.0.6-1_amd64.deb
Checksums-Sha256:
 9b27bd8dd656357745efab47ec3b1fc64e3e1700b6c460e0f430d7e18fd01ab7 2795 audacity_2.0.6-1.dsc
 4d5cb86c15e372f09c2db158c1bacc3206b017dc3f9c494401c4ebf153a29585 6556636 audacity_2.0.6.orig.tar.xz
 17212976aa8aa84bdf1243ee805062a0a58bc8aaa5dbbf5511031e6562734371 31452 audacity_2.0.6-1.debian.tar.xz
 2b5a6c9868f2c7ed25a7dce333c089905f67ed2c739167ed8f77ca5be9c5883c 2838716 audacity_2.0.6-1_amd64.deb
 d94e8676f735ac4d789ac2861a21d20af8edd3f0db10ea7153368be3ab5fddb3 1380910 audacity-data_2.0.6-1_all.deb
 4da49da768dad2d40d30df3dca1f0c9655daed4b58f805408ff1229aaec4d3ab 30276264 audacity-dbg_2.0.6-1_amd64.deb
Files:
 303d2e03199636c3d4bb7aeaa9b62fbb 2795 sound optional audacity_2.0.6-1.dsc
 71eaa55474b90b9e144c2dbf35391994 6556636 sound optional audacity_2.0.6.orig.tar.xz
 321d9c62abedd647d973c9884f824769 31452 sound optional audacity_2.0.6-1.debian.tar.xz
 c63d917a0313959cb0b9cf8da5818d7b 2838716 sound optional audacity_2.0.6-1_amd64.deb
 102a95214c463ae0942dfff58d35fffe 1380910 sound optional audacity-data_2.0.6-1_all.deb
 fb270d49655c4afb31d67c30aa8930b3 30276264 debug extra audacity-dbg_2.0.6-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJUPGHmAAoJEBWetcTvyHdMoswP+gLxqG5q5uxLtm+WHllOWO2E
N69h/xXJ+YYcpmBJYzPfqhLG5/Za0zRIjqvRcylhiDOA2WxftPgVQm3knnIlJvP8
umQ9VBo4LzVcXtsW0Ywc8ga4C1RlZnwQEHh1Q+MJj5aiE2F1BsY4q1YuH3QHjTvv
rGDhlO8gchFtyKoRWgVlF1+JAccso81MbhvcS6m9pCcZheZLMUOXV22HATUx+NCX
C392qp7Q7cohLhUVTnffGIScrnmuHlACuloaaR80lqIvnP2HZDhCskL5B+6Ye7Pa
5XAw6phSwIp5PekAf20cJbvtf3012+N2NIO84LVt0D622Z5mNeJBzk9rZFu/9dF4
dKv+DfygI94NKQE2bzjhC/TaqHtM0JxyahsPvwKE75yccqIA0CfX8S4DBrpz6gPt
WqPqh9XSQnhEPJpHR6HCib/uLGnWpJYvwRUNjdrkg1DQRyO2B+ZfLQ670TV+nXzO
PfxXWrnnvFRPniAYMaBu3LHpnj1b+VKGcnwI/UqbQ03KFqpkNEJMmWp547g1ceUh
CQV+v2q8vPxIlFk8fQMMp7zhda6U8k5jQskozUVGzyPgVk6eIN/pQkXwn1LXc2Pw
rl2jbulmctQ+ViSAwmN99fIBjDWQu91m4yGQe/mlWu8CA4ITWotiiP2ry5v/R3we
ou0oYOcJUlcRE3JBpABj
=5Hcb
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.