Debian Bug report logs - #748590
Missing error handling due to conflicting return types of function encodeMB

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Tautschnig <mt@debian.org>

To: bugs@debian.org

Subject: Missing error handling due to conflicting return types of function encodeMB

Date: Sun, 18 May 2014 18:04:00 +0100

[Message part 1 (text/plain, inline)]

Package: jxrlib
Version: 1.1-4
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
/usr/bin/cc  -fPIC -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2   -Wl,-z,relro -shared -Wl,-soname,libjpegxr.so.0 -o libjpegxr.so.1.1 CMakeFiles/jpegxr.dir/image/encode/encode.c.o CMakeFiles/jpegxr.dir/image/encode/segenc.c.o CMakeFiles/jpegxr.dir/image/encode/strenc.c.o CMakeFiles/jpegxr.dir/image/encode/strFwdTransform.c.o CMakeFiles/jpegxr.dir/image/encode/strPredQuantEnc.c.o CMakeFiles/jpegxr.dir/image/decode/decode.c.o CMakeFiles/jpegxr.dir/image/decode/postprocess.c.o CMakeFiles/jpegxr.dir/image/decode/segdec.c.o CMakeFiles/jpegxr.dir/image/decode/strdec.c.o CMakeFiles/jpegxr.dir/image/decode/strInvTransform.c.o CMakeFiles/jpegxr.dir/image/decode/strPredQuantDec.c.o CMakeFiles/jpegxr.dir/image/decode/JXRTranscode.c.o CMakeFiles/jpegxr.dir/image/sys/adapthuff.c.o CMakeFiles/jpegxr.dir/image/sys/image.c.o CMakeFiles/jpegxr.dir/image/sys/strcodec.c.o CMakeFiles/jpegxr.dir/image/sys/strPredQuant.c.o CMakeFiles/jpegxr.dir/image/sys/strTransform.c.o CMakeFiles/jpegxr.dir/image/sys/perfTimerANSI.c.o 
CMakeFiles/jpegxr.dir/image/encode/strenc.c.o: In function `StrIOEncInit':
/srv/jenkins-slave/workspace/sid-goto-cc-jxrlib/jxrlib-1.1/image/encode/strenc.c:485: warning: the use of `tmpnam' is dangerous, better use `mkstemp'

error: conflicting function declarations "encodeMB"
old definition in module strenc file /srv/jenkins-slave/workspace/sid-goto-cc-jxrlib/jxrlib-1.1/image/encode/strenc.c line 212
signed int (struct CWMImageStrCodec *pSC, signed int iMBX, signed int iMBY)
new definition in module JXRTranscode file /srv/jenkins-slave/workspace/sid-goto-cc-jxrlib/jxrlib-1.1/image/decode/JXRTranscode.c line 50
void (struct CWMImageStrCodec *, signed int, signed int)
CMakeFiles/jpegxr.dir/build.make:513: recipe for target 'libjpegxr.so.1.1' failed
make[3]: *** [libjpegxr.so.1.1] Error 64

Reviewing the code, it seems encodeMB uses the return value to report errors.
Thus the declaration in JXRTranscode.c should be fixed, and all call sites
should consider the return value.

Best,
Michael

[Message part 2 (application/pgp-signature, inline)]

Message #12 received at 748590@bugs.debian.org (full text, mbox, reply):

From: Mathieu Malaterre <malat@debian.org>

To: 748590@bugs.debian.org

Date: Thu, 22 May 2014 09:34:23 +0200

Control: tags -1 fixed-upstream patch

it's been fixed upstream.

Message #19 received at 748590-close@bugs.debian.org (full text, mbox, reply):

From: Mathieu Malaterre <malat@debian.org>

To: 748590-close@bugs.debian.org

Subject: Bug#748590: fixed in jxrlib 1.1-5

Date: Thu, 22 May 2014 10:19:50 +0000

Source: jxrlib
Source-Version: 1.1-5

We believe that the bug you reported is fixed in the latest version of
jxrlib, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 748590@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mathieu Malaterre <malat@debian.org> (supplier of updated jxrlib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 22 May 2014 11:36:05 +0200
Source: jxrlib
Binary: libjxr0 libjxr-dev libjxr-tools
Architecture: source amd64
Version: 1.1-5
Distribution: unstable
Urgency: low
Maintainer: Mathieu Malaterre <malat@debian.org>
Changed-By: Mathieu Malaterre <malat@debian.org>
Description: 
 libjxr-dev - JPEG-XR lib - dev files
 libjxr-tools - JPEG-XR lib - command line apps
 libjxr0    - JPEG-XR lib - libraries
Closes: 748590
Changes: 
 jxrlib (1.1-5) unstable; urgency=low
 .
   * Fix function signature. Closes: #748590
Checksums-Sha1: 
 6597d89a6258b255755fbb352f043f812a7767ba 1959 jxrlib_1.1-5.dsc
 a06563cd752a2cd160ddafe126afd899c263fb7d 23644 jxrlib_1.1-5.debian.tar.xz
 aa7d1e49e85b3059511f183bfb7f9c2287d2e4f3 157464 libjxr0_1.1-5_amd64.deb
 986989ebee95c2a730fea20bc0d86ec699e4e4df 32120 libjxr-dev_1.1-5_amd64.deb
 2fda22e87dfdbc2e37e4c93b7d9efebfa76d39cf 16756 libjxr-tools_1.1-5_amd64.deb
Checksums-Sha256: 
 b2566383c3e9d64b3a8c245fe6197a79f530f644f517db9a5e2884b9640292d0 1959 jxrlib_1.1-5.dsc
 5064dc118f0e753ef3d4b630f2d8d7903bf4d0f223946d3ad036a0d880d6206e 23644 jxrlib_1.1-5.debian.tar.xz
 ae455381dbdcd9fb4388615e0eb678fe7f21b12228da13177542950e6683961b 157464 libjxr0_1.1-5_amd64.deb
 1bcf9112d62c3e92b4dc08ce6bf3868698ac2f8b3bdcd01a75c3795f2045992d 32120 libjxr-dev_1.1-5_amd64.deb
 b8ee8899842cbb49375ee5b8fc3261bfa997870f1f4db9d71a378b656cfc5ac9 16756 libjxr-tools_1.1-5_amd64.deb
Files: 
 f52ad0a2667c27a9d1fa7d8c101d1d68 157464 libs optional libjxr0_1.1-5_amd64.deb
 7830a85628e622db78180aff907433f1 32120 libdevel optional libjxr-dev_1.1-5_amd64.deb
 18d86adb051ede67b5d5452605a1f42a 16756 utils optional libjxr-tools_1.1-5_amd64.deb
 9fb4299b15fcc0df12a816f10af1310d 1959 graphics optional jxrlib_1.1-5.dsc
 b93e24965ca1bcc07438304e76339d56 23644 graphics optional jxrlib_1.1-5.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJTfcewAAoJEAFx4YKK4JNFyTEP/3y3swUnJUW1EVr0qvToeUpb
0RaEkwmtzPbOoX0RFFfB9YVWs1XxyRJevp5KabJx80PYOF6FrHxkrC/8cUVh2wEX
mFNiwoPlBflqZPeF/6+12y1BHfhcAv3q+W1fdw1mfWhT7Kul5YOnYWPsmpcK3NUb
3h5IYbz/z3D/YwFoHWizQnZLX4PTAx6JaK6XtikMprKylR9SEGb01RQJP+qVr7DW
vewf0LsPGKuRoATDEeqh5nMvBC6qXnTMarePVydCLcqc4Sv80yoxqcjt/HjVlkCR
El8tGJ6I2harWzEktJBrgv+7PxNnyzijU565GUvO8BiqtjujAI7as9tP3X1XT3fa
dvgZDqUfscADaJbNSAOXC+rvRRBC+m7Qg+iNzOWTDRx1c2E4X/wOczQV3jYNG79p
lvKViAx35RnNOFm7SAe7h5j4BWIIL4Bgd8um4YDhr21p7gVKTdtuLIge+dHl3gvW
KE8GHk0/60SY01DT9L/zWD4ZTgMsSobAVu6JbV6jJifCidIaQgFRcdkzl/qVQUtI
2YFRRqtIVG98wIAKmYuvKM4+jLHkqMdf1uslENBT/3RPWghRwsjaAgqPiOZqfAIk
yBJKOcEUkdoZxkUkrTdUS31cYrNFsiYCo5VEDccs9s+GTAb28XD1mFfazYdjZa35
FoG/8Vo1lD9/vBguQs9K
=78sQ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.