Debian Bug report logs - #747908
[libtuxcap] [transition blocker] Please allow to compile with imagemagick/experimental

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: bastien ROUCARIES <roucaries.bastien@gmail.com>

To: submit@bugs.debian.org

Subject: [libtuxcap] [transition blocker] Please allow to compile with imagemagick/experimental

Date: Mon, 12 May 2014 21:33:52 +0000

[Message part 1 (text/plain, inline)]

Package: libtuxcap
Severity: important
control: block -1 by  747907
control: block 740495 by -1
control: tags -1 + patch

Hi,

Please allow  libtuxcap to compile with newer imagemagick.

I have a patch to test but due to cmake bug I could not yet test.

[magick.patch (text/x-patch, attachment)]

Message #16 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Bastien ROUCARIES <roucaries.bastien@gmail.com>

To: 747908@bugs.debian.org

Subject: Raise severity

Date: Tue, 9 Sep 2014 21:06:36 +0200

control: severity -1 + serious

Message #21 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Emilio Pozuelo Monfort <pochu@debian.org>

To: 747908@bugs.debian.org

Subject: libtuxcap: FTBFS with new imagemagick

Date: Wed, 10 Sep 2014 04:40:35 +0200

Control: severity -1 serious

The new imagemagick is now in unstable, so this is RC. It'd be great to get it
fixed ASAP as it blocks a transition.

Emilio

Message #30 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@gambaru.de>

To: bastien ROUCARIES <roucaries.bastien@gmail.com>

Cc: 747908@bugs.debian.org, Emilio Pozuelo Monfort <pochu@debian.org>

Subject: Re: [libtuxcap] [transition blocker] Please allow to compile with imagemagick/experimental

Date: Fri, 12 Sep 2014 13:14:47 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 - patch

On Mon, 12 May 2014 21:33:52 +0000 bastien ROUCARIES
<roucaries.bastien@gmail.com> wrote:

[...]
> Hi,
> 
> Please allow  libtuxcap to compile with newer imagemagick.
> 
> I have a patch to test but due to cmake bug I could not yet test.

Hi,

I have just tested your patch. Unfortunately libtuxcap still FTBFS in
the configure step.

I wonder if we should keep libtuxcap at all. There has not been a new
release for five years now, it has no reverse dependencies and it seems
there is not much interest in maintaining this package.

For what it's worth, libtuxcap shouldn't block this transition so please
go ahead and remove it from testing.

Regards,

Markus

[signature.asc (application/pgp-signature, attachment)]

Message #37 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@ubuntu.com>

To: Markus Koschany <apo@gambaru.de>, 747908@bugs.debian.org

Cc: bastien ROUCARIES <roucaries.bastien@gmail.com>, Emilio Pozuelo Monfort <pochu@debian.org>

Subject: Re: Bug#747908: [libtuxcap] [transition blocker] Please allow to compile with imagemagick/experimental

Date: Fri, 31 Oct 2014 10:24:09 +0000

Control: tag -1 patch
Control: user ubuntu-devel@lists.ubuntu.com
Control: usertag -1 ubuntu-patch vivid

On Fri, Sep 12, 2014 at 01:14:47PM +0200, Markus Koschany wrote:
> On Mon, 12 May 2014 21:33:52 +0000 bastien ROUCARIES
> <roucaries.bastien@gmail.com> wrote:
> > Please allow  libtuxcap to compile with newer imagemagick.
> > 
> > I have a patch to test but due to cmake bug I could not yet test.
> 
> Hi,
> 
> I have just tested your patch. Unfortunately libtuxcap still FTBFS in
> the configure step.

Here's a simpler patch that gets the job done.  I effectively replaced
the existing cmake_imagemagick.patch rather than creating too much
patch-on-patch spaghetti there.

  * Use pkg-config to get ImageMagick build flags.

diff -u libtuxcap-1.4.0.dfsg2/debian/patches/cmake_imagemagick.patch libtuxcap-1.4.0.dfsg2/debian/patches/cmake_imagemagick.patch
--- libtuxcap-1.4.0.dfsg2/debian/patches/cmake_imagemagick.patch
+++ libtuxcap-1.4.0.dfsg2/debian/patches/cmake_imagemagick.patch
@@ -1,19 +1,56 @@
-Description: cmake's ImageMagick module seems to have changed and now looks
- for the executables, while we only need the libs here
+Description: Use pkg-config to get ImageMagick build flags
 Origin: vendor
-Bug-Debian: http://bugs.debian.org/674369
+Bug-Debian: https://bugs.debian.org/747908
 Forwarded: no
-Author: gregor herrmann <gregoa@debian.org>
-Last-Update: 2012-06-07
+Author: Colin Watson <cjwatson@ubuntu.com>
+Last-Update: 2014-10-31
 
+Index: b/tuxcap/CMakeLists.txt
+===================================================================
 --- a/tuxcap/CMakeLists.txt
 +++ b/tuxcap/CMakeLists.txt
-@@ -16,7 +16,7 @@
+@@ -16,10 +16,10 @@
  
  Find_Package ( SDL REQUIRED )
  Find_Package ( SDL_mixer REQUIRED )
 -Find_Package ( ImageMagick REQUIRED )
-+Find_Package ( ImageMagick COMPONENTS Magick++ MagickWand MagickCore REQUIRED )
  Find_Package ( OpenGL REQUIRED )
  
- FIND_PACKAGE(ImageMagickLib)
+-FIND_PACKAGE(ImageMagickLib)
++FIND_PACKAGE(PkgConfig REQUIRED)
++PKG_CHECK_MODULES(IMAGEMAGICK REQUIRED Magick++ MagickWand MagickCore)
+ 
+ FIND_PACKAGE(AudiereLib)
+ IF(AUDIERELIB_FOUND)
+@@ -31,8 +31,7 @@
+    ${SDL_LIBRARY}
+    ${SDLMIXER_LIBRARY}
+    ${OPENGL_LIBRARIES}
+-   ${IMAGEMAGICKLIB_LIBRARIES} 
+-   ${IMAGEMAGICKLIB_CXX_LIBRARIES} 
++   ${IMAGEMAGICK_LIBRARIES}
+ )
+ 
+ IF (PYTHON_LIBRARIES)
+@@ -76,11 +75,7 @@
+ MESSAGE(FATAL_ERROR "libSDL requested but not found.")
+ ENDIF(SDL_FOUND)
+ 
+-IF(IMAGEMAGICKLIB_FOUND)
+-MESSAGE("lib ImageMagick found. ${IMAGEMAGICKLIB_INCLUDE_DIR} ${IMAGEMAGICKLIB_LIBRARIES} ${IMAGEMAGICKLIB_CXX_LIBRARIES}")
+-ELSE(IMAGEMAGICKLIB_FOUND)
+-MESSAGE(FATAL_ERROR "lib ImageMagick requested but not found.")
+-ENDIF(IMAGEMAGICKLIB_FOUND)
++MESSAGE("lib ImageMagick found. ${IMAGEMAGICK_INCLUDE_DIRS} ${IMAGEMAGICK_LIBRARIES}")
+ 
+ IF(SDLMIXER_FOUND)
+ MESSAGE("libSDL_mixer found. ${SDLMIXER_INCLUDE_DIR} ${SDLMIXER_LIBRARY}")
+@@ -96,7 +91,7 @@
+ 
+ SET ( MY_INCLUDE_DIRS  
+ #/usr/include/swfdec-0.5 /usr/include/glib-2.0 /usr/lib/glib-2.0/include 
+-{SDL_INCLUDE_DIR} ${IMAGEMAGICKLIB_INCLUDE_DIR} ${SDLMIXER_INCLUDE_DIR} ${OPENGL_INCLUDE_DIR} ${PYTHON_INCLUDE_PATH} )
++{SDL_INCLUDE_DIR} ${IMAGEMAGICK_INCLUDE_DIRS} ${SDLMIXER_INCLUDE_DIR} ${OPENGL_INCLUDE_DIR} ${PYTHON_INCLUDE_PATH} )
+ IF(AUDIERELIB_FOUND)
+ SET ( MY_INCLUDE_DIRS ${MY_INCLUDE_DIRS} ${AUDIERELIB_INCLUDE_DIR} )
+ ENDIF(AUDIERELIB_FOUND)

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

Message #44 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@gambaru.de>

To: Colin Watson <cjwatson@ubuntu.com>, 747908@bugs.debian.org

Cc: bastien ROUCARIES <roucaries.bastien@gmail.com>, Emilio Pozuelo Monfort <pochu@debian.org>

Subject: Re: Bug#747908: [libtuxcap] [transition blocker] Please allow to compile with imagemagick/experimental

Date: Fri, 31 Oct 2014 19:44:56 +0100

[Message part 1 (text/plain, inline)]

On 31.10.2014 11:24, Colin Watson wrote:
[...]
> Here's a simpler patch that gets the job done.  I effectively replaced
> the existing cmake_imagemagick.patch rather than creating too much
> patch-on-patch spaghetti there.

Hi,

thanks for the patch. I can't upload the package myself. If you have
some spare time left, feel free to do a NMU for libtuxcap. Otherwise I
have to find a sponsor first.

Regards,

Markus

[signature.asc (application/pgp-signature, attachment)]

Message #49 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@gambaru.de>

To: 747908@bugs.debian.org

Subject: Re: Bug#747908: [libtuxcap] [transition blocker] Please allow to compile with imagemagick/experimental

Date: Mon, 03 Nov 2014 17:29:00 +0100

[Message part 1 (text/plain, inline)]

Although libtuxcap can be compiled again, I doubt that the package is in
a releasable state. I don't see any upstream activity, the version of
libtuxcap is already five years old and there are more packaging
problems such as

https://bugs.debian.org/767948
https://bugs.debian.org/623300

In addition popcon shows that there are no active users of libtuxcap and
it has no reverse-dependencies.

Markus

[signature.asc (application/pgp-signature, attachment)]

Message #54 received at 747908@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: 747908@bugs.debian.org

Subject: libtuxcap: diff for NMU version 1.4.0.dfsg2-2.2

Date: Thu, 6 Nov 2014 10:48:33 +0000

[Message part 1 (text/plain, inline)]

Control: tag -1 pending

Dear maintainer,

I've prepared an NMU for libtuxcap (versioned as 1.4.0.dfsg2-2.2) and
uploaded it to DELAYED/5.  Please feel free to tell me if I should delay
it longer.

Regards,

-- 
Colin Watson                                       [cjwatson@debian.org]

[libtuxcap-1.4.0.dfsg2-2.2-nmu.diff (text/x-diff, attachment)]

Message #61 received at 747908-close@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: 747908-close@bugs.debian.org

Subject: Bug#747908: fixed in libtuxcap 1.4.0.dfsg2-2.2

Date: Tue, 11 Nov 2014 11:19:30 +0000

Source: libtuxcap
Source-Version: 1.4.0.dfsg2-2.2

We believe that the bug you reported is fixed in the latest version of
libtuxcap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 747908@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated libtuxcap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 06 Nov 2014 10:16:34 +0000
Source: libtuxcap
Binary: libtuxcap-dev libtuxcap4.0 libtuxcap4.0-dbg
Architecture: source amd64
Version: 1.4.0.dfsg2-2.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 libtuxcap-dev - framework for developing 2D games - development files
 libtuxcap4.0 - framework for developing 2D games - runtime libraries
 libtuxcap4.0-dbg - framework for developing 2D games - debugging symbols
Closes: 747908
Changes:
 libtuxcap (1.4.0.dfsg2-2.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Use pkg-config to get ImageMagick build flags (closes: #747908).
Checksums-Sha1:
 13ad094660666c5df087b35f76e23c2e542a031c 2283 libtuxcap_1.4.0.dfsg2-2.2.dsc
 e9b69481a315d80e56d4c8ab45c59fc7709a887e 10863 libtuxcap_1.4.0.dfsg2-2.2.diff.gz
 2f0578e6227a3ee4a4f8c01e3553bbc4947bc6c0 788624 libtuxcap-dev_1.4.0.dfsg2-2.2_amd64.deb
 0a7e74cc3e7febbd2a681cc093dd19672d10afb7 473866 libtuxcap4.0_1.4.0.dfsg2-2.2_amd64.deb
 b8e6bb6d5f3f210c64ce130a99141c200a03392c 107114 libtuxcap4.0-dbg_1.4.0.dfsg2-2.2_amd64.deb
Checksums-Sha256:
 9c412d3e015daf2025aaee7cff835f99ebca11c147c98155052c1b4df8524086 2283 libtuxcap_1.4.0.dfsg2-2.2.dsc
 43c4d50e47f2ea7813dd9a71446ed27440f4c9b1c901fe36f64951f9b0259d93 10863 libtuxcap_1.4.0.dfsg2-2.2.diff.gz
 a9dac3f6a398f4e3f15129e66b4eb5971bac5cf997bb42ecb4fb749c7adfe547 788624 libtuxcap-dev_1.4.0.dfsg2-2.2_amd64.deb
 e279f6ceb27eb728923f6180c5cb88b2232ce2c69f2e3f61dba30f4654240546 473866 libtuxcap4.0_1.4.0.dfsg2-2.2_amd64.deb
 1dc0fbee6b311b3c8b0bc8f0b8184ce9308ac81f16f54f27a2295ab876c2d49a 107114 libtuxcap4.0-dbg_1.4.0.dfsg2-2.2_amd64.deb
Files:
 fcb063043ea3db97d8eb19380aaa08ce 2283 libs optional libtuxcap_1.4.0.dfsg2-2.2.dsc
 104b47fdfb832ab5c28ad7b183784308 10863 libs optional libtuxcap_1.4.0.dfsg2-2.2.diff.gz
 383a5dc58dcc98671bf106e6666e9231 788624 libdevel optional libtuxcap-dev_1.4.0.dfsg2-2.2_amd64.deb
 072569c5c6be24e57141489c275d1e66 473866 libs optional libtuxcap4.0_1.4.0.dfsg2-2.2_amd64.deb
 dc168bc376369e7c40ad0cac4057c9d2 107114 debug extra libtuxcap4.0-dbg_1.4.0.dfsg2-2.2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBVFtRgzk1h9l9hlALAQiGyg/+PcVqaR0IWZ+MZT90fq8oNvWlR+zrBLcj
dWWo3EZwDJ8XXzvzZOdH9XyrVkX04BEdzwj/2AtjuTYcmgo3rI/twzd2F98myb2j
AcMdcYabRwgNQiDtS71lyhelvGxKUe1mW594RxTG0cNhDWk1An+J4PkZC0T3HZRv
8Fp2Wlhm1wMtfAq0Zh2mLGlSPeUKYS7LQ776HSZ0W9Hj0c8YKI1UtBGMY8XCnBx6
TO9TRfYmV6vFxqtJQdJwH1sKffv8K+7uxpGSTT8q3LAXMEFym+37E/KUOxygtc6q
vrnU8E6wOah2fs1W5No9E6AnDRHoJSMU0+9yfVPKPEpRoGmwC+StwYc+IdZUBSPD
UnZ/PMLNNg9lX1nnQfnviXzp0QOFodf5i0is6StzVQFD5gc9tQTSWPth2wEU+LRT
7RewLqcGm+Pzxbev1lrGBT4Mx7bhI8vf05+g1g9nMjXrM3/a+jau5tc+Ejz+Kaa7
OlNS5OnQRkuyhd1wgT5RhEVtWvTLlOGi/wxwLnpFH6TYTC9/LPxC0YCFArLO5kvt
BQxCRgffoxfBJ12oSt4HTsI+bxBvcxZxLhI7H/5bA1dM+cohz3cRvmkXkbUkX6CY
1m8TtuvbJQI+dBDt4LrD2iLLCgQ7iao67w4yiovF6pYGPcisTqxox7abb98aRGzk
PolE3M64QXo=
=PZQ4
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.