Debian Bug report logs - #742410
please update ifenslave script to be compatible with latest ifupdown

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andrew Shadura <andrewsh@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: please update ifenslave script to be compatible with latest ifupdown

Date: Sun, 23 Mar 2014 14:55:33 +0100

[Message part 1 (text/plain, inline)]

Package: ifenslave
Version: 2.4
Severity: important
Tags: patch

Here's a patch to fix some issues with latest ifupdown versions.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.12-1-686-pae (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/mksh

Versions of packages ifenslave depends on:
ii  ifupdown  0.7.47.2
ii  iproute2  3.9.0-5

Versions of packages ifenslave recommends:
ii  net-tools  1.60-24.2

ifenslave suggests no packages.

-- no debconf information

[ifenslave.diff (text/x-diff, attachment)]

Message #10 received at 742410@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@debian.org>

To: Andrew Shadura <andrewsh@debian.org>, 742410@bugs.debian.org

Subject: Re: Bug#742410: please update ifenslave script to be compatible with latest ifupdown

Date: Mon, 24 Mar 2014 14:22:36 +1100

[Message part 1 (text/plain, inline)]

Hi Andrew,

On Sun, 23 Mar 2014 14:55:33 Andrew Shadura wrote:
> Here's a patch to fix some issues with latest ifupdown versions.

Thanks for your patch but I have some questions:

 * What issues?

 * What is the meaning of "[ "$ADDRFAM" = meta ] && exit 0"?
   Should we use it in all (if-post-down|if-pre-up|if-up) scripts?

 * What are the benefits of using "ifquery --state" over
   "/etc/network/run/ifstate"? Are you planning to decomission the latter?

 * Could you please review the attached patch?

Thank you.

-- 
Cheers,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

Problems are not stop signs, they are guidelines.
        -- Robert H. Schuller

[0001-ifupdown-0.7.46-compatibility-update-Closes-742410.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 742410@bugs.debian.org (full text, mbox, reply):

From: Andrew Shadura <andrewsh@debian.org>

To: 742410@bugs.debian.org

Cc: Dmitry Smirnov <onlyjob@debian.org>

Subject: Re: Bug#742410: please update ifenslave script to be compatible with latest ifupdown

Date: Mon, 24 Mar 2014 07:35:44 +0100

[Message part 1 (text/plain, inline)]

Hello,

On Mon, 24 Mar 2014 14:22:36 +1100
Dmitry Smirnov <onlyjob@debian.org> wrote:

>  * What issues?

The script apparently is being called for ‘--all’ pseudointerface.
Also, it uses ifstate file from a wrong location, which is no longer
guaranteed to exist. Apart from that, I plan to break ifstate file down
in multiple per-interface files possibly with a bit different format,
so it won't work either in that case.

>  * What is the meaning of "[ "$ADDRFAM" = meta ] && exit 0"?
>    Should we use it in all (if-post-down|if-pre-up|if-up) scripts?

Yes, I should have patched all three scripts, but was a bit in a
hurry :)

>  * What are the benefits of using "ifquery --state" over
>    "/etc/network/run/ifstate"? Are you planning to decomission the
> latter?

Yes, see above.

>  * Could you please review the attached patch?

Well, the changelog entry could be more descriptive :) Also, I don't
know why did I write it that way, but grep isn't needed there. It's
possible to directly ask ifquery about an interface:

 ifquery --state eth0

and it will print the corresponding line from ifstate and return true,
or print nothing and return false if that interface isn't up.

-- 
Cheers,
  Andrew

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 742410-submitter@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@member.fsf.org>

To: 742410-submitter@bugs.debian.org

Subject: Bug#742410 tagged as pending

Date: Mon, 24 Mar 2014 07:31:26 +0000

tag 742410 pending
--

We believe that the bug #742410 you reported has been fixed in the Git
repository. You can see the commit message below and/or inspect the
commit contents at:

    http://anonscm.debian.org/gitweb/?p=collab-maint/ifenslave.git;a=commitdiff;h=d97b18d

(This message was generated automatically by
 'git-post-receive-tag-pending-commitmsg' hook).
---
commit d97b18d (HEAD, master)
Author: Dmitry Smirnov <onlyjob@member.fsf.org>
Date:   Mon Mar 24 02:53:19 2014

    "ifupdown (>= 0.7.46)" compatibility update (Closes: #742410)
    
        Thanks to Andrew Shadura.

Message #25 received at 742410@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@debian.org>

To: Andrew Shadura <andrewsh@debian.org>

Cc: 742410@bugs.debian.org

Subject: Re: Bug#742410: please update ifenslave script to be compatible with latest ifupdown

Date: Mon, 24 Mar 2014 18:38:41 +1100

Hi Andrew,

Thank you very much for your comments.

> Dmitry Smirnov <onlyjob@debian.org> wrote:
> >  * What is the meaning of "[ "$ADDRFAM" = meta ] && exit 0"?

Sorry could you please write a little bit more about how

    [ "$ADDRFAM" = meta ] && exit 0

works and what does it do? I don't know about "$ADDRFAM"... Thanks.


> >  * Could you please review the attached patch?
> 
> Well, the changelog entry could be more descriptive :) Also, I don't
> know why did I write it that way, but grep isn't needed there. It's
> possible to directly ask ifquery about an interface:
> 
>  ifquery --state eth0
> 
> and it will print the corresponding line from ifstate and return true,
> or print nothing and return false if that interface isn't up.

I've committed corresponding changes. Please let me know if you spot anything 
else to improve. :)

-- 
Cheers,
 Dmitry Smirnov.

Message #30 received at 742410@bugs.debian.org (full text, mbox, reply):

From: Andrew Shadura <andrewsh@debian.org>

To: 742410@bugs.debian.org

Cc: Dmitry Smirnov <onlyjob@debian.org>

Subject: Re: Bug#742410: please update ifenslave script to be compatible with latest ifupdown

Date: Mon, 24 Mar 2014 09:00:59 +0100

[Message part 1 (text/plain, inline)]

Hello,

On Mon, 24 Mar 2014 18:38:41 +1100
Dmitry Smirnov <onlyjob@debian.org> wrote:

> > Dmitry Smirnov <onlyjob@debian.org> wrote:
> > >  * What is the meaning of "[ "$ADDRFAM" = meta ] && exit 0"?
> 
> Sorry could you please write a little bit more about how
> 
>     [ "$ADDRFAM" = meta ] && exit 0
> 
> works and what does it do? I don't know about "$ADDRFAM"... Thanks.

Actually I did, but not directly :)

Here's an excerpt from the man page:

When  ifupdown  is being called with the --all option, before doing
anything to interfaces, if calls all the hook scripts (pre-up or down)
with IFACE set to "--all", LOGICAL set to the current value of
--allow  parameter  (or  "auto"  if  it's  not  set),  ADDRFAM="meta"
and METHOD="none".  After all the interfaces have been brought up or
taken down, the appropriate scripts (up or post-down) are executed.


-- 
Cheers,
  Andrew

[signature.asc (application/pgp-signature, attachment)]

Message #35 received at 742410-close@bugs.debian.org (full text, mbox, reply):

From: Dmitry Smirnov <onlyjob@debian.org>

To: 742410-close@bugs.debian.org

Subject: Bug#742410: fixed in ifenslave 2.5

Date: Thu, 27 Mar 2014 05:03:44 +0000

Source: ifenslave
Source-Version: 2.5

We believe that the bug you reported is fixed in the latest version of
ifenslave, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 742410@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Smirnov <onlyjob@debian.org> (supplier of updated ifenslave package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 24 Mar 2014 18:26:30 +1100
Source: ifenslave
Binary: ifenslave ifenslave-2.6
Architecture: source all
Version: 2.5
Distribution: unstable
Urgency: low
Maintainer: Guus Sliepen <guus@debian.org>
Changed-By: Dmitry Smirnov <onlyjob@debian.org>
Description: 
 ifenslave  - configure network interfaces for parallel routing (bonding)
 ifenslave-2.6 - transitional package, use "ifenslave"
Closes: 742410
Changes: 
 ifenslave (2.5) unstable; urgency=low
 .
   * "ifupdown (>= 0.7.46)" compatibility update (Closes: #742410).
     Thanks to Andrew Shadura.
   * Added versioned Depends on "ifupdown (>= 0.7.46)".
Checksums-Sha1: 
 2ac6f48688cfc6bf0ba4d962df0c3de0cfb77c08 1599 ifenslave_2.5.dsc
 4112b5d7b9ba68c0e12ed6cc3abf5fbcb85c5592 12216 ifenslave_2.5.tar.xz
 dd0adf13b870e4e23ccafbecddde0dba0b31d69f 14756 ifenslave_2.5_all.deb
 879e7310dee28dab3724a0ccfeb4c89ba07f2fc3 5824 ifenslave-2.6_2.5_all.deb
Checksums-Sha256: 
 96e0a75861c0e49f480071cc4c1a6bb95c6d048fa3df040570e9bb66cde90b9f 1599 ifenslave_2.5.dsc
 2230c49a652ba772573d6e3a130433597197a05079761a4a316eacdacf42b0d4 12216 ifenslave_2.5.tar.xz
 dd60f52bae30d41ca54f194e4c9c2c523b13c5b5f4b7d23109e8fc4a7924b761 14756 ifenslave_2.5_all.deb
 53b77f98125f242e15c7cac237490e3091b4902908f8146791900208de5dd78c 5824 ifenslave-2.6_2.5_all.deb
Files: 
 20322696089f25b2b31c9ecae0c0a392 1599 net optional ifenslave_2.5.dsc
 e62ccd92e2fb28296af341ae44abf410 12216 net optional ifenslave_2.5.tar.xz
 c7998361b21b8f181526f6261bf8e576 14756 net optional ifenslave_2.5_all.deb
 c4c57f669b44cace9a0e620e447afe43 5824 oldlibs extra ifenslave-2.6_2.5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJTMmNdAAoJEFK2u9lTlo0bSQQQALZXHZ7+BXFPmzzyrySTAfxG
DY8Gj+c8OJVyMuDeT5Vkgtk7QfOi4BA7mt6wTlRBiehz+g872zF7FoGPL34Xqxap
EPBSbdMxdc7HwzjabziVtT/1cko8jqUNcnXIr1t9D1YDuv8lCMBg3XTcC8Zrik6A
SHTIbDW1TU9ui5Hxs4nQj1eqkSImgHsofpk8qnzeWwAz+Jba23bzxgriqx35N8Vm
JrPjEIy/rWDLN2LUB4xAH49JWcgEgreDuzxtgSL5NISr14AGQUDVoiYiQsEv/CsS
Cybf94B8R5k3SpxP4GH8PjlieVS2f4r/rjBNxQ8jTrUm7JhV85JkFdLjX8qsTPDE
zOvH93ekHLY+Q+l829pnRWhUnNz5WQLE7ZYteKDKretohO+gvgUn4ZkxU42e3zlp
UAzhGEjkL987cGv3bsfEaUfIgBcTTYDWkIzi6fLxj70ja4vGoNM8O5UJgryaxWPM
/bQrcEz6UdzdCIE5X7KaRgRLlLkt1YtmUsbqGbzvsuDKRRF6WX/wT5IiMkXyyouJ
LyeP16zq6+hmr8LYeu3fTdeafFS8v4b0/9rkCXKPgX2pBtgtLFGzzPRrmYrzH6HP
P9qxuCdts8UZ91oqhFafigWkHiTZMA1JJFTwUHYZ+BzayTWvJ9Z0XohYRauBd8ig
+z1PoHlOCzAFLfxVP1mX
=Bqit
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.