Debian Bug report logs - #739835
filename completion broken with bash 4.3

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Dan Jacobson <jidanni@jidanni.org>

To: submit@bugs.debian.org

Subject: Re: ~ vs. filename expansion

Date: Sun, 23 Feb 2014 09:05:19 +0800

X-debbugs-cc: chet.ramey@case.edu bug-bash@gnu.org
Package: bash-completion
Version: 1:2.1-2

>>>>> "CR" == Chet Ramey <chet.ramey@case.edu> writes:
CR> On 2/21/14, 9:33 PM, Dan Jacobson wrote:
>> Hitting TAB twice at the end of
>> nobody@jidanni5:/$ : /home/jidanni/jidanni.org/location/directions/
>> nobody@jidanni5:/$ : ~jidanni/jidanni.org/location/directions/
>> shows a list of list of the filenames for the former, but not the
>> latter. Indeed the for the latter one will have to type the filenames in
>> by hand. BASH_VERSION='4.3.0(1)-rc2'

CR> I can't reproduce this on Mac OS X or RHEL 5.  Are you sure it's not
CR> bash-completion?

Indeed, I see that package is installed on my jidanni5 machine where the
problem occurred, but not on my jidanni6 machine where I am today where
I cannot reproduce it. OK I will remove the bash-completion package on
my jidanni5 machine. If anybody is interested, all one needs to do is su
- nobody to get the pristine testing environment to reproduce it there
on Debian sid.

Message #10 received at 739835@bugs.debian.org (full text, mbox, reply):

From: Francesco Poli <invernomuto@paranoici.org>

To: 740975@bugs.debian.org, 739835@bugs.debian.org

Subject: Should these two bugs be merged?

Date: Mon, 10 Mar 2014 22:08:52 +0100

[Message part 1 (text/plain, inline)]

Hello,
I also seem to experience this bug, after the upgrade

[UPGRADE] bash:amd64 4.2+dfsg-1 -> 4.3-2

I am under the impression that these two bug reports (#740975 and
#739835) are about the same issue: should they be just be merged?

I hope this issue may be fixed real soon now, as it is definitely
annoying.

Thanks for any help you may provide.
Bye.


-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 739835@bugs.debian.org (full text, mbox, reply):

From: JuanJo Ciarlante <jjo@canonical.com>

To: 739835@bugs.debian.org

Subject: Re: ~ vs. filename expansion

Date: Tue, 11 Mar 2014 11:44:04 -0300

Following patch (from this MP[1]) seems to fix it for me - at least for:

1) completion when 1st char is '~'
2) fixing potential double escaping when the argument is already
escaped, eg: cat /tmp/file\ with\ spac<TAB>

------------------------------------------------------------
revno: 46
committer: JuanJo Ciarlante <jjo@canonical.com>
branch nick: bash-completion
timestamp: Tue 2014-03-11 11:27:12 -0300
message:
  [jjo, r=] fix _quote_readline_by_ref to avoid escaping 1st '~', and
re-eval to fix double escaping
diff:
=== modified file 'bash_completion'
--- bash_completion	2013-12-27 01:28:28 +0000
+++ bash_completion	2014-03-11 14:27:12 +0000
@@ -539,6 +539,9 @@
     if [[ $1 == \'* ]]; then
         # Leave out first character
         printf -v $2 %s "${1:1}"
+    elif [[ $1 == ~* ]]; then
+        # avoid escaping first ~
+        printf -v $2 ~%q "${1:1}"
     else
         printf -v $2 %q "$1"
     fi
@@ -547,6 +550,10 @@
     # drop the additional quoting.  See also: http://www.mail-archive.com/
     # bash-completion-devel@lists.alioth.debian.org/msg01942.html
     [[ ${!2} == \$* ]] && eval $2=${!2}
+    # Re-evaluate if result is double escaped, ie contains: \\
+    # This happens always when argument is already escaped at cmdline,
+    # and passed to this function as e.g.: file\ with\ spaces
+    [[ ${!2} == *\\* ]] && eval $2=${!2}
 } # _quote_readline_by_ref()

[1]
https://code.launchpad.net/~jjo/bash-completion/fix-bash43-quote_readline_by_ref-tilde-and-double_escaping/+merge/210421

Cheers,
--JuanJo - http://twitter.com/xjjo - http://bit.ly/jjo-cv

Message #20 received at 739835@bugs.debian.org (full text, mbox, reply):

From: Matthew Gabeler-Lee <cheetah@fastcat.org>

To: Debian Bug Tracking System <739835@bugs.debian.org>

Subject: Re: ~ vs. filename expansion

Date: Tue, 11 Mar 2014 17:18:15 -0400

Package: bash-completion
Version: 1:2.1-2
Followup-For: Bug #739835

Dear Maintainer,

Now that jessie has upgrade to bash 4.3, this is pretty much making bash-completion unusable!

The patch referenced JuanJo Ciarlante definitely fixes the problem for me.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages bash-completion depends on:
ii  bash  4.3-2
ii  dpkg  1.17.6

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information

Message #25 received at 739835@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: 739835@bugs.debian.org

Cc: 741479@bugs.debian.org, shirish शिरीष <shirishag75@gmail.com>, Claudio Moretti <flyingstar16@gmail.com>, Joey Hess <joeyh@debian.org>, 741860@bugs.debian.org, 742071@bugs.debian.org, KatolaZ <v.nicosia@qmul.ac.uk>, 742054@bugs.debian.org, 741903@bugs.debian.org, Paul Brossier <piem@debian.org>, 740975@bugs.debian.org, Philipp Hagemeister <phihag@phihag.de>, Jean-Baka Domelevo Entfellner <domelevo@gmail.com>, Francesco Poli <invernomuto@paranoici.org>, Dan Jacobson <jidanni@jidanni.org>, JuanJo Ciarlante <jjo@canonical.com>, Matthew Gabeler-Lee <cheetah@fastcat.org>, Ville Skyttä <ville.skytta@iki.fi>

Subject: filename completion broken with bash 4.3

Date: Wed, 19 Mar 2014 01:17:17 +0100

forcemerge 739835 741479 741860 742071 742054 741903 740975
retitle 739835 filename completion broken with bash 4.3
severity 739835 important
tags 739835 upstream confirmed
thanks

Hello all,

(sorry for the long list of CC)

writing to you because you reported a bug within bash-completion, which is
likely caused by the upgrade of bash to 4.3.

I've added Ville Skyttä in CC too -- I stopped actively developing
bash-completion long ago, and I believe he's now the main upstream developer,
so keeping him in the mail loop.

Please, from now on, refer to bug #739835 for further posts.

Ville: it seems like
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739835#15 contains a
patch: have you had the chance to look at it? It seems to me that it doesn't
solve the problems reported.

Thanks, and sorry for not being totally clueless,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Message #40 received at 739835@bugs.debian.org (full text, mbox, reply):

From: JuanJo Ciarlante <jjo@canonical.com>

To: 739835@bugs.debian.org, dapal@debian.org

Subject: Re: filename completion broken with bash 4.3

Date: Tue, 18 Mar 2014 22:34:16 -0300

[Message part 1 (text/plain, inline)]

On 03/18/2014 09:17 PM, David Paleino wrote:
> forcemerge 739835 741479 741860 742071 742054 741903 740975
> retitle 739835 filename completion broken with bash 4.3
> severity 739835 important
> tags 739835 upstream confirmed
> thanks
> 
> Hello all,
> 
> (sorry for the long list of CC)
> 
> writing to you because you reported a bug within bash-completion, which is
> likely caused by the upgrade of bash to 4.3.
> 
> I've added Ville Skyttä in CC too -- I stopped actively developing
> bash-completion long ago, and I believe he's now the main upstream developer,
> so keeping him in the mail loop.
> 
> Please, from now on, refer to bug #739835 for further posts.
> 
> Ville: it seems like
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739835#15 contains a
> patch: have you had the chance to look at it? It seems to me that it doesn't
> solve the problems reported.
> 
> Thanks, and sorry for not being totally clueless,
> David
> 

Please find attached the patch we merged into ubuntu trusty, contains
some extra fixes above the one previously at this thread.

Cheers,
--JuanJo

[bash-completion-4.3-from_ubuntu_trusty-proposed.debian.patch (text/x-patch, attachment)]

Message #45 received at 739835@bugs.debian.org (full text, mbox, reply):

From: Paul Brossier <piem@debian.org>

To: dapal@debian.org, 739835@bugs.debian.org

Cc: 741479@bugs.debian.org, shirish शिरीष <shirishag75@gmail.com>, Claudio Moretti <flyingstar16@gmail.com>, Joey Hess <joeyh@debian.org>, 741860@bugs.debian.org, 742071@bugs.debian.org, KatolaZ <v.nicosia@qmul.ac.uk>, 742054@bugs.debian.org, 741903@bugs.debian.org, 740975@bugs.debian.org, Philipp Hagemeister <phihag@phihag.de>, Jean-Baka Domelevo Entfellner <domelevo@gmail.com>, Francesco Poli <invernomuto@paranoici.org>, Dan Jacobson <jidanni@jidanni.org>, JuanJo Ciarlante <jjo@canonical.com>, Matthew Gabeler-Lee <cheetah@fastcat.org>, Ville Skyttä <ville.skytta@iki.fi>, control@bugs.debian.org

Subject: Re: filename completion broken with bash 4.3

Date: Tue, 18 Mar 2014 22:17:15 -0300

[Message part 1 (text/plain, inline)]

tags 739835 patch
thanks

06:28 < piem> am i the only one being struck by 741903?
06:33 < infinity> piem:
http://launchpadlibrarian.net/169422307/bash-completion_1%3A2.1-2ubuntu3_1%3A2.1-2ubuntu4.diff.gz
06:33  * infinity bugs jjo to forward that.
06:40 < infinity> piem: You might just want to grab the Ubuntu
bash-completion deb, it fixes a few bugs, I'll hunt down people to
forward it all.
06:40 < infinity>
https://launchpad.net/ubuntu/+source/bash-completion/1:2.1-2ubuntu4/+build/5810094
06:44 < piem> infinity: nice, thanks

On 03/18/2014 09:17 PM, David Paleino wrote:
> forcemerge 739835 741479 741860 742071 742054 741903 740975
> retitle 739835 filename completion broken with bash 4.3
> severity 739835 important
> tags 739835 upstream confirmed
> thanks
>
> Hello all,
>
> (sorry for the long list of CC)
>
> writing to you because you reported a bug within bash-completion, which is
> likely caused by the upgrade of bash to 4.3.
>
> I've added Ville Skyttä in CC too -- I stopped actively developing
> bash-completion long ago, and I believe he's now the main upstream developer,
> so keeping him in the mail loop.
>
> Please, from now on, refer to bug #739835 for further posts.
>
> Ville: it seems like
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739835#15 contains a
> patch: have you had the chance to look at it? It seems to me that it doesn't
> solve the problems reported.
>
> Thanks, and sorry for not being totally clueless,
> David
>
   

[signature.asc (application/pgp-signature, attachment)]

Message #50 received at 739835@bugs.debian.org (full text, mbox, reply):

From: Jean-Baka Domelevo Entfellner <domelevo@gmail.com>

To: Paul Brossier <piem@debian.org>, 740975@bugs.debian.org

Cc: dapal@debian.org, 739835@bugs.debian.org, 741479@bugs.debian.org, shirish शिरीष <shirishag75@gmail.com>, Claudio Moretti <flyingstar16@gmail.com>, Joey Hess <joeyh@debian.org>, 741860@bugs.debian.org, 742071@bugs.debian.org, KatolaZ <v.nicosia@qmul.ac.uk>, 742054@bugs.debian.org, 741903@bugs.debian.org, Philipp Hagemeister <phihag@phihag.de>, Francesco Poli <invernomuto@paranoici.org>, Dan Jacobson <jidanni@jidanni.org>, JuanJo Ciarlante <jjo@canonical.com>, Matthew Gabeler-Lee <cheetah@fastcat.org>, Ville Skyttä <ville.skytta@iki.fi>, control@bugs.debian.org

Subject: Re: Bug#740975: filename completion broken with bash 4.3

Date: Wed, 19 Mar 2014 09:08:24 +0200

Ok, thanks, any of the two patches proposed by JuanJo works fine for
me (Debian unstable, GNU bash version 4.3.0(1)-release, patching
bash-completion bash-completion version: 1:2.1-2).

Thanks,
   Jean-Baka

On Wed, Mar 19, 2014 at 3:17 AM, Paul Brossier <piem@debian.org> wrote:
> tags 739835 patch
> thanks
>
> 06:28 < piem> am i the only one being struck by 741903?
> 06:33 < infinity> piem:
> http://launchpadlibrarian.net/169422307/bash-completion_1%3A2.1-2ubuntu3_1%3A2.1-2ubuntu4.diff.gz
> 06:33  * infinity bugs jjo to forward that.
> 06:40 < infinity> piem: You might just want to grab the Ubuntu
> bash-completion deb, it fixes a few bugs, I'll hunt down people to
> forward it all.
> 06:40 < infinity>
> https://launchpad.net/ubuntu/+source/bash-completion/1:2.1-2ubuntu4/+build/5810094
> 06:44 < piem> infinity: nice, thanks
>
> On 03/18/2014 09:17 PM, David Paleino wrote:
>> forcemerge 739835 741479 741860 742071 742054 741903 740975
>> retitle 739835 filename completion broken with bash 4.3
>> severity 739835 important
>> tags 739835 upstream confirmed
>> thanks
>>
>> Hello all,
>>
>> (sorry for the long list of CC)
>>
>> writing to you because you reported a bug within bash-completion, which is
>> likely caused by the upgrade of bash to 4.3.
>>
>> I've added Ville Skyttä in CC too -- I stopped actively developing
>> bash-completion long ago, and I believe he's now the main upstream developer,
>> so keeping him in the mail loop.
>>
>> Please, from now on, refer to bug #739835 for further posts.
>>
>> Ville: it seems like
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739835#15 contains a
>> patch: have you had the chance to look at it? It seems to me that it doesn't
>> solve the problems reported.
>>
>> Thanks, and sorry for not being totally clueless,
>> David
>>
>
>

Message #55 received at 739835@bugs.debian.org (full text, mbox, reply):

From: Vincenzo Nicosia <v.nicosia@qmul.ac.uk>

To: Jean-Baka Domelevo Entfellner <domelevo@gmail.com>

Cc: Paul Brossier <piem@debian.org>, <740975@bugs.debian.org>, <dapal@debian.org>, <739835@bugs.debian.org>, <741479@bugs.debian.org>, shirish शिरीष <shirishag75@gmail.com>, Claudio Moretti <flyingstar16@gmail.com>, Joey Hess <joeyh@debian.org>, <741860@bugs.debian.org>, <742071@bugs.debian.org>, <742054@bugs.debian.org>, <741903@bugs.debian.org>, Philipp Hagemeister <phihag@phihag.de>, Francesco Poli <invernomuto@paranoici.org>, Dan Jacobson <jidanni@jidanni.org>, JuanJo Ciarlante <jjo@canonical.com>, Matthew Gabeler-Lee <cheetah@fastcat.org>, Ville Skyttä <ville.skytta@iki.fi>, <control@bugs.debian.org>

Subject: Re: Bug#740975: filename completion broken with bash 4.3

Date: Wed, 19 Mar 2014 09:05:29 +0000

On Wed, Mar 19, 2014 at 09:08:24AM +0200, Jean-Baka Domelevo Entfellner wrote:
> Ok, thanks, any of the two patches proposed by JuanJo works fine for
> me (Debian unstable, GNU bash version 4.3.0(1)-release, patching
> bash-completion bash-completion version: 1:2.1-2).
> 

Is there a tiny hope we might have the patched packet in Jessie before
2015? :) I'm kidding, but seriously this is a quite basic packet used
by virtually all people who open a text shell (even once in a while),
and not a forgotten script used only by a handful of developers. Is
there anything we may do to speed up the process and have the patch
accepted in testing sooner?

Best

KatolaZ

Message #60 received at 739835-close@bugs.debian.org (full text, mbox, reply):

From: David Paleino <dapal@debian.org>

To: 739835-close@bugs.debian.org

Subject: Bug#739835: fixed in bash-completion 1:2.1-3

Date: Wed, 19 Mar 2014 11:03:30 +0000

Source: bash-completion
Source-Version: 1:2.1-3

We believe that the bug you reported is fixed in the latest version of
bash-completion, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 739835@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Paleino <dapal@debian.org> (supplier of updated bash-completion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 19 Mar 2014 11:44:27 +0100
Source: bash-completion
Binary: bash-completion
Architecture: source all
Version: 1:2.1-3
Distribution: unstable
Urgency: medium
Maintainer: Bash Completion Maintainers <bash-completion-devel@lists.alioth.debian.org>
Changed-By: David Paleino <dapal@debian.org>
Description: 
 bash-completion - programmable completion for the bash shell
Closes: 496162 574950 665651 673235 680852 697513 698977 702498 704832 708173 737672 737881 739835 741657
Changes: 
 bash-completion (1:2.1-3) unstable; urgency=medium
 .
   * Import patch from Ubuntu:
     - fix_quote_readline_by_ref.patch, thanks to JuanJo Ciarlante
       (Closes: #739835):
       + avoid escaping 1st '~' (LP: #1288314)
       + avoid quoting if empty, else expansion without args only shows
         dirs (LP: #1288031)
       + replace double escaping to single (eg for completing file/paths
         with spaces)
     - words_bad_array_subscript.patch, thanks to Barry Warsaw
     - dpkg_ddeb.patch: dpkg also supports *.ddeb, thanks to Sebastien
       Bacher (LP: #568404, Closes: #737881)
     - disable_avahi_browse.patch: slow, and doesn't scale to big
       networks, thanks to Chris Jones (Closes: #574950, LP: #510591)
     - xine_add_more_formats.patch: add oga and ogx to multimedia players
       (Closes: #496162, LP: #311525)
   * debian/maintscript, debian/postinst:
     - clean etc conffiles on upgrade since completion files are in /usr
       with 2.0, thanks to Sebastien Bacher
   * debian/control: marked Multi-Arch: foreign
   * debian/patches/:
     - fix_gcc_detection.patch, correctly parses Debian's GCC version
       number, thanks to Tomas Janousek (Closes: #665651)
     - xpdf_support_compressed_pdf.patch, in Debian xpdf also supports
       compressed files, thanks to Alfredo Finelli (Closes: #702498)
     - dpkg_support_raw-extract_vextract.patch: add support for more
       options in dpkg-deb, thanks to Uwe Storbeck (Closes: #698977)
     - dpkg_fix_-W_option.patch: -W|--show doesn't support udebs/ddebs,
       thanks to Luca Capello (Closes: #697513)
     - aptitude_safe-upgrade.patch: safe-upgrade supports package names,
       thanks to Nicolas Le Cam (Closes: #673235)
     - ifconfig_locale.patch: _mac_addresses() didn't consider locale
       awareness of ifconfig, thanks to Thilo Six (Closes: #704832)
     - dont_return_from_sourced_script.patch: avoid problems with shells
       not supporting returning from a sourced script (Closes: #741657)
     - look_for_pod.patch: perldoc: look for .pod in addition to .pm
       files, thanks to Carl Hayter (Closes: #708173)
   * debian/extra/debhelper/dh_bash-completion: fix installation process
     when more than one "proper snippet" is being installed, thanks to
     Jean-Michel Vourgère (Closes: #680852)
   * Dropped completions included in util-linux (Closes: #737672)
Checksums-Sha1: 
 e9849707f765792d9227836eec5a9db90a1bcb0b 1377 bash-completion_2.1-3.dsc
 abd628e5dfef3242aa467277e4647a0ec0b13a7d 19408 bash-completion_2.1-3.debian.tar.xz
 f2a0edfbace7dfc007d629968e6eec180267c124 182124 bash-completion_2.1-3_all.deb
Checksums-Sha256: 
 2b44aeb674a9690c6af75957fa5308889277c9abd1a05143c81ccb4733e0a15f 1377 bash-completion_2.1-3.dsc
 8f48a945a680d9ab0da54be570929c33ae7bc5ec0f25fb6512fb75db1013ee3a 19408 bash-completion_2.1-3.debian.tar.xz
 d226ff84e0633c0ee4abdb9b2631fe0532b6c516f9d434a035633500811d9049 182124 bash-completion_2.1-3_all.deb
Files: 
 1ad095c77d5c9f34aa34d8822c52af4b 1377 shells standard bash-completion_2.1-3.dsc
 0d3f94bc45de05f6c05bfdf7d8d9a82e 19408 shells standard bash-completion_2.1-3.debian.tar.xz
 b3f48281983f26282a473b2a082d9786 182124 shells standard bash-completion_2.1-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlMpdqQACgkQ5qqQFxOSsXRWtwCfRpjyuFpSIdtHdUnGSM3nzZSv
5OUAn29tGWEKYQydzlajsOUrA45W4D/f
=67po
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.