Debian Bug report logs - #735940
Sourceless file

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: bastien ROUCARIES <roucaries.bastien@gmail.com>

To: submit@bugs.debian.org

Subject: Sourceless file

Date: Sat, 18 Jan 2014 22:34:55 +0000

Package: src:tahoe-lafs 
Version:1.10.0-1
Severity: serious
User: debian-qa@lists.debian.org
Usertags: source-contains-prebuilt-javascript-object
X-Debbugs-CC: ftpmaster@debian.org

It seems that this file are not sourced:

    src/allmydata/web/static/d3-2.4.6.min.js
    src/allmydata/web/static/d3-2.4.6.time.min.js
    src/allmydata/web/static/jquery-1.6.1.min.js

Bastien

Message #10 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Subject: Sourceless file

Date: Tue, 25 Mar 2014 13:04:08 +0000

I'm a maintainer of Tahoe-LAFS. I just opened a ticket to track this
issue in our issue tracker:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2208

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.

Message #15 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Date: Tue, 25 Mar 2014 13:07:44 +0000

Would it satisfy the Debian policy if those Javascript files were
stored in source form instead of minified form?

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.

Message #20 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Olivier Schwander <olivier.schwander@chadok.info>

To: Zooko Wilcox-OHearn <zooko@leastauthority.com>, 735940@bugs.debian.org

Subject: Re: Bug#735940:

Date: Tue, 25 Mar 2014 14:29:58 +0100

Le 25 Mar 2014 13:07, Zooko Wilcox-OHearn a écrit:
> Would it satisfy the Debian policy if those Javascript files were
> stored in source form instead of minified form?

The Debian policy is to avoid shipping external libraries inside a
source package. Since libjs-jquery (1.7.2+dfsg-1) and libjs-d3
(3.3.13-1) are available in sid, the best is to use the minified js
files provided by these two packages. Before doing that, we should check
tahoe-lafs is really working with these version, since they are
different from the ones provided with tahoe-lafs.

Best,

Olivier

Message #25 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: Olivier Schwander <olivier.schwander@chadok.info>

Cc: 735940@bugs.debian.org

Subject: Re: Bug#735940:

Date: Tue, 25 Mar 2014 14:10:42 +0000

I would like for Tahoe-LAFS v1.10 to be included in Debian, but I
don't understand how to make it use the Debian packages of jquery and
d3. That doesn't sound like something that could be done by changing
the upstream source of Tahoe-LAFS. How can I help?

Regards,

Zooko

Message #30 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Olivier Schwander <olivier.schwander@chadok.info>

To: Zooko Wilcox-OHearn <zooko@leastauthority.com>, 735940@bugs.debian.org

Subject: Re: Bug#735940:

Date: Tue, 25 Mar 2014 15:26:57 +0100

Le 25 Mar 2014 14:10, Zooko Wilcox-OHearn a écrit:
> I would like for Tahoe-LAFS v1.10 to be included in Debian, but I
> don't understand how to make it use the Debian packages of jquery and
> d3. That doesn't sound like something that could be done by changing
> the upstream source of Tahoe-LAFS. How can I help?

Hum, I just gave a quick look at the debian package and I do not
understand how these files are produced for the binary package.

Do you know where these 3 files come from ? Some magic inside setup.py
or something like that ?

Message #35 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: Olivier Schwander <olivier.schwander@chadok.info>

Cc: 735940@bugs.debian.org

Subject: Re: Bug#735940:

Date: Tue, 25 Mar 2014 14:41:48 +0000

On Tue, Mar 25, 2014 at 2:26 PM, Olivier Schwander
<olivier.schwander@chadok.info> wrote:
> Hum, I just gave a quick look at the debian package and I do not understand how these files are produced for the binary package.
>
> Do you know where these 3 files come from ? Some magic inside setup.py or something like that ?

Yes, all files in src/allmydata/web/static ¹ get included into the
package built by "setup.py", because it is marked in setup.py as being
"package_data" ².

Does that answer your question?

¹ https://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/src/allmydata/web/static

² https://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/setup.py?annotate=blame&rev=37c8b733a57dbbc4f9db0b3c8427f4e07994c3fa#L454

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.

Message #40 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Olivier Schwander <olivier.schwander@chadok.info>

To: Zooko Wilcox-OHearn <zooko@leastauthority.com>, 735940@bugs.debian.org

Subject: Re: Bug#735940:

Date: Tue, 25 Mar 2014 16:03:35 +0100

Le 25 Mar 2014 14:41, Zooko Wilcox-OHearn a écrit:
> Yes, all files in src/allmydata/web/static ¹ get included into the
> package built by "setup.py", because it is marked in setup.py as being
> "package_data" ².
>
> Does that answer your question?

Oh, ok, I made a mess with my find invocation and missed the js files
inside src/allmydata/web/static.

So, a first solution would be to remove the .min.js upstream, add
original .js and to do the minification at build time.

Since the two js libraries are shipped in Debian the best would be to
remove these js files completely (at least in the debian version of the
sources) and to use the files provided by the debian packages.

Creating a symlink between /usr/share/javascript/d3/d3.min.js (and
others) and the static directory of tahoe-lafs (which seems to be
/usr/lib/python2.7/dist-packages/allmydata/web/static/ right now) would
do the job. Another solution (as found in the libjs-rickshaw package)
would be to replace all the references to a local foobar.min.js file in
html files by the absolute path of the debian-provided js file with a
quick and dirty sed -i in the debian rules (I have no idea of why is
file is publicly accessible through a web server). I don't know how the
webserver part of tahoe works, but it may also be possible to the
directory /usr/share/javascript/ to the search path.

By the way, it's just some ideas, I do not have any experience with js
in debian packages and I do not have any time to work precisely on it
these days.

Best,

Olivier

Message #47 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org, Olivier Schwander <olivier.schwander@chadok.info>

Subject: proposed fix

Date: Sun, 30 Mar 2014 03:43:30 +0000

Dear Olivier, et al.:

Please see Daira Hopwood's proposal:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2208#comment:3

Steps 1, 2, and 3 should be done by Tahoe-LAFS upstream and steps 4,
5, and 6 should be done by Debian. Please go ahead and do your three
steps in parallel with us while we do our three steps!

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.

Message #52 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Daira Hopwood <daira@jacaranda.org>

To: 735940@bugs.debian.org

Subject: Re: Bug#735940

Date: Tue, 08 Apr 2014 00:34:13 +0100

[Message part 1 (text/plain, inline)]

We've run into a snag: the file d3-2.4.6.time.min.js (or any more recent version of that
file) does not appear to be packaged in the libjs-d3 package. Loading only d3.min.js is
not sufficient, since it does not include the d3.time "module". We cannot find any other
Debian package that includes it.

In addition, version 3.3.13-1 of libjs-d3 contains a d3.min.js file that is not
binary-identical to the d3.min.js from the upstream d3 project (downloadable from
<https://github.com/mbostock/d3/releases/tag/v3.3.13>). We are loath to proceed
with using the Debian version without knowing what the differences from upstream are.
(They could just be differences in minification, but that isn't clear.)

-- 
Daira Hopwood ⚥

[signature.asc (application/pgp-signature, attachment)]

Message #57 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Date: Fri, 11 Apr 2014 15:48:24 +0000

I asked on the #debian-devel IRC channel, and mrvn there suggested
that we update the d3 source package and upload the new version to
mentors.debian.org. Also Clint on that channel said that we should
file a bug on libjs-d3.

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.

Message #62 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Ramakrishnan Muthukrishnan <ram@rkrishnan.org>

To: control@bugs.debian.org

Cc: 735940@bugs.debian.org

Subject: Sourceless file

Date: Fri, 18 Apr 2014 09:36:34 +0530

affects 735940 libjs-d3
thanks

Dear libjs-d3 maintainer,

Would you please take a look at the tahoe-lafs bug #735940 report
thread?
-- 
  Ramakrishnan

Message #69 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Daira Hopwood <daira@jacaranda.org>

To: 735940@bugs.debian.org

Subject: Minified JavaScript has been removed upstream

Date: Sun, 27 Apr 2014 00:33:20 +0100

[Message part 1 (text/plain, inline)]

The original complaint is now fixed upstream:
https://tahoe-lafs.org/trac/tahoe-lafs/changeset/b6c0297deea77cce2aa22458f0645635cb1aa50d/trunk
or on github:
https://github.com/tahoe-lafs/tahoe-lafs/commit/b6c0297deea77cce2aa22458f0645635cb1aa50d


We had intended to use the same versions of d3 and jquery that were available
as Debian packages, but were stymied by two problems:

1. There appears to be a non-backward-compatible change in the 3.x releases of d3
   that breaks zoom and pan functionality.
2. We cannot reproduce the d3.js file in the libjs-d3 3.4.6-1 package from the
   upstream sources (filed as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745688 ).


I hope this change is sufficient despite not using the libjs-d3 or libjs-jquery packages.
Please feel free to cherry-pick the above changeset to make a new version of the Debian
tahoe-lafs 1.10 package; it should backport cleanly. (Alternatively, it will be in the
upcoming Tahoe-LAFS v1.11 release.)

-- 
Daira Hopwood ⚥

[signature.asc (application/pgp-signature, attachment)]

Message #74 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Subject: fixed

Date: Wed, 30 Apr 2014 02:39:47 +0000

We, the upstream Tahoe-LAFS maintainers, believe we have fixed this
issue in Tahoe-LAFS. We've closed the ticket in the Tahoe-LAFS issue
tracker:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2208

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.

Message #79 received at 735940@bugs.debian.org (full text, mbox, reply):

From: intrigeri <intrigeri@debian.org>

To: Zooko Wilcox-OHearn <zooko@leastauthority.com>

Cc: 735940@bugs.debian.org

Subject: Re: Bug#735940: fixed

Date: Wed, 30 Apr 2014 08:57:13 +0200

Zooko Wilcox-OHearn wrote (30 Apr 2014 02:39:47 GMT) :
> We, the upstream Tahoe-LAFS maintainers, believe we have fixed this
> issue in Tahoe-LAFS.

Great news! You might want to indicate this tagging this Debian bug
"fixed-upstream". Cheers :)

Message #84 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Subject: Re: fixed

Date: Wed, 30 Apr 2014 16:47:40 +0000

Tags: fixed-upstream

Message #89 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Subject: Re: Bug#735940: Info received (fixed)

Date: Wed, 30 Apr 2014 16:54:52 +0000

Package: tahoe-lafs
Version: 1.10.0-1
Tags: fixed-upstream

Message #94 received at 735940@bugs.debian.org (full text, mbox, reply):

From: intrigeri <intrigeri@debian.org>

To: Zooko Wilcox-OHearn <zooko@leastauthority.com>

Cc: 735940@bugs.debian.org

Subject: Re: Bug#735940: Info received (fixed)

Date: Wed, 30 Apr 2014 19:10:19 +0200

Hi Zooko,

Zooko Wilcox-OHearn wrote (30 Apr 2014 16:54:52 GMT) :
> Package: tahoe-lafs
> Version: 1.10.0-1
> Tags: fixed-upstream

This syntax would work when creating a bug report, but not when
modifying an existing one. Instead, you'll want to either email the
bug address with the "Control: tag -1 + fixed-upstream" pseudo-header,
or the control@bugs.d.o address.

Resources:

  https://www.debian.org/Bugs/server-control
  https://wiki.debian.org/HowtoUseBTS#Tweaking_bug_reports:_control.40bugs.debian.org

Alternatively, the bts(1) command-line tool, available in the
devscripts package, does it just right for you :)

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc

Message #99 received at 735940@bugs.debian.org (full text, mbox, reply):

From: Zooko Wilcox-OHearn <zooko@leastauthority.com>

To: 735940@bugs.debian.org

Subject: Re: Bug#735940: Info received (fixed)

Date: Wed, 30 Apr 2014 17:12:06 +0000

Package: tahoe-lafs
Version: 1.10.0-1
Control: tag -1 + fixed-upstream

Message #106 received at 735940-close@bugs.debian.org (full text, mbox, reply):

From: Ramakrishnan Muthukrishnan <rkrishnan@debian.org>

To: 735940-close@bugs.debian.org

Subject: Bug#735940: fixed in tahoe-lafs 1.10.0-2

Date: Fri, 02 May 2014 18:49:17 +0000

Source: tahoe-lafs
Source-Version: 1.10.0-2

We believe that the bug you reported is fixed in the latest version of
tahoe-lafs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 735940@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ramakrishnan Muthukrishnan <rkrishnan@debian.org> (supplier of updated tahoe-lafs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 02 May 2014 23:47:07 +0530
Source: tahoe-lafs
Binary: tahoe-lafs
Architecture: source all
Version: 1.10.0-2
Distribution: unstable
Urgency: medium
Maintainer: Bert Agaz <bertagaz@ptitcanardnoir.org>
Changed-By: Ramakrishnan Muthukrishnan <rkrishnan@debian.org>
Description: 
 tahoe-lafs - Secure distributed filesystem
Closes: 735940
Changes: 
 tahoe-lafs (1.10.0-2) unstable; urgency=medium
 .
   [Ramakrishnan Muthukrishnan]
   * Include unminified sources for d3 and jquery. (Closes: #735940)
   * New co-maintainer (Ramakrishnan Muthukrishnan).
Checksums-Sha1: 
 a8e674aa20a98eb91a1e0cabba39a8f6d81a18dd 2024 tahoe-lafs_1.10.0-2.dsc
 14fcfa63f44f87d81d840c05216491e7acc328cd 157344 tahoe-lafs_1.10.0-2.debian.tar.xz
 0549ef956b15ab1080abb6af26b256ca2bfdada5 1055748 tahoe-lafs_1.10.0-2_all.deb
Checksums-Sha256: 
 b9afdc2f0fad835222f2efe072ec73c4571a899fe3673411aa4e029f8f5c6ad5 2024 tahoe-lafs_1.10.0-2.dsc
 0e8dc50dcf2afc3e7eae924b39891655185f31fb06f03d9dd02a4f7676954ca0 157344 tahoe-lafs_1.10.0-2.debian.tar.xz
 06b57f6a220c608c875cda3fa5d938878ca3c3c4eb52a021d0ce25e2871bf605 1055748 tahoe-lafs_1.10.0-2_all.deb
Files: 
 df3321b7ab35329579d57c9afacb5714 1055748 utils optional tahoe-lafs_1.10.0-2_all.deb
 28867b477f92a0d9b95c7c648b211013 2024 utils optional tahoe-lafs_1.10.0-2.dsc
 7e64ec4b36110791fe894b0618f5ef7b 157344 utils optional tahoe-lafs_1.10.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBCAAGBQJTY+WiAAoJEM9kzWHrRsqaO1gQAIzLnWjPCjaM7Rb1sPvVXNmf
KP4BX20zbGmBl/DyJAhgpx0PYJ0MB49HRve2XVyF9pXsT222HPzzu5SFNJ8QgkJW
KLbSEYilHmBOdY534qcNsUr/94racMZauWWEOmjcZ2tQDOWtoAzq3i/xLXqRoCKD
eDN37Tynbw+GPw16mHJ/hcSpnC0zZpVlYbNfrUROCf7YXtV/YycZeotW1iH2v9v1
M3nFW3B9sHG/7uFVw6fCQpz0iZAAXxK0Vo9kfmmFjcEA3Y2dDfy20Slci4HWKmTE
fW3+igPg0ss8zBHg1tbDB+SuXE/OQV+sOPyeLCWIFuhuh4kslvfA4PXLQvLuARmF
+0hqiwD4H8NXiiNuH1E7dNn/dsud/SkBoRp4WEU02RU+DN0Jmc6rJiU0/fwQc0ti
IozSrwSLsJwAXWmtfWqCplqJhJBcASYFRUwNXyJKwVCVN7TiUOsxaHaxUgz/O/yK
PQLdMDH4k+o+njYGrOn4/TbLKWFm4Rb3aaq5BTkg64j+GqJjYsEPI+WVtFj7BQAj
xWu+eLl4AQ0QvsmWtSysdNnPYGu+2c+cm2+Jw0JeFUHPltag4WfjMWG2dZpcgGcz
kBDYKqQ/x/uzoLm6KtQKd17yZghAiqiPkSzBvPrCT41pFHNIN1WZI3hxX5+GQLYE
fVYbbk6lW5dJPDMBPcMx
=SGUf
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.