Debian Bug report logs - #732821
ocl-icd: Use autoreconf instead of autotools-dev to allow rebuildability

version graph

Package: src:ocl-icd; Maintainer for src:ocl-icd is Vincent Danjean <vdanjean@debian.org>;

Reported by: Wookey <wookey@wookware.org>

Date: Sun, 22 Dec 2013 03:51:02 UTC

Severity: normal

Tags: patch

Found in version ocl-icd/2.1.0

Fixed in version ocl-icd/2.1.3-1

Done: Vincent Danjean <vdanjean@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Vincent Danjean <vdanjean@debian.org>:
Bug#732821; Package src:ocl-icd. (Sun, 22 Dec 2013 03:51:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Wookey <wookey@wookware.org>:
New Bug report received and forwarded. Copy sent to Vincent Danjean <vdanjean@debian.org>. (Sun, 22 Dec 2013 03:51:06 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Wookey <wookey@wookware.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: ocl-icd: Use autoreconf instead of autotools-dev to allow rebuildability
Date: Sun, 22 Dec 2013 03:48:16 +0000
[Message part 1 (text/plain, inline)]
Source: ocl-icd
Version: 2.1.0
Severity: normal
Tags: patch

I spent a while trying to build the unstable version on unstable, discovering the AM_PROG_AR bug 713333 and then the
test bug 700398, before realising that there was a newer version that already fixed all this in experimental.

During that process I discovered that this package will only ever build once after unpacking. Because it does an autoreconf, 
and thus a load of autotools files get overwritten with new verions, and it is a dpkg quilt-format package: dpkg 
fails on the second build, pointing out the huge patch of changed source files.

This is very simply fixed by the attached patch which uses dh-autoreconf, instead of the dh_autotools-dev that 
was already in use, to track all the changed autotools files, and not just config.sub/guess, so that the source 
can be restored to its pristine state in the clean rule.

This works nicely.

Rebuildability is important, especially for porters, and in this case is very easy to preserve. Please include 
this in the next upload. (Can the experimental version be uploaded to unstable now BTW - that would be very helpful?)

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
[ocl-icd_2.1.0-1-autoreconf.patch (text/x-diff, attachment)]

Reply sent to Vincent Danjean <vdanjean@debian.org>:
You have taken responsibility. (Sun, 22 Dec 2013 13:54:13 GMT) Full text and rfc822 format available.

Notification sent to Wookey <wookey@wookware.org>:
Bug acknowledged by developer. (Sun, 22 Dec 2013 13:54:13 GMT) Full text and rfc822 format available.

Message #10 received at 732821-close@bugs.debian.org (full text, mbox):

From: Vincent Danjean <vdanjean@debian.org>
To: 732821-close@bugs.debian.org
Subject: Bug#732821: fixed in ocl-icd 2.1.3-1
Date: Sun, 22 Dec 2013 13:51:31 +0000
Source: ocl-icd
Source-Version: 2.1.3-1

We believe that the bug you reported is fixed in the latest version of
ocl-icd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 732821@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Danjean <vdanjean@debian.org> (supplier of updated ocl-icd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 22 Dec 2013 14:26:39 +0100
Source: ocl-icd
Binary: ocl-icd-libopencl1 ocl-icd-opencl-dev ocl-icd-dev ocl-icd-dbg
Architecture: amd64 source
Version: 2.1.3-1
Distribution: unstable
Urgency: medium
Maintainer: Vincent Danjean <vdanjean@debian.org>
Changed-By: Vincent Danjean <vdanjean@debian.org>
Closes: 713333 727134 732821
Description: 
 ocl-icd-dbg - Debug symbols for the generic OpenCL ICD Loader
 ocl-icd-dev - Development files to build a ICD Loader
 ocl-icd-libopencl1 - Generic OpenCL ICD Loader
 ocl-icd-opencl-dev - OpenCL development files
Changes: 
 ocl-icd (2.1.3-1) unstable; urgency=medium
 .
   * New upstream release
     + fix several NULL pointer handlings by selecting default objects
       (Closes: #727134)
   * Use autoreconf instead of autotools-dev (Closes: #732821)
     Thanks Wookey for reporting the bug and providing the patch
   * Fix autotools issue (the fix was in experimental for several
     releases but the bug was not closed)
     Closes: #713333
Checksums-Sha1: 
 c51e49bd911e204c6f7ca819471263ae20eeb4a2 2125 ocl-icd_2.1.3-1.dsc
 8828006430e32ea82f1bfda70c90729ec1def83a 419083 ocl-icd_2.1.3.orig.tar.gz
 9dc8b3b2860de528b9a6a4ed54a5532371f3f94b 10065 ocl-icd_2.1.3-1.debian.tar.gz
 98e719551807550fb526e35877bc03c7d40cd2d2 31606 ocl-icd-libopencl1_2.1.3-1_amd64.deb
 18c7cd599873593452b637256b6a832764c912d3 7126 ocl-icd-opencl-dev_2.1.3-1_amd64.deb
 036c485f6c9119cb89293a27554d095140bf0540 13098 ocl-icd-dev_2.1.3-1_amd64.deb
 f8df039632f935c2758dd98311503ab76ec4cf9a 38082 ocl-icd-dbg_2.1.3-1_amd64.deb
Checksums-Sha256: 
 1c8acac8a5a6bc0e5fdfdc8ebb2eee0f957e0718b5c4e7847d729a4e6480c97e 2125 ocl-icd_2.1.3-1.dsc
 8338c6ae5cb7a9b34dfe79922f5e32c4f78c535a2217321dae842f72e0a2b175 419083 ocl-icd_2.1.3.orig.tar.gz
 467d4d912cdc61d9da623209822172f737a2924be8fe079da324631522752867 10065 ocl-icd_2.1.3-1.debian.tar.gz
 bb95b8c1d14be178bacd21997cc5c7571c64a9e0d1f559dd7683e119dbc0c4e2 31606 ocl-icd-libopencl1_2.1.3-1_amd64.deb
 a37ce72c99083b1a7da877cc4ecc08dd48723ec0256165d87f84eba3df2dc32e 7126 ocl-icd-opencl-dev_2.1.3-1_amd64.deb
 97a47d3e52ba4cb8eb7b369aa53b4c12448e0d1ea9c08afb548a90d0f13ef55b 13098 ocl-icd-dev_2.1.3-1_amd64.deb
 8a6426f4181ba0b7c910131c92e9e714780da75e4f2cdacf8788b4dc7e4b6990 38082 ocl-icd-dbg_2.1.3-1_amd64.deb
Files: 
 981d8a7a64da670f5ead8b69ed0a1f45 2125 libs extra ocl-icd_2.1.3-1.dsc
 579ba811fe9e229cc21e48406ddba94a 419083 libs extra ocl-icd_2.1.3.orig.tar.gz
 bb2ee81f1f3515536446baf0a1c5939d 10065 libs extra ocl-icd_2.1.3-1.debian.tar.gz
 f31857134c6f688ff23650dec4618a3f 31606 libs extra ocl-icd-libopencl1_2.1.3-1_amd64.deb
 e69d30a80b208d4fa15e3ac63988b747 7126 libdevel extra ocl-icd-opencl-dev_2.1.3-1_amd64.deb
 d782de024d0383651b4af7c7631effd1 13098 libdevel extra ocl-icd-dev_2.1.3-1_amd64.deb
 cafa8e1f85a13cb814c3c8b14e0b71f7 38082 debug extra ocl-icd-dbg_2.1.3-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIVAwUBUrbq09T1zgD6DpudAQibwA//bejBLl0QC/cYv/DZ5gkQ8GFCjtoT4VWJ
3aToE9KpmjOk1r2RLu99ugqKk751xwbYr5C2PNYu52zEEjk1/ODH1ViDsZEpbu9n
iMeNGLikl4iF6ut3mCWvRzPmbNNlJRfInZCtDaiuIxG9cTjwC9B5D+di4N2S8tpd
V1MpCAlaiuyaAOnZIo0yBqzTUXtEcc+GGkEhU9ueaU4Ji+rcOlV29b+CE1TkhGTy
lx6m5Wp3Z53uhvh+DM7RdezpRGbCyJB1EZa5AbxfwAsYQjeDPVERtY3+7uRWTOwj
AZR+kWH1OQIWRqsvBVV16jboyZ6/Iv7yRGgGdY68zLszQZdcfFrvFWGkNH5MEvKW
FA30kE1U9SdYlBfdTKKChbjvJhMacH9HyQ+hlYnoflskxCfFnVDBjAJS+epPoz1v
HDHuGXTKduAOC6mBbnZfMP5lmzvUk4p6CJNx7QF891XmcmwYzxOIjztqnFzc1cCT
907ystvBKClwBVrac+9H5Bkwlf4gLlBRsXg1lDO2Zh0FFMFFomuRxuoKKr9OKP6C
PeQJETS3l4qjtPN6usQHUQxQJLfkl1/AUAN4st6yQgOzuZUdDkpPJ32u8ToSZIsx
Pp9aE1E3QDNYopsKs0eS5r+26TnC7Caj/ykC13gSVecTHkAZUV3rEZu6q1G/UwDs
wMxTXltYSRY=
=yGFj
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 27 Jan 2014 07:27:50 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Thu Apr 24 20:38:38 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.