Debian Bug report logs - #723142
RFS: dnt/0.10-1 [ITP]

Package: sponsorship-requests; Maintainer for sponsorship-requests is Debian Mentors <package-sponsorship-requests@lists.debian.org>;

Reported by: Vincent Prat <vinceprat@free.fr>

Date: Mon, 16 Sep 2013 20:09:02 UTC

Severity: wishlist

Blocking fix for 610875: ITP: dnt -- DccNiTghtmare (aka DNT) is a project to make a Free (as in free speech) 3D single player RPG in a satirical post-apocalyptical world.

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#723142; Package sponsorship-requests. (Mon, 16 Sep 2013 20:09:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vincent Prat <vinceprat@free.fr>:
New Bug report received and forwarded. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Mon, 16 Sep 2013 20:09:07 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Vincent Prat <vinceprat@free.fr>
To: submit@bugs.debian.org
Subject: RFS: dnt/0.10-1 [ITP]
Date: Mon, 16 Sep 2013 22:07:47 +0200
Package: sponsorship-requests
Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "dnt"

 * Package name    : dnt
   Version         : 0.10-1
   Upstream Author : The DNTeam
 * URL             : http://dnt.dnteam.org/
 * License         : GPL-3.0+
   Section         : games

  It builds those binary packages:

 dnt   	    - Post-apocalyptical 3D single player RPG
 dnt-data   - Post-apocalyptical 3D single player RPG - game data
 dnt-dbg    - Post-apocalyptical 3D single player RPG - debug
 dnt-tools  - Post-apocalyptical 3D single player RPG - development tools

  To access further information about this package, please visit the following URL:

  http://mentors.debian.net/package/dnt


  Alternatively, one can download the package with dget using this command:

    dget -x http://mentors.debian.net/debian/pool/main/d/dnt/dnt_0.10-1.dsc


  Regards,
   Vincent Prat




Added indication that bug 723142 blocks 610875 Request was from Bart Martens <bartm@quantz.debian.org> to control@bugs.debian.org. (Tue, 17 Sep 2013 16:27:05 GMT) Full text and rfc822 format available.

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#723142; Package sponsorship-requests. (Wed, 02 Oct 2013 23:03:12 GMT) Full text and rfc822 format available.

Acknowledgement sent to Markus Koschany <apo@gambaru.de>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Wed, 02 Oct 2013 23:03:12 GMT) Full text and rfc822 format available.

Message #12 received at 723142@bugs.debian.org (full text, mbox):

From: Markus Koschany <apo@gambaru.de>
To: Debian Games Team <debian-devel-games@lists.debian.org>
Cc: 723142@bugs.debian.org
Subject: Re: Bug#723142: RFS: dnt/0.10-1 [ITP]
Date: Thu, 03 Oct 2013 00:59:13 +0200
[Message part 1 (text/plain, inline)]
Hi Vincent,

as promised, here is my review for DNT.

First of all the overall impression is very positive and the whole
package is already in a good shape. Thanks for packaging DNT.
Things you could improve:

- please depend on debhelper >=9 and use compat level 9
- you don't have to build-depend on quilt because source format 3.0
  uses quilt by default
- your dependency on dnt-data (= ${source:Version}) is probably too
  strict in this case because your data package is rather large. (> 150
  MB). You can save a lot of bandwidth by depending on

 dnt-data (>= ${source:Upstream-Version}),
 dnt-data (<= ${source:Version})

The same goes for dnt-tools.

- Package: dnt-data
I would lower Recommends: dnt (= ${binary:Version}) to Suggests: dnt.
Most people, who download the data package directly, are only interested
in the data files.

- package description: Maybe you could find one or two additional
sentences why people should play this game and describe what it makes
special. You don't have to mention that it is a free game. All packages
in main are free.

- Your desktop files contain a minor mistake because all keywords must
have a semicolon as trailing character. You can validate your desktop
file with desktop-file-validate.

- It is not 100% clear how you obtained the sources. The original
tarball is bz2 compressed. Yours is gz compressed. I suggest you switch
to xz compression in source/options and for the upstream tarball and
document modifications either in README.source or you might want to
write a get-orig-source target for debian/rules.

https://wiki.debian.org/onlyjob/get-orig-source

- The desktop icons for the map-editor and part-editor look blurred on
Gnome 3. The dnt icon looks much better.

- debian/copyright:
Please update the old dep5 syntax to copyright format 1.0.
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

- You might want to add the license paragraph in upstream's README as a
comment to your copyright file because it clarifies the whole licensing.

- You can avoid some useless dependencies by using

export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed

in debian/rules or by updating the build system.

- I get a strange error message when I run the map editor from the
command line:

EE r600_texture.c:786 r600_texture_transfer_map - mapping MSAA zbuffer
unimplemented
OpenGL Error: out of memory

Otherwise it seems to work.

- You need to install the game data to /usr/share/games
- Some of the fonts are non-free. Those have to be removed in the
  original tarball and not only in the final package.

Regards,

Markus


[signature.asc (application/pgp-signature, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#723142; Package sponsorship-requests. (Thu, 03 Oct 2013 03:09:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Paul Wise <pabs@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Thu, 03 Oct 2013 03:09:04 GMT) Full text and rfc822 format available.

Message #17 received at 723142@bugs.debian.org (full text, mbox):

From: Paul Wise <pabs@debian.org>
To: Debian Games Team <debian-devel-games@lists.debian.org>
Cc: 723142@bugs.debian.org
Subject: Re: Bug#723142: RFS: dnt/0.10-1 [ITP]
Date: Thu, 3 Oct 2013 11:07:16 +0800
On Thu, Oct 3, 2013 at 6:59 AM, Markus Koschany wrote:

> - It is not 100% clear how you obtained the sources. The original
> tarball is bz2 compressed. Yours is gz compressed. I suggest you switch
> to xz compression in source/options and for the upstream tarball and
> document modifications either in README.source or you might want to
> write a get-orig-source target for debian/rules.

The orig.tar should either be exactly the tarball from upstream or
have non-free content removed (or maybe hundreds of MB of embedded
code copies). Just recompressing the tarball with a different
compression format isn't a valid reason to differ from upstream here.
If you want a different compression format, get upstream to switch.
get-orig-source is definitely needed for the non-free/code copies
removal case.

> - Some of the fonts are non-free. Those have to be removed in the
>   original tarball and not only in the final package.

This would be a reason to modify the upstream tarball, then you can
use xz and add a get-orig-source. Removing the fonts and using xz
should be pushed upstream though.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#723142; Package sponsorship-requests. (Thu, 03 Oct 2013 11:27:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vincent Prat <vinceprat@free.fr>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Thu, 03 Oct 2013 11:27:04 GMT) Full text and rfc822 format available.

Message #22 received at 723142@bugs.debian.org (full text, mbox):

From: Vincent Prat <vinceprat@free.fr>
To: debian-devel-games@lists.debian.org, 723142@bugs.debian.org
Subject: Re: Bug#723142: RFS: dnt/0.10-1 [ITP]
Date: Thu, 03 Oct 2013 13:22:37 +0200
Thanks to both of you for the review.
As regards the repackaging of the orig.tar tarball, if I have correctly 
understood, there are two solutions: do it by hand (and document it in 
README.source) or do it automatically with a get-orig-source target (and 
that's it). Am I right?
Then, what would you recommand to me?

Le 03/10/2013 05:07, Paul Wise a écrit :
> On Thu, Oct 3, 2013 at 6:59 AM, Markus Koschany wrote:
>
>> - It is not 100% clear how you obtained the sources. The original
>> tarball is bz2 compressed. Yours is gz compressed. I suggest you switch
>> to xz compression in source/options and for the upstream tarball and
>> document modifications either in README.source or you might want to
>> write a get-orig-source target for debian/rules.
> The orig.tar should either be exactly the tarball from upstream or
> have non-free content removed (or maybe hundreds of MB of embedded
> code copies). Just recompressing the tarball with a different
> compression format isn't a valid reason to differ from upstream here.
> If you want a different compression format, get upstream to switch.
> get-orig-source is definitely needed for the non-free/code copies
> removal case.
>
>> - Some of the fonts are non-free. Those have to be removed in the
>>    original tarball and not only in the final package.
> This would be a reason to modify the upstream tarball, then you can
> use xz and add a get-orig-source. Removing the fonts and using xz
> should be pushed upstream though.
>




Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#723142; Package sponsorship-requests. (Thu, 03 Oct 2013 11:33:11 GMT) Full text and rfc822 format available.

Acknowledgement sent to Paul Wise <pabs@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Thu, 03 Oct 2013 11:33:11 GMT) Full text and rfc822 format available.

Message #27 received at 723142@bugs.debian.org (full text, mbox):

From: Paul Wise <pabs@debian.org>
To: debian-devel-games@lists.debian.org
Cc: 723142@bugs.debian.org
Subject: Re: Bug#723142: RFS: dnt/0.10-1 [ITP]
Date: Thu, 3 Oct 2013 19:31:29 +0800
On Thu, Oct 3, 2013 at 7:22 PM, Vincent Prat wrote:

> Thanks to both of you for the review.
> As regards the repackaging of the orig.tar tarball, if I have correctly
> understood, there are two solutions: do it by hand (and document it in
> README.source) or do it automatically with a get-orig-source target (and
> that's it). Am I right?
> Then, what would you recommand to me?

I would never recommend doing it by hand, always automate it.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#723142; Package sponsorship-requests. (Fri, 20 Dec 2013 22:57:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vincent Prat <vinceprat@free.fr>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Fri, 20 Dec 2013 22:57:05 GMT) Full text and rfc822 format available.

Message #32 received at 723142@bugs.debian.org (full text, mbox):

From: Vincent Prat <vinceprat@free.fr>
To: 723142@bugs.debian.org, debian-devel-games@lists.debian.org
Subject: RFS: dnt/0.10-1 [ITP]
Date: Fri, 20 Dec 2013 23:52:11 +0100
[Message part 1 (text/plain, inline)]
Hello everybody,

I have taken into account the reviews of Markus and Pabs, and a new 
version of the DNT package (project for a satirical post-apocalyptical 
3D RPG) is now ready for other reviews and sponsorship.
It is available on Debian Mentors 
(http://mentors.debian.net/package/dnt) and in the SVN repository of the 
team (http://anonscm.debian.org/viewvc/pkg-games/packages/trunk/dnt).
Feel free to take a look at it.

Best regards,
Vincent


<http://mentors.debian.net/package/dnt>
[Message part 2 (text/html, inline)]

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed Apr 16 16:10:15 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.