Debian Bug report logs - #721424
RFS: pentobi/7.1-1

Package: sponsorship-requests; Maintainer for sponsorship-requests is Debian Mentors <package-sponsorship-requests@lists.debian.org>;

Reported by: Juhani Numminen <juhaninumminen0@gmail.com>

Date: Sat, 31 Aug 2013 11:39:02 UTC

Severity: normal

Done: Bart Martens <bartm@quantz.debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#721424; Package sponsorship-requests. (Sat, 31 Aug 2013 11:39:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Juhani Numminen <juhaninumminen0@gmail.com>:
New Bug report received and forwarded. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Sat, 31 Aug 2013 11:39:06 GMT) Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Juhani Numminen <juhaninumminen0@gmail.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: RFS: pentobi/7.1-1
Date: Sat, 31 Aug 2013 14:36:31 +0300
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "pentobi".

 * Package name    : pentobi
   Version         : 7.1-1
   Upstream Author : Markus Enzenberger <enz@users.sourceforge.net>
 * URL             : http://pentobi.sourceforge.net/
 * License         : GPLv3+
   Section         : games

It builds those binary packages:

 pentobi - clone of Blokus, a strategy board game based on the concept of
polyominoes

To access further information about this package, please visit the following
URL:

 http://mentors.debian.net/package/pentobi

Alternatively, one can download the package with dget using this command:

 dget -x http://mentors.debian.net/debian/pool/main/p/pentobi/pentobi_7.1-1.dsc

More information about pentobi can be obtained from
http://pentobi.sourceforge.net/.

Changes since the last upload:

 * New upstream release.
 * Add myself to Uploaders.
 * Bump Standards-Version to 3.9.4, no changes needed.
 * Update debian/copyright.
   + Add Upstream-Contact field.
   + Update copyright years.
   + Remove the Tango icons which Pentobi upstream is no longer shipping.
   + Add myself to packaging files' copyright holders.
 * Fix path for the svg and generated xpm icons.
 * Improve debian/menu longtitle.
   Thanks to Bill Allombert, Chris Leick (Closes: #684476)
 * Don't install upstream changelog twice.
 * Remove unneeded Build-Depends on boost libraries and Depends on libqt4-svg.
 * Use canonical Vcs-Git and Vcs-Browser URIs.
 * Fix CMake flags.
 * Register the user manuals with doc-base.
 * Replace duplicate files of en_CA and en_GB manuals with symlinks.
 * Unapply patches from source to ease package maintaining with git.
 * Add patches.
   + hyphen-used-as-minus-sign to fix manpage using hyphens as minus signs
   + desktop-entry-keywords to add Keywords to desktop entry
 * Remove installed COPYING file containing GPL-3.0+.

Regards,
--
Juhani Numminen



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#721424; Package sponsorship-requests. (Sat, 23 Nov 2013 01:24:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Paul Wise <pabs@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Sat, 23 Nov 2013 01:24:04 GMT) Full text and rfc822 format available.

Message #10 received at 721424@bugs.debian.org (full text, mbox):

From: Paul Wise <pabs@debian.org>
To: Juhani Numminen <juhaninumminen0@gmail.com>, 721424@bugs.debian.org
Subject: Re: Bug#721424: RFS: pentobi/7.1-1
Date: Sat, 23 Nov 2013 09:20:39 +0800
On Sat, Aug 31, 2013 at 7:36 PM, Juhani Numminen wrote:

> I am looking for a sponsor for my package "pentobi".

Uploaded, thanks for taking care of the package.

Here are some things you might want to look at:

Please send upstream these links.

http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/
http://wiki.debian.org/UpstreamGuide

You might want to run tagpending after closing bugs in
debian/changelog in future.

There is a newer Debian policy out recently.

http://www.debian.org/doc/debian-policy/upgrading-checklist

Don't list lintian tags in the patch's Subject, that is for the description

What do you think about enabling the KDE thumbnailer?

Might want to add a debian/upstream file.

https://wiki.debian.org/UpstreamMetadata

Some of the PNG and ICO images were or look like they were created in
SVG format, they should be rendered from the SVGs at build time
instead. Preferrably upstream would remove them from the tarball and
VCS but if they are unwilling to do that they should be removed before
dh_auto_configure is run.

Likewise I wonder if there is any way to generate the screenshots at
build time so they look correct for the version of pentobi that is
being built.

Recent versions of nsis 3 support Unicode so this file can be
converted to UTF-8:

./windows_installer/German.nsh

Please upload a screenshot for the new version.

http://screenshots.debian.net/upload

Automated checks:

https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

lintian

P: pentobi: no-upstream-changelog

cme

Warning in 'control source Standards-Version' value '3.9.4': Current
standards version is 3.9.5
Warning in 'control binary:pentobi Synopsis' value 'clone of Blokus, a
strategy board game based on the concept of polyominoes': Synopsis is
too long.
Warning in 'patches:"0001-hyphen-used-as-minus-sign.patch" Synopsis'
value <undef>: Empty synopsis (code is: 'defined $_ && /\w/ ? 1 : 0
;')
Warning in 'patches:"0002-desktop-entry-keywords.patch" Synopsis'
value <undef>: Empty synopsis (code is: 'defined $_ && /\w/ ? 1 : 0
;')

blhc

CXXFLAGS missing (-fPIE)
LDFLAGS missing (-fPIE -pie -Wl,-z,now)

cppcheck

[src/libboardgame_sgf/Node.h:222]: (error) Reference to auto variable returned.

desktop-file-validate

./src/pentobi_kde_thumbnailer/pentobi-thumbnail.desktop: error: key
"MimeType" is present in group "Desktop Entry", but the type is
"Service" while this key is only valid for type "Application"

pep8

./tools/twogtp/analyze.py:7:1: E302 expected 2 blank lines, found 1
./tools/twogtp/analyze.py:46:1: E302 expected 2 blank lines, found 1
./tools/twogtp/analyze.py:53:1: E302 expected 2 blank lines, found 1
./tools/twogtp/analyze.py:62:9: E126 continuation line over-indented
for hanging indent
./tools/twogtp/analyze.py:63:9: E126 continuation line over-indented
for hanging indent
./tools/twogtp/analyze.py:146:1: W391 blank line at end of file
./tools/twogtp/split-gamefile.py:7:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:14:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:17:47: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:17:49: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:17:62: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:17:64: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:18:39: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:18:41: E251 unexpected spaces around keyword
/ parameter equals
./tools/twogtp/twogtp.py:19:1: W293 blank line contains whitespace
./tools/twogtp/twogtp.py:47:32: E711 comparison to None should be 'if
cond is not None:'
./tools/twogtp/twogtp.py:51:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:98:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:106:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:130:1: W293 blank line contains whitespace
./tools/twogtp/twogtp.py:131:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:145:19: E201 whitespace after '['
./tools/twogtp/twogtp.py:145:28: E202 whitespace before ']'
./tools/twogtp/twogtp.py:147:19: E201 whitespace after '['
./tools/twogtp/twogtp.py:147:38: E202 whitespace before ']'
./tools/twogtp/twogtp.py:157:16: W291 trailing whitespace
./tools/twogtp/twogtp.py:171:26: W291 trailing whitespace
./tools/twogtp/twogtp.py:221:80: E501 line too long (80 > 79 characters)
./tools/twogtp/twogtp.py:224:1: E302 expected 2 blank lines, found 1
./tools/twogtp/twogtp.py:246:9: E126 continuation line over-indented
for hanging indent
./tools/twogtp/twogtp.py:254:9: E126 continuation line over-indented
for hanging indent

todo

./src/libpentobi_mcts/State.cpp:    // TODO: m_nu_passes should be
initialized without assuming alternating
./src/pentobi/Main.cpp:/** @todo: Move to an extra file to encapsulate
the inclusion of <windows.h>,
./src/libpentobi_base/BoardConst.cpp:    // TODO: Better distinction
between board type and set of pieces.

duplicate files

./src/pentobi/manual/en_CA/shortcuts.html
./src/pentobi/manual/en_GB/shortcuts.html

./src/pentobi/manual/en_CA/trigon_rules.html
./src/pentobi/manual/en_GB/trigon_rules.html

./src/pentobi/manual/en_CA/user_interface.html
./src/pentobi/manual/en_GB/user_interface.html

./src/pentobi/manual/en_CA/index.html
./src/pentobi/manual/en_GB/index.html

./src/pentobi/manual/en_CA/system.html
./src/pentobi/manual/en_GB/system.html

./src/pentobi/manual/en_CA/classic_rules.html
./src/pentobi/manual/en_GB/classic_rules.html

./src/pentobi/manual/en_CA/license.html
./src/pentobi/manual/en_GB/license.html

./src/pentobi/manual/en_CA/duo_rules.html
./src/pentobi/manual/en_GB/duo_rules.html

./src/pentobi/manual/en_CA/junior_rules.html
./src/pentobi/manual/en_GB/junior_rules.html

./src/pentobi/icons/pentobi-forward.png
./src/libpentobi_gui/icons/go-next.png

./src/pentobi/icons/pentobi-forward.svg
./src/libpentobi_gui/icons/go-next.svg

/usr/share/games/pentobi/translations/libpentobi_gui_en_GB.qm
/usr/share/games/pentobi/translations/libpentobi_gui_en_CA.qm

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Reply sent to Bart Martens <bartm@quantz.debian.org>:
You have taken responsibility. (Sat, 23 Nov 2013 04:30:14 GMT) Full text and rfc822 format available.

Notification sent to Juhani Numminen <juhaninumminen0@gmail.com>:
Bug acknowledged by developer. (Sat, 23 Nov 2013 04:30:14 GMT) Full text and rfc822 format available.

Message #15 received at 721424-done@bugs.debian.org (full text, mbox):

From: Bart Martens <bartm@quantz.debian.org>
To: 721424-done@bugs.debian.org
Subject: closing RFS: pentobi/7.1-1
Date: Sat, 23 Nov 2013 04:27:18 +0000
Package pentobi has been removed from mentors.



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#721424; Package sponsorship-requests. (Wed, 27 Nov 2013 16:33:05 GMT) Full text and rfc822 format available.

Acknowledgement sent to Juhani Numminen <juhaninumminen0@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Wed, 27 Nov 2013 16:33:05 GMT) Full text and rfc822 format available.

Message #20 received at 721424@bugs.debian.org (full text, mbox):

From: Juhani Numminen <juhaninumminen0@gmail.com>
To: Paul Wise <pabs@debian.org>
Cc: 721424@bugs.debian.org
Subject: Re: Bug#721424: RFS: pentobi/7.1-1
Date: Wed, 27 Nov 2013 18:30:31 +0200
Sat, 23 Nov 2013 09:20:39 +0800
Paul Wise <pabs@debian.org> kirjoitti:

> On Sat, Aug 31, 2013 at 7:36 PM, Juhani Numminen wrote:
> 
> > I am looking for a sponsor for my package "pentobi".
> 
> Uploaded, thanks for taking care of the package.
> 
> Here are some things you might want to look at:

I will, and I’ll investigate the failed builds on some architectures
as well.

> Please send upstream these links.
> 
> http://tieguy.org/blog/2012/03/17/on-the-importance-of-per-file-license-information/
> http://wiki.debian.org/UpstreamGuide

Okay.

> You might want to run tagpending after closing bugs in
> debian/changelog in future.
> 
> There is a newer Debian policy out recently.
>
> http://www.debian.org/doc/debian-policy/upgrading-checklist

I’ll update it.

> Don't list lintian tags in the patch's Subject, that is for the
> description

I’ll fix those.

> What do you think about enabling the KDE thumbnailer?

I missed the fact that there are two thumbnailers. I see no reason to
keep it disabled.

> Might want to add a debian/upstream file.
> 
> https://wiki.debian.org/UpstreamMetadata

I can add this file, but are you aware of its uses other than to
“display bibliographic information about which academic article to
cite”? Also as pointed out earlier, DEP12 isn’t available. 

> Some of the PNG and ICO images were or look like they were created in
> SVG format, they should be rendered from the SVGs at build time
> instead. Preferrably upstream would remove them from the tarball and
> VCS but if they are unwilling to do that they should be removed before
> dh_auto_configure is run.
> 
> Likewise I wonder if there is any way to generate the screenshots at
> build time so they look correct for the version of pentobi that is
> being built.

I will talk to the upstream about these points on the pentobi-devel
mailing list.

> Please upload a screenshot for the new version.
> 
> http://screenshots.debian.net/upload

It has been uploaded.

> lintian
> 
> P: pentobi: no-upstream-changelog

I could probably just rename /usr/share/doc/pentobi/NEWS to
changelog, would it be ok?

> cme
> 
> [...]
> Synopsis is too long.

Seems that I have figure out a shorter one.

> pep8
> [...]

I have sent a patch to upstream.


Thanks,

--   Juhani



Information forwarded to debian-bugs-dist@lists.debian.org, Debian Mentors <package-sponsorship-requests@lists.debian.org>:
Bug#721424; Package sponsorship-requests. (Thu, 28 Nov 2013 00:45:09 GMT) Full text and rfc822 format available.

Acknowledgement sent to Paul Wise <pabs@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Mentors <package-sponsorship-requests@lists.debian.org>. (Thu, 28 Nov 2013 00:45:09 GMT) Full text and rfc822 format available.

Message #25 received at 721424@bugs.debian.org (full text, mbox):

From: Paul Wise <pabs@debian.org>
To: Juhani Numminen <juhaninumminen0@gmail.com>, 721424@bugs.debian.org
Subject: Re: Bug#721424: RFS: pentobi/7.1-1
Date: Thu, 28 Nov 2013 08:42:55 +0800
On Thu, Nov 28, 2013 at 12:30 AM, Juhani Numminen wrote:

> I can add this file, but are you aware of its uses other than to
> “display bibliographic information about which academic article to
> cite”? Also as pointed out earlier, DEP12 isn’t available.

The PTS points at it where the file is available. Unfortunately the
situation there is sub-optimal. The gatherer isn't looking at packages
not in a VCS and it isn't running right now due to the alioth outage.

http://packages.qa.debian.org/u/umegaya.html

> I could probably just rename /usr/share/doc/pentobi/NEWS to
> changelog, would it be ok?

Yep.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Thu, 26 Dec 2013 07:28:16 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Apr 19 23:29:10 2014; Machine Name: beach.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.