Debian Bug report logs - #720695
[udisks2] [PATCH] Add default exfat mount options

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Andrey Jr. Melnikov" <temnota.am@gmail.com>

To: submit@bugs.debian.org

Subject: [udisks2] [PATCH] Add default exfat mount options

Date: Sat, 24 Aug 2013 19:42:43 +0400

Package: udisks2
Version: 2.1.0-4
Severity: normal
Tags: patch

--- Please enter the report below this line. ---

Add default exFAT mount options. This set of default options compatible with
exfat-fuse and exfat-nofuse kernel driver.
Without this patch user unable to use mounted drive under gnome - it's mount
with root permissions only.

--- udisks2-2.1.0.orig/src/udiskslinuxfilesystem.c	2013-07-23 06:51:10.000000000 +0000
+++ udisks2-2.1.0/src/udiskslinuxfilesystem.c	2013-08-24 14:59:54.195567080 +0000
@@ -302,6 +302,13 @@
 static const gchar *udf_allow_uid_self[] = { "uid=", NULL };
 static const gchar *udf_allow_gid_self[] = { "gid=", NULL };
 
+/* ---------------------- exfat -------------------- */
+
+static const gchar *exfat_defaults[] = { "uid=", "gid=", "iocharset=utf8", "namecase=0", "errors=remount-ro", "umask=0022", NULL };
+static const gchar *exfat_allow[] = { "dmask=", "errors=", "fmask=", "iocharset=", "namecase=", "umask=", NULL };
+static const gchar *exfat_allow_uid_self[] = { "uid=", NULL };
+static const gchar *exfat_allow_gid_self[] = { "gid=", NULL };
+
 /* ------------------------------------------------ */
 /* TODO: support context= */
 
@@ -313,6 +320,7 @@
     { "ntfs", ntfs_defaults, ntfs_allow, ntfs_allow_uid_self, ntfs_allow_gid_self },
     { "iso9660", iso9660_defaults, iso9660_allow, iso9660_allow_uid_self, iso9660_allow_gid_self },
     { "udf", udf_defaults, udf_allow, udf_allow_uid_self, udf_allow_gid_self },
+    { "exfat", exfat_defaults, exfat_allow, exfat_allow_uid_self, exfat_allow_gid_self },
   };
 
 /* ------------------------------------------------ */


--- System information. ---
Architecture: amd64
Kernel:       Linux 3.10-2-amd64

Debian Release: jessie/sid
  500 unstable        mirror.yandex.ru 
  500 experimental    mirror.yandex.ru 

--- Package information. ---
Depends                       (Version) | Installed
=======================================-+-==============
libacl1                   (>= 2.2.51-8) | 2.2.52-1
libatasmart4                  (>= 0.13) | 0.19-2
libc6                          (>= 2.7) | 
libglib2.0-0               (>= 2.31.18) | 
libgudev-1.0-0                 (>= 165) | 
libpolkit-agent-1-0           (>= 0.99) | 
libpolkit-gobject-1-0        (>= 0.101) | 
libudisks2-0                (>= 2.0.91) | 
udev                                    | 
dbus                                    | 


Recommends       (Version) | Installed
==========================-+-===========
policykit-1                | 0.110-3
dosfstools                 | 3.0.22-1
ntfs-3g                    | 1:2013.1.13AR.2-3
eject                      | 2.1.5+deb1+cvs20081104-13


Suggests            (Version) | Installed
=============================-+-===========
xfsprogs                      | 
reiserfsprogs                 | 
exfat-utils                   | 
btrfs-tools                   | 
mdadm                         | 
cryptsetup-bin                | 2:1.6.1-1

Message #10 received at 720695@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: "Andrey Jr. Melnikov" <temnota.am@gmail.com>, 720695@bugs.debian.org

Subject: Re: [Pkg-utopia-maintainers] Bug#720695: [udisks2] [PATCH] Add default exfat mount options

Date: Sun, 01 Sep 2013 03:15:56 +0200

[Message part 1 (text/plain, inline)]

Hi,

the patch looks ok to me from a cursory glance, see comments inline

Am 24.08.2013 17:42, schrieb Andrey Jr. Melnikov:
>  
> +/* ---------------------- exfat -------------------- */
> +
> +static const gchar *exfat_defaults[] = { "uid=", "gid=", "iocharset=utf8", "namecase=0", "errors=remount-ro", "umask=0022", NULL };

using umask=0022 looks inconsistent what we use for other file systems,
ntfs uses "dmask=0077", "fmask=0177", vfat "dmask=0077"


Martin, any comments?


Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 720695@bugs.debian.org (full text, mbox, reply):

From: Andrey Melnikov <temnota.am@gmail.com>

To: Michael Biebl <biebl@debian.org>

Cc: 720695@bugs.debian.org

Subject: Re: [Pkg-utopia-maintainers] Bug#720695: [udisks2] [PATCH] Add default exfat mount options

Date: Sun, 1 Sep 2013 11:02:18 +0400

2013/9/1 Michael Biebl <biebl@debian.org>:
> Hi,
>
> the patch looks ok to me from a cursory glance, see comments inline
>
> Am 24.08.2013 17:42, schrieb Andrey Jr. Melnikov:
>>
>> +/* ---------------------- exfat -------------------- */
>> +
>> +static const gchar *exfat_defaults[] = { "uid=", "gid=", "iocharset=utf8", "namecase=0", "errors=remount-ro", "umask=0022", NULL };
>
> using umask=0022 looks inconsistent what we use for other file systems,
> ntfs uses "dmask=0077", "fmask=0177", vfat "dmask=0077"
No problem for both modules (fuse/non-fuse) to use dmask=0077,
fmask=0177. Regenerate patch?

Message #20 received at 720695@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: "Andrey Jr. Melnikov" <temnota.am@gmail.com>, 720695@bugs.debian.org

Subject: Re: Bug#720695: [Pkg-utopia-maintainers] Bug#720695: [udisks2] [PATCH] Add default exfat mount options

Date: Fri, 22 Nov 2013 16:41:34 +0100

[Message part 1 (text/plain, inline)]

Michael Biebl [2013-09-01  3:15 +0200]:
> > +static const gchar *exfat_defaults[] = { "uid=", "gid=", "iocharset=utf8", "namecase=0", "errors=remount-ro", "umask=0022", NULL };
> 
> using umask=0022 looks inconsistent what we use for other file systems,
> ntfs uses "dmask=0077", "fmask=0177", vfat "dmask=0077"

Agreed.

> Martin, any comments?

Looks good to me in principle, but I would rather apply it upstream
together with a proper integration test (using exfat-utils), to make
sure it is and stays working. I'll follow up on Monday about that.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 720695@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: "Andrey Jr. Melnikov" <temnota.am@gmail.com>, 720695@bugs.debian.org

Subject: Re: Bug#720695: [udisks2] [PATCH] Add default exfat mount options

Date: Mon, 25 Nov 2013 10:24:49 +0100

[Message part 1 (text/plain, inline)]

tag 720695 fixed-upstream pending
thanks

Hello Andrey,

Andrey Jr. Melnikov [2013-08-24 19:42 +0400]:
> Add default exFAT mount options. This set of default options compatible with
> exfat-fuse and exfat-nofuse kernel driver.

Thanks! I committed this upstream:

  http://cgit.freedesktop.org/udisks/commit/?id=4d4b05974

and also added an integration test:

  http://cgit.freedesktop.org/udisks/commit/?id=a2b8186

This reveals a bug in current Debian's wipefs (our util-linux version
is ancient unfortunately) that doesn't wipe exfat partitions properly.
This is fixed in current util-linux upstream. But aside from this, it
works fine.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 720695-close@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: 720695-close@bugs.debian.org

Subject: Bug#720695: fixed in udisks2 2.1.2-1

Date: Tue, 14 Jan 2014 09:51:27 +0000

Source: udisks2
Source-Version: 2.1.2-1

We believe that the bug you reported is fixed in the latest version of
udisks2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 720695@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <mpitt@debian.org> (supplier of updated udisks2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 14 Jan 2014 10:04:52 +0100
Source: udisks2
Binary: udisks2 udisks2-doc libudisks2-0 libudisks2-dev gir1.2-udisks-2.0
Architecture: source amd64 all
Version: 2.1.2-1
Distribution: unstable
Urgency: low
Maintainer: Utopia Maintenance Team <pkg-utopia-maintainers@lists.alioth.debian.org>
Changed-By: Martin Pitt <mpitt@debian.org>
Description: 
 gir1.2-udisks-2.0 - GObject based library to access udisks2 - introspection data
 libudisks2-0 - GObject based library to access udisks2
 libudisks2-dev - GObject based library to access udisks2 - development files
 udisks2    - D-BUS service to access and manipulate storage devices
 udisks2-doc - udisks2 documentation
Closes: 720491 720695 732287
Changes: 
 udisks2 (2.1.2-1) unstable; urgency=low
 .
   [ Martin Pitt ]
   * New upstream release:
     - Add exfat support (Closes: #720695)
     - Fix crash when waiting for loop device (LP: #1128275)
     - Use dosfstools instead of mtools
     - Add polkit authorization variables for removable media
     - Hide more rescue partitions
   * Drop dosfslabel.patch, fixed upstream.
   * Add Recommends: gdisk, as we need it for manipulating GPT partition tables
     through sgdisk. (LP: #1080745)
   * Bump Standards-Version to 3.9.5. No changes necessary.
 .
   [ Colin Watson ]
   * Use dh-autoreconf to update libtool macros for new ports.
     (Closes: #732287)
 .
   [ Andreas Henriksson ]
   * Add parted dependency. (Closes: #720491)
Checksums-Sha1: 
 75380cc0b87be19ddc90006a7ec79231a103d913 2513 udisks2_2.1.2-1.dsc
 093dc9a32752b63819e5d6856a8b0e3ba6d6d902 899694 udisks2_2.1.2.orig.tar.bz2
 b086c4beb721689a2d41842986fd106b296d2fe9 13383 udisks2_2.1.2-1.debian.tar.gz
 4a166dd885070a5bc885a18670c0f62d7423ac61 254150 udisks2_2.1.2-1_amd64.deb
 6d38dde0cea0a9f1eb56cff8ccc1991de10fb1f6 179538 udisks2-doc_2.1.2-1_all.deb
 4c20239d42851290bad71d6cf530be98c8acc0eb 93076 libudisks2-0_2.1.2-1_amd64.deb
 1bf7184082898f9eebd9e8a151b8bf2ebb245434 144376 libudisks2-dev_2.1.2-1_amd64.deb
 d7d244eef7a0ccee6278ece221a2e57fd73b0aa5 20166 gir1.2-udisks-2.0_2.1.2-1_amd64.deb
Checksums-Sha256: 
 865d93ec6bdd785833d9f0ef0a29366b46859e0d042c61a1ab0db8017c172e78 2513 udisks2_2.1.2-1.dsc
 afe928fe7f44086b835257efc3fcbe503e2da7c988a773c997d0291bbab4a637 899694 udisks2_2.1.2.orig.tar.bz2
 84ae28069e7d42f266985917af939725c2cf03e54804ddeaff8e45a25a5d3aa4 13383 udisks2_2.1.2-1.debian.tar.gz
 bea519844651d440a5b1f364d8aea08ddb0e4d4aaefdf8a9897eeee923e9c7e7 254150 udisks2_2.1.2-1_amd64.deb
 f789985d8f4acfa1fd431c8c8827cf4e31e8dbc016df1d737eb2ba686201096c 179538 udisks2-doc_2.1.2-1_all.deb
 524c500612e95995c38778dba814ec4f2ea5fdc1c78806e2a14101a45ad8ae95 93076 libudisks2-0_2.1.2-1_amd64.deb
 4f5ec5e7cdf5144362d8c191b0ebcd595b8d2174ac60fa8b479c6ac2545a5605 144376 libudisks2-dev_2.1.2-1_amd64.deb
 d144293eb2d5bd390460e5f5ded7f05b152e69d773c14df571dbcadc6b7358a2 20166 gir1.2-udisks-2.0_2.1.2-1_amd64.deb
Files: 
 e02b73e4e08b4f459c87b3d11147c9c9 2513 admin optional udisks2_2.1.2-1.dsc
 bc5c4dc209f517e15b655302b028e3e6 899694 admin optional udisks2_2.1.2.orig.tar.bz2
 433812d599f2c1b879bb9eb9445b3809 13383 admin optional udisks2_2.1.2-1.debian.tar.gz
 6496c44d90d15705e6decb4131e4a351 254150 admin optional udisks2_2.1.2-1_amd64.deb
 05da2f9124656f37415caed329db1cda 179538 doc optional udisks2-doc_2.1.2-1_all.deb
 3e5a9b9dd4eadb390d2b6c27dbef333f 93076 libs optional libudisks2-0_2.1.2-1_amd64.deb
 5e3766760b0258c6ab1818248c01ef1d 144376 libdevel optional libudisks2-dev_2.1.2-1_amd64.deb
 4d0e561f6c0231c0f87906509132af29 20166 introspection optional gir1.2-udisks-2.0_2.1.2-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIcBAEBCAAGBQJS1QP+AAoJENFO8V2v4RNH4ZgQAJ3gb50j7B9mwp3Pg5hJjrex
CGLq6AE1IiPOK+L/LgTZBUBOxsf2N5COQgs7z4o60wMnMBiL3IZ0+tPEaS0BYEWK
fhHOVAZtbRE0a3o+ZqqIpAAlIhX868/PZ53upxZD1HTP+oLlUtRTxdRSByiKIgJy
FJO9ibBahPiTGYwvplHZh6xQYCkpcgoesJd/j3UvU9I2fTYS9REWks6AVydXJ+BT
wMozhvUfp2EyLHLepZxoiNIQoZQZnQZp+QjjPDqqYi7ff/xW0gMSkizPFwIxvbk8
VFauM8d3026v++spfQcz1icr/ywK20HEx/4J+sU8GQ+/4wnW94lLchnImsU/GpxF
VJymwD5A39DdOAEKB+mWWilgGxzuaD73rSfomhkw1RzyDuus7aU9ey0TH5NfABjN
tKOjtmMUOb7IKFg/lXxQ+xg610QX123mnPv1jPbqqUqq5iABrl5HauT4NYVLGwtI
xxg8PZNwJMRvc/1GFSV7uT6Oc0/2onKhePpgrGYc9+ErXft0/3tolnjZKp3VZu/P
7hciQUkfm+sgCg8GIMIc3zA09wapI8A17dEmoUasEqt9vVRI4CLqy49NUl6mz2xZ
R1pTfOt20IbACFc/UU2MCRcXE6hdS3EJ5OEaueFI3uZUWJb8qwmsw0/n3xvtRqH0
EOMgBYFZcgNS+VKW27aX
=zHAR
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.