Debian Bug report logs - #717801
Changing save slot using 0-9 keys is broken

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Milan Straka <fox@ucw.cz>

To: submit@bugs.debian.org

Subject: Changing save slot using 0-9 keys is broken

Date: Thu, 25 Jul 2013 10:56:25 +0200

Package: libmupen64plus2
Version: 2.0-1

When upgrading libmupen64plus2 from 1.99.5-6 to 2.0-1, using 0-9 keys to
change save slot stopped working. The reason is that the version 2.0-1
uses SDL 2.0 and uses scancodes instead of keysyms to test for keys 0-9,
in the following way:

src/main/eventloop.c:457
    else if (keysym >= SDL_SCANCODE_0 && keysym <= SDL_SCANCODE_9)
        main_state_set_slot(keysym - SDL_SCANCODE_0);

Unfortunately, the values of scancodes for 0-9 are not sequential:
SDL2/SDL_scancode.h:81
    SDL_SCANCODE_1 = 30,
    SDL_SCANCODE_2 = 31,
    SDL_SCANCODE_3 = 32,
    SDL_SCANCODE_4 = 33,
    SDL_SCANCODE_5 = 34,
    SDL_SCANCODE_6 = 35,
    SDL_SCANCODE_7 = 36,
    SDL_SCANCODE_8 = 37,
    SDL_SCANCODE_9 = 38,
    SDL_SCANCODE_0 = 39,

Therefore, keysym is never >= SDL_SCANCODE_0 and <= SDL_SCANCODE_9.

According to SDL2 docs, "The values in this enumeration are based on the
USB usage page standard http://www.usb.org/developers/docs/", so it is
probably safe to assume that they will not be changed and so
SDL_SCANCODE_1 to SDL_SCANCODE_9 are sequential, and test for
SDL_SCANCODE_0 separately.

Cheers,
Milan Straka

Message #10 received at 717801@bugs.debian.org (full text, mbox, reply):

From: Sven Eckelmann <sven@narfation.org>

To: Milan Straka <fox@ucw.cz>, 717801@bugs.debian.org

Subject: Re: Bug#717801: Changing save slot using 0-9 keys is broken

Date: Thu, 25 Jul 2013 13:05:39 +0200

[Message part 1 (text/plain, inline)]

On Thursday 25 July 2013 10:56:25 Milan Straka wrote:
> Package: libmupen64plus2
> Version: 2.0-1
> 
> When upgrading libmupen64plus2 from 1.99.5-6 to 2.0-1, using 0-9 keys to
> change save slot stopped working. The reason is that the version 2.0-1
> uses SDL 2.0 and uses scancodes instead of keysyms to test for keys 0-9,
> in the following way:
> 
> src/main/eventloop.c:457
>     else if (keysym >= SDL_SCANCODE_0 && keysym <= SDL_SCANCODE_9)
>         main_state_set_slot(keysym - SDL_SCANCODE_0);
> 
> Unfortunately, the values of scancodes for 0-9 are not sequential:
> SDL2/SDL_scancode.h:81
>     SDL_SCANCODE_1 = 30,
>     SDL_SCANCODE_2 = 31,
>     SDL_SCANCODE_3 = 32,
>     SDL_SCANCODE_4 = 33,
>     SDL_SCANCODE_5 = 34,
>     SDL_SCANCODE_6 = 35,
>     SDL_SCANCODE_7 = 36,
>     SDL_SCANCODE_8 = 37,
>     SDL_SCANCODE_9 = 38,
>     SDL_SCANCODE_0 = 39,
> 
> Therefore, keysym is never >= SDL_SCANCODE_0 and <= SDL_SCANCODE_9.
> 
> According to SDL2 docs, "The values in this enumeration are based on the
> USB usage page standard http://www.usb.org/developers/docs/", so it is
> probably safe to assume that they will not be changed and so
> SDL_SCANCODE_1 to SDL_SCANCODE_9 are sequential, and test for
> SDL_SCANCODE_0 separately.

Thanks a lot for the bug report.

I will change it later when I have access to an actual PC (unfortunatelly, 
this can take quite long because I am currently on vacation). But I try my 
best to find some computing device were I can prepare the upload.

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 717801-close@bugs.debian.org (full text, mbox, reply):

From: Sven Eckelmann <sven@narfation.org>

To: 717801-close@bugs.debian.org

Subject: Bug#717801: fixed in mupen64plus-core 2.0-2

Date: Thu, 25 Jul 2013 12:03:09 +0000

Source: mupen64plus-core
Source-Version: 2.0-2

We believe that the bug you reported is fixed in the latest version of
mupen64plus-core, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 717801@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sven Eckelmann <sven@narfation.org> (supplier of updated mupen64plus-core package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 25 Jul 2013 13:25:47 +0200
Source: mupen64plus-core
Binary: libmupen64plus2 libmupen64plus2-dbg libmupen64plus-dev mupen64plus-data
Architecture: source i386 all
Version: 2.0-2
Distribution: unstable
Urgency: low
Maintainer: Tobias Loose <TobiasLoose@gmx.de>
Changed-By: Sven Eckelmann <sven@narfation.org>
Description: 
 libmupen64plus-dev - mupen64plus development package
 libmupen64plus2 - plugin-based Nintendo 64 emulator, core library
 libmupen64plus2-dbg - mupen64plus debug symbols package
 mupen64plus-data - plugin-based Nintendo 64 emulator, data files
Closes: 717801
Changes: 
 mupen64plus-core (2.0-2) unstable; urgency=low
 .
   * debian/patches:
     - Add n64_cic_nus_6105_reset.patch, Reset PIF_RAMb 46,47 after the
       n64_cic_nus_6105 challenge
     - Add sdl2_select_saveslot.patch, Fix saveslot selection for SDL2
       (Closes: #717801)
Checksums-Sha1: 
 8e99537b7b747a39e8b9e23cd98e68ad95e56b19 2332 mupen64plus-core_2.0-2.dsc
 a5f1f9a0ef30a81658c7e1c4f744a166e63f1ed0 28953 mupen64plus-core_2.0-2.debian.tar.gz
 c3daf0447ef12e4b15344929f708b96a3b6ec10d 219602 libmupen64plus2_2.0-2_i386.deb
 8b48575b754abe40234ad9d3c600ecc8f7070e65 515706 libmupen64plus2-dbg_2.0-2_i386.deb
 3d52f9a2d1d21dd70a3aa1d8353bd50bb43f7736 36308 libmupen64plus-dev_2.0-2_all.deb
 06500d01b6172ffa0b6b1c6df0bec28a57db9601 636850 mupen64plus-data_2.0-2_all.deb
Checksums-Sha256: 
 03ab884ac1160bd1a2c6fcb34b6cb53d10e4ad234dc23c46ef125bc2513652db 2332 mupen64plus-core_2.0-2.dsc
 5ae765000b61797bf6075ce3e09fd6a3928dfb51e92231ec38f4d5940089e305 28953 mupen64plus-core_2.0-2.debian.tar.gz
 246be047a0f56c24127d228faa29c79d112630b55a337955ad4ac89d164e8e7e 219602 libmupen64plus2_2.0-2_i386.deb
 8afe33e42fbd5cd82be61b00cfde5775d92447cb95e5ae0d1ee1813cc7b8bb9d 515706 libmupen64plus2-dbg_2.0-2_i386.deb
 7900e6056bb9fdf9e440a44ba4def68ea0bd087217e83e094fdcbc1891a3fd0c 36308 libmupen64plus-dev_2.0-2_all.deb
 688a5a8d79db35b198229684c83dee790b9266c9fee1835157d48c615c0a5a6b 636850 mupen64plus-data_2.0-2_all.deb
Files: 
 82a6f73c0ab18a2341a622326385eb15 2332 games optional mupen64plus-core_2.0-2.dsc
 6ca6d9b6cd647c5b0f6c5c5db7c1420e 28953 games optional mupen64plus-core_2.0-2.debian.tar.gz
 f723d4fd610734a1ecad5b8320cb7609 219602 libs optional libmupen64plus2_2.0-2_i386.deb
 359473273bdefa50813b22336c996066 515706 debug extra libmupen64plus2-dbg_2.0-2_i386.deb
 09f5627bea43770b586511373e71fe87 36308 libdevel optional libmupen64plus-dev_2.0-2_all.deb
 8879c12d9a58cf7b69a22079b9b94cae 636850 games optional mupen64plus-data_2.0-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCgAGBQJR8RJvAAoJEF2HCgfBJntGh7sP/jUufyq3BRQPY0JZkIM4gSzU
5J4BmMycIgsP9yOOirfMhCjxRiodvgOUurKTNxS1RSOnfgHB6Fz3VJ7lZOSq442c
ToOS8FFzJa2hM1ftPKeEJnsJdMgTl8NQa3VewxQyWK76+AdYdcrGDFqGhvdmU8gc
9RbeFMgL1A8qkI2Clc344AnIdfNe/IneZhKppzc1lOZkrT1VTvQuLFkllojHcsBF
dWYgKgGnlMczePA4j4qVdAltKjlKKOL6uplcRu9I6zIT9v0DYwOleP1RoWe/vGsP
1MVPhfm8dc/nlG/ryYmIE3KZOWIBJBLS5ZHHU9m5KptVHL45QogVIe6qmo2FyBwh
fM+cA1cbUU36VO7esiut1EFvnLNiL1GBcS2j4soZqr5vxaGpUCL8alf3y8cbYTIP
T/ia3ZAOQsNnku9ipqrg5vmFj9U153qAgfA/R11UtUMyqFsLi85P9dUIezu5QHtF
v4Hrs5psdXpguc2YJr2T5k1YDM9wVUSmXvekE0OMnn5+1CDpY2XFTH92LRXYFQrN
dhMeJCgYzqjZK1dnXUPyOPyA2aO82Af8f2VTl+ZUeIG8nkcesipew26dAic7peYl
+j2EySLHebVuZrZZQr0IfTK0Ma7JI68T2KDGt39bVH0g1J/WCZOkwvVpqglbf2LG
RHYe+Niw4PW9ZYVCLEh9
=+/CS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.