Debian Bug report logs - #712078
fsck.btrfs not working due to argv[0] inspection

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>

To: submit@bugs.debian.org

Subject: btrfs-progs: fsck.btrfs -a is not working

Date: Wed, 12 Jun 2013 21:09:33 +0200

Package: btrfs-tools
Version: 0.19+20130315-2
Severity: important

Just upgraded from stable to sid on a machine where rootfs is on a btrfs
partition. The machine does hangs during boot because fsck failed. The call
chain is:

| init boot
|  \_ /bin/sh /etc/init.d/rc S
|      \_ startpar -p 4 -t 20 -T 3 -M boot -P N -R S
|          \_ /bin/sh /etc/init.d/checkroot.sh start
|              \_ logsave -s /var/log/fsck/checkroot fsck -C -a -t btrfs /run /rootdev
|                  \_ fsck -C -a -t btrfs /run/rootdev
|                      \_ /bin/sh /sbin/fsck.btrfs -a /run/rootdev
|

with 

|lrwxrwxrwx 1 root root 7 May 20 11:23 /sbin/fsck.btrfs -> btrfsck

and the output is

| $ /sbin/fsck.btrfs -a /run/rootdev
| Unknown option: -a
| usage: btrfs [--help] [--version] <group> [<group>...] <command> [<args>]
| $ echo $?
| 129

-a and -y should be probably mapped to --repair by fsck for btrfs or
implemented by btrfs-tools. Any idea what is the better way?

Sebastian

Message #10 received at 712078@bugs.debian.org (full text, mbox, reply):

From: chrysn <chrysn@fsfe.org>

To: 712078@bugs.debian.org

Cc: contro@bugs.debian.org

Subject: fsck.btrfs not working due to argv[0] inspection

Date: Fri, 14 Jun 2013 20:56:03 +0200

[Message part 1 (text/plain, inline)]

retitle 712078 fsck.btrfs not working due to argv[0] inspection
thank you

the problem you describe is much more general, as shown by this
comparison:

> $ /sbin/fsck.btrfs /dev/null
> btrfs: unknown token '/dev/null'
> usage: btrfs [--help] [--version] <group> [<group>...] <command> [<args>]
> [...]
> 
> $ /sbin/btrfsck /dev/null
> No valid Btrfs found on /dev/null

given /sbin/btrfsck and /sbin/btrfs are identical, it seems to me that
that binary decides what to do based on the name it is invoked as (just
like busybox). that failes when invoked as the symlink fsck.btrfs ->
btrfsck.

the trivial fix is to replace the /sbin/fsck.btrfs symlink by a shell
script:

> #!/bin/sh
> /sbin/btrfsck $@

a better thing to do might be to add fsck.btrfs to the list of accepted
names in order to start an fsck run.


best regards
chrysn

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 712078-close@bugs.debian.org (full text, mbox, reply):

From: Dmitrijs Ledkovs <xnox@debian.org>

To: 712078-close@bugs.debian.org

Subject: Bug#712078: fixed in btrfs-tools 0.19+20130315-3

Date: Tue, 23 Jul 2013 21:48:14 +0000

Source: btrfs-tools
Source-Version: 0.19+20130315-3

We believe that the bug you reported is fixed in the latest version of
btrfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 712078@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitrijs Ledkovs <xnox@debian.org> (supplier of updated btrfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 23 Jul 2013 16:12:29 +0100
Source: btrfs-tools
Binary: btrfs-tools btrfs-tools-udeb btrfs-tools-dbg
Architecture: source amd64
Version: 0.19+20130315-3
Distribution: unstable
Urgency: low
Maintainer: Dmitrijs Ledkovs <xnox@debian.org>
Changed-By: Dmitrijs Ledkovs <xnox@debian.org>
Description: 
 btrfs-tools - Checksumming Copy on Write Filesystem utilities
 btrfs-tools-dbg - Checksumming Copy on Write Filesystem utilities (debug)
 btrfs-tools-udeb - Checksumming Copy on Write Filesystem utilities (udeb) (udeb)
Closes: 712078 717564
Changes: 
 btrfs-tools (0.19+20130315-3) unstable; urgency=low
 .
   * New maintainer (Closes: #717564)
     - Thanks a lot to Luk and Daniel for previous
       maintainership. Co-maintainance is welcome!
   * Include fsck.btrfs in the initramfs
   * Use correct compiler, when cross-compiling
   * Default to act like fsck. (Closes: #712078)
   * Apply a gross hack to set fastboot for grub, if root is on btrfs
     because of bug 701936. One still needs to manually run update-grub.
Checksums-Sha1: 
 aeb0cb8dadca8de853f7a868e96c14f11cba819d 1986 btrfs-tools_0.19+20130315-3.dsc
 60b78639d0b64a0d7d738d492e7f3a58395d071f 204576 btrfs-tools_0.19+20130315.orig.tar.xz
 89abcab2c0cf20f09491d0ac0e58283dfdefa7f3 10156 btrfs-tools_0.19+20130315-3.debian.tar.xz
 08745e698bf1ab2666effbdd04191012fbdf8a62 320182 btrfs-tools_0.19+20130315-3_amd64.deb
 e4157f6b8b0779cf80806cbaf78765e732f6c3b6 149502 btrfs-tools-udeb_0.19+20130315-3_amd64.udeb
 297a6db369bfff9cb1c692e4d57712a80b70f3b6 4143578 btrfs-tools-dbg_0.19+20130315-3_amd64.deb
Checksums-Sha256: 
 bcedcd656e0a5e7efa047fb62503e75028cb82551970566d25a8ea44905a52af 1986 btrfs-tools_0.19+20130315-3.dsc
 95a9de93c3785a8a2d7750fce4196c6574f6cbe9b54c28c2b42219857388d855 204576 btrfs-tools_0.19+20130315.orig.tar.xz
 63f8a702b29a44bb966a1cce6dc3bb990602ebe722decc8944262b06f8fdffc7 10156 btrfs-tools_0.19+20130315-3.debian.tar.xz
 5858482239755c536dcea1a6c2f13cbf7cda27f1cbbf9c21dfdd486d5c60fbd9 320182 btrfs-tools_0.19+20130315-3_amd64.deb
 e6344fea0c36d42262726c0dbfd49690f4743ce83a6f8e741b6525e1ed1b5cae 149502 btrfs-tools-udeb_0.19+20130315-3_amd64.udeb
 562e24da1dcf01ba8529e2b536b3e2b68b808e829869783654284c5e6ff48c19 4143578 btrfs-tools-dbg_0.19+20130315-3_amd64.deb
Files: 
 e62ae14f37bb4f5455e643980506a62f 1986 admin optional btrfs-tools_0.19+20130315-3.dsc
 fad014ef28308cd42e1c4f0022490cef 204576 admin optional btrfs-tools_0.19+20130315.orig.tar.xz
 67a3c6171274e39fb3f4fb287e815337 10156 admin optional btrfs-tools_0.19+20130315-3.debian.tar.xz
 0513827388d165b9a3fed2767c872914 320182 admin optional btrfs-tools_0.19+20130315-3_amd64.deb
 1668610a9c020936a89f5ed175fcfe36 149502 debian-installer optional btrfs-tools-udeb_0.19+20130315-3_amd64.udeb
 f6ae82ee12b3e88c47cf44846e9344c1 4143578 debug extra btrfs-tools-dbg_0.19+20130315-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJR7vdLAAoJEIh7YGGLPBautVUP/ilC5cnOuCRmHTI7pCXDXUBL
lpAV2/vZroBbAkvGXMZy0vxzBE1ecytcqlKEarxFn5CMIxlR4SdljRzIDuevPMWQ
H4NzAEYfzj24WRMufkghOFPOcaIxycw1SJuNaB/UM3jt84XpDkE5uRB5xYZuh+Vo
lsWhZjzpPRaHzI722vr+ZMlXDiX8Mpfqt9O2em8xOlcIvMPtHXeefsH0OwL+yrsq
im+QeWPjYMy7w7GZ4H+Ivr9W+JcNMu+DosXA+iJombq3HIsfiSUZPcU+k2e6YO6n
q8EXJFuPhg6aZXxpluXmv5KAUsBM9jltYntOOK69xwitRnkKaji5k5o9vIK+++ls
MdzHkVKIfq+pqrBmus6WSiTu8wqzyGU4nAim8Nzka9fYe3Qzq2qDttFcFt7OejNJ
Vnboq6xPk9bpN6tT94kNRZ4yWJJE+UO1jHYObR37tPpawo8KMTglfjYy8OEUPbka
5Afoc00UeAWvhEf7Cl6TDLZp++fCkEa+7Zs/aNiTk49247E+dSwnLlLOB7DWZ6uu
Kwqsfd431YOR25lccIzDS15wo6CXiIZ+uJgYpbpOmMNeApU6BOuvnUV8fvdY6Ldp
W8hMPVDRUNkmGnfdkj1igLBCQy6owti1VskTrS4l5/dHna4FlsyX4icd0bLEIyb7
LhJiC+bJLeJhMTkQGCtQ
=jMyf
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.