Debian Bug report logs - #710643
ibus: FTBFS: ibusfactory.c:294:52: error: format not a string literal and no format arguments [-Werror=format-security]

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: David Suárez <david.sephirot@gmail.com>

To: submit@bugs.debian.org

Subject: ibus: FTBFS: ibusfactory.c:294:52: error: format not a string literal and no format arguments [-Werror=format-security]

Date: Fri, 31 May 2013 21:39:16 +0200

Source: ibus
Version: 1.5.1.is.1.4.2-1
Severity: serious
Tags: jessie sid
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20130529 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> make[5]: Entering directory `/«PKGBUILDDIR»/src'
>   CC     ibusshare.lo
> ibusshare.c: In function 'ibus_init':
> ibusshare.c:329:5: warning: 'g_type_init' is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Wdeprecated-declarations]
>   CC     ibusobject.lo
>   CC     ibusserializable.lo
>   CC     ibusproxy.lo
>   CC     ibusservice.lo
>   CC     ibusfactory.lo
> ibusfactory.c: In function 'ibus_factory_service_method_call':
> ibusfactory.c:294:52: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
> make[5]: *** [ibusfactory.lo] Error 1

The full build log is available from:
   http://deiv.vzpla.net/logs/2013/05/29/ibus_1.5.1.is.1.4.2-1_unstable.log

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

Message #10 received at 710643@bugs.debian.org (full text, mbox, reply):

From: Andrey Rahmatullin <wrar@wrar.name>

To: David Suárez <david.sephirot@gmail.com>, 710643@bugs.debian.org

Subject: Re: Bug#710643: ibus: FTBFS: ibusfactory.c:294:52: error: format not a string literal and no format arguments [-Werror=format-security]

Date: Sat, 1 Jun 2013 22:44:59 +0600

[Message part 1 (text/plain, inline)]

On Fri, May 31, 2013 at 09:39:16PM +0200, David Suárez wrote:
> > ibusfactory.c: In function 'ibus_factory_service_method_call':
> > ibusfactory.c:294:52: error: format not a string literal and no format arguments [-Werror=format-security]
> > cc1: some warnings being treated as errors
The code:

g_dbus_method_invocation_return_error (invocation,
                                       G_DBUS_ERROR,
                                       G_DBUS_ERROR_FAILED,
                                       error_message);

Docs say that the 4th parameter is "printf()-style format".

-- 
WBR, wRAR

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 710643@bugs.debian.org (full text, mbox, reply):

From: peter green <plugwash@p10link.net>

To: 710643@bugs.debian.org

Subject: re: ibus: FTBFS: ibusfactory.c:294:52: error: format not a string literal and no format arguments [-Werror=format-security]

Date: Wed, 05 Jun 2013 22:30:14 +0100

[Message part 1 (text/plain, inline)]

The fix was pretty simple, just let 
g_dbus_method_invocation_return_error do the formatting rather than 
trying to do it ourselves. Format security error fixed, code simplified 
and unnessacery copy avoided win-win-win.

Patch is attached. The patch contains a NMU changelog entry but I have 
no immediate plans to NMU because I have no idea how to test the package.

[ibus.debdiff (text/plain, attachment)]

Message #20 received at 710643-close@bugs.debian.org (full text, mbox, reply):

From: Osamu Aoki <osamu@debian.org>

To: 710643-close@bugs.debian.org

Subject: Bug#710643: fixed in ibus 1.5.1.is.1.4.2-2

Date: Sun, 16 Jun 2013 15:20:34 +0000

Source: ibus
Source-Version: 1.5.1.is.1.4.2-2

We believe that the bug you reported is fixed in the latest version of
ibus, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 710643@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Osamu Aoki <osamu@debian.org> (supplier of updated ibus package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 16 Jun 2013 22:29:37 +0900
Source: ibus
Binary: ibus libibus-1.0-0 libibus-1.0-dev ibus-gtk ibus-gtk3 python-ibus ibus-doc gir1.2-ibus-1.0
Architecture: source amd64 all
Version: 1.5.1.is.1.4.2-2
Distribution: unstable
Urgency: low
Maintainer: IME Packaging Team <pkg-ime-devel@lists.alioth.debian.org>
Changed-By: Osamu Aoki <osamu@debian.org>
Description: 
 gir1.2-ibus-1.0 - Intelligent Input Bus - introspection data
 ibus       - Intelligent Input Bus - core
 ibus-doc   - Intelligent Input Bus - development documentation
 ibus-gtk   - Intelligent Input Bus - GTK+2 support
 ibus-gtk3  - Intelligent Input Bus - GTK+3 support
 libibus-1.0-0 - Intelligent Input Bus - shared library
 libibus-1.0-dev - Intelligent Input Bus - development file
 python-ibus - Intelligent Input Bus - Python support
Closes: 710643 712149
Changes: 
 ibus (1.5.1.is.1.4.2-2) unstable; urgency=low
 .
   [ Peter Michael Green ]
   * Fix format security error by passing format string and parameter directly
     to g_dbus_method_invocation_return_error rather than formatting the string
     ourselves and passing that to the function. Closes: #710643
 .
   [ Osamu Aoki ]
   * Fix ibus-setup breakage by setting all related packages to use
    --libexec=/usr/lib/ibus.  Closes: #712149
Checksums-Sha1: 
 0347383b3b341fc225c182e132477e05de3bcb7a 2038 ibus_1.5.1.is.1.4.2-2.dsc
 68cad27f1e502ec1613cfd2673ad4bf084bd5368 22875 ibus_1.5.1.is.1.4.2-2.debian.tar.gz
 c0473e6d1804eccdd733307d929212e0b0eda8d2 447778 ibus_1.5.1.is.1.4.2-2_amd64.deb
 6a25144994e0a36e0b288002c4c81c6674805a6f 264990 libibus-1.0-0_1.5.1.is.1.4.2-2_amd64.deb
 30a098efd62c4da6934994cf8d6c99dbe5c9aa13 290804 libibus-1.0-dev_1.5.1.is.1.4.2-2_amd64.deb
 f0f50fd506af846a9f694477e086bb19d60edca6 167488 ibus-gtk_1.5.1.is.1.4.2-2_amd64.deb
 b602580dbaca72ab9364cc3dd9b545c47073ec86 167424 ibus-gtk3_1.5.1.is.1.4.2-2_amd64.deb
 ed5cba0e5d770fc2371597ad3555d08015addb9e 188532 python-ibus_1.5.1.is.1.4.2-2_all.deb
 94a0d9f4b8aeb94f93f84f541b0f6da40718f316 339042 ibus-doc_1.5.1.is.1.4.2-2_all.deb
 1b3800af116f2c5eb5f04a908a4b86abec4b77f8 207638 gir1.2-ibus-1.0_1.5.1.is.1.4.2-2_amd64.deb
Checksums-Sha256: 
 f5d9e6e2070408d90c73a3670e44660b2c15511ca7bd2b62b962130c419ffb47 2038 ibus_1.5.1.is.1.4.2-2.dsc
 eb7d91e68a9138ac65e2e2f708b013faa342048345ac7b9ab84ffe7e80477037 22875 ibus_1.5.1.is.1.4.2-2.debian.tar.gz
 039b7e5de5088612183ae8db06656f1d1eafdfd985a55c47c269fa2f85b5bc88 447778 ibus_1.5.1.is.1.4.2-2_amd64.deb
 85a60687f1cf9fefd93a092f4de013739c21ed6d1700ac3a7c3d9dfe11e29df9 264990 libibus-1.0-0_1.5.1.is.1.4.2-2_amd64.deb
 6b200bb48760fc2d37c63cdb50315d6883e25ce56e536a15379b528c22006f1d 290804 libibus-1.0-dev_1.5.1.is.1.4.2-2_amd64.deb
 beb9b1527f32883ed47b5a362b32678476198b80099c27b560f1882785f2425f 167488 ibus-gtk_1.5.1.is.1.4.2-2_amd64.deb
 f993e09aad2259250d85958743cdce89b0b8a3c64c03be12079638c6057786a2 167424 ibus-gtk3_1.5.1.is.1.4.2-2_amd64.deb
 209bd7fd1d21e95ea2e1b7b06642c541448273390419a734b51baf9a85322822 188532 python-ibus_1.5.1.is.1.4.2-2_all.deb
 a9b2d01ebde0a4de62654351e13d122e55f0c06f947704c4306f9f8819dfac13 339042 ibus-doc_1.5.1.is.1.4.2-2_all.deb
 e24b5428f69288e69282ede7059a9770fdb9263b6a4768a97df04650e5c3ff0e 207638 gir1.2-ibus-1.0_1.5.1.is.1.4.2-2_amd64.deb
Files: 
 5f83097981635aeccb031894d3bc4849 2038 utils optional ibus_1.5.1.is.1.4.2-2.dsc
 79187e6959a6d8515fc72a0a3d2e0f35 22875 utils optional ibus_1.5.1.is.1.4.2-2.debian.tar.gz
 138e57b3fc5b6789a84a26dbfa1e4617 447778 utils optional ibus_1.5.1.is.1.4.2-2_amd64.deb
 a2150ce30666b2006de0e46e71e6b5de 264990 libs optional libibus-1.0-0_1.5.1.is.1.4.2-2_amd64.deb
 c1e80a3af8e102dba1cd4fc6355d8d34 290804 libdevel optional libibus-1.0-dev_1.5.1.is.1.4.2-2_amd64.deb
 1b5bd0d073bbc334cec1dd29f099eccd 167488 utils optional ibus-gtk_1.5.1.is.1.4.2-2_amd64.deb
 386462b9aec93a1a65342e7f4e992126 167424 utils optional ibus-gtk3_1.5.1.is.1.4.2-2_amd64.deb
 314051897b55f8c52d8c1fc4ab0ea0e2 188532 python optional python-ibus_1.5.1.is.1.4.2-2_all.deb
 ddc6ef9496a8bd7b76b8a76599d622af 339042 doc optional ibus-doc_1.5.1.is.1.4.2-2_all.deb
 10ce8c1dc2fe50dcaf8936a4ed3b7c1f 207638 introspection optional gir1.2-ibus-1.0_1.5.1.is.1.4.2-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlG9wacACgkQ6A/EwagGHzLuYwCffpl5C8fz3iA9bDkGQzfFMZGL
rIsAn07whfajHrgFKTNMs1iV8H2fZsxh
=8x21
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.