Debian Bug report logs - #710625
performous: FTBFS: xtime.hh:27:34: error: expected unqualified-id before numeric constant

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: David Suárez <david.sephirot@gmail.com>

To: submit@bugs.debian.org

Subject: performous: FTBFS: xtime.hh:27:34: error: expected unqualified-id before numeric constant

Date: Fri, 31 May 2013 23:58:40 +0200

Source: performous
Version: 0.7.0-1
Severity: serious
Tags: jessie sid
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20130529 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

It's a problem in boost which is fixed in 1.50. TIME_UTC is a C11 macro
that colides with boost::TIME_UTC. In Boost 1.50, this constant was renamed
to TIME_UTC_. 

You should update your Build-Depends (upstream has already fixed this).

Relevant part:
> make[3]: Entering directory `/«PKGBUILDDIR»/build-tree'
> /usr/bin/cmake -E cmake_progress_report /«PKGBUILDDIR»/build-tree/CMakeFiles 19
> [ 17%] Building CXX object game/CMakeFiles/performous.dir/ffmpeg.cc.o
> cd /«PKGBUILDDIR»/build-tree/game && /usr/bin/c++   -DBOOST_FILESYSTEM_VERSION=2 -DUSE_GETTEXT -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -pthread -O2 -g -DNDEBUG -I/usr/include/SDL -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/cairo -I/usr/include/librsvg-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libxml++-2.6 -I/usr/sbin/../lib/libxml++-2.6/include -I/usr/include/libxml2 -I/usr/include/glibmm-2.4 -I/usr/lib/x86_64-linux-gnu/glibmm-2.4/include -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include -I/usr/include/GL -I/usr/include/x86_64-linux-gnu -I/«PKGBUILDDIR»/build-tree/game    -o CMakeFiles/performous.dir/ffmpeg.cc.o -c /«PKGBUILDDIR»/game/ffmpeg.cc
> In file included from /«PKGBUILDDIR»/game/ffmpeg.cc:5:0:
> /«PKGBUILDDIR»/game/xtime.hh: In function 'boost::xtime {anonymous}::now()':
> /«PKGBUILDDIR»/game/xtime.hh:27:34: error: expected unqualified-id before numeric constant
> make[3]: *** [game/CMakeFiles/performous.dir/ffmpeg.cc.o] Error 1

The full build log is available from:
   http://deiv.vzpla.net/logs/2013/05/29/performous_0.7.0-1_unstable.log

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

Message #10 received at 710625@bugs.debian.org (full text, mbox, reply):

From: peter green <plugwash@p10link.net>

To: 710625@bugs.debian.org

Subject: re: performous: FTBFS: xtime.hh:27:34: error: expected unqualified-id before numeric constant

Date: Mon, 03 Jun 2013 23:57:11 +0100

[Message part 1 (text/plain, inline)]

>
> It's a problem in boost which is fixed in 1.50. TIME_UTC is a C11 macro
> that colides with boost::TIME_UTC. In Boost 1.50, this constant was renamed
> to TIME_UTC_. 
>
> You should update your Build-Depends (upstream has already fixed this).
>   
Unfortunately changing the build-depends to point at boost 1.50 or 1.53 
results in a different error.

In file included from /usr/include/boost/filesystem.hpp:15:0,
                from /performous-0.7.0.new/game/fs.hh:3,
                from /performous-0.7.0.new/game/controllers.cc:9:
/usr/include/boost/filesystem/config.hpp:16:5: error: #error Compiling 
Filesystem version 3 file with BOOST_FILESYSTEM_VERSION defined != 3

So I decided to take a different approach. Rather than trying to move to 
a newer boost I decided to try and deal with the problem with 1.49. It 
seems that the renaming of the enum value has been backported to 1.49 by 
debian but performous doesn't know this. I edited the code to 
unconditionally use the new name

I also changed the build-depends to 1.49 explicitly so the package will 
continue to build after the boost-defaults are changed and versioned the 
build-depends on the version that backported the enum fix.

I will be uploading this fix to Raspbian jessie along with a raspbian 
specific change for an issue that I could not reproduce in debian. I 
have no immediate plans to upload this as a NMU but I may change my mind 
on that later.

Patch (including NMU changelog) is attached.

Note: i'm just a guy who stubled across this bug while working on a 
deriviative, I have no relation to the package.

[performous.debdiff (text/plain, attachment)]

Message #15 received at 710625@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@gambaru.de>

To: 710625@bugs.debian.org

Cc: peter green <plugwash@p10link.net>

Subject: performous: FTBFS: xtime.hh:27:34: error: expected unqualified-id before numeric constant

Date: Sun, 30 Jun 2013 12:39:39 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 pending

Hello Peter,


thank you for your patch and the additional information. However i had
to make some small adjustments. The versioned dependencies on libboost
are not necessary anymore because they are trivially satisfied now.

I have simply changed TIME_UTC to TIME_UTC_ for older versions of
libboost. This patch will not be required anymore as soon as Debian
switches to libboost1.53 as the new default version.


Regards,

Markus

[signature.asc (application/pgp-signature, attachment)]

Message #22 received at 710625-close@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@gambaru.de>

To: 710625-close@bugs.debian.org

Subject: Bug#710625: fixed in performous 0.7.0-2

Date: Sun, 30 Jun 2013 15:20:14 +0000

Source: performous
Source-Version: 0.7.0-2

We believe that the bug you reported is fixed in the latest version of
performous, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 710625@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <apo@gambaru.de> (supplier of updated performous package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 30 Jun 2013 11:59:10 +0200
Source: performous
Binary: performous performous-tools performous-dbg
Architecture: source i386
Version: 0.7.0-2
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Markus Koschany <apo@gambaru.de>
Description: 
 performous - karaoke game that allows user supplied songs
 performous-dbg - karaoke game that allows user supplied songs - debug
 performous-tools - karaoke game that allows user supplied songs - tools
Closes: 710625
Changes: 
 performous (0.7.0-2) unstable; urgency=low
 .
   * Team upload.
   * debian/control:
     - Use canonical VCS-URI.
     - Remove versioned dependencies on boost libraries because they are
       trivially satisfied now.
     - Remove superfluous ${shlibs:Depends} substvar from performous-dbg
       package.
     - Bump Standards-Version to 3.9.4, no changes.
   * debian/copyright: Fix lintian issue copyright-refers-to-symlink-license and
     point to GPL-2 license.
   * Add use-Boost-TIME_UTC_-constant-unconditionally.patch. Use always the new
     Boost constant TIME_UTC_ and fix FTBFS with libboost1.49. (Closes: #710625)
   * Drop boost_filesystem_v2.patch. Not necessary for newer boost versions.
Checksums-Sha1: 
 8922243d063a02c7a98fc2650ec63affd1eb7143 1859 performous_0.7.0-2.dsc
 be6558c888a4de0dc75d2b48e0286d5239679a4d 14759 performous_0.7.0-2.debian.tar.bz2
 5c0cfc76e6ec5fedfeea6121098ec984a495cdf4 3720914 performous_0.7.0-2_i386.deb
 5a779ae9781873b752814b5926a538fe15542432 139794 performous-tools_0.7.0-2_i386.deb
 75223c8b105f3a7f4fe23c18cd801d760c05633c 11852668 performous-dbg_0.7.0-2_i386.deb
Checksums-Sha256: 
 394532c8d62acfb539d97b86ec582d610d76688046adb30dccabae3809f30a26 1859 performous_0.7.0-2.dsc
 e86ac8c7e4d0fe8ec3bfe8da87c509ecd5c2e8e6106318ba4a5233dfcfa68247 14759 performous_0.7.0-2.debian.tar.bz2
 5add278bee97cde312e2a4bbf8fec41cc9f7bebf3877b7c06d30d78e93d6c6bd 3720914 performous_0.7.0-2_i386.deb
 277867bd9a42d61c622fdb8bd2c08ddd2967b7bff337ca27deb32bcf83f48da7 139794 performous-tools_0.7.0-2_i386.deb
 d3991c7bb807e2fa265469c5227414135604af487274d47e6b0643f5bd97e25c 11852668 performous-dbg_0.7.0-2_i386.deb
Files: 
 63008cd67810c3c5926e75de1a4fddeb 1859 games optional performous_0.7.0-2.dsc
 9db54fd8b0c78d135bb169a556a7eca1 14759 games optional performous_0.7.0-2.debian.tar.bz2
 df28828eccd79f5c7e1aa9f3ca441bf0 3720914 games optional performous_0.7.0-2_i386.deb
 8cbf060e327a2e6c5069fdaa07a42724 139794 games optional performous-tools_0.7.0-2_i386.deb
 6b226be4a9c9a5031793b3f1596f8e91 11852668 debug extra performous-dbg_0.7.0-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlHQDz0ACgkQ5ItltUs5T35f8ACg9F8tJ3zxKdY7gZEwnpvr7AYB
wcwAn1IhIDi6do328/ppQXsXVldjKqHF
=OInE
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.