Debian Bug report logs - #706564
supertux: joystick input configuration is lost, if supertux is started when the joystick is not plugged in

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Francesco Poli \(wintermute\)" <invernomuto@paranoici.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: supertux: joystick input configuration is lost, if supertux is started when the joystick is not plugged in

Date: Wed, 01 May 2013 19:50:22 +0200

Package: supertux
Version: 0.3.3-5
Severity: normal

Hello,
the in-game configuration menu for joystick input lets me assign a different
button or axis movement to each action.
For instance, I may configure the game so that:

  Action       Control
  -----------------------
  up           "Axis -Y"
  down         "Axis +Y"
  left         "Axis -X"
  right        "Axis +X"
  jump         "Button 6"
  action       "Button 7"
  pause/menu   "Button 5"
  peek left    "Button 3"
  peek right   "Button 1"
  peek up      "Button 4"
  peek down    "Button 0"

This is really nice and is automatically saved to ~/.supertux2/config

However, I found that, if you start the game when the joystick is not
plugged in, the program spits out the following messages to stderr
(among many other ones):

  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '0' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '1' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '3' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '4' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '5' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '6' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:234 Invalid button '7' in buttonmap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:242 Invalid axis '-2' in axismap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:242 Invalid axis '-1' in axismap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:242 Invalid axis '1' in axismap
  [INFO] /tmp/buildd/supertux-0.3.3/src/control/joystickkeyboardcontroller.cpp:242 Invalid axis '2' in axismap

and my joystick input configuration gets lost!
In other words, the configuration file ~/.supertux2/config gets
overwritten with default values for joystick input configuration!

As a consequence, next time I start the game with the joystick plugged
in, I have to re-configure the joystick controls from scratch!
This is very annoying!

I am convinced that supertux should remember the joystick input configuration,
even when the joystick is not plugged in.

Please fix this bug and/or forward my bug report upstream.

Thanks for your time!


-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages supertux depends on:
ii  libc6                     2.13-38
ii  libcurl3-gnutls           7.26.0-1+wheezy2
ii  libgcc1                   1:4.7.2-5
ii  libgl1-mesa-glx [libgl1]  8.0.5-4
ii  libglew1.7                1.7.0-3
ii  libglu1-mesa [libglu1]    8.0.5-4
ii  libogg0                   1.3.0-4
ii  libopenal1                1:1.14-4
ii  libphysfs1                2.0.3-1
ii  libsdl-image1.2           1.2.12-2
ii  libsdl1.2debian           1.2.15-5
ii  libstdc++6                4.7.2-5
ii  libvorbis0a               1.3.2-1.3
ii  libvorbisfile3            1.3.2-1.3
ii  libx11-6                  2:1.5.0-1
ii  libxext6                  2:1.3.1-2
ii  supertux-data             0.3.3-5

supertux recommends no packages.

supertux suggests no packages.

-- no debconf information

Message #12 received at 706564@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <vincentc1208@gmail.com>

To: Francesco Poli <invernomuto@paranoici.org>

Cc: 706564@bugs.debian.org, 288432@bugs.debian.org

Subject: Re: Bug#288432: supertux: Joystick does not work

Date: Wed, 8 May 2013 15:58:41 -0700

On Wed, May 8, 2013 at 2:56 PM, Francesco Poli
<invernomuto@paranoici.org> wrote:
> On Mon, 6 May 2013 01:34:07 -0700 Vincent Cheng wrote:
>
>> Hi Francesco,
>
> Hi Vincent!
>
>>
>> Can you try testing the attached patch? It was forwarded to the
>> upstream's bug report tracker (from a quick look, it seems reasonable,
>> but I don't know if it actually solves the issue, and again I don't
>> have a joystick to test with).
>
> Wasn't this patch meant for bug #706564 ?

Oops, sorry about that! Yes, this is meant for #706564.

Vincent

Message #17 received at 706564@bugs.debian.org (full text, mbox, reply):

From: Francesco Poli <invernomuto@paranoici.org>

To: 706564@bugs.debian.org

Subject: The patch seems to work! [was: Re: Bug#288432: supertux: Joystick does not work]

Date: Wed, 22 May 2013 23:14:08 +0200

[Message part 1 (text/plain, inline)]

On Wed, 8 May 2013 15:58:41 -0700 Vincent Cheng wrote:

> On Wed, May 8, 2013 at 2:56 PM, Francesco Poli
> <invernomuto@paranoici.org> wrote:
> > On Mon, 6 May 2013 01:34:07 -0700 Vincent Cheng wrote:
[...]
> >> Can you try testing the attached patch? It was forwarded to the
> >> upstream's bug report tracker (from a quick look, it seems reasonable,
> >> but I don't know if it actually solves the issue, and again I don't
> >> have a joystick to test with).
> >
> > Wasn't this patch meant for bug #706564 ?
> 
> Oops, sorry about that! Yes, this is meant for #706564.

Hi Vincent,
I finally managed to test the patch.

Applying the patch to the Debian source package (supertux/0.3.3-5)
required a little (automatic) re-adaptation and adding some patch
description to satisfy the 3.0 (quilt) debian source format.
The resulting re-adapted patch is attached, in the hope that it may
save you the (admittedly very little) time to redo what I have already
done.  

After adding this patch to the quilt series and rebuilding the Debian
package, the bug seems to be fixed.
Please apply the patch to the Debian package and inform upstream the
that patch works.

Thanks a lot for your time!


P.S.: I wonder what would happen if a user had two or more
joysticks/joypads... I suppose that starting supertux with one
joystick plugged could destroy the input configuration previously set
for another joystick... I cannot test this, as I have one joypad only,
but I am under the impression that a better and longer-term solution for
the bug that I experienced would require recognizing different joystick
models (this seems to be already done by supertux, at least for USB
joysticks) and storing distinct configuration settings for each
different joystick model.
Please talk to upstream about this, if you agree.
Thanks again.


-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

[fix_joystick_conf_loss.patch (text/x-diff, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #22 received at 706564-close@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <Vincentc1208@gmail.com>

To: 706564-close@bugs.debian.org

Subject: Bug#706564: fixed in supertux 0.3.3-6

Date: Sun, 26 May 2013 19:04:20 +0000

Source: supertux
Source-Version: 0.3.3-6

We believe that the bug you reported is fixed in the latest version of
supertux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 706564@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Cheng <Vincentc1208@gmail.com> (supplier of updated supertux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 23 May 2013 02:52:12 -0700
Source: supertux
Binary: supertux supertux-data
Architecture: source amd64 all
Version: 0.3.3-6
Distribution: experimental
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Vincent Cheng <Vincentc1208@gmail.com>
Description: 
 supertux   - Classic 2D jump 'n run sidescroller with Tux
 supertux-data - Classic 2D jump 'n run sidescroller with Tux (data files)
Closes: 706564
Changes: 
 supertux (0.3.3-6) experimental; urgency=low
 .
   * Add debian/patches/fix_joystick_conf_loss.patch: stop overwriting user's
     joystick configuration with default values when joystick is not plugged in.
     (Closes: #706564)
   * Fix vcs-field-not-canonical.
   * Bump standards version from 3.9.3 to 3.9.4.
Checksums-Sha1: 
 0b69299be4759084f8928c49f89db92e96456cdd 1971 supertux_0.3.3-6.dsc
 debfe503a3edf0092a3cb28ba2b0b2b63fb6d9aa 10602 supertux_0.3.3-6.debian.tar.gz
 80e43fbda8f0f006759bb01bbc30edd7b8f9f82f 823816 supertux_0.3.3-6_amd64.deb
 bd08a95969287b951f7736126cc5988911581658 58606912 supertux-data_0.3.3-6_all.deb
Checksums-Sha256: 
 422dc158ef8125d226b90c3a3de606fad3ac8eed660fcbd57394c977d1d09c2b 1971 supertux_0.3.3-6.dsc
 d16674c81a435431e18ac1324dd0928022a23845e77d7487240464b06ce67384 10602 supertux_0.3.3-6.debian.tar.gz
 ae7c83385a2d415160697aa70471d3e809a3e369939dfd33f52c2f2b722db76c 823816 supertux_0.3.3-6_amd64.deb
 e43045922c307f7a675fcdf52916ea9d0511e6e6aa70da9cfedd7148a66e9c0d 58606912 supertux-data_0.3.3-6_all.deb
Files: 
 3f6ead5112466acfb5f8b6592fa35afe 1971 games optional supertux_0.3.3-6.dsc
 5c7bec0ff53691ba491377a5da48813a 10602 games optional supertux_0.3.3-6.debian.tar.gz
 06df544b3aa84498a156ba655b35e623 823816 games optional supertux_0.3.3-6_amd64.deb
 da2a3b8cb43584484ddf24000066574f 58606912 games optional supertux-data_0.3.3-6_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBAgAGBQJRolrtAAoJEIAhAkTu07wNs20IAJxdO6Z4A4Qj1/c/PeGFX9/2
4s93QEJ2DvCuNuuc0iXLsqZl0uV1xSbCs8k73R3Szix2ODIKwmUAv0s9Cr0vfUgQ
ju7UL3kN6u8XJZJIdRD3toFpWxEYhRaqcbLe4+UwpitejsMe7rS2XKmYTmfP3ae+
U+9lneCyzeluEKSj5GDlP7OU5c4MV94I/J4EvoRC+Mvj3xPlzlDouMcEjBe8bItc
SHCHTVu9d5O5j46tgWeUVeR2cNObrIcN89MJdQbnhLybRTI2YJq+vxCN4NkdqEkc
n/pj6dgQR3do6Hky1x21bLrWn254U5csxNZKjP8IIQ3b6SNjKzQVrVwL+O5yxoY=
=z2H/
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.