Debian Bug report logs - #706067
libpam-dynalogin: crashes when connection to server cannot be established

version graph

Package: libpam-dynalogin; Maintainer for libpam-dynalogin is (unknown);

Reported by: Petr Čech <cech@debian.org>

Date: Wed, 24 Apr 2013 10:15:02 UTC

Severity: normal

Tags: patch, upstream

Found in version dynalogin/1.0.0-1

Fixed in version 1.0.0-3+rm

Done: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Authentication Maintainers <pkg-auth-maintainers@lists.alioth.debian.org>:
Bug#706067; Package libpam-dynalogin. (Wed, 24 Apr 2013 10:15:06 GMT) (full text, mbox, link).


Acknowledgement sent to Petr Čech <cech@debian.org>:
New Bug report received and forwarded. Copy sent to Debian Authentication Maintainers <pkg-auth-maintainers@lists.alioth.debian.org>. (Wed, 24 Apr 2013 10:15:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Petr Čech <cech@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: libpam-dynalogin: crashes when connection to server cannot be established
Date: Wed, 24 Apr 2013 11:58:07 +0200
Package: libpam-dynalogin
Version: 1.0.0-1
Severity: normal
Tags: upstream patch

Hi,
when the dynalogind server does not run, the PAM module segfaults. The following
patch solves the problem (for me, at least).

Regards,
Petr

diff --git a/pam_dynalogin/pam_dynalogin.c b/pam_dynalogin/pam_dynalogin.c
index df902ed..092c2f3 100644
--- a/pam_dynalogin/pam_dynalogin.c
+++ b/pam_dynalogin/pam_dynalogin.c
@@ -303,7 +303,7 @@ pam_sm_authenticate (pam_handle_t * pamh,
        retval = PAM_SUCCESS;

        done:
-       dynalogin_session_stop(session);
+       if (session) dynalogin_session_stop(session);
        free (query_prompt);
        free (onlypasswd);
        if (cfg.alwaysok && retval != PAM_SUCCESS)


-- System Information:
Debian Release: 7.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing'), (99, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8-trunk-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libpam-dynalogin depends on:
ii  libc6                   2.17-0experimental2
ii  libdynaloginclient-1-0  1.0.0-1
ii  libgnutls28             3.1.10-1
ii  libpam0g                1.1.3-9

libpam-dynalogin recommends no packages.

libpam-dynalogin suggests no packages.

-- no debconf information



Information stored :
Bug#706067; Package libpam-dynalogin. (Wed, 10 May 2017 11:09:04 GMT) (full text, mbox, link).


Acknowledgement sent to Hector Oron <zumbi@debian.org>:
Extra info received and filed, but not forwarded. (Wed, 10 May 2017 11:09:04 GMT) (full text, mbox, link).


Message #10 received at 706067-quiet@bugs.debian.org (full text, mbox, reply):

From: Hector Oron <zumbi@debian.org>
To: Petr Čech <cech@debian.org>, 706067-quiet@bugs.debian.org
Cc: daniel@pocock.pro
Subject: Re: Bug#706067: libpam-dynalogin: crashes when connection to server cannot be established
Date: Wed, 10 May 2017 13:07:24 +0200
[Message part 1 (text/plain, inline)]
Hello,

On Wed, Apr 24, 2013 at 11:58:07AM +0200, Petr Čech wrote:
> Package: libpam-dynalogin
> Version: 1.0.0-1
> Severity: normal
> Tags: upstream patch
> 
> Hi,
> when the dynalogind server does not run, the PAM module segfaults. The following
> patch solves the problem (for me, at least).

The issue is tagged with upstream patch, but I am checking at:
  https://github.com/dynalogin/dynalogin/blob/master/pam_dynalogin/pam_dynalogin.c#L306
and I do not see that patch applied. I also do not see it forwarded upstream:
  https://github.com/dynalogin/dynalogin/issues

Could you please submit it upstream or am I missing something?

Best regards,
  -- really hopping it'll get eventually fixed.

> Regards,
> Petr
> 
> diff --git a/pam_dynalogin/pam_dynalogin.c b/pam_dynalogin/pam_dynalogin.c
> index df902ed..092c2f3 100644
> --- a/pam_dynalogin/pam_dynalogin.c
> +++ b/pam_dynalogin/pam_dynalogin.c
> @@ -303,7 +303,7 @@ pam_sm_authenticate (pam_handle_t * pamh,
>         retval = PAM_SUCCESS;
> 
>         done:
> -       dynalogin_session_stop(session);
> +       if (session) dynalogin_session_stop(session);
>         free (query_prompt);
>         free (onlypasswd);
>         if (cfg.alwaysok && retval != PAM_SUCCESS)
> 
> 
> -- System Information:
> Debian Release: 7.0
>   APT prefers testing-updates
>   APT policy: (500, 'testing-updates'), (500, 'testing'), (99, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 3.8-trunk-amd64 (SMP w/1 CPU core)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages libpam-dynalogin depends on:
> ii  libc6                   2.17-0experimental2
> ii  libdynaloginclient-1-0  1.0.0-1
> ii  libgnutls28             3.1.10-1
> ii  libpam0g                1.1.3-9
> 
> libpam-dynalogin recommends no packages.
> 
> libpam-dynalogin suggests no packages.
> 
> -- no debconf information

-- 
[signature.asc (application/pgp-signature, inline)]

Reply sent to Debian FTP Masters <ftpmaster@ftp-master.debian.org>:
You have taken responsibility. (Sat, 14 Mar 2020 03:15:08 GMT) (full text, mbox, link).


Notification sent to Petr Čech <cech@debian.org>:
Bug acknowledged by developer. (Sat, 14 Mar 2020 03:15:08 GMT) (full text, mbox, link).


Message #15 received at 706067-done@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 705936-done@bugs.debian.org,705939-done@bugs.debian.org,706067-done@bugs.debian.org,732250-done@bugs.debian.org,743004-done@bugs.debian.org,923319-done@bugs.debian.org,953443-done@bugs.debian.org,
Cc: dynalogin@packages.debian.org
Subject: Bug#953837: Removed package(s) from unstable
Date: Sat, 14 Mar 2020 03:13:44 +0000
Version: 1.0.0-3+rm

Dear submitter,

as the package dynalogin has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/953837

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 11 Apr 2020 07:32:19 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Tue Dec 26 06:58:18 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.