Debian Bug report logs - #701294
holotz-castle: ftbfs with GCC-4.8

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: maintonly@bugs.debian.org

Subject: holotz-castle: ftbfs with GCC-4.8

Date: Sat, 23 Feb 2013 11:20:55 +0000

Package: src:holotz-castle
Version: 1.3.14-5
Severity: important
Tags: sid jessie
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-4.8

The package fails to build in a test rebuild on at least amd64 with
gcc-4.8/g++-4.8, but succeeds to build with gcc-4.7/g++-4.7. The
severity of this report may be raised before the jessie release.

  ../JLib/JLib/Util/JRW.h:206:16: error: typedef 'pre_cxx0x_static_assert' locally defined but not used [-Werror=unused-local-typedefs]

The full build log can be found at:
http://people.debian.org/~doko/logs-20130217/gcc48/holotz-castle_1.3.14-5_unstable_gcc48.log
The last lines of the build log are at the end of this report.

To build with GCC 4.8, either set CC=gcc-4.8 CXX=g++-4.8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t experimental install g++ g++-4.7 g++-4.8 libc6-dev

The test rebuild was done with eglibc-2.17 and GCC-4.8, so some issues
might be caused by the updated glibc.

[...]
a - JLib/Graphics/JGLAxes.o
a - JLib/Graphics/JGLCamera.o
a - JLib/Graphics/JGLConsole.o
a - JLib/Graphics/JGLGrid.o
a - JLib/Graphics/JGLLight.o
a - JLib/Graphics/JGLTexture.o
a - JLib/Graphics/JGLVector.o
a - JLib/Graphics/JControlImage.o
a - JLib/Graphics/JImage.o
a - JLib/Graphics/JImageSprite.o
a - JLib/Graphics/JSprite.o
a - JLib/Graphics/JFont.o
a - JLib/Graphics/JTextMenu.o
a - JLib/Graphics/JImageMenu.o
a - JLib/Graphics/JGLMesh.o
a - JLib/Graphics/JGLImage.o
a - JLib/Util/JFile.o
a - JLib/Util/JGLApp.o
a - JLib/Util/JObject.o
a - JLib/Util/JTextFile.o
a - JLib/Util/JTextUtil.o
a - JLib/Util/JTimer.o
a - JLib/Util/JUtil.o
a - JLib/Util/JApp.o
a - JLib/Util/JFS.o
a - JLib/Util/JThread.o
a - JLib/Util/JRW.o
a - JLib/Math/J2DPolygon.o
make[3]: Leaving directory `/«PKGBUILDDIR»/JLib'
g++ -fno-strict-aliasing -I. -I../JLib `sdl-config --cflags` -I/usr/local/include/ -I/usr/local/include/SDL -O3 -Wall -Werror -Wshadow  -ffast-math -c -DHC_DATA_DIR=\"/usr/share/games/holotz-castle/game/\" -DHCED_DATA_DIR=\"/usr/share/games/holotz-castle/editor/\" HCUtil.cpp -o HCUtil.o
In file included from ../JLib/JLib/Util/JLoadSave.h:36:0,
                 from ../JLib/JLib/Util/JString.h:38,
                 from ./HCUtil.h:50,
                 from HCUtil.cpp:30:
../JLib/JLib/Util/JRW.h: In member function 'u32 JRW::ReadLE32(float*)':
../JLib/JLib/Util/JRW.h:206:16: error: typedef 'pre_cxx0x_static_assert' locally defined but not used [-Werror=unused-local-typedefs]
   typedef char pre_cxx0x_static_assert[sizeof(u32) == sizeof(float) ? 1 : -1 ];
                ^
../JLib/JLib/Util/JRW.h: In member function 'u32 JRW::WriteLE32(const float*)':
../JLib/JLib/Util/JRW.h:311:16: error: typedef 'pre_cxx0x_static_assert' locally defined but not used [-Werror=unused-local-typedefs]
   typedef char pre_cxx0x_static_assert[sizeof(u32) == sizeof(float) ? 1 : -1 ];
                ^
cc1plus: all warnings being treated as errors
make[2]: *** [HCUtil.o] Error 1
make[2]: Leaving directory `/«PKGBUILDDIR»/src'
make[1]: *** [all] Error 2
dh_auto_build: make -j1 returned exit code 2
make[1]: Leaving directory `/«PKGBUILDDIR»'
make: *** [build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2

Message #14 received at 701294@bugs.debian.org (full text, mbox, reply):

From: Juhani Numminen <juhaninumminen0@gmail.com>

To: 701294@bugs.debian.org

Subject: Patch: holotz-castle: ftbfs with GCC-4.8

Date: Wed, 5 Jun 2013 15:14:07 +0300

[Message part 1 (text/plain, inline)]

Control: tags -1 patch

Hi!
The attached patch fixes the FTBFS by appending the GCC flag
-Wno-error=unused-local-typedefs.

Regards,
Juhani Numminen

[13_gcc-4.8.patch (text/x-patch, attachment)]

Message #21 received at 701294@bugs.debian.org (full text, mbox, reply):

From: Juhani Numminen <juhaninumminen0@gmail.com>

To: 701294@bugs.debian.org

Subject: holotz-castle: ftbfs with GCC-4.8

Date: Fri, 7 Jun 2013 10:53:58 +0300

[Message part 1 (text/plain, inline)]

Hi,
I have revised my patch.

Wed, 5 Jun 2013 15:14:07 +0300
Juhani Numminen <juhaninumminen0@gmail.com> kirjoitti:

> The attached patch fixes the FTBFS by appending the GCC flag
> -Wno-error=unused-local-typedefs.

However, a little later I found this Porting to GCC 4.8 page
http://gcc.gnu.org/gcc-4.8/porting_to.html.
It has also -Wunused-local-typedefs listed, but a solution is to remove
the typedefs and adding no- is just a workaround.

Thanks for your time,
Juhani Numminen

[13_gcc-4.8.patch (text/x-patch, attachment)]

Message #28 received at 701294-close@bugs.debian.org (full text, mbox, reply):

From: Barry deFreese <bdefreese@debian.org>

To: 701294-close@bugs.debian.org

Subject: Bug#701294: fixed in holotz-castle 1.3.14-6

Date: Thu, 13 Jun 2013 12:48:19 +0000

Source: holotz-castle
Source-Version: 1.3.14-6

We believe that the bug you reported is fixed in the latest version of
holotz-castle, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 701294@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Barry deFreese <bdefreese@debian.org> (supplier of updated holotz-castle package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 07 Jun 2013 16:47:25 -0400
Source: holotz-castle
Binary: holotz-castle holotz-castle-data holotz-castle-editor
Architecture: source i386 all
Version: 1.3.14-6
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Barry deFreese <bdefreese@debian.org>
Description: 
 holotz-castle - platform game with high doses of mystery
 holotz-castle-data - platform game with high doses of mystery - data files
 holotz-castle-editor - platform game with high doses of mystery - level editor
Closes: 701294
Changes: 
 holotz-castle (1.3.14-6) unstable; urgency=low
 .
   * Add patch to fix FTBFS with gcc-4.8. (Closes: #701294).
     + Thanks to Juhani Numminen for the patch.
   * Don't install themes/dungeons as they are just duplicates of themes/default.
   * Add patch to fix spelling errors in manpage and binaries.
   * Bump debhelper build-dep and compat to 9.
   * Bump Standards Version to 3.9.4.
Checksums-Sha1: 
 d556b5a0ead2d7e8f817ee2b0fb774ff35840478 1653 holotz-castle_1.3.14-6.dsc
 4bc657c37412b6a969d17cc0d578d3649863fa39 13810 holotz-castle_1.3.14-6.debian.tar.gz
 41e201524df644a26b2bd0519bf5c55b9607369b 102044 holotz-castle_1.3.14-6_i386.deb
 ddb2cdaf4e87c6086748f368229b14be6bfda52e 3301738 holotz-castle-data_1.3.14-6_all.deb
 cc6af24e5bdce7538a5bf30fc982912373f8d66d 108600 holotz-castle-editor_1.3.14-6_i386.deb
Checksums-Sha256: 
 64988f0ed2055a1d62bf77e703a465758ae000b1d3482440081d2812912e6436 1653 holotz-castle_1.3.14-6.dsc
 cb7218f875a415ac12481eb3e986b7085809ba30402be67dede743983d76863a 13810 holotz-castle_1.3.14-6.debian.tar.gz
 d7c0e1d44f1bfb23942446a45169b37fa4d8d7608ffd40bc380b3d22a812f03c 102044 holotz-castle_1.3.14-6_i386.deb
 397caa0dc0d9946f64c04ab0bd1867b1ad2b1592d837c81566464f21f47d3eb9 3301738 holotz-castle-data_1.3.14-6_all.deb
 d7c3c491fef1584bffc9e3294af56fe7b24d858618ca90556c9302f396c3c4c3 108600 holotz-castle-editor_1.3.14-6_i386.deb
Files: 
 1b0d4e30bf32b383d8d3ebfd6c2352aa 1653 games optional holotz-castle_1.3.14-6.dsc
 1c39e31e1f1454b537f9b6b85b4ebcfd 13810 games optional holotz-castle_1.3.14-6.debian.tar.gz
 7dbbcc7c4972631e25909ed6d9bf4961 102044 games optional holotz-castle_1.3.14-6_i386.deb
 3008050a200a5299278a06fe94e5e114 3301738 games optional holotz-castle-data_1.3.14-6_all.deb
 216adade99f71af281cb918e503146dd 108600 games optional holotz-castle-editor_1.3.14-6_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEUEARECAAYFAlG5htIACgkQ5ItltUs5T34FWgCYzbzIV5B0Juq18uCaleFcJ1hV
hwCfT7RlA7hLvzbwM236y4R8TPVElX8=
=MwNe
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.